exceptionfactory closed pull request #82: NIFI-12566 Deploy Redesigned Project
Website
URL: https://github.com/apache/nifi-site/pull/82
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
exceptionfactory commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1881496885
Thanks to everyone who provided feedback on this new design! With the syntax
corrections and several minor improvements, I will proceed to merge and deploy
this version, and we
exceptionfactory commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1881494692
> A couple of comments:
>
> * can the top menu be dynamic? meaning that the sub menu would show up
when hovering the title, right now you have to click to display the
exceptionfactory commented on code in PR #82:
URL: https://github.com/apache/nifi-site/pull/82#discussion_r1445012188
##
content/community/_index.md:
##
@@ -0,0 +1,117 @@
+---
+title: "Community"
+menu:
+ main:
+weight: 3
+---
+
+# Apache {{< project-label >}} Team
+
+A
pvillard31 commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1881474984
A couple of comments:
- can the top menu be dynamic? meaning that the sub menu would show up when
hovering the title, right now you have to click to display the sub menu
- can we
exceptionfactory commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1877801663
> @james-elliott, @exceptionfactory thank you for the changes. The new site
looks much nicer than the old. I noticed though in the old site when clicking
on any menu item under
exceptionfactory commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1877799958
> I saw some odd rendering of some characters on the Community - Team page
(Chrome). There is a third instance below the two shown in this image.
>
Thanks for catching
ChrisSamo632 commented on code in PR #82:
URL: https://github.com/apache/nifi-site/pull/82#discussion_r1442277594
##
content/community/_index.md:
##
@@ -0,0 +1,117 @@
+---
+title: "Community"
+menu:
+ main:
+weight: 3
+---
+
+# Apache {{< project-label >}} Team
+
+A
exceptionfactory commented on code in PR #82:
URL: https://github.com/apache/nifi-site/pull/82#discussion_r1442273184
##
content/community/_index.md:
##
@@ -0,0 +1,117 @@
+---
+title: "Community"
+menu:
+ main:
+weight: 3
+---
+
+# Apache {{< project-label >}} Team
+
+A
pvillard31 commented on code in PR #82:
URL: https://github.com/apache/nifi-site/pull/82#discussion_r1442248696
##
content/community/_index.md:
##
@@ -0,0 +1,117 @@
+---
+title: "Community"
+menu:
+ main:
+weight: 3
+---
+
+# Apache {{< project-label >}} Team
+
+A
ChrisSamo632 commented on code in PR #82:
URL: https://github.com/apache/nifi-site/pull/82#discussion_r1442243049
##
content/community/_index.md:
##
@@ -0,0 +1,117 @@
+---
+title: "Community"
+menu:
+ main:
+weight: 3
+---
+
+# Apache {{< project-label >}} Team
+
+A
dan-s1 commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1877603004
@james-elliott, @exceptionfactory thank you for the changes. The new site
looks much nicer than the old. I noticed though in the old site when clicking
on any menu item under `Apache` no
mosermw commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1877512228
I saw some odd rendering of some characters on the Community - Team page
(Chrome).
![image](https://github.com/apache/nifi-site/assets/10587698/b500eca7-ac2c-4a62-9dfd-ced829e41176)
exceptionfactory commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1877222973
> Looks pretty good, I did see some text artifacts on the FDS page.
Thanks for catching that issue @rfellows, I corrected those characters in
the pull request, so it will be
exceptionfactory commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1877218058
> I think this is less a problem of the updated site per se but rather how
the header of the rendered documentation behaves on mobile view. I don't know
how the documentation gets
rfellows commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1877043954
Looks pretty good, I did see some text artifacts on the FDS page:
https://github.com/apache/nifi-site/assets/713866/80fdcbf6-abac-476d-bd41-81fa7111a15c;>
--
This is an
EndzeitBegins commented on PR #82:
URL: https://github.com/apache/nifi-site/pull/82#issuecomment-1876400123
Thank you for your work on this @james-elliott, @exceptionfactory and all
others who contributed. The new page looks refreshing.
I haven't looked at the code changes but
exceptionfactory opened a new pull request, #82:
URL: https://github.com/apache/nifi-site/pull/82
[NIFI-12566](https://issues.apache.org/jira/browse/NIFI-12566) builds on the
work of @james-elliott in
[NIFI-12495](https://issues.apache.org/jira/browse/NIFI-12495) deployed to
18 matches
Mail list logo