Re: [PR] NIFI-12854: Add S3 user metadata via flowfile attributes [nifi]

2024-06-24 Thread via GitHub
MikeThomsen commented on PR #8477: URL: https://github.com/apache/nifi/pull/8477#issuecomment-2186635897 @gforeman02 Heads up: you have merge conflicts with `main` that need to be resolved on your branch. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] NIFI-12854: Add S3 user metadata via flowfile attributes [nifi]

2024-06-04 Thread via GitHub
gforeman02 commented on PR #8477: URL: https://github.com/apache/nifi/pull/8477#issuecomment-2148546071 @exceptionfactory thanks for the idea on an approach. I guess a decision needs to be made: Should the PutS3Object processor support dynamic metadata keys? +1 here for suppor

Re: [PR] NIFI-12854: Add S3 user metadata via flowfile attributes [nifi]

2024-03-14 Thread via GitHub
gforeman02 commented on PR #8477: URL: https://github.com/apache/nifi/pull/8477#issuecomment-1998298309 @markap14 i created a custom s3 nar with the following mod: ``` final Map userMetadata = new HashMap<>(); for (final Entry entry : context.getProperties().entrySet()) { if

Re: [PR] NIFI-12854: Add S3 user metadata via flowfile attributes [nifi]

2024-03-07 Thread via GitHub
gforeman02 commented on PR #8477: URL: https://github.com/apache/nifi/pull/8477#issuecomment-198352 @markap14 one other approach could be to have a special dynamic property that the processor uses to read key/value pairs from the dynamic property value. Maybe something like a key "meta

Re: [PR] NIFI-12854: Add S3 user metadata via flowfile attributes [nifi]

2024-03-06 Thread via GitHub
gforeman02 commented on PR #8477: URL: https://github.com/apache/nifi/pull/8477#issuecomment-1981644942 Hello @markap14 , thanks for posting. Yes, the existing method (dynamic properties) requires knowing what the user metadata keys will be in advance. My client has a scenario where one f

Re: [PR] NIFI-12854: Add S3 user metadata via flowfile attributes [nifi]

2024-03-06 Thread via GitHub
markap14 commented on PR #8477: URL: https://github.com/apache/nifi/pull/8477#issuecomment-1981584269 Hey @gforeman02 thanks for putting this forward. I'm not sure that I agree that it's a good idea to add this, though. In general, we should not support multiple different ways to do the sam