joewitt commented on PR #8498:
URL: https://github.com/apache/nifi/pull/8498#issuecomment-2093453610
@mattyb149 It is important to undo all the whitespace changes to improve the
reviewer efficiency and avoid the whitespace in general.
--
This is an automated message from the Apache Git
joewitt commented on code in PR #8498:
URL: https://github.com/apache/nifi/pull/8498#discussion_r1589498608
##
nifi-api/src/main/java/org/apache/nifi/provenance/ProvenanceEventBuilder.java:
##
@@ -283,6 +283,13 @@ public interface ProvenanceEventBuilder {
*/
joewitt commented on code in PR #8498:
URL: https://github.com/apache/nifi/pull/8498#discussion_r1589491223
##
nifi-api/src/main/java/org/apache/nifi/provenance/ProvenanceEventBuilder.java:
##
@@ -283,6 +283,13 @@ public interface ProvenanceEventBuilder {
*/
joewitt commented on code in PR #8498:
URL: https://github.com/apache/nifi/pull/8498#discussion_r1589489118
##
minifi/minifi-nar-bundles/minifi-provenance-repository-bundle/minifi-provenance-repositories/src/main/java/org/apache/nifi/provenance/NoOpProvenanceRepository.java:
##
mattyb149 closed pull request #8498: NIFI-12855: Add more information to
provenance events to facilitate full graph traversal
URL: https://github.com/apache/nifi/pull/8498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
mattyb149 commented on PR #8498:
URL: https://github.com/apache/nifi/pull/8498#issuecomment-2000353866
The graph client stuff has been removed, I'll do a separate PR but not yet
in case the reviews here affect the clients. Once this is in it will facilitate
more clients such as perhaps an
mattyb149 opened a new pull request, #8498:
URL: https://github.com/apache/nifi/pull/8498
# Summary
[NIFI-12855](https://issues.apache.org/jira/browse/NIFI-12855) This PR
augments the provenance capabilities to include the following features:
- A reference in a provenance
mattyb149 closed pull request #8476: NIFI-12855: Add more information to
provenance events to facilitate full graph traversal
URL: https://github.com/apache/nifi/pull/8476
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
markap14 commented on PR #8476:
URL: https://github.com/apache/nifi/pull/8476#issuecomment-1981604614
Yeah, I would agree with you here @exceptionfactory . The API should not
change for this. The Process Session knows which relationship each FlowFile is
routed to.
That said, I don't
exceptionfactory commented on PR #8476:
URL: https://github.com/apache/nifi/pull/8476#issuecomment-1980030839
I also recommend separating out any GraphClientService changes to their own
pull request, as they should be more straightforward to review.
--
This is an automated message from
exceptionfactory commented on PR #8476:
URL: https://github.com/apache/nifi/pull/8476#issuecomment-198002
I agree that the FlowFile Repository only has part of the information as
well, so an end-to-end solution would require some intermediate layer for
sending some metadata elsewhere
mattyb149 commented on PR #8476:
URL: https://github.com/apache/nifi/pull/8476#issuecomment-1979963149
True, I considered that approach but it relies on the FlowFile repository to
be as complete as the provenance repository but doesn't it usually "expire"
earlier? That's also why I didn't
mattyb149 commented on PR #8476:
URL: https://github.com/apache/nifi/pull/8476#issuecomment-1979923174
If a processor issues an event for each FlowFile or for a whole set, they
should all go to the relationship. Without having the relationship name you can
still link the events but you
mattyb149 opened a new pull request, #8476:
URL: https://github.com/apache/nifi/pull/8476
# Summary
[NIFI-12855](https://issues.apache.org/jira/browse/NIFI-12855) This PR adds
additional information to provenance events (such as previous event IDs) to
help facilitate its
14 matches
Mail list logo
