Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-04-03 Thread via GitHub
exceptionfactory closed pull request #8484: NIFI-12875: Add unsuccessful HTTP status code handling logic URL: https://github.com/apache/nifi/pull/8484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-04-01 Thread via GitHub
gforeman02 commented on PR #8484: URL: https://github.com/apache/nifi/pull/8484#issuecomment-2030290474 @dan-s1 and @exceptionfactory thanks for the reviews/suggestions. Updates committed. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-04-01 Thread via GitHub
dan-s1 commented on code in PR #8484: URL: https://github.com/apache/nifi/pull/8484#discussion_r1546454088 ## nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/test/java/org/apache/nifi/lookup/TestRestLookupService.java: ## @@ -170,6

Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-04-01 Thread via GitHub
exceptionfactory commented on code in PR #8484: URL: https://github.com/apache/nifi/pull/8484#discussion_r1546313115 ## nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java: ## @@

Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-03-28 Thread via GitHub
gforeman02 commented on code in PR #8484: URL: https://github.com/apache/nifi/pull/8484#discussion_r1543533349 ## nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java: ## @@ -172,6

Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-03-28 Thread via GitHub
gforeman02 commented on code in PR #8484: URL: https://github.com/apache/nifi/pull/8484#discussion_r1543530660 ## nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java: ## @@ -172,6

Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-03-27 Thread via GitHub
exceptionfactory commented on code in PR #8484: URL: https://github.com/apache/nifi/pull/8484#discussion_r1542112684 ## nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup/RestLookupService.java: ## @@

Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-03-19 Thread via GitHub
gforeman02 commented on PR #8484: URL: https://github.com/apache/nifi/pull/8484#issuecomment-2007637620 @exceptionfactory thanks for responding. I see your point about the 404 scenario, good catch. I will add the property and submit the changes. -- This is an automated message

Re: [PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-03-13 Thread via GitHub
Lehel44 commented on PR #8484: URL: https://github.com/apache/nifi/pull/8484#issuecomment-1996559949 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] NIFI-12875: Add unsuccessful HTTP status code handling logic [nifi]

2024-03-07 Thread via GitHub
gforeman02 opened a new pull request, #8484: URL: https://github.com/apache/nifi/pull/8484 # Summary [NIFI-12875](https://issues.apache.org/jira/browse/NIFI-12875) # Tracking Please complete the following tracking steps