Re: [PR] NIFI-13072: Fix MonitorActivity problems with cluster scope flow monitoring [nifi]

2024-05-12 Thread via GitHub
asfgit closed pull request #8669: NIFI-13072: Fix MonitorActivity problems with cluster scope flow monitoring URL: https://github.com/apache/nifi/pull/8669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] NIFI-13072: Fix MonitorActivity problems with cluster scope flow monitoring [nifi]

2024-05-07 Thread via GitHub
turcsanyip commented on code in PR #8669: URL: https://github.com/apache/nifi/pull/8669#discussion_r1592885962 ## nifi-extension-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/MonitorActivity.java: ## @@ -447,25 +457,202 @

Re: [PR] NIFI-13072: Fix MonitorActivity problems with cluster scope flow monitoring [nifi]

2024-05-07 Thread via GitHub
takraj commented on PR #8669: URL: https://github.com/apache/nifi/pull/8669#issuecomment-2097605328 @turcsanyip I've made it optional, with the original behavior as default. Thanks for the suggestion. I also had to fix a bug, that prevented ths feature to work in case NiFi is not clu

Re: [PR] NIFI-13072: Fix MonitorActivity problems with cluster scope flow monitoring [nifi]

2024-05-06 Thread via GitHub
turcsanyip commented on PR #8669: URL: https://github.com/apache/nifi/pull/8669#issuecomment-2095427711 @takraj Could you please rebase you PR onto the latest main? The module structure has been refactored since you opened the PR. I also noticed that MonitorActivity's logic has been c

Re: [PR] NIFI-13072: Fix MonitorActivity problems with cluster scope flow monitoring [nifi]

2024-04-23 Thread via GitHub
turcsanyip commented on PR #8669: URL: https://github.com/apache/nifi/pull/8669#issuecomment-2072023632 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[PR] NIFI-13072: Fix MonitorActivity problems with cluster scope flow monitoring [nifi]

2024-04-19 Thread via GitHub
takraj opened a new pull request, #8669: URL: https://github.com/apache/nifi/pull/8669 # Summary [NIFI-13072](https://issues.apache.org/jira/browse/NIFI-13072) # Tracking Please complete the following tracking steps prio