exceptionfactory merged PR #9108:
URL: https://github.com/apache/nifi/pull/9108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.
EndzeitBegins commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1731484202
##
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/Triple.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
EndzeitBegins commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1731484202
##
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/Triple.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
juldrixx commented on PR #9108:
URL: https://github.com/apache/nifi/pull/9108#issuecomment-2310557290
> > > Thanks for working on this improvement @juldrixx, I noted one general
concern about the introduction of commons-lang3.
> >
> >
> > I'm not sure what is the change requested?
exceptionfactory commented on PR #9108:
URL: https://github.com/apache/nifi/pull/9108#issuecomment-2310498411
> > Thanks for working on this improvement @juldrixx, I noted one general
concern about the introduction of commons-lang3.
>
> I'm not sure what is the change requested? And w
juldrixx commented on PR #9108:
URL: https://github.com/apache/nifi/pull/9108#issuecomment-2310489187
> Thanks for working on this improvement @juldrixx, I noted one general
concern about the introduction of commons-lang3.
I'm not sure what is the change requested? And what is your co
juldrixx commented on PR #9108:
URL: https://github.com/apache/nifi/pull/9108#issuecomment-2254631030
> Besides the wording of the exception messages, the PR looks good to me
now. Thank you for working on these improvements @juldrixx. 👍🏻
>
> Just a minor hint towards contributing to t
EndzeitBegins commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1694280287
##
nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-mock-record-utils/src/main/java/org/apache/nifi/serialization/record/MockSchemaRegistry.java:
#
EndzeitBegins commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1694279813
##
nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-mock-record-utils/src/main/java/org/apache/nifi/serialization/record/MockSchemaRegistry.java:
#
juldrixx commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1694257810
##
nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-mock-record-utils/src/main/java/org/apache/nifi/serialization/record/MockSchemaRegistry.java:
##
@@
EndzeitBegins commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1694245268
##
nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-mock-record-utils/src/main/java/org/apache/nifi/serialization/record/MockSchemaRegistry.java:
#
EndzeitBegins commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1694245632
##
nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-mock-record-utils/src/main/java/org/apache/nifi/serialization/record/MockSchemaRegistry.java:
#
EndzeitBegins commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1694245632
##
nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-mock-record-utils/src/main/java/org/apache/nifi/serialization/record/MockSchemaRegistry.java:
#
EndzeitBegins commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1694245632
##
nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-mock-record-utils/src/main/java/org/apache/nifi/serialization/record/MockSchemaRegistry.java:
#
EndzeitBegins commented on code in PR #9108:
URL: https://github.com/apache/nifi/pull/9108#discussion_r1694245268
##
nifi-extension-bundles/nifi-extension-utils/nifi-record-utils/nifi-mock-record-utils/src/main/java/org/apache/nifi/serialization/record/MockSchemaRegistry.java:
#
juldrixx commented on PR #9108:
URL: https://github.com/apache/nifi/pull/9108#issuecomment-2248656035
> You're absolutely right, I didn't notice that difference.
>
> Do you think it makes sense to add a test, that uses the added properties
to ensure they're properly integr
EndzeitBegins commented on PR #9108:
URL: https://github.com/apache/nifi/pull/9108#issuecomment-2248605420
You're absolutely right, I didn't notice that difference.
Do you think it makes sense to add a test, that uses the added properties to
ensure they're properly integrated and not
juldrixx commented on PR #9108:
URL: https://github.com/apache/nifi/pull/9108#issuecomment-2248417578
> Thank you for working on this @juldrixx. The addition of these properties
seems coherent with other implementations.
>
> Instead of re-declaring both `SCHEMA_BRANCH_NAME` and `SCHEM
EndzeitBegins commented on PR #9108:
URL: https://github.com/apache/nifi/pull/9108#issuecomment-2248193849
Thank you for working on this @juldrixx. The addition of these properties
seems coherent with other implementations.
Instead of re-declaring both `SCHEMA_BRANCH_NAME` and `SCHEM
juldrixx opened a new pull request, #9108:
URL: https://github.com/apache/nifi/pull/9108
# Summary
[NIFI-13578](https://issues.apache.org/jira/browse/NIFI-13578)
# Tracking
Please complete the following tracking steps pr
20 matches
Mail list logo
