Re: [PR] NIFI-13755 On NiFi restart, re-enable as many previously enabled controller services as possible [nifi]

2024-09-27 Thread via GitHub
exceptionfactory commented on PR #9273: URL: https://github.com/apache/nifi/pull/9273#issuecomment-2379524999 Thanks @mattyb149, I will take another look and follow up soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] NIFI-13755 On NiFi restart, re-enable as many previously enabled controller services as possible [nifi]

2024-09-27 Thread via GitHub
mattyb149 commented on PR #9273: URL: https://github.com/apache/nifi/pull/9273#issuecomment-2379506092 +1 LGTM, verified the expected behavior. @exceptionfactory do you want another look at this? If not I'll merge -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] NIFI-13755 On NiFi restart, re-enable as many previously enabled controller services as possible [nifi]

2024-09-18 Thread via GitHub
jrsteinebrey commented on code in PR #9273: URL: https://github.com/apache/nifi/pull/9273#discussion_r1765711886 ## nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java: ## @@ -253,

Re: [PR] NIFI-13755 On NiFi restart, re-enable as many previously enabled controller services as possible [nifi]

2024-09-18 Thread via GitHub
jrsteinebrey commented on code in PR #9273: URL: https://github.com/apache/nifi/pull/9273#discussion_r1765706305 ## nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java: ## @@ -253,

Re: [PR] NIFI-13755 On NiFi restart, re-enable as many previously enabled controller services as possible [nifi]

2024-09-18 Thread via GitHub
jrsteinebrey commented on code in PR #9273: URL: https://github.com/apache/nifi/pull/9273#discussion_r1765704164 ## nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java: ## @@ -253,

Re: [PR] NIFI-13755 On NiFi restart, re-enable as many previously enabled controller services as possible [nifi]

2024-09-17 Thread via GitHub
exceptionfactory commented on code in PR #9273: URL: https://github.com/apache/nifi/pull/9273#discussion_r1764381414 ## nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/controller/service/StandardControllerServiceProvider.java: ## @@ -

[PR] NIFI-13755 On NiFi restart, re-enable as many previously enabled controller services as possible [nifi]

2024-09-17 Thread via GitHub
jrsteinebrey opened a new pull request, #9273: URL: https://github.com/apache/nifi/pull/9273 (meaning all the ones which are not dependent on another disabled service). Only skip trying to re-enable a previously disabled controller service IF it depends on another service which is disable