Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on PR #8011: URL: https://github.com/apache/nifi/pull/8011#issuecomment-1813151208 The backport was more straightforward than I've expected. I've opened #8031. I'd highly appreciate if you'd take a look at it @exceptionfactory, as you're familiar with this original

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on PR #8011: URL: https://github.com/apache/nifi/pull/8011#issuecomment-1812907291 Thank you for your reviews and the fast merge @exceptionfactory. I'll take a look at what's required for the backport in the next days presumably and open a new pull-request if t

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

exceptionfactory closed pull request #8011: NIFI-4550 Detect charset for FlowFile with MIME type text/* URL: https://github.com/apache/nifi/pull/8011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on code in PR #8011: URL: https://github.com/apache/nifi/pull/8011#discussion_r1393217615 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -89,14 +89,17 @@ @T

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

exceptionfactory commented on code in PR #8011: URL: https://github.com/apache/nifi/pull/8011#discussion_r1393209952 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -89,14 +89,17 @@

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on code in PR #8011: URL: https://github.com/apache/nifi/pull/8011#discussion_r1393174739 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -89,14 +89,17 @@ @T

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on code in PR #8011: URL: https://github.com/apache/nifi/pull/8011#discussion_r1393174739 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -89,14 +89,17 @@ @T

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on code in PR #8011: URL: https://github.com/apache/nifi/pull/8011#discussion_r1393176002 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -233,53 +239,62 @@ p

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on code in PR #8011: URL: https://github.com/apache/nifi/pull/8011#discussion_r1393175162 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -233,53 +239,62 @@ p

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on code in PR #8011: URL: https://github.com/apache/nifi/pull/8011#discussion_r1393174739 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -89,14 +89,17 @@ @T

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

exceptionfactory commented on code in PR #8011: URL: https://github.com/apache/nifi/pull/8011#discussion_r1393154825 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -233,53 +239,62 @

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

exceptionfactory commented on code in PR #8011: URL: https://github.com/apache/nifi/pull/8011#discussion_r1393158889 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java: ## @@ -89,14 +89,17 @@

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on PR #8011: URL: https://github.com/apache/nifi/pull/8011#issuecomment-1811025944 @exceptionfactory Is there any chance to include this into 1.24.0, now that the RC1 is called off? This way, we wouldn't need to wait for the following release which will be some weeks

Re: [PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins commented on PR #8011: URL: https://github.com/apache/nifi/pull/8011#issuecomment-1808890691 Thank you for taking a look at this @exceptionfactory, I highly appreciate it. I've made some changes regarding the stream re-use as you've pointed out. I replaced the use of

[PR] NIFI-4550 Detect charset for FlowFile with MIME type text/* [nifi]

EndzeitBegins opened a new pull request, #8011: URL: https://github.com/apache/nifi/pull/8011 # Summary Identifies `charset`as part of `IdentifyMimeType` processor, when the detected MIME type is `text/*`. [NIFI-4550](https://