Re: [PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]

2024-04-22 Thread via GitHub
jrsteinebrey closed pull request #8639: NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. URL: https://github.com/apache/nifi/pull/8639 -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]

2024-04-22 Thread via GitHub
mattyb149 commented on PR #8639: URL: https://github.com/apache/nifi/pull/8639#issuecomment-2070055327 I think that's why this Jira has sat around for so long, most ListXYZ processors are true source processors because they mostly deal with filesystems which are hierarchical and can be recu

Re: [PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]

2024-04-22 Thread via GitHub
joewitt commented on PR #8639: URL: https://github.com/apache/nifi/pull/8639#issuecomment-2069658691 These components are quite widely used so in review it is important to carefully consider whether this degree of change is desirable vs new components more specific to the use case(s) intend

Re: [PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]

2024-04-22 Thread via GitHub
jrsteinebrey commented on code in PR #8639: URL: https://github.com/apache/nifi/pull/8639#discussion_r1574853643 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java: ## @@ -270,24 +297,40 @@

Re: [PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]

2024-04-19 Thread via GitHub
dan-s1 commented on code in PR #8639: URL: https://github.com/apache/nifi/pull/8639#discussion_r1572734213 ## nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListDatabaseTables.java: ## @@ -270,24 +297,40 @@ public

[PR] NIFI-5519 Allow ListDatabaseTables to accept incoming connections and tweak GenerateTableFetch to work the same. [nifi]

2024-04-12 Thread via GitHub
jrsteinebrey opened a new pull request, #8639: URL: https://github.com/apache/nifi/pull/8639 …nc up code in GenerateTableFetch to have its incoming connection work better like ListDatabaseTables. # Summary [NIFI-5519](https://