Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-14 Thread via GitHub
asfgit closed pull request #8146: NIFI-6730 AMQP QoS support URL: https://github.com/apache/nifi/pull/8146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-14 Thread via GitHub
MooseTheBrown commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1426806679 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java: ## @@ -112,6 +115,17 @@ public class

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-14 Thread via GitHub
turcsanyip commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1426750707 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java: ## @@ -112,6 +115,17 @@ public class

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-14 Thread via GitHub
MooseTheBrown commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1426414623 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java: ## @@ -112,6 +115,17 @@ public class

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-13 Thread via GitHub
turcsanyip commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1425813999 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java: ## @@ -112,6 +115,17 @@ public class

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-13 Thread via GitHub
dan-s1 commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1425453995 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java: ## @@ -112,6 +112,16 @@ public class ConsumeAMQP

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-13 Thread via GitHub
dan-s1 commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1425443615 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java: ## @@ -43,6 +43,7 @@ public class

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-13 Thread via GitHub
MooseTheBrown commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1425103142 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java: ## @@ -80,30 +80,30 @@ public void

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-13 Thread via GitHub
MooseTheBrown commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1425102857 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java: ## @@ -80,30 +80,30 @@ public void

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-13 Thread via GitHub
MooseTheBrown commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1425102583 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java: ## @@ -55,7 +55,7 @@ public void

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-13 Thread via GitHub
MooseTheBrown commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1425102068 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java: ## @@ -112,6 +112,16 @@ public class

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-12 Thread via GitHub
dan-s1 commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1424500623 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java: ## @@ -112,6 +112,16 @@ public class ConsumeAMQP

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-12 Thread via GitHub
dan-s1 commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1424437510 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java: ## @@ -55,7 +55,7 @@ public void

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-12 Thread via GitHub
dan-s1 commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1424500623 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/ConsumeAMQP.java: ## @@ -112,6 +112,16 @@ public class ConsumeAMQP

Re: [PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-12 Thread via GitHub
dan-s1 commented on code in PR #8146: URL: https://github.com/apache/nifi/pull/8146#discussion_r1424438916 ## nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/test/java/org/apache/nifi/amqp/processors/AMQPConsumerTest.java: ## @@ -80,30 +80,30 @@ public void

[PR] NIFI-6730 AMQP QoS support [nifi]

2023-12-08 Thread via GitHub
MooseTheBrown opened a new pull request, #8146: URL: https://github.com/apache/nifi/pull/8146 # Summary [NIFI-6730](https://issues.apache.org/jira/browse/NIFI-6730) Implement basicQos (prefetch count) support in ConsumeAMQP