asfgit closed pull request #7562: NIFI-8606 Added Stop & Configure button to
the Controller Services De…
URL: https://github.com/apache/nifi/pull/7562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mosermw commented on PR #7562:
URL: https://github.com/apache/nifi/pull/7562#issuecomment-1901055385
I tested this again on main and support/nifi-1.x branches. The duplicated
references is fixed. So this looks good to me.
+1 will merge to main and 1.x
--
This is an automated
mosermw commented on PR #7562:
URL: https://github.com/apache/nifi/pull/7562#issuecomment-1898743694
@mcgilman Are we at the point on the main branch where changes to
nifi-web-ui also have to be made on the new nifi-web-frontend? I'm not sure
how they have been kept up-to-date.
--
This
Freedom9339 commented on PR #7562:
URL: https://github.com/apache/nifi/pull/7562#issuecomment-1792887093
@mcgilman Thank you for the review. I've changed the text to show Disable
instead of stopped, and fixed the issue where the referenced components were
being shown twice.
--
This is
Freedom9339 commented on PR #7562:
URL: https://github.com/apache/nifi/pull/7562#issuecomment-1792884864
> @Freedom9339 Thanks for the PR!
>
> @mosermw Thanks for the initial review!
>
> Sorry for the delay reviewing this effort. I was happy to see that the
work here accounts
Freedom9339 commented on code in PR #7562:
URL: https://github.com/apache/nifi/pull/7562#discussion_r1382032653
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-service.js:
##
@@ -2457,6 +2487,72 @@
mcgilman commented on code in PR #7562:
URL: https://github.com/apache/nifi/pull/7562#discussion_r1380652773
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-controller-service.js:
##
@@ -2457,6 +2487,72 @@
mcgilman commented on PR #7562:
URL: https://github.com/apache/nifi/pull/7562#issuecomment-1791306505
Will review...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mosermw commented on PR #7562:
URL: https://github.com/apache/nifi/pull/7562#issuecomment-1773061142
I tested this on the support/nifi-1.x branch and this code works as expected
there, too.
I would still like another javascript dev to review this.
--
This is an automated message
mosermw commented on PR #7562:
URL: https://github.com/apache/nifi/pull/7562#issuecomment-1771271709
I tested this (after resolving conflicts locally) and it works on the main
branch. I will also test this on the support/nifi-1.x branch. I like seeing
the status-bar for controller
mosermw commented on PR #7562:
URL: https://github.com/apache/nifi/pull/7562#issuecomment-1771258568
@Freedom9339 Your branch now has conflicts with two files. If you could
rebase onto main and resolve those conflicts, I will be happy to review.
--
This is an automated message from the
11 matches
Mail list logo
