[ https://issues.apache.org/jira/browse/NIFI-4687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299776#comment-16299776 ]
Pierre Villard commented on NIFI-4687: -------------------------------------- Hi [~rhopfer], Just had a look into the code, it LGTM. Could you update unit tests to confirm the new feature? [~alopresto] - a second pair of eyes could be great as you reviewed this part in the past. > Allow IP addresses in SANs of tls-toolkit generated certificates > ---------------------------------------------------------------- > > Key: NIFI-4687 > URL: https://issues.apache.org/jira/browse/NIFI-4687 > Project: Apache NiFi > Issue Type: Improvement > Reporter: Roland Hopferwieser > Priority: Minor > Attachments: TlsHelper-allow-ip-addresses-in-SAN.patch > > > If you run > {{tls-toolkit.sh standalone -n nifi.localdomain --subjectAlternativeNames > 10.0.0.2}} > you get a certificate with the "X509v3 Subject Alternative Name" > {{DNS:nifi.localdomain, DNS:10.0.0.2}} > This patch will change it to the correct form > {{DNS:nifi.localdomain, IP Address:10.0.0.2}} -- This message was sent by Atlassian JIRA (v6.4.14#64029)