Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/32
+1 I rebased against master and resolved the conflict in the list viewer,
everything looks good and verified the coasters display on deleting a bucket or
flow
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/30
+1 Verified the authorizedActions are returning correctly, will merge,
thanks!
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/34
NIFIREG-49 Adding UserClient to nifi-registry-client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi-registry user-client
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/35
NIFIREG-50 Adding additional metadata to some objects in the data modâ¦
â¦el, changing serializers to only serialize VersionedProcessGroup
You can merge this pull request into a Git
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/33
Not sure why one travis job failed, all tests passing for me locally
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/31
+1 Looks good, will merge to master
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/33
This was merged by Mark, closing the PR
---
Github user bbende closed the pull request at:
https://github.com/apache/nifi-registry/pull/33
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/29
Looks good! Going to merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/29
This looks good, was able to get a JWT for a user from the test LDAP server
and then use it to make another request.
Can we add the DisposableBean approach
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/29
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/48
Thanks for the review Kevin! I'll merge to master
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/43
+1 verified the new functionality and everything looks good, will merge to
master
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2325
+1 Moving the syslog test to IT tests is a good idea
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/49
+1 will merge to master
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/46
Closing this PR in favor of PR 48 which includes this work.
---
Github user bbende closed the pull request at:
https://github.com/apache/nifi-registry/pull/46
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/48
NIFIREG-63 Add ability to get latest snapshot metadata
and avoid loading every snapshot metadata into memory when retrieving
latest snapshot or snapshot metadata
You can merge this pull
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/48
This PR includes the commit from PR 46 for NIFIREG-42, so that must be
merged first.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/26
Looks like this gets the travis build passing so I am a +1, we can just
make a habit of running UI tests locally when reviewing, thanks @scottyaslan
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/28
+1 This looks good, nice to have some automation around our TLS/security
setup, thanks! I'll merge in soon.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/27
Thanks, I'll change that string so its not called system anymore, and then
I'll merge to master.
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/27
NIFIREG-43 Provide configurable extension directories with class loadâ¦
â¦er isolation
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2673
Looks good, will merge, thanks!
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2681#discussion_r186457698
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/MoveHDFS.java
---
@@ -228,14 +232,15
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2676
Looks good, will merge, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/117
@pvillard31 this should be good to go pending any review feedback, let me
know if you have any cycles to take a look, thanks
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2677
Looks good, will merge, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/110
Thanks for the quick review. Using the commit message definitely makes
sense, I will add those fields back to the event for creating a flow version.
I think we could support an option
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/110
@pvillard31 I branched off your commit and resolved conflicts and took a
stab at making the the event publishing/consuming asynchronous so that the main
request path won't be impacted by any
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/112#discussion_r184694579
--- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -895,3 +895,167 @@ Providing 2 total locations, including
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
@ijokarumawak I agree about the email and author approach, after reading
what you wrote in the admin guide, it makes sense.
Thanks for pushing those changes. Will try them out shortly.
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/112#discussion_r184709680
--- Diff:
nifi-registry-utils/src/main/java/org/apache/nifi/registry/util/FileUtils.java
---
@@ -389,4 +389,38 @@ public static void sleepQuietly
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/112#discussion_r184706432
--- Diff: nifi-registry-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -895,3 +895,167 @@ Providing 2 total locations, including
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
Async pushing looks good, so I think final two items are updating the
migration guidance and whether or not we want to leave spaces in the
bucket/flow names.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2518
@MikeThomsen @ijokarumawak I'd say unless there is something in the 1.2
client that is needed to implement the visibility labels, then it might be
safer to just stay on 1.1.2, and hopefully soon we
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/117
NIFIREG-160 Implement a hook provider
For whoever reviews/merges this, please keep the commit history and don't
squash.
You can merge this pull request into a Git repository by running
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/117
For an easy way to test this you can turn uncomment the
LoggingEventHookProvider in providers.xml and then use the registry as normal
to create buckets and save flows from NiFi, then tail
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2685
NIFI-5163 Clearing version control info when creating a template
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2677
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
@ijokarumawak thanks for the updates, everything looks good, going to
merge... thanks for all the work on this!
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2681#discussion_r186478219
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/MoveHDFS.java
---
@@ -228,14 +232,17
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/114
Looks good, going to merge, thanks for the contribution!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2681
Merged to master, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2702
@MikeThomsen I've only spent a couple of minutes looking at this, but I'm
not sure it can work out as nicely as you are hoping... the controller service
API here is heavily dependent on the actual
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/117
@pvillard31 thanks for the review, i'm fine with you doing the minor
cleanup on merge, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2726
@zenfenan the getAndPutIfAbsent method needs to be an atomic operation
which is the reason we are using the watch and multi step operation so we can't
remove that
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2726
Was looking into this a little more and I believe we can keep all of the
origin getAndPutIfAbsent, and just add the following right after the set:
`redisConnection.expire(kv.getKey(), 1000
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2726
The TTL concept is really specific to the implementation (Redis in this
case). From the perspective of the DMC interface, the API for getAndPutIfAbsent
is saying it will only do a put if the key
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2726
Looks good, merged, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2726
@zenfenan thanks for the updates, I think there is also a small changed
needed in putIfAbsent correct? If setnx returns true then set expire?
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/118
NIFIREG-160 Fixing issue where version created event throws an exceptâ¦
â¦ion when comments are not provided
You can merge this pull request into a Git repository by running:
$ git
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2735
NIFI-5229 Adding a DBCPService implementation that can lookup other Dâ¦
â¦BCPServices dynamically at runtime
Thank you for submitting a contribution to Apache NiFi.
In order
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2619#discussion_r193733115
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/schema/access/SchemaAccessUtils.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2619#discussion_r193734191
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2619#discussion_r193735509
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/serialization
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2619
I haven't gone too deep looking at this, but if the goal is to have a
re-usable way to infer a schema from JSON across various NoSQL components, have
we considered just putting some utility code
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2619#discussion_r193739859
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2801
@ottobackwards thanks, i mixed up the numbers, will force push with the
correct commit message
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2639
Looks good, will merge, thanks!
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2801
NIFI-5139 Utilize NiFi Registry 0.2.0 client
NOTE: This should only be merged after the NiFi Registry 0.2.0 release is
complete and the 0.2.0 artifacts are available in Maven central.
You can merge
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/124
NIFIREG-174 Fixing start-up to look for the system properties specifyâ¦
â¦ing the location of properties and bootstrap, and fallback to relative
paths
You can merge this pull request
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/119
Thanks! looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/119
Swagger part looks good, nice work!
I think nifi-registry-assembly/NOTICE just needs the 2017 changed to 2018
at the top.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2755
Tested this out and looks good, going to merge
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194437894
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194421999
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194421861
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194427937
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194424610
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194456502
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194443340
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194430127
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194428165
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194446685
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2639#discussion_r194421928
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFSFileInfo.java
---
@@ -0,0 +1,803
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2797
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2797
Looks good, unit tests pass, ran the toolkit against the example
authorizers and identity-providers files and verified the passwords were
successfully encrypted, merging...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2763
+1 looks good, will merge
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2735#discussion_r191057795
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPoolLookup.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2735#discussion_r191057922
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/test/java/org/apache/nifi/dbcp/TestDBCPConnectionPoolLookup.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2735#discussion_r191057746
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPoolLookup.java
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2740
+1 Have been testing this and looks good from my perspective
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2746#discussion_r191555681
--- Diff: nifi-toolkit/nifi-toolkit-assembly/src/main/resources/bin/cli.sh
---
@@ -111,8 +111,7 @@ run() {
export NIFI_TOOLKIT_HOME
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2740
Will review...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2755
Will also review...
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/121
NIFIREG-173 Refactor metadata DB to be independent of H2
The approach here is to create a new DB with a schema and DataSource that
is not specific to H2 and migrate existing data
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2764
NIFI-5260 Adding version elements in archetypes for dependencies thatâ¦
⦠previously were under dependencyManagement
Thank you for submitting a contribution to Apache NiFi
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/122
NIFIREG-173 Improving logic for detecting existence of legacy database
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2742
Looks good, will merge, thanks!
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2827
NIFI-5354 Changing ranger.version to 1.0.0 and ranger.hadoop.version â¦
â¦to 3.0.0
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2809
NIFI-5316 Fixed array handling for Avro that comes from Parquet's Avrâ¦
â¦o reader
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2448
You could call session.remove() instead of transferring it, but then I'm
not sure you can still use that flow file in future operations when calling
create(original).
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r196906833
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml ---
@@ -327,6 +327,10 @@
1.7.0-SNAPSHOT
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r196905162
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-nar/src/main/resources/META-INF/NOTICE
---
@@ -218,6 +218,14 @@ The following binary components
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r196907444
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseSyslog5424.java
---
@@ -0,0
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r196910966
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/syslog/StrictSyslog5424Parser.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r196908047
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseSyslog5424.java
---
@@ -0,0
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r196912736
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/syslog/StrictSyslog5424Parser.java
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r196913302
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestParseSyslog5424.java
501 - 600 of 897 matches
Mail list logo
