Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2668
@ottobackwards I identified the leaks using VisualVM to analyze the heap,
and can now see that the processors and class loader references are no longer
in the heap after these changes
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
Been testing this and has been looking good so far...
I was doing a test where I configured to push to a remote, but I didn't
supply a username/password because I honestly wasn't sure
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/112
I noticed when I ran "git log" that the commit was made by "anonymous"
which is correct since I was in an unsecure instance, but the email address of
the commit ended up
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/112#discussion_r184458388
--- Diff:
nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/flow/git/GitFlowMetaData.java
---
@@ -0,0 +1,384
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2668
NIFI-5136 Ensure processor references are removed from LogRepository â¦
â¦and from ProcessScheduler
- Forcing FileSystem statistics thread to be interrupted when HDFS
processors
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2498
@MikeThomsen thanks! I'll update the PR once things settle down
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2674
NIFI-5148 Refactoring Kerberos auth for Solr processors
- Created resuable KeytabUser and KeytabConfiguration in nifi-security-utils
- Refactored Solr processors to use a KeytabControllerService
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/22#discussion_r145762243
--- Diff:
nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/FlowResource.java
---
@@ -0,0 +1,69 @@
+/*
+ * Licensed
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/22
Thanks for the review! I am working on resolving the conflicts now.
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2221
NIFI-4506 Adding toDate and format functions to record path
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2221
Yea I forgot about the timezone, but that should be added as an optional
parameter, and that will make use of the unused method that Matt pointed out :)
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2228
+1 Looks good and verified this addresses the problem, will merge to master
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/74
@dannylane thanks for the contribution! From a quick glance this looks
good, will do a more detailed review when I get a chance.
One thing that will need to be done is providing
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/67
NIFIREG-76 Adding exception mapper for ConstraintViolationException, â¦
â¦and validating blank names on updates
You can merge this pull request into a Git repository by running:
$ git
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2388
NIFI-4708 Correcting logic for determining decryption key in NiFiRegiâ¦
â¦stryMode.groovy
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2219
Have been testing for a while and everything looks good, going to merge...
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2387
NIFI-4750 Ensuring preDestruction is called on authorizer and approprâ¦
â¦iate policy/user-group providers
Thank you for submitting a contribution to Apache NiFi.
In order
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2385
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2221
I'd like to merge this in as is (barring any feedback) and add the timezone
support later.
I created this JIRA for the timezone support:
https://issues.apache.org/jira/browse/NIFI-4732
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/81
Looks good, going to merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/80
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/78
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/79
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/77
Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2396
+1 looks good, verified 0.11 and 1.0 processors send attributes in headers
correctly, there was a minor check-style error that i am fixing while merging
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2396
Reviewing...
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/89#discussion_r162360367
--- Diff: nifi-registry-docker/pom.xml ---
@@ -0,0 +1,15 @@
+
--- End diff --
Thanks for putting this together!
I noticed
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/88
Nice work! Tested this out and everything looks good, going to merge
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/90
NIFIREG-121 Bumping pom versions from 0.1.1-SNAPSHOT to 0.2.0-SNAPSHOT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/87
This is really helpful! Looks good, merging
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2406
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2393
+1 looks good and verified behavior, merging
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/92
Good idea! merging
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2391#discussion_r162655326
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/GetHDFSTest.java
---
@@ -224,17 +224,6
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2092
Looks good, merging
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/91
Looks good, merging
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2391#discussion_r162655242
--- Diff:
nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/GetHDFS.java
---
@@ -220,16 +220,6
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/82
Looks good, will merge, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/96
+1 Verified I got back the untrusted proxy error on the client side, and
also saw it in the logs on registry server side, going to merge, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/96
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/95
+1 Looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2455
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2460
Looks good, merging to master
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2455
+1 Looks good, tested the scenario in the JIRA and verified the thread
count longer continues to increase, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2462
+1 Ran through test scenarios with input and output ports on RPGs in
versioned flows and this appears to clear up all the issues, merging to master
---
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2454
NIFI-4841 Fixing NPE when reverting local changes involving remote grâ¦
â¦oup ports
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2477
NIFI-4839 Adding CLI to nifi-toolkit
For whoever reviews this, I'd like to preserve the commit history to retain
the contributions for each individual. I've already squashed down to the
minimum set
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2470#discussion_r168568930
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/2472
NIFI-4884 Fixing ordering during import from registry so that we set â¦
â¦schedule strategy on a processor before setting scheduling duration
Thank you for submitting a contribution
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2477
@pvillard31 thanks for the feedback! Regarding the docs...
Long-term I do agree that our admin guide has become quite lengthy and hard
to find information, and we should probably spin-off
GitHub user bbende opened a pull request:
https://github.com/apache/nifi-registry/pull/73
NIFIREG-87 Updating assembly README for release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bbende/nifi-registry update-readme
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2219
@pvillard31 if the variable is added and not referenced by anything then i
believe that is expected behavior, there would be no reason to include that
variable in the versioned flow sent
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2219
@pvillard31 I see what you are saying.. so the flow referenced variables
which didn't really exist yet so in v1 of the flow it didn't capture any
variables, then you want to add them but adding them
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/75
Thanks for catching this! Will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2219
I'll start reviewing this...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/74
@alopresto thanks for mentioning about the discussion of the NiFi landing
page, I wasn't aware of that.
Even if we changed to a silent redirect, I _think_ we still want most of
what
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/67
Thanks for reviewing Kevin, merging to master
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/65
Merging based on Kevin's review, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/66
+1 looks good, merging
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/64
Reviewing...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/57
Looks like a good start to the docs, going to merge this in and we can
follow up with another PR to add the appropriate screenshots to the user guide
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/64
+1 Ran through a full test with NiFi & Registry both configured with a
composite user-group-provider, and put an LDAP user into a file-based group,
and then made a bucket and gave the g
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/68
Verified the behavior and looks good, will merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/51
Spoke with @kevdoran and was able to test the functionality in this PR
using a pre-encrypted conf directory, verified the app started and worked
successfully when encrypted values were present
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/71
Very cool addition, going to merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/72
Looks good, merging
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/70
This looks good, nice work getting all the screenshots in there! Going to
merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/69
Looks good, merging...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/61
This looks good, going to merge to master, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/63
+1 I was able to resolve the merge conflict locally and test this out,
works nicely... was able to login/logout with multiple users against LDAP and
verified that basic auth was being used
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/62#discussion_r158176849
--- Diff: nifi-registry-web-docs/src/main/resources/META-INF/LICENSE ---
@@ -0,0 +1,223 @@
+
+ Apache License
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2367
+1 Builds cleanly and project structure looks correct between processors
and service API, going to merge
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2219
@pvillard31 the current thinking behind variables is that they serve as a
starting point when someone imports a flow, but aren't considered as changes
that make a flow "dirty" and requir
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2219#discussion_r159513297
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardFlowSynchronizer.java
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2477
Fixed the issue with returning the appropriate exit code in standalone
mode. An example of testing this would be running a script like the following:
```
#!/bin/sh
CMD_OUT=`./bin
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2478#discussion_r170687174
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java
---
@@ -0,0 +1,564
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2478#discussion_r170684472
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java
---
@@ -0,0 +1,564
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2478#discussion_r170683857
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java
---
@@ -0,0 +1,564
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2478#discussion_r170688235
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java
---
@@ -0,0 +1,564
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2478#discussion_r170686168
--- Diff:
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/ScanHBase.java
---
@@ -0,0 +1,564
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2477
@pvillard31 since you tested this out a bit, would you be able to give a
final review & merge?
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r197142251
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseSyslog5424.java
---
@@ -0,0
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2805#discussion_r197144571
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseSyslog5424.java
---
@@ -0,0
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2805
Looks good, merging, thanks!
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2930
I think the primary concern is ensuring that existing flows behave the same
as they currently do, which means the default behavior needs to apply the file
filter to files and directories
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2930
Will review...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2866
@pepov your description of the various kerberos options is correct, and the
SPNEGO approach is definitely the traditional way kerberos is intended to work.
The direct login is definitely more
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2913
I think you will also need to find where the group id property is used and
ensure that evaluateAttributeExpressions() is called when obtaining the value.
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2913
Actually, I take back my last comment, I now see where the value is
obtained and it does have the logic:
```
String propertyValue = propertyDescriptor.isExpressionLanguageSupported
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2939
Will review...
---
Github user bbende commented on the issue:
https://github.com/apache/nifi-registry/pull/136
Looks good to me, will merge, thanks!
---
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/133#discussion_r209132775
--- Diff:
nifi-registry-framework/src/main/java/org/apache/nifi/registry/provider/hook/AbstractEventHookProvider.java
---
@@ -0,0 +1,72
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/136#discussion_r209961895
--- Diff:
nifi-registry-data-model/src/main/java/org/apache/nifi/registry/flow/VersionedConnection.java
---
@@ -134,6 +139,36 @@ public void
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2939
Code looks good and verified stats functionality from using the
application, once the license headers are resolved I am a +1
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2939
Just started reviewing, there are a bunch of files with missing license
headers...
```
[WARNING] Files with unapproved licenses:
/home/travis/build/apache/nifi/nifi-nar-bundles/nifi
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2959
Verified that I am now able to start up a cluster without explicitly
specifying a sensitive properties key, same as it previously worked before this
issue, thanks Andy! Will merge shortly
---
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2820
I haven't looked at any of the code so keep that in mind :)
If we are talking about NiFi templates, then they are just examples of how
to use a processor or set of processors, which you can
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2900#discussion_r203060708
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2900#discussion_r203052373
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache/nifi
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2900
Looks good, merging, thanks!
---
601 - 700 of 897 matches
Mail list logo
