[GitHub] nifi issue #1279: NIFI-2017: Fixed typo in nf-port.js that was referencing t...

2016-11-30 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1279 Thanks @markap14! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1287: Authorizing restricted components on snippet usage

2016-12-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1287 Authorizing restricted components on snippet usage NIFI-3135: - Authorizing restricted components on snippet usage. - Ensuring REST API docs accordingly. You can merge this pull request

[GitHub] nifi pull request #1275: Add support for LDAPS

2016-11-29 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1275 Add support for LDAPS NIFI-2325: - Adding support for LDAPS. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mcgilman/nifi NIFI-2325

[GitHub] nifi issue #1300: NIFI-3152: Ensure that we always close the IndexWriter whe...

2016-12-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1300 Yep, looks good to me as well. Please merge @bbende. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1300: NIFI-3152: Ensure that we always close the IndexWriter whe...

2016-12-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1300 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1297: NIFI-3133: Ensure correct checks against Remote Gro...

2016-12-05 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1297#discussion_r90964719 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java

[GitHub] nifi issue #1279: NIFI-2017: Fixed typo in nf-port.js that was referencing t...

2016-11-30 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1279 The proposed change definitely addressing the issue. Things looked great when I was verifying in standalone mode. However, when running clustered the transmitting flag does not seem accurate

[GitHub] nifi pull request #1399: NIFI-3251: Updating authorization requirements for ...

2017-01-05 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1399 NIFI-3251: Updating authorization requirements for removing components - Requiring WRITE permissions to the parent resource when attempting to remove a component. - Updating expired

[GitHub] nifi issue #1384: NIFI-2839 Add a confirmation dialog when deleting a Contro...

2017-01-04 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1384 The code changes look good. Will have @andrewmlim review as well since he created the JIRA. May need to update some wording for consistency throughout the application. For instance, template

[GitHub] nifi issue #1384: NIFI-2839 Add a confirmation dialog when deleting a Contro...

2017-01-04 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1384 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1337: NIFI-3118: Inconsistent order of garbage collection statis...

2017-01-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1337 The PR has been updated. Discovered a separate issue that I've created another JIRA [1] for which can be addressed later. [1] https://issues.apache.org/jira/browse/NIFI-3272 --- If your

[GitHub] nifi issue #1322: [NIFI-3170] remove action details if user does not have re...

2016-12-19 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1322 Thanks @scottyaslan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1340: NIFI-2967: Disabling Add button in new component di...

2016-12-19 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1340 NIFI-2967: Disabling Add button in new component dialog when appropriate NIFI-2967: - Disabling the Add button in the new Processor, Controller Service, and Reporting Task dialog when

[GitHub] nifi issue #1334: NIFI-3207: Incorrect URI generated when replicating Templa...

2016-12-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1334 Thanks for checking back and providing these details. I think the button is wrapping to the next line. We've seen this sort of thing in the past. In fact, we just merged in a PR that addressed

[GitHub] nifi issue #1303: NIFI-2994: Provide default position for RPGs

2016-12-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1303 Thanks @YolandaMDavis. Will update. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1337: NIFI-3118: Inconsistent order of garbage collection statis...

2016-12-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1337 Please hold off on reviewing this PR. The issue also occurs in the Cluster view and the proposed solution needs to be updated to account for that. --- If your project is set up for it, you can

[GitHub] nifi pull request #1353: NIFI-3247: Removing unnecessary authorization check...

2016-12-21 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1353 NIFI-3247: Removing unnecessary authorization check during second phase of connection creation NIFI-3247: - Removing unnecessary authorization check during second phase of connection creation

[GitHub] nifi issue #1354: [NIFI-96] add align horizontal and align vertical capabili...

2016-12-22 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1354 Will review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1303: NIFI-2994: Provide default position for RPGs

2016-12-22 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1303 The PR has been updated. Thanks again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1354: [NIFI-96] add align horizontal and align vertical capabili...

2016-12-22 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1354 Thanks @scottyaslan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1334: NIFI-3207: Incorrect URI generated when replicating Templa...

2016-12-22 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1334 Thanks for the feedback. That button is present based on the users permission to modify the template [1]. Looking at the screenshot, the button has been added to the DOM so the permissions

[GitHub] nifi issue #1600: [NIFI-2697] revert transmission switch toggle on failed up...

2017-03-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1600 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1601: NIFI-3361 Upgrade Jetty version to 9.4.2

2017-03-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1601 Thanks @alopresto. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1616: NIFI-3272: GC stats in Cluster view

2017-03-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1616 Thanks @joewitt! Will update accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1620: NIFI-3421: Preventing successive attempts to create...

2017-03-24 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1620 NIFI-3421: Preventing successive attempts to create a FlowController NIFI-3421: - On contextDestroyed, referencing beans created during contextInitialized to prevent successive attempts

[GitHub] nifi issue #1622: NIFI-79 - Introduces the ability to set Bulletin Level to ...

2017-03-30 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1622 @trixpan Totally forgot to add the 'This closes...' bit to the commit message. Can you please close the PR? Thanks! --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #1622: NIFI-79 - Introduces the ability to set Bulletin Level to ...

2017-03-30 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1622 Thanks @trixpan! This has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1559: [NIFI-3035] add deep linking URL to canvas components and ...

2017-03-22 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1559 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1616: NIFI-3272: GC stats in Cluster view

2017-03-23 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1616 NIFI-3272: GC stats in Cluster view NIFI-3272: - Adding explicit support for the default and G1 garbage collector in the JVM tab of the cluster table. You can merge this pull request

[GitHub] nifi issue #1622: NIFI-79 - Introduces the ability to set Bulletin Level to ...

2017-03-29 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1622 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1635: NIFI-3520 Refactoring instance class loading

2017-03-29 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1635 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1622: NIFI-79 - Introduces the ability to set Bulletin Level to ...

2017-03-29 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1622 @trixpan Thanks for the PR. Everything functions correctly but behind the scenes we were recording observers for the NONE log level because the observers are registered according to the severity

[GitHub] nifi issue #1616: NIFI-3272: GC stats in Cluster view

2017-03-29 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1616 Rebased, squashed, and pushed. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1616: NIFI-3272: GC stats in Cluster view

2017-03-28 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1616 @joewitt I took a different approach. Please pull down the latest and re-review. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1626: NIFI-3643: Fixing capitalization in Java Property

2017-03-27 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1626 NIFI-3643: Fixing capitalization in Java Property NIFI-3643: - Addressing incorrect capitalization in VersionInfoDTO in NiFiVersion. You can merge this pull request into a Git repository

[GitHub] nifi pull request #1627: NIFI-3380: Fixing paths in generated documentation

2017-03-27 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1627 NIFI-3380: Fixing paths in generated documentation NIFI-3380: - Addressing issues with paths in generated documentation. You can merge this pull request into a Git repository by running

[GitHub] nifi issue #1635: NIFI-3520 Refactoring instance class loading

2017-03-31 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1635 @bbende The code changes look good. However, I think the implication of the using the `RequiresInstanceClassLoading` annotation with the `cloneDuringInstanceClassLoading` flag on an NAR could lead

[GitHub] nifi issue #1600: [NIFI-2697] revert transmission switch toggle on failed up...

2017-03-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1600 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1601: NIFI-3361 Upgrade Jetty version to 9.4.2

2017-03-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1601 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1585: NIFI-3380 Support Multiple Versions of the Same Com...

2017-03-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1585#discussion_r105980001 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js

[GitHub] nifi pull request #1585: NIFI-3380 Support Multiple Versions of the Same Com...

2017-03-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1585#discussion_r105980032 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/resources/filters/canvas.properties --- @@ -28,6 +28,7

[GitHub] nifi pull request #1599: NIFI-3615: Removing hidden control characters

2017-03-17 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1599 NIFI-3615: Removing hidden control characters NIFI-3615: - Removing hidden control characters. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #1635: NIFI-3520 Refactoring instance class loading

2017-04-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1635 I think the proposed solution will offer clear, concise rules for when resources are cloned. It also offers further granularity has it puts the cloning of the parent resources in control

[GitHub] nifi pull request #1647: NIFI-3664: - UI Timestamp Issue

2017-04-03 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1647 NIFI-3664: - UI Timestamp Issue NIFI-3664: - Updating the unmarshalling to consider the current date when parsing the time. You can merge this pull request into a Git repository by running

[GitHub] nifi pull request #1648: NIFI-2940: Accessing history for deleted components

2017-04-04 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1648 NIFI-2940: Accessing history for deleted components NIFI-2940: - Allowing access to configuration actions through the Controller when the underlying component has been removed. You can merge

[GitHub] nifi issue #1651: NIFI-3509 Fixed ID duplication

2017-04-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1651 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1653: NIFI-2940: Fixing broken integration test following...

2017-04-06 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1653 NIFI-2940: Fixing broken integration test following changes introduced in NIFI-2940 - Fixing broken integration test following changes introduced in NIFI-2940. You can merge this pull request

[GitHub] nifi issue #1635: NIFI-3520 Refactoring instance class loading

2017-04-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1635 Thanks @bbende. This looks good. It has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1651: NIFI-3509 Fixed ID duplication

2017-04-06 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1651 Thanks @olegz. This has been merged into master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1635: NIFI-3520 Refactoring instance class loading

2017-04-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1635 Thanks will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1672: NIFI-3705: Using consistent logic when verifying co...

2017-04-13 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1672 NIFI-3705: Using consistent logic when verifying connection creation NIFI-3705: - Using consistent logic when verifying connection creation. Removed some unnecessary checks as verification has

[GitHub] nifi pull request #1684: NIFI-3380: Fixing usage links from Controller Servi...

2017-04-20 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1684 NIFI-3380: Fixing usage links from Controller Service and Reporting Tasks tables NIFI-3380: - Fixing opening of Usage from the Controller Service and Reporting Task table. You can merge

[GitHub] nifi issue #1685: [NIFI-3360] inject nf.ControllerServices into nf.Controlle...

2017-04-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1685 Thanks @scottyaslan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1685: [NIFI-3360] inject nf.ControllerServices into nf.Controlle...

2017-04-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1685 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1306: NIFI-1202: Site-to-Site batch settings.

2017-04-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1306 Thanks for the updates. Continuing to follow up on the partial update... is there a reason that batchCount, batchSize, and batchDuration must be updated as a single unit? Should a user not but able

[GitHub] nifi issue #1659: [NIFI-3035] use URLSearchParams .toString() to update URL

2017-04-13 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1659 Thanks guys. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1673: NIFI-3706: Removing non-existent resource when conv...

2017-04-13 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1673 NIFI-3706: Removing non-existent resource when converting a legacy authorized users file - Removing non-existent resource when converting a legacy authorized users file. You can merge this pull

[GitHub] nifi issue #1306: NIFI-1202: Site-to-Site batch settings.

2017-04-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1306 Thanks for rebasing... Will review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1306: NIFI-1202: Site-to-Site batch settings.

2017-04-20 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1306#discussion_r112474822 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/dao/impl

[GitHub] nifi pull request #1306: NIFI-1202: Site-to-Site batch settings.

2017-04-20 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1306#discussion_r112466638 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/audit/RemoteProcessGroupAuditor.java

[GitHub] nifi pull request #1306: NIFI-1202: Site-to-Site batch settings.

2017-04-20 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1306#discussion_r112461210 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/RemoteProcessGroupPortDTO.java

[GitHub] nifi issue #1306: NIFI-1202: Site-to-Site batch settings.

2017-04-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1306 So far the changes look good. One suggestion I'd like to offer is rendering something in this batch settings when there is nothing configured. Typically, we use a string like 'No value set' or relay

[GitHub] nifi issue #1687: [NIFI-3035] disable deep linking when URL .searchParams an...

2017-04-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1687 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1687: [NIFI-3035] disable deep linking when URL .searchParams an...

2017-04-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1687 Thanks @scottyaslan. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1582: NIFI-3575: Prevent unintended move events

2017-03-09 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1582 I left this guidance on the JIRA for anyone testing/reviewing... > Feel free to apply the server side changes first. This should prevent NiFi from getting into this state. You should

[GitHub] nifi pull request #1582: NIFI-3575: Prevent unintended move events

2017-03-09 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1582 NIFI-3575: Prevent unintended move events - Verify that when moving a snippet, we do not attempt to move a process group into itself. - Update the UI to ensure a subsequent move event cannot

[GitHub] nifi issue #1574: NIFI-3541 Add copying of local network interface for DtoFa...

2017-03-08 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1574 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1572: NIFI-3334 Fix Update Run Duration

2017-03-09 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1572 Thanks @jvwing! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1574: NIFI-3541 Add copying of local network interface for DtoFa...

2017-03-09 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1574 Thanks @apiri! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1590: NIFI-3244: Updating rendering of parent of Controll...

2017-03-13 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1590 NIFI-3244: Updating rendering of parent of Controller Service NIFI-3244: - Updating Controller Service scope header. - Rendering the name of the parent when possible. - Fixing the check

[GitHub] nifi pull request #1593: NIFI-3245: Controller Service availability note

2017-03-13 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1593 NIFI-3245: Controller Service availability note NIFI-3245: - Adding notes to the controller service tables to better define their availability. - Clarifying support of Safari. You can

[GitHub] nifi pull request #1594: NIFI-3246: Prevent editing of inherited Controller ...

2017-03-14 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1594 NIFI-3246: Prevent editing of inherited Controller Services NIFI-3246: - Preventing the editing of controller services that are defined in an ancestor process group. - Adding a go to link

[GitHub] nifi issue #1572: NIFI-3334 Fix Update Run Duration

2017-03-08 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1572 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1591: NIFI-3243: Rendering the selected Process Group in ...

2017-03-13 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1591 NIFI-3243: Rendering the selected Process Group in the header if possible NIFI-3243: - Rendering the selected Process Group in the header if possible. You can merge this pull request into a Git

[GitHub] nifi pull request #1585: NIFI-3380 Support Multiple Versions of the Same Com...

2017-03-13 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1585#discussion_r105758869 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/pom.xml --- @@ -440,6 +440,7

[GitHub] nifi pull request #1585: NIFI-3380 Support Multiple Versions of the Same Com...

2017-03-13 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1585#discussion_r105759544 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-actions.js --- @@ -1214,6 +1217,23

[GitHub] nifi issue #1555: NIFI-3548: Fixed bug that caused failed requests to not ge...

2017-03-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1555 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1555: NIFI-3548: Fixed bug that caused failed requests to not ge...

2017-03-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1555 Thanks @markap14. This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1559: [NIFI-3035] add deep linking URL to canvas components and ...

2017-03-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1559 Will Review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1560: [NIFI-3550] inject nf.ConnectionConfiguration into the nf....

2017-03-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1560 Will Review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1560: [NIFI-3550] inject nf.ConnectionConfiguration into the nf....

2017-03-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1560 Thanks @scottyaslan! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-04-05 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/1644 @trixpan Sorry for the delay, I must have missed the mention on this PR. Evaluating EL can lead to different types of Exceptions depending on the issue with the statement

[GitHub] nifi pull request #1657: NIFI-3683: Ensuring the correct policy is displayed

2017-04-07 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/1657 NIFI-3683: Ensuring the correct policy is displayed NIFI-3683: - Ensuring we use the appropriate action based on the previously displayed policy. You can merge this pull request into a Git

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130962746 --- Diff: pom.xml --- @@ -95,7 +95,7 @@ 9.4.3.v20170317 4.10.4 4.2.4.RELEASE -4.0.3.RELEASE

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130962379 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130871309 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r130873359 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessResource.java

[GitHub] nifi-registry pull request #3: NIFIREG-6 Adding nifi-registry-bootstrap modu...

2017-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/3#discussion_r131141483 --- Diff: nifi-registry-runtime/src/main/java/org/apache/nifi/registry/NiFiRegistry.java --- @@ -18,22 +18,69 @@ import

[GitHub] nifi-registry pull request #3: NIFIREG-6 Adding nifi-registry-bootstrap modu...

2017-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/3#discussion_r131150677 --- Diff: nifi-registry-runtime/src/main/java/org/apache/nifi/registry/NiFiRegistry.java --- @@ -43,28 +90,242 @@ public void run

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2047 NIFI-4210: Add support for OpenId Connect NIFI-4210: - Introducing support for OpenId Connect. - Updating REST API and UI to support the authorization code flow. You can merge this pull

[GitHub] nifi issue #2044: NIFI-4139 Extract key provider to framework-level service

2017-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2044 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #2051: NIFI-4224: Initial implementation of Process Group level V...

2017-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2051 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #2047: NIFI-4210: Add support for OpenId Connect

2017-08-03 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/2047#discussion_r131135419 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc

[GitHub] nifi-registry issue #3: NIFIREG-6 Adding nifi-registry-bootstrap module

2017-08-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi-registry/pull/3 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #2087: NIFI-4295: When determining which controller services to r...

2017-08-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2087 Will review... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #2072: NIFI-3232: Adding support for cascading sub context...

2017-08-10 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/2072 NIFI-3232: Adding support for cascading sub context menus NIFI-3232: - Adding support for cascading sub context menus. You can merge this pull request into a Git repository by running

[GitHub] nifi-registry issue #1: NIFIREG-1 Initial project structure for NiFi Registr...

2017-07-13 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi-registry/pull/1 Thanks @bbende! This has been merged to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1872: NIFI-106: Expose processors' counters in Stats Hist...

2017-07-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1872#discussion_r127739416 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/endpoints

[GitHub] nifi pull request #1872: NIFI-106: Expose processors' counters in Stats Hist...

2017-07-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1872#discussion_r127742238 --- Diff: nifi-api/src/main/java/org/apache/nifi/controller/status/ProcessorStatus.java --- @@ -234,6 +245,7 @@ public ProcessorStatus clone

[GitHub] nifi pull request #1872: NIFI-106: Expose processors' counters in Stats Hist...

2017-07-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/1872#discussion_r127741268 --- Diff: nifi-framework-api/src/main/java/org/apache/nifi/controller/status/history/StatusHistory.java --- @@ -41,4 +41,9 @@ * @return List

<    1   2   3   4   5   6   7   8   9   10   >