GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1871
NIFI-3719: Address timezone issue when formatting hours/minutes/seconds
NIFI-3719:
- Removing the usage of SimpleDateFormat when formatting
hours/minutes/seconds as the current timezone could
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1644
@trixpan I believe there a couple other instances where we are evaluating
an expression where we are still just catching ProcessException. Specifically,
I believe we also need this adjustment when
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1897
NIFI-3653: Introduce ManagedAuthorizer
NIFI-3653:
- Introducing UserGroup and Policy provider interfaces.
- Introducing FileUserGroupProvider and FileAccessPolicyProvider.
- Refactoring
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1900
NIFI-4019: Added support for X-Forwarded-* headers
NIFI-4019:
- Adding support for X-Forwarded-* headers.
- Unrelated code clean up.
You can merge this pull request into a Git repository
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1903
NIFI-4045: POST lineage may not respond with eventId
NIFI-4045:
- Addressing issues causing the eventId to not be relayed when submitting a
lineage request under certain conditions.
You can
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1893
NIFI-4027: Restoring tooltips in the toolbar
NIFI-4027:
- Fixing the positioning of the tooltips in the component toolbar.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1897
I'll be posting another commit to this PR to more easily allow providers to
map their users, groups, and policies to the internal data model. Also, have
minor documentation and error message tweaks
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1897
For those reviewing... just pushed a follow-up commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman closed the pull request at:
https://github.com/apache/nifi/pull/1900
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1900
Yup. Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1923
NIFI-4059: Introduce LdapUserGroupProvider
NIFI-4059:
- Introducing the LdapUserGroupProvider.
- Updating documentation accordingly.
- Moving the IdentityMapping utilities so they were
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1900
Thanks for catching those @jtstorck! Will update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1923
Thanks @pvillard31 for having a look at this PR! I've addressed the two
issues above and I think resolving the group name when searching users only and
detecting group membership is supported. Check
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1725
NIFI-3762: Fixing JS errors when referencing services are out of scope
NIFI-3762:
- Addressing issue when enabling/disabling controller services when
referencing services are not in scope
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1725
@markap14 - I was hoping you might be able to evaluate the PR in the
environment where you first encountered the issue.
@scottyaslan - I was hoping you might be able to review some of the finer
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1757
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1759
NIFI-3808: Conflicting style name
NIFI-3808:
- Renaming styles used for showing the enable/disable state of referencing
services. Previously name was too general and was affect other parts
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1757
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1760
NIFI-3801: Making the version text next to the component name more subtle
NIFI-3801:
- Making the version text next to the component name more subtle.
You can merge this pull request into a Git
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1718
@trixpan How did you want to handle this PR? Should we get this part merged
into master and then the UI work can follow? The only reason this might be a
good idea is that we won't have to struggle
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1751
Thanks @alopresto. Verified that that tests in question pass on my Windows
10 VM. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1751
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1752
NIFI-3800: Cleaning up the headers when replicating requests
NIFI-3800:
- Cleaning up the headers when replicating requests.
There is still some testing efforts ongoing but I wanted
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1726
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1730
NIFI-3764: Ensuring that UUIDs are not converted multiple times during
template export
NIFI-3764:
- Ensuring that UUIDs are not converted multiple times during template
export
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1848
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1644
@trixpan I think the most recent commit does address the remaining spots,
however it appears break a unit test. Do you mind updating? Looking at the
failure in the Travis build, I believe the new
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2170
Thanks for the PR @yuri1969! I had tried implementing this awhile back
allowing the user to tab into the table and then navigate from there. I wasn't
thrilled with the solution has it required
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2167
I don't think we can always add the group name to the BulletinDTO. A user
could have permissions to the component generating the bulletin but not the
Process Group the component lives in. Adding
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2167
That is correct. Knowledge of the components (UUID, status, etc) is
allowed. Knowledge of what those components are/how they are configured is not.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2084
@joewitt Thanks for reviewing the L concerns...
@alopresto Reviewing...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2084
@alopresto I believe the exclusions for the solr processors are incorrect.
`jackson-core` has been excluded but not explicitly added. Also, I noticed that
the change to `jackson-annotations` made
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2134
Thanks @alopresto! I've made some minor adjustments to your PR to address
the merge conflicts and the error I reported earlier. This has now been merged
to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2170
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2200
@yuri1969 What is your JIRA username? I should be able to grant you
additional permissions. Thanks.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2170
Thanks @yuri1969! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2178
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2178
Thanks @yuri1969! This has been merged to master. Just FYI - I made a minor
tweak to your commit to ensure the counter name was properly escaped prior to
passing it to `nfDialog`.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2178
@yuri1969 no worries! It was a trivial tweak and the rest looked great.
Thanks again!
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2209
Thanks @andrewmlim! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2210
NIFI-4481: Visualize Processors Running on Primary Node
NIFI-4481:
- Adding support for visualizing if a component is scheduled for primary
node only.
[Visualization](https
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2209
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2134
Will review...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2135
NIFI-4280: Introduce UI for managing variables
NIFI-4280:
- Adding support for the user to configure variables in the UI.
- Updating the endpoints for changing variables as necessary.
You
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2126
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2134
Thanks for the PR @alopresto! I've run into a small issue with one of my
tests. When I upload a template into my NiFi instance subsequent restarts fail
with the following exception
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2119#discussion_r137876726
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2119#discussion_r137875951
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2119#discussion_r137877545
--- Diff:
nifi-commons/nifi-utils/src/main/java/org/apache/nifi/util/file/FileUtils.java
---
@@ -592,4 +592,41 @@ public static boolean isSame(final File
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2137
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2137
Thanks @combineads! This has been merged to master. Great catch!
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2119
Thanks @pvillard31! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2126
Thanks @yuri1969! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2128
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/8
The PR is a great starting point for the registry front end. Obviously,
there is some work remaining to get the front end and back end integrated but
we can file subsequent JIRAs
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/8#discussion_r137053368
--- Diff:
nifi-registry-web-ui/src/main/webapp/components/administration/users/nf-registry-users-administration.js
---
@@ -0,0 +1,128
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/8#discussion_r137048675
--- Diff: nifi-registry-web-ui/src/main/webapp/nf-registry.routes.js ---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/8#discussion_r137049115
--- Diff: nifi-registry-web-ui/src/main/platform/core/LICENSE.md ---
@@ -0,0 +1,22 @@
+The MIT License
--- End diff --
Let's license
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/8#discussion_r137051887
--- Diff: nifi-registry-web-ui/src/main/frontend/package.json ---
@@ -0,0 +1,65 @@
+{
+ "name": "nifi-registry",
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/8#discussion_r137052037
--- Diff: nifi-registry-web-ui/src/main/platform/core/package.json ---
@@ -0,0 +1,33 @@
+{
+ "name": "@fluid-des
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/8#discussion_r137047620
--- Diff: nifi-registry-web-ui/src/main/webapp/nf-registry-bootstrap.js ---
@@ -0,0 +1,57 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2119
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/8
Thanks for updating @scottyaslan! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2119#discussion_r137878394
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/SystemDiagnosticsSnapshotDTO.java
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2128
Thanks @alopresto! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2177#discussion_r141159713
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/knox/KnoxService.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2177#discussion_r141158109
--- Diff:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
---
@@ -886,18 +893,70 @@ public String
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2177#discussion_r141157943
--- Diff:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
---
@@ -886,18 +893,70 @@ public String
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2177#discussion_r141159568
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/knox
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2177
A new commit has been pushed that addresses the comments received thus far.
Thanks for reviewing @jtstorck and @alopresto!
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2177
@alopresto I just rebuilt and the properties in `conf/nifi.properties`
start on line 167. Can you please double check for them?
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2177#discussion_r141158978
--- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc ---
@@ -282,20 +282,23 @@ For a client certificate that can be easily imported
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2177#discussion_r141159236
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/knox
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2177
Do you think that we should support logout in this case? If yes, Iâll
need to figure out the best way to handle this as currently logging out is
entirely client side and I believe this would
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2177
NIFI-4382: Adding support for Apache Knox SSO
NIFI-4382:
- Adding support for KnoxSSO.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2177
JIRAs for logout [1] and login splash screen [2].
[1] https://issues.apache.org/jira/browse/NIFI-4430
[2] https://issues.apache.org/jira/browse/NIFI-4431
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2179
NIFI-4413: Fixing issue viewing content when running behind a proxy
NIFI-4413:
- Using the incoming request to determine the appropriate scheme for the
data reference URI. Necessary for cases
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2177
Thanks again @alopresto for the review. I had observed the same behavior
where the user is redirected back to the login page when the token could not be
validated. I think a good path forward here
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2191
NIFI-4328: Upgrade Swagger
NIFI-4328:
- Upgrading swagger and the corresponding maven plugin to address issues
discovered in recursive domain models.
You can merge this pull request into a Git
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2109
NIFI-4324: Addressing sub context menu issue
NIFI-4324:
- Ensuring that sub context menus are removed when hiding to ensure they
are correctly (re)created during mouseenter events.
You can
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2115
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2115
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/8
Will review...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2116
NIFI-4224: Reopened Variable Registry at a Process Group Level
NIFI-4224:
- Ensuring the parent permissions are used when building the variable
registry for a process group ancestry.
You can
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2124
@yuri1969 @alopresto Just wanted to chime in that technically the
Controller Services in the Controller Settings are for Reporting Tasks and
other Controller Services denied there. For instance
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2084
Thanks @alopresto! Looks good. This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2195
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2206
Thanks @bbende. I've pushed another commit that addresses the checkstyle
issues.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2206
NIFI-: Upgrade to Jersey 2.x
NIFI-:
- Upgrading to Jersey 2.x.
- Updating NOTICE files where necessary.
You can merge this pull request into a Git repository by running:
$ git
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2206
This PR upgrades Jersey throughout NiFi where it is used directly. Most
transitive Jersey dependencies are left intact. The most significant changes
are centered in the clustering framework
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2216
NIFI-4497: Fixing issue preventing separators in sub context menus
NIFI-4497:
- Fixing issue preventing separators in sub context menus.
@scottyaslan Was hoping you could take a peek
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2219
NiFi-4436: Add UI controls for starting/stopping/reverting flow versioning
@markap14 Please review the frontend/backend integration of the early
version control capabilities utilizing the local
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2217
Reviewing...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2217
Thanks @jtstorck! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2219
I am going to update this PR to indicate that it is a work in progress as
merging will break the build because it depends on Registry artifacts. Will
hold off on merging until we either release
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2298
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2298
Thanks @markap14! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2306
NIFI-4646: AbstractRecordProcessor: Report reason for
SchemaNotFoundException
NIFI-4646:
- Ensuring the reason behind the SchemaNotFoundException is reported when
interacting
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2305
+1 Looks good @joewitt! Will merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2311
NIFI-4645: Remove activation rules for include the grpc bundle
NIFI-4645:
- Removing rule based activation because it was causing the
generateArchives profile to not activate. Now the grpc
601 - 700 of 1112 matches
Mail list logo
