Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2703
Thanks for having a look. I'll include these when I merge in your changes.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2750#discussion_r195449260
--- Diff:
nifi-nar-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/java/org/apache/nifi/processors/couchbase/AbstractCouchbaseProcessor.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2750#discussion_r195453378
--- Diff:
nifi-nar-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/java/org/apache/nifi/processors/couchbase/AbstractCouchbaseProcessor.java
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/123
@scottyaslan Thanks for the PR! It appears that some of the font weights
have changed. I'm not sure if we want to try to retain the existing look or use
the new styles from the newer
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r194495873
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r194498155
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r194499578
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r194496260
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r194495379
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r194503331
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r194512038
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2773
@zenfenan Correct. The cluster coordinator handles setting the node address
for the bulletins that are returned through the REST API. However, those are
not the same objects that are available
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2674
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2674
Thanks @bbende! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-fds/pull/2
Thanks @scottyaslan! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r192492247
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r192493635
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-volatile-provenance-repository/src/main/java/org/apache/nifi/provenance
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r192493603
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/authorization
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r192493531
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r192493550
--- Diff:
nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2752#discussion_r193081251
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-jetty/src/main/java/org/apache/nifi/web/server/JettyServer.java
---
@@ -689,6
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2763
NIFI-5237: Considering proxy headers follow OIDC login
NIFI-5237:
- Ensuring the proxy headers are considered when redirecting the user
following a OIDC or Knox login exchange.
You can merge
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2766
NIFI-3217: Preventing editor close on window resize
NIFI-3217:
- Disabling the resize of SlickGrid when there is an active edit occuring.
This will prevent the accidental closure
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2703#discussion_r191444067
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/controller/ControllerFacade.java
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2721
Thanks @scottyaslan! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2756
NIFI-5263: Fixing advice for auditing controller service actions
NIFI-5263:
- Fixing the advice auditing the method for updating controller service
referencing components.
You can merge
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2757
NIFI-5208: Fixing issue preventing connections from being moved.
NIFI-5208:
- Ensuring nf-storage is injected where necessary.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2831
Thanks @markap14! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2831
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2662
@alopresto I don't see the commit for this PR in master (unless I'm missing
it). Can you please double check that it was pushed? Thanks!
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2669
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2669
Thanks @markap14! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2509
@zenfenan Yeah I think we're on the same page here. Sorry for the different
suggestions earlier but I think we're ultimately getting it right here...
- `All nodes` should be disabled
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2662
NIFI-5124: Upgrading commons-fileupload
NIFI-5124:
- Upgrading to the latest version of commons-fileupload.
You can merge this pull request into a Git repository by running:
$ git pull
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2509
Hey @zenfenan... So I just checked out the updated PR. Things seem to be
running as suggested, however, I'm wondering if it makes sense to improve it a
little and in the process reduce
Github user mcgilman commented on the issue:
https://github.com/apache/nifi-registry/pull/115
Will review...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2673
NIFI-5135: User identities and group name transforms
NIFI-5135:
- Adding support for applying transforms to user identities and group names.
You can merge this pull request into a Git
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2227
NIFI-4518: Fixing URI issue when querying the bulletin board with many
source ids
NIFI-4518:
- When the URI is too long, invoking the bulletin board multiple times for
all specified component
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2377
Thanks @ijokarumawak! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2378
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2364
@yuri1969 Unfortunately, we consider the REST API to be a public API so we
cannot introduce breaking changes in non-major releases.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2378
Looks great @kevdoran! Verified ldap users could be added to file-based
groups and file-based groups are considered when authorizing an LDAP user. Will
merge.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2373
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2373
Thanks @mattyb149! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2374
NIFI-4739: Ensure logout action is using a relative URL
NIFI-4739:
- Ensuring the logout action is using a relative link.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2379
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2379
Thanks @mattyb149! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2385
NIFI-4436: Only enforcing registry unique name check when appropriate
NIFI-4436:
- Only enforcing the unique name check when the registry has a different
identifier.
You can merge this pull
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2382
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2382
Thanks @andrewmlim! These look great. Thanks for putting these together.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2387
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2387
Looks great @bbende! I have merged this to master. Just a heads up... made
a minor tweak to your PR to ensure all each provider has a chance to clean up
when an exceptional case occurs.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2394#discussion_r160995095
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-process-group.js
---
@@ -847,6 +870,7
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2394
Thanks @mgaido91! This has been merged to master.
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2394#discussion_r161001512
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-process-group.js
---
@@ -847,6 +870,7
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2370
NIFI-4733: Addressing two phase commit logic issue in variable registry
NIFI-4733:
- Resolving logic issue in two phase commit when updating variable registry.
You can merge this pull request
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2195
Yup. So sorry for the delay guys. Thanks @yuri1969! This has been merged to
master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2377
Will review...
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2370#discussion_r159700591
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2370#discussion_r159703818
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2370
Thanks @alopresto! I've addressed the comments here and I will merge to
master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2394
Thanks for submitting a PR for this @mgaido91! Would you be able to also
update the tooltips on the icons on the Process Group node on the canvas? They
should be in nf-process-group.js
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2394
The change should be pretty straight forward. Here is an example of setting
the title on the SVG elements [1]. In this example however, the tooltip is
dynamic and needs to be regularly updated. Your
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2395
NIFI-4754: Only show import link when appropriate
NIFI-4754:
- Only showing the import link in the new Process Group dialog when
initiating from the toolbar.
You can merge this pull request
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2394#discussion_r160740747
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/canvas/flow-status.jsp
---
@@ -17,23
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2213
Thanks @Senthilannaswamy! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2408
@ns7381 Thanks for the PR! I plan to start reviewing this soon.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2407
Thanks @sbouchex! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2407
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
I see. So the issue is with this annotation?
@ApiModelProperty(
value = "The state of the processor.",
allowableValues = "RUNNING, ST
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
We only use swagger for documentation generation. Changing the resulting
value would break the current API that existing clients expect. I believe the
best path forward would be to fix
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
In some cases, human-readable labels are generated and other cases not.
Often times we defer to the `toString` of the enum to drive the resulting value.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2213
@Senthilannaswamy I just double check the specification and the suggested
changes make sense.
> token_endpoint_auth_methods_supported
> OPTIONAL. JSON array containing a list of
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2415
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2415
Thanks @alopresto! This has been merged to master. I updated the items you
pointed out.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2418
NIFI-4761 Fixing test case regression.
NIFI-4761 Fixing test case regression.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2414
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2414
Thanks @sbouchex! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2410
Updating proxy documentation
NIFI-4766:
- Documenting nifi.web.proxy.host property.
- Updating proxy confiugration.
NIFI-4618:
- Documenting nifi.web.proxy.context.path property
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2364
@yuri1969 There appears to be a merge conflict with this branch and the
current state of master. I'll be unavailable for a couple days but should have
some time to devote to this review later next
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2428
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2428
Thanks @kevdoran! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
I'd suggest invoking the endpoints using curl or looking at Dev Tools in
your browser to verify that the issue is with NiFi.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2276
@sbouchex What version of NiFi are you running? When endpoint are you
invoking that is not setting this value? Are you running standalone or
clustered?
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2213
@Senthilannaswamy Thanks for issuing a PR! Sorry for the delay. Is there a
JIRA that explains the issue that this PR addresses?
---
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2157#discussion_r161298805
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/modal/jquery.modal.js
---
@@ -50,6 +50,7
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2157#discussion_r161299941
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/modal/jquery.modal.js
---
@@ -127,6 +128,10
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2364
@yuri1969 Thanks! Will start reviewing...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2364
@yuri1969 The introduction of the Parent group makes a lot of sense.
However, I thought the idea of the Top level group was a little confusing.
Technically, the Top level group is the Root group we
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2455
NIFI-4837: Addressing thread leak in HandleHTTPRequest
NIFI-4837:
- When Jetty initializes fails, performing a shutdown sequence to ensure
all allocated resources are released.
You can merge
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2464
Thanks! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2466
Thanks @alopresto! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2468
Will review...
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2471
NIFI-3502: Upgrading D3 version
NIFI-3502:
- Upgrading to D3 version 4.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman/nifi NIFI
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2435
Thanks @ijokarumawak! This has been merged to master.
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2453
Will review...
---
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2453
Thanks @ijokarumawak! This has been merged to master.
---
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/2482
NIFI-4894: Ensuring that any proxy paths are retained when querying for
bulletins
NIFI-4894:
- Ensuring that any proxy paths are retained when querying for bulletins.
You can merge this pull
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2471#discussion_r169394276
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/canvas/nf-canvas.js
---
@@ -996,34 +1030,42
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2364
Thanks @yuri1969! This has been merged to master.
---
801 - 900 of 1112 matches
Mail list logo
