[GitHub] nifi pull request #1462: NIFI-819 - Extend GetHTTP to use dynamically add HT...

2017-02-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1462#discussion_r99038757 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GetHTTP.java --- @@ -467,6 +486,18

[GitHub] nifi-site pull request #11: NIFI-1448 - Update NiFi and MiNiFi site to use t...

2017-02-01 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi-site/pull/11 NIFI-1448 - Update NiFi and MiNiFi site to use the new ASF branding @apiri can you have a look at this PR? You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-02-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 @brianburnett can't you simply rebase? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1480: NIFI-1657 - Configure travis-ci to run mvn verify i...

2017-02-07 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1480 NIFI-1657 - Configure travis-ci to run mvn verify in jp and fr Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 I changed the commit a bit so to use envs (I think things should move faster this way) I reckon we should merge and use it to correct residual issues. This second attempt should hopefully

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 by the way, just in case someone ever wonder the rationale behind the countries: basic English (Java's default env), a Latin and a "Asian" language with no official status at the UN. -

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 good catch! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 Only if you commit to port NiFi to minitel. :rofl: ... Just kidding, done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 seems good to go. failures were caused by TCP processors --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1462: NIFI-819 - Extend GetHTTP to use dynamically add HTTP head...

2017-02-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1462 @apiri just pushed a refreshed version of the code. let me know how it goes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1473: NIFI-940 - Exposes filename attribute to DFM on PutFile, P...

2017-02-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1473 still not ready to commit as sftp and ftp modification have not yet been added to commit. Hope to finish those in the next few days. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #1473: NIFI-940 - Exposes filename attribute to DFM on Put...

2017-02-05 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1473 NIFI-940 - Exposes filename attribute to DFM on PutFile, PutHDFS, Put… …SFTP, PutFTP Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #1474: NIFI-3442 - Explictly support EL on Username, password, po...

2017-02-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1474 @markap14 you may want to have a look note that in the case of transfer method I simply removed the EL evaluation. Happy to follow the opposite approach if needed --- If your project is set

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

2017-02-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1108 @joewitt when you have time can you have a final look on this one? LGTM and I am happy to address the two remaining cosmetic comments as part of a separate PR. --- If your project is set up

[GitHub] nifi issue #1472: NIFI-3434 - Introduce the ability to skip the packaging of...

2017-02-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1472 @pvillard31 @apiri done. Please note I added a second commit as this helps keeping track of why the travis file was changed. --- If your project is set up for it, you can reply

[GitHub] nifi issue #1418: NIFI-3238 - Introduce ListenBeats processor and deprecates...

2017-02-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1418 @nickcarenza thanks for the feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1418: NIFI-3238 - Introduce ListenBeats processor and deprecates...

2017-02-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1418 For future reference: https://discuss.elastic.co/t/testers-wanted-beat-integration-with-apache-nifi/73671/ --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request #1472: NIFI-3434 - Introduce the ability to skip the packa...

2017-02-03 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1472 NIFI-3434 - Introduce the ability to skip the packaging of zip and ta… …r.gz archive via maven profile (i.e. -Pdir-only) Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #1467: NIFI-3408 Add exception class when InvokeHTTP fails

2017-02-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1467 @gglanzani - thank you for the contribution. Code looks great but would it be possible for you to extend the test harness to include a test that will trigger your code(i.e. failure

[GitHub] nifi pull request #1422: NIFI-3015 - Corrects issue were RPM profile run.as ...

2017-01-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1422#discussion_r97304871 --- Diff: nifi-assembly/pom.xml --- @@ -19,6 +19,10 @@ language governing permissions and limitations under the License. --> nifi-assem

[GitHub] nifi issue #1421: NIFI-3352 - Address issue where ListenLumberjack was sendi...

2017-01-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1421 @joewitt sure thing: https://github.com/elastic/logstash-forwarder/blob/master/PROTOCOL.md#ack-frame-type --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1335 @ijokarumawak reviewing it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1335 LGTM merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1519: [NIFI3501] Upgrade D3 to 3.5.17 and allow npm to pull it d...

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1519 @mcgilman any chance of having a look on this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1240: NIFI-3039 Provenance Repository - Fix PurgeOldEvent and Ro...

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1240 @bbende @markap14 or @joewitt I suspect this PR and its 0.x counterpart will benefit from having one of you reviewing it? --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #1526: NIFI-3514 - Ensures ListGCPBucket triggers serially...

2017-02-22 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1526 NIFI-3514 - Ensures ListGCPBucket triggers serially and forbids inputs Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask

[GitHub] nifi issue #1526: NIFI-3514 - Ensures ListGCPBucket triggers serially and fo...

2017-02-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1526 @jvwing @gene-telligent - would you mind having a look ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1378: NIFI-2952 Fixed search value validation in ReplaceText

2017-02-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1378 @pvillard31 :rofl: yeah... wrong PR but glad you got it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1395: NIFI-3280 PostHTTP Option to write response to attribute o...

2017-02-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1395 @nickcarenza - welcome. We all have been in that very same boat once. :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1148 @mauriziocolleluori thank you for the contribution. any intent on addressing @pvillard31 's comment? While a positive answer is more than welcome, a negative answer is also welcome... all we

[GitHub] nifi issue #1332: NIFI-3163: Flow Fingerprint should include new RPG configu...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1332 @ijokarumawak - This PR needs rebasing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101915884 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101915841 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916076 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** The Get/PutAWSIoT processors read and overwrite mqttClient many times without a read/write lock, this can lead to problems in multi-threaded scenarios. For example, the both

[GitHub] nifi pull request #1387: NIFI-1797 - Added compression codec property to Cre...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1387#discussion_r101913412 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/CreateHadoopSequenceFile.java

[GitHub] nifi issue #349: NIFI-1767 AWS IoT processors

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/349 @joewitt - I am happy to adopt the stalled PR and address @JPercivall 's comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 JPercivall Does AWS IoT support communicating over SSL with MQTT or shadows? If so, that option should be added. --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** Currently the only tests are integration tests that rely on an AWS instance. I would like to see more true unit tests. For inspiration, check out the Publish/Consume MQTT unit

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** A couple places have weird comments like "// @TRACE 252=connect to host {0} port {1} timeout {2}". Is this a convention I'm not aware of or left over from

[GitHub] nifi issue #399: NIFI-1833 - Adding Azure Storage processors

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/399 @slachterman - thank you for the handy link --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916101 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/util/IoTMessage.java --- @@ -0,0 +1,44

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916129 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/PutAWSIoTShadow.java --- @@ -0,0 +1,107

[GitHub] nifi issue #1521: NIFI-1767 - Add IOT-Processors for reading and writing AWS...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 @JPercivall @joewitt The original PR seems to contain significant sections of code that are close to an old version of the following code: https://github.com/inventit/mqtt

[GitHub] nifi issue #1395: NIFI-3280 PostHTTP Option to write response to attribute o...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1395 @nickcarenza thank you for the contribution. May I ask you to squash the commit as requested by the PR template? ` Is your initial contribution a single, squashed commit?` At least

[GitHub] nifi issue #1331: NIFI-3196 Provide MiNiFi FlowStatus Insights processor tha...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1331 @apsaltis - loved the idea behind this contribution - I'm also very much in favor of fitting MiNiFi with existing systems - and perhaps that's the reason for my first question

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1521 NIFI-1767 - Added 1st iteration of IOT-Processors for reading and wri… …ting AWS IOT shadow and MQTT topics This closes: #349 Thank you for submitting a contribution to Apache

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** I actually already committed general MQTT processors [1] and they have some good "best practices" with regards to publishing/consuming messages and MQTT I think wou

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 **JPercivall** A bit nit picky and I may be alone here, but I find putting "if" statements and their content on the same line a bit hard to read when trying to read someone e

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916245 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoTShadow.java --- @@ -0,0 +1,114

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916202 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/GetAWSIoTShadow.java --- @@ -0,0 +1,114

[GitHub] nifi issue #1331: NIFI-3196 Provide MiNiFi FlowStatus Insights processor tha...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1331 @apsaltis - glad comments were helpful. New PR or not, the work is truly great and I can confess that with the exception of Azure components I will very likely be using it the outcome

[GitHub] nifi issue #1521: NIFI-1767 - Added 1st iteration of IOT-Processors for read...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 @KayLerch - Thank you for the contribution, I squashed your commit but left attribution untouched so credit is due to who deserves it. @JPercivall this is not ready to review. For now the PR

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916052 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916039 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/AbstractAWSIoTProcessor.java --- @@ -0,0

[GitHub] nifi pull request #1521: NIFI-1767 - Added 1st iteration of IOT-Processors f...

2017-02-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1521#discussion_r101916002 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/iot/util/MqttWebSocketAsyncClient.java

[GitHub] nifi issue #1521: NIFI-1767 - Add IOT-Processors for reading and writing AWS...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 https://github.com/aws/aws-iot-device-sdk-java --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1521: NIFI-1767 - Add IOT-Processors for reading and writing AWS...

2017-02-19 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1521 To further my above comments, it seems that shortly after the original PR, AWS released an IoT SDK for Java under ASL2 license. I vote we close this PR and restart work using AWS' own SDK

[GitHub] nifi issue #1290: Fix NIFI-3142: ExtractHL7Attribute processor: Route a flow...

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1290 @klinvill Is this PR still needed or was it identified as a data quality issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 @brianburnett I suspect the reason for that is because you are trying to cherry-pick from the branch you already have a commit. Note how I suggested you to circle around

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102860737 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java --- @@ -0,0

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102854106 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/pom.xml --- @@ -0,0 +1,39 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://w

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102854253 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-nar/pom.xml --- @@ -0,0 +1,41 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi issue #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1529 @WilliamNouet - thank you for the contribution. Had a quick look and added some comments. Other will probably want to have a look as well. --- If your project is set up for it, you can reply

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102860592 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java --- @@ -0,0

[GitHub] nifi issue #1528: NIFI-385 Add Kerberos support in nifi-kite-nar

2017-02-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1528 @WilliamNouet this looks like a duplicated PR from the other one introducing Morphlines? If so, mind to close it? --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102853739 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/pom.xml --- @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102854353 --- Diff: nifi-nar-bundles/nifi-kite-bundle/nifi-kite-processors/pom.xml --- @@ -40,7 +40,21 @@ org.apache.nifi nifi-utils

[GitHub] nifi issue #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1529 @WilliamNouet to squash commit just checkout your branch and run: `git rebase -i` and follow the squash process as very well exemplified here: http://gitready.com/advanced

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102855578 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/pom.xml --- @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1529: NIFI-3518 Create a Morphlines processor

2017-02-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1529#discussion_r102856855 --- Diff: nifi-nar-bundles/nifi-morphlines-bundle/nifi-morphlines-processor/src/main/java/org/apache/nifi/processors/morphlines/Morphlines.java --- @@ -0,0

[GitHub] nifi issue #1528: NIFI-385 Add Kerberos support in nifi-kite-nar

2017-02-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1528 Thanks for the heads up @pvillard31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1541: NIFI-329 - Introduce IRC Client Services and Consum...

2017-02-24 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1541 NIFI-329 - Introduce IRC Client Services and ConsumeIRC processor Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #1541: NIFI-329 - Introduce IRC Client Services and ConsumeIRC pr...

2017-02-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1541 also note that the easier way of setting up an IRC for testing is to spin up miniircd, which works like a charm for basic testing --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1541: NIFI-329 - Introduce IRC Client Services and ConsumeIRC pr...

2017-02-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1541 this PR still not ready to review, however given this is the first time I am putting together a ControllerService I would appreciate some early feedback. As you can see, design

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-17 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1335 @ijokarumawak merged. However I forgot to add reference to the PR in the commit message. Would you mind closing it manually ? I thank you in advance --- If your project is set up

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/379 @pvillard31 that connection strategy is agnostic to the underlying filesystem supporting alluxio. What it does is to allow a hadoop compatible application to access alluxio without further coding

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/379 And by last comment I naturally refer to use a customised core-site.xml that includes: ``` fs.alluxio.impl alluxio.hadoop.FileSystem The Alluxio FileSystem (Hadoop 1.x

[GitHub] nifi issue #379: NIFI-1022 Added Tachyon/Alluxio processors

2017-02-21 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/379 @pvillard31 not sure if it is the case but have you by any chance tried to use the Hadoop alluxio interfaces with puthdfs and co instead of a new processor? e.g https

[GitHub] nifi pull request #1521: NIFI-1767 - Add IOT-Processors for reading and writ...

2017-02-20 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/1521 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #349: NIFI-1767 AWS IoT processors

2017-02-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/349 Thabk Kay, would it be possible to close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #689: NIFI-2305: Do not run processors that are marked as Primary...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/689 @markap14 @JPercivall Given we getting well into 1.2, should this PR still go ahead? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #913: NIFI-2440 - Add 'file.lastModifiedTime' attribute to ListSF...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/913 @jskora closed it. Whenever this happens you can simply push an empty commit to git with the fixed reference to the PR --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #709: NIFI-2369 - Added EL support to CSV properties

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/709 @simonellistonball ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1328: NIFI-1682 Adding RollingWindowOperation processor

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1328 @JPercivall - needs rebasing again. :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-09 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 - this seems to be working now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1370: NIFI-3057 Added provenance events to PutElasticsearch and ...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1370 @pvillard31 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1474: NIFI-3442 - Explictly support EL on Username, password, po...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1474 @alopresto - the missing amendments have been uploaded and hopefully also addressed the comments made earlier --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1474: NIFI-3442 - Explictly support EL on Username, password, po...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1474 PR still not complete Andy. My bad --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #1474: NIFI-3442 - Explictly support EL on Username, passw...

2017-02-14 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1474#discussion_r101007316 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -230,6 +230,12 @@ language governing permissions and limitations

[GitHub] nifi pull request #1505: NIFI-2565 - Add Elastic copyright to notice due to ...

2017-02-14 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1505 NIFI-2565 - Add Elastic copyright to notice due to the use of grok patterns during test since the patterns used during testing were originally defined here https://github.com/logstash

[GitHub] nifi pull request #1474: NIFI-3442 - Explictly support EL on Username, passw...

2017-02-14 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1474#discussion_r101007689 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutFTP.java --- @@ -0,0 +1,90

[GitHub] nifi pull request #1474: NIFI-3442 - Explictly support EL on Username, passw...

2017-02-14 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1474#discussion_r101007664 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutFTP.java --- @@ -0,0 +1,90

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-08 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 by the way, good catch, I had faced this issue before but totally forgot about it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-08 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 seems great. will do it and force push soon --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1480: NIFI-1657 - Configure travis-ci to run mvn verify in jp an...

2017-02-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1480 @pvillard31 - after a few hundred builds and options build seems to be having as expected: https://travis-ci.org/trixpan/nifi/builds/200568234 when environment is set to en_US

[GitHub] nifi issue #1383: NIFI-2859 - Ignore files starting with a dot in ListHDFS

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1383 @pvillard31 @bbende LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi issue #1481: NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatExce...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1481 @mosermw ohhh. wasn't aware of it. thanks for sharing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1505: NIFI-2565 - Add Elastic copyright to notice due to the use...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1505 @apiri hopefully this time it looks a bit better... yes... it is a fork of a fork. :crying_cat_face: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1326: NIFI-2779 - Add processor to GetEmail Supporting Exchange ...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1326 you did a merge and that dragged dozens of committed commits into this PR. Instead you may want to do: ``` git checkout master -b NIFI-2779v2 git cherry-pick git push

<    1   2   3   4   5   6   7   >