[GitHub] nifi issue #1481: NIFI-3055 StandardRecordWriter Can Throw UTFDataFormatExce...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1481 @markap14 I suspect the reason is @mosermw added the closure after the signature and closure should come above sign-off-by? --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1326: NIFI-2779 - Add processor to GetEmail Supporting Exchange ...

2017-02-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1326 @patricker merge after build, reviewed code and ran against an exchange server. Seems to be working fine. thank you for the contribution! --- If your project is set up for it, you can

[GitHub] nifi issue #1505: NIFI-2565 - Add Elastic copyright to notice due to the use...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1505 Epic. Will adjust --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #972: NIFI-2711 - Making top-level nifi-assemblies directory with...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/972 @brosander is the PR still wanted? If yes, mind rebasing? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1326: NIFI-2779 - Add processor to GetEmail Supporting Exchange ...

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1326 @patricker can you please rebase as changes to master are causing conflicts ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #453: Nifi 539c

2017-02-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/453 @eorgad , this PR is nearly 1 year old do you still plan to address some of the feedback? Would you mind closing the PR for now? --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1335: NIFI-3213: ListFile - Do not skip obviously old files.

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1335 @ijokarumawak my bad. I was just running a extra set of compilations and I noticed that under certain conditions there seems to be a race condition affecting ``` Tests run: 12, Failures

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 That was a merge, not a rebase :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 Try git checkout master -b nifi-2724v2 git cherry-pick git push origin nifi-2724 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 Try git checkout master -b nifi-2724v2 git cherry-pick your commit hash git push - f origin nifi-2724 This will create a temporary branch Allow you to copy a commit from

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-02-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 No no. Cherry pick your commit number. You will likely to fix conflicts in the process but git will flag those files with conflict so once you fix it should be ok at the end --- If your

[GitHub] nifi issue #1402: NIFI-3288: Add Clojure support for ExecuteScript

2017-01-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1402 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1108: NIFI-2565: add Grok parser

2017-01-16 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1108#discussion_r96236367 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java --- @@ -0,0

[GitHub] nifi pull request #420: NIFI-1280 Create FilterCSVColumns Processor.

2017-01-16 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/420#discussion_r96251033 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -235,6 +235,11 @@ language governing permissions and limitations under

[GitHub] nifi issue #1198: [NIFI-3015] Run NiFi service from nifi user instead of roo...

2017-01-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1198 @jfrazee - odd. Should the bootstrap.conf `run.as` be [populated](https://github.com/apache/nifi/blob/d838f61291d2582592754a37314911b701c6891b/nifi-nar-bundles/nifi-framework-bundle/nifi-framework

[GitHub] nifi issue #1302: NIFI-2656: replace -k [password] with -K [passwordfile].

2017-01-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1302 @alopresto ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #991: NIFI-2742 - Explicitly declare the kite hadoop depen...

2017-01-16 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/991 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #397: NIFI-1815

2017-01-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/397 @jdye64 is the PR active or should we close it? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #1421: NIFI-3352 - Address issue where ListenLumberjack wa...

2017-01-16 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1421 NIFI-3352 - Address issue where ListenLumberjack was sending long num… …bers back to clients - instead of int Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi issue #709: NIFI-2369 - Added EL support to CSV properties

2017-01-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/709 @simonellistonball @mattyb149 should we perhaps close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #1326: NIFI-2779 - Add processor to GetEmail Supporting Ex...

2017-01-16 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1326#discussion_r96258831 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ConsumeEWS.java --- @@ -0,0 +1,518

[GitHub] nifi pull request #1326: NIFI-2779 - Add processor to GetEmail Supporting Ex...

2017-01-16 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1326#discussion_r96259066 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ConsumeEWS.java --- @@ -0,0 +1,518

[GitHub] nifi issue #1326: NIFI-2779 - Add processor to GetEmail Supporting Exchange ...

2017-01-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1326 @patricker Joe will have a more complete view on this but looking at the MSFT code there seem to be some dependencies with NOTICE. From top of my mind, joda-time, commons-io and others that must

[GitHub] nifi pull request #1422: NIFI-3015 - Corrects issue were RPM profile run.as ...

2017-01-16 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1422#discussion_r96312325 --- Diff: nifi-assembly/pom.xml --- @@ -19,6 +19,10 @@ language governing permissions and limitations under the License. --> nifi-assem

[GitHub] nifi pull request #1422: NIFI-3015 - Corrects issue were RPM profile run.as ...

2017-01-19 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1422#discussion_r96984003 --- Diff: nifi-assembly/pom.xml --- @@ -19,6 +19,10 @@ language governing permissions and limitations under the License. --> nifi-assem

[GitHub] nifi pull request #1422: NIFI-3015 - Corrects issue were RPM profile run.as ...

2017-01-16 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1422#discussion_r96322520 --- Diff: nifi-assembly/pom.xml --- @@ -19,6 +19,10 @@ language governing permissions and limitations under the License. --> nifi-assem

[GitHub] nifi pull request #1422: NIFI-3015 - Corrects issue were RPM profile run.as ...

2017-01-16 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1422 NIFI-3015 - Corrects issue were RPM profile run.as property was not b… …eing used This supersedes #1198 Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi issue #1422: NIFI-3015 - Corrects issue were RPM profile run.as propert...

2017-01-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1422 @fidget83 and @jfrazee mind having a look and let me know if it addresses the issue? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1422: NIFI-3015 - Corrects issue were RPM profile run.as propert...

2017-01-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1422 Reviewers: Key here is that bootstrap.conf with RPM profile should result on `run.as=nifi` while vanilla build should result in `run.as=` (naturally assuming nothing else breaks

[GitHub] nifi pull request #871: NIFI-2519 - ListenSMTP addresses mismatch between sm...

2016-08-15 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/871 NIFI-2519 - ListenSMTP addresses mismatch between smtp.src attribute … …documentation and attribute.put You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75580268 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 The error is expected as the regex does not contain a capture group named KEY. It is a bug as I should detect KEY or whatever value was chosen. But your feedback

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75579997 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/pom.xml --- @@ -63,5 +63,31 @@ nifi-mock test

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75580295 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75580308 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/enrich/TestQueryWhois.java --- @@ -0,0 +1,187

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75579988 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/pom.xml --- @@ -63,5 +63,31 @@ nifi-mock test

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 As you can see the KEY group is documented within NiFi code but the UI lacks such explanation https://github.com/apache/nifi/pull/858/files#diff-d13cbfd36645869513f9d09b76636240R183

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103645596 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,233

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103647459 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/pom.xml --- @@ -0,0 +1,76 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103648185 --- Diff: nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/ListenLumberjack.java

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103648209 --- Diff: nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/event/LumberjackEvent.java

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103649158 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,216

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103650361 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0 +1,330

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103651066 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0 +1,330

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103652588 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0 +1,330

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-03-01 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103653787 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,216

[GitHub] nifi issue #1541: NIFI-329 - Introduce IRC Client Services and ConsumeIRC pr...

2017-03-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1541 processor logic is theoretically complete. Now finishing the IRC over TLS logic --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi pull request #1016: NIFI-2724 New JMX Processor

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1016#discussion_r103875353 --- Diff: nifi-nar-bundles/nifi-jmx-bundle/nifi-jmx-processors/pom.xml --- @@ -0,0 +1,67 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-03-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 Looks good. Will review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi pull request #1016: NIFI-2724 New JMX Processor

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1016#discussion_r103875643 --- Diff: nifi-nar-bundles/nifi-jmx-bundle/nifi-jmx-processors/src/main/java/org/apache/nifi/processors/jmx/GetJMX.java --- @@ -0,0 +1,415

[GitHub] nifi pull request #1016: NIFI-2724 New JMX Processor

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1016#discussion_r103875149 --- Diff: nifi-nar-bundles/nifi-jmx-bundle/nifi-jmx-processors/pom.xml --- @@ -0,0 +1,67 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi

[GitHub] nifi pull request #1551: NIFI-3054 - Create default all default directions a...

2017-03-02 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1551 NIFI-3054 - Create default all default directions as part of maven-as… …sembly Update Admin Guide with recommended directory permissions Update some minor

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-02 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1553 NIFI-1449 - Migrate PutEmail tests from Mock class to ListenSMTP Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #1552: NIFI-3544 - Fixes minor typo n ExtractEmailHeaders ...

2017-03-02 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1552 NIFI-3544 - Fixes minor typo n ExtractEmailHeaders log message Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi issue #1553: NIFI-1449 - Migrate PutEmail tests from Mock class to List...

2017-03-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1553 @joewitt - Perhaps you would you be able to give me some insight here. For some reason when I run the following lines of testOutgoingMessageAttachment

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103599675 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/ListenBeats.java --- @@ -0,0 +1,216

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103599499 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-nar/src/main/resources/META-INF/LICENSE --- @@ -0,0 +1,233

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r76220146 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r76225271 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r76225290 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 - reworded validators, unified the regex / split parses to use numeric capture groups/columns --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #940: NIFI-2662 - Fix checkstyle violations introduced by ...

2016-08-25 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/940 NIFI-2662 - Fix checkstyle violations introduced by NIFI-2605 You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2662

[GitHub] nifi issue #940: NIFI-2662 - Fix checkstyle violations introduced by NIFI-26...

2016-08-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/940 previous title and commit message referred to incorrect JIRA number. Correct number according to Github's blame view is NIFI-2635 --- If your project is set up for it, you can reply

[GitHub] nifi pull request #941: NIFI-2662 - Fix style violations previously missed

2016-08-25 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/941 NIFI-2662 - Fix style violations previously missed Fix styles missed during PR940 You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi

[GitHub] nifi issue #941: NIFI-2662 - Fix style violations previously missed

2016-08-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/941 @mattyb149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 @mattyb149 feedback addressed. My comment is to play particular attention on threat concurrency around Jackson's ObjectMapper (jackson say it is threat safe but thread safety

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 Rofl. Well at least I got 1 out 3 right. As you can see we security folks are a bit obsessed with threats and risks :-) --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/985 NIFI-2728 - Attempt to fix travis-ci build woes You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2728 Alternatively you can

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 @mcgilman can you please review this and if in agreement merge it to master? Current travis-ci settings seem to be unable to reliably build nifi. I fiddled with Xmx settings, enabled

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 Seems like moving `mvn -T2.0C clean install` to travis install phase and `mvn checkstyle:check` to the script phase did the trick. around 25% reduction in build time and a far more reliable

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 @apiri makes complete sense. afaik this can be achieved using `mvn apache-rat:check and checkstyle:check ` so I added the above command to the before_install stage of the travis job

[GitHub] nifi pull request #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-06 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/817#discussion_r77625743 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ExtractTNEFAttachments.java --- @@ -0,0

[GitHub] nifi pull request #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-06 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/817#discussion_r77625649 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ExtractTNEFAttachments.java --- @@ -0,0

[GitHub] nifi pull request #960: NIFI-2685 - Configure maven to use java headless mod...

2016-09-01 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #991: NIFI-2742 - Explicitly declare the kite hadoop dependencies...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/991 @rdblue would you have any feedback over this change? Not ideal but I couldn't find a better way. Open to suggestions --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi issue #991: NIFI-2742 - Explicitly declare the kite hadoop dependencies...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/991 @joewitt I will be happy to address that! Changing the master LICENSE and NOTICE files is one of my part time hobbies! :neutral_face: --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #990: NIFI-2744 - turn hbase-client version into a pom.xml...

2016-09-07 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/990 NIFI-2744 - turn hbase-client version into a pom.xml property You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2744

[GitHub] nifi issue #990: NIFI-2744 - turn hbase-client version into a pom.xml proper...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/990 @mattyb149 seems like this one is also required to address @xmlking concerns around MapR-DB --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 Matt, the profile is still being run but it run after compilation. First (install) travis performs a multi threaded mvn build. Immediately aftet this completes it runs a mvn checkstyle:check

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 @mcgillman, what do you think about leaving the - T2.0C setting to speed up build and adding an extra post-compile step to run - Pcontrib-check single threaded (this is similar to spark's approach

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @olegz Rebased. Please note that while I will be happy to keep rebasing as peer review is in progress, this PR makes additions to the nifi-assembly LICENSE and NOTICE files so

[GitHub] nifi pull request #990: NIFI-2744 - turn hbase-client version into a pom.xml...

2016-09-07 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #990: NIFI-2744 - turn hbase-client version into a pom.xml proper...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/990 No worries --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #980: NIFI-1170 - Improved TailFile processor to support multiple...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/980 Let me know when this is ready to test and I will give it a go --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-08 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @olegz how is testing looking like? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-08 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 any chance of completing this PR ? :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #1003: NIFI-2755 - Fixes minor typo in Developers Guide

2016-09-11 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1003 NIFI-2755 - Fixes minor typo in Developers Guide You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2755 Alternatively you can

[GitHub] nifi pull request #1004: NIFI-2756 - Add displayName to maven archetypes

2016-09-11 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1004 NIFI-2756 - Add displayName to maven archetypes @alopresto Would you mind having a look on this PR? I am not familiar with maven archetypes but I noticed that the ones we have seem

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-12 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 feedback addressed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #980: NIFI-1170 - Improved TailFile processor to support m...

2016-09-14 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/980#discussion_r78770355 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/TailFile.java --- @@ -117,31

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-12 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r78476147 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/AbstractEnrichProcessor.java --- @@ -65,7

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-12 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r78475823 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/AbstractEnrichProcessor.java

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-12 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r78476100 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/AbstractEnrichProcessor.java

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-12 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 can you confirm if this was generated by Split or Regex capture? Note that the regex is a multiline match, therefore user can remove the newline via regular expression

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 @ijokarumawak --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1025: Trying to fix Travis build failure.

2016-09-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1025 @ijokarumawak there's already a PR for that keen for you to look at https://github.com/apache/nifi/pull/985 and merge it if you don't mind --- If your project is set

[GitHub] nifi pull request #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-09 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/985#discussion_r78266044 --- Diff: .travis.yml --- @@ -6,12 +21,22 @@ os: jdk: - oraclejdk8 +# Caches mvn repository in order to speed upbuilds +cache

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-09 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 @apiri, @mcgilman I did a few new tweaks so that job sequence is: 1. rat check (before_install) 2. parallel compile with skipTests (install) 3. style check and test via mvn

[GitHub] nifi issue #1002: NIFI-2684 - Change AbstractConfigurableComponent to use di...

2016-09-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1002 @joewitt this commit is quite small (intent is just aesthetics / UX) but ventures into waters I don't usually sail... Would you mind having a look? I thank you in advance --- If your

[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code

2016-09-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1057 @pvillard31 note to myself: Never try to hunt typos after midnight ... :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

<    1   2   3   4   5   6   7   >