[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1057#discussion_r80344174 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/MockProcessSession.java --- @@ -164,7 +164,7 @@ public void commit() { * {@link

[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1057#discussion_r80344591 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/ControllerConfigurationDTO.java

[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1057#discussion_r80344580 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/parser/BinaryReader.java --- @@ -86,9 +86,9

[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1057#discussion_r80344540 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/crypto/bcrypt/BCrypt.java

[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1057#discussion_r80344575 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/parser/BinaryReader.java --- @@ -86,9 +86,9

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 @mcgilman would you mind pushing this commit to 0.x as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code

2016-09-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1057 @pvillard31 I did a second sweep on this commit and the following public classes or methods have also been changed

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-24 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 thanks for finding this. Could not believe... missing curly bracket after and else. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #1059: NIFI-2818 - Minimise fs permission required by NiFi

2016-09-24 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1059 NIFI-2818 - Minimise fs permission required by NiFi 1 - Replace a r/w test over $NIFI_HOME/lib that is performed but never utilised by a RO test 2

[GitHub] nifi issue #1058: NIFI-2814 - Add ASF header to AppVeyor settings file

2016-09-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1058 @apiri another small clean up activity. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1057: NIFI-2816 - Clean typos across the code

2016-09-26 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1057 @bbende there's a few hundred more but I decided to split the task to avoid having to rebase non-stop! :sunglasses: @joewitt pleased to help, next time the kangaroo steak bill is yours

[GitHub] nifi pull request #1062: Backport NIFI-2814 to 0.x tree

2016-09-26 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/1062 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @olegz I guess you have been busy but I was wondering if you are still planning to review this? Cheers --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1004: NIFI-2756 - Add displayName to maven archetypes

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1004 @bbende mind sharing the steps you took? Keen to try to reproduce and fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1054: Dummy commit focused in closing stalled PR requests

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1054 @apiri should we go ahead and commit the PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #1083: NIFI-2709 - Refactor ConsumeIMAP and ConsumePOP3 to...

2016-09-30 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1083 NIFI-2709 - Refactor ConsumeIMAP and ConsumePOP3 to generate RFC2822 compliant flowfiles You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #1083: NIFI-2709 - Refactor ConsumeIMAP and ConsumePOP3 to genera...

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1083 @bbende this should solve the IMAP issue. Notes: 1. This PR reads the content of the message into memory, in contrast with the original design that relied on InputStream to write

[GitHub] nifi issue #1083: NIFI-2709 - Refactor ConsumeIMAP and ConsumePOP3 to genera...

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1083 content no long loaded into memory. except for the issue around jUnits (2 & 3), it should be ready to review --- If your project is set up for it, you can reply to this email and have your r

[GitHub] nifi issue #1081: NIFI-1912 - PutEmail fixed format when attachment

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1081 @pvillard31 thanks for the code. LGTM. Will merge later today against master and check if I can apply against 0.x as well. Cheers --- If your project is set up

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1108 @selim-namsi thanks for putting together. I was coding this processor but happy to review it. Few comments: 1. Your code is failing -Pcontrib-check. Can you please fix

[GitHub] nifi issue #409: NIFI-1840 Added compression type property in Kite processor...

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/409 I will merge later today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi pull request #1093: Fixes NIFI-1069 init script status exit code 3 when...

2016-10-05 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1093#discussion_r82104883 --- Diff: nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java --- @@ -581,30 +585,31 @@ private Status getStatus(final Logger logger

[GitHub] nifi issue #1073: Nifi 2829

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1073 @paulgibeault would you mind squashing this PR? I thank you in advance --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #675: LSB Adherence

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/675 @PuspenduBanerjee From what I understand from the trail, we can close PR? Best regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #984: Nifi 2624

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/984 @ToivoAdams would you mind rebasing this PR? Kind regards --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #409: NIFI-1840 Added compression type property in Kite processor...

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/409 merged. thanks for the contribution @pvillard31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1103 @apiri I know this ticket is assigned to you but given I suspect how busy your side of the ocean is, I thought I would give it a go and try to help. Let me know if that is not ok and I

[GitHub] nifi pull request #1103: NIFI-1615 - Add initial GitHbub pull request templa...

2016-10-05 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1103 NIFI-1615 - Add initial GitHbub pull request template to address some… … of the reocurring PR mistakes You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1103 @apiri - hopefully addressed most of the typos and comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #1103: NIFI-1615 - Add initial GitHbub pull request templa...

2016-10-05 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1103#discussion_r81988084 --- Diff: .github/PULL_REQUEST_TEMPLATE.md --- @@ -0,0 +1,32 @@ + + +Thank you for submiting a contribution to Apache NiFi. + +In order

[GitHub] nifi issue #1103: NIFI-1615 - Add initial GitHbub pull request template to a...

2016-10-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1103 OMG... that's what happens when someone decides to type text into vi by 1AM... :smiley: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi issue #675: LSB Adherence

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/675 @apiri have a look on https://github.com/apache/nifi/pull/1092 and https://github.com/apache/nifi/pull/1093 Which are essentially addressing a number of the issues

[GitHub] nifi-minifi-cpp issue #16: MINIFI-116 Initial Travis CI configuration for Ma...

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/16 once this is merged it should be easier to expand with CMake and different environments. I am particularly keen to ensure we are able to generate both deb and rpm files --- If your project

[GitHub] nifi-minifi-cpp issue #16: MINIFI-116 Initial Travis CI configuration for Ma...

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/16 no no. just thinking about getting travis-ci working asap. Once that is done, evolving the work on #14 - i.e. CMake, windows, etc - should be easier due to the ability of iterating code

[GitHub] nifi-minifi-cpp issue #16: MINIFI-116 Initial Travis CI configuration for Ma...

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/16 @apiri LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1105: NIFI-2691 Replaced references to kerberos/spegno principle...

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1105 @andrewmlim great. Thanks for the clarification. Will merge soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #512: NIFI-401

2016-10-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/512 @beugley doesn't seem to have worked yet --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi-minifi-cpp issue #18: MINIFI-34 - attempt to progress the CMake environ...

2016-10-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/18 @apiri indeed. solving the INTERFACE was a matter of using what seems to be called the "infamous `dummy.cpp `". Good news is that this should be working now (it wor

[GitHub] nifi-minifi-cpp issue #18: MINIFI-34 - attempt to progress the CMake environ...

2016-10-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/18 ok. So precise(12.04) does not work out of the box, only with add on packages. I think we should push this with 14.04 (travis' `dist: tahr`) and add 12.04 as a docker container

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

2016-10-08 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1108 Please rebase this PR so it only include your changes. Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1108 By the way, most of these modifications are already available here: https://github.com/trixpan/nifi/commits/NIFI-2565 --- If your project is set up for it, you can reply to this email

[GitHub] nifi issue #1108: NIFI-2565: add Grok parser

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1108 You can certainly include a file with the default patterns, however you should not hardcode them. By hardcoding them you prevent the user from optimising for speed by removing unused patterns from

[GitHub] nifi-minifi-cpp pull request #18: MINIFI-34 - attempt to progress the CMake ...

2016-10-06 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/18 MINIFI-34 - attempt to progress the CMake environment You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi-minifi-cpp

[GitHub] nifi-minifi-cpp pull request #17: MINIFI-34 - Add Travis badge to README.md

2016-10-06 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/17 MINIFI-34 - Add Travis badge to README.md You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi-minifi-cpp MINIFI-34

[GitHub] nifi-minifi-cpp issue #17: MINIFI-34 - Add Travis badge to README.md

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/17 @apiri we forgot this. :fearful: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi-minifi-cpp issue #14: MINIFI-34 Establishing CMake build system to prov...

2016-10-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/14 @apiri another note: Seems like CMake is a must before we get Windows build in shape: According to [this](http://help.appveyor.com/discussions/problems/1467-building-with-makefile

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-17 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 I just noticed the git woes I've noticed before were a bit more extensive that I initially realised. Some of the code changes made during code review were reverted when forced a push

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-17 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 Expected error as your regex string has no capture groups. I am not sure if I can test the regex contains at least one capture group but will try --- If your project is set up

[GitHub] nifi issue #1049: Fix for invalid M2_HOME directory in Appveyor

2016-09-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1049 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1047: [NIFI-2812] Fix creating NiFi RPM

2016-09-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1047 @fidget83 would you mind amending the commit message and adding reference to the JIRA you mentioned above? You can do so by running `git commit --amend` --- If your project is set up

[GitHub] nifi issue #1049: Fix for invalid M2_HOME directory in Appveyor

2016-09-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1049 @vegaed is it too much asking you to raise a JIRA ticket and amending the git commit message? I will merge after that. --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #1054: Dummy commit focused in closing stalled PR requests

2016-09-23 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1054 Dummy commit focused in closing stalled PR requests Closes: #239 Closes: #769 Closes: #595 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 @mattyb149 PR rebased and in theory should be ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1049: [NIFI-2813] Fix for invalid M2_HOME directory in Appveyor

2016-09-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1049 @vegaed not exactly... Assuming you are using Linux/MacOS/Unix, you can try this: ``` cd nifi git checkout master git checkout -b temp git cherrypick 7ef2782 git

[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1047#discussion_r80255224 --- Diff: nifi-assembly/pom.xml --- @@ -505,11 +510,18 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1047#discussion_r80253235 --- Diff: nifi-assembly/pom.xml --- @@ -505,11 +510,18 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1047#discussion_r80255471 --- Diff: nifi-assembly/pom.xml --- @@ -505,11 +510,18 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1047#discussion_r80255200 --- Diff: nifi-assembly/pom.xml --- @@ -505,11 +510,18 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1047#discussion_r80255251 --- Diff: nifi-assembly/pom.xml --- @@ -505,11 +510,18 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1047#discussion_r80255166 --- Diff: nifi-assembly/pom.xml --- @@ -505,11 +510,18 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1047#discussion_r80255144 --- Diff: nifi-assembly/pom.xml --- @@ -505,11 +510,18 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1047: [NIFI-2812] Fix creating NiFi RPM

2016-09-23 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1047#discussion_r80253174 --- Diff: nifi-assembly/pom.xml --- @@ -505,11 +510,18 @@ language governing permissions and limitations under the License

[GitHub] nifi pull request #1057: NIFI-2816 - Clean typos across the code

2016-09-23 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1057 NIFI-2816 - Clean typos across the code part 1 of typo hunting You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi typos Alternatively

[GitHub] nifi issue #315: NIFI-1710 Resolve path name to nifi.sh in start script

2016-09-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/315 @jfrazee could you rebase this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #583: NIFI-2115 Detailed Version Info for About Box

2016-09-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/583 Looks amazing but I would add some flashing/blinking HTML and a construction sign as homage to the good old GeoCities pages. :-) On a more serious note, @jvwing could you rebase? --- If your

[GitHub] nifi issue #1034: Allow Content Type to be set in PutS3Object processor

2016-09-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1034 @vegaed Thanks for looking at appveyor. Do you mind cherry picking 7a2fc08 into a separate PR? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #1004: NIFI-2756 - Add displayName to maven archetypes

2016-09-22 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1004#discussion_r80066292 --- Diff: nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-processors/src/main/java

[GitHub] nifi pull request #1004: NIFI-2756 - Add displayName to maven archetypes

2016-09-22 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1004#discussion_r80064544 --- Diff: nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-processors/src/main/java

[GitHub] nifi pull request #1004: NIFI-2756 - Add displayName to maven archetypes

2016-09-22 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1004#discussion_r80064941 --- Diff: nifi-maven-archetypes/nifi-processor-bundle-archetype/src/main/resources/archetype-resources/nifi-__artifactBaseName__-processors/src/main/java

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-27 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 figured out what it is. I needed to exclude slf4j-log4j12 from parCEFone dependency. In the process found a few bugs. Fixing. :-) --- If your project is set up for it, you can reply

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-27 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 Ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #960: NIFI-2685 - Configure maven to use java headless mod...

2016-08-28 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/960 NIFI-2685 - Configure maven to use java headless mode during build You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2685

[GitHub] nifi pull request #961: NIFI-2685 - Configure surefire to use JAVA Headless ...

2016-08-28 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/961 NIFI-2685 - Configure surefire to use JAVA Headless mode You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2685-master

[GitHub] nifi pull request #964: Port NIFI-2688 to NIFI 1.0.0 RC1 branch

2016-08-28 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/964 Port NIFI-2688 to NIFI 1.0.0 RC1 branch adjust ConfigEncryptionToolTest datePattern regex to cater for timezones with 4 characters You can merge this pull request into a Git repository by running

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-29 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r76623940 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java --- @@ -0,0 +1,172

[GitHub] nifi pull request #941: NIFI-2662 - Fix style violations previously missed

2016-08-25 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/941 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #941: NIFI-2662 - Fix style violations previously missed

2016-08-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/941 closed as per @mcgilman request --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-27 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r80663050 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestParseCEF.java --- @@ -0,0

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-27 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r80663321 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java --- @@ -0,0 +1,323

[GitHub] nifi pull request #1061: Backport NIFI-2728 to 0.x tree

2016-09-27 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/1061 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1059: NIFI-2818 - Minimise fs permission required by NiFi

2016-09-27 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1059 not yet ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-27 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r80719887 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -254,6 +254,17 @@ language governing permissions and limitations under

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r80934511 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/pom.xml --- @@ -254,6 +254,17 @@ language governing permissions and limitations under

[GitHub] nifi issue #1083: NIFI-2709 - Refactor ConsumeIMAP and ConsumePOP3 to genera...

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1083 User reveals patch works as expected: https://community.hortonworks.com/comments/59274/view.html --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #1004: NIFI-2756 - Add displayName to maven archetypes

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1004 @bbende hopefully the second commit should address your feedback. May I ask you to test and if ok, merge into master? Kind regards --- If your project is set up for it, you can

[GitHub] nifi issue #1024: Adding EL support to TailFile processor

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1024 @apsaltis is the PR still required? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1083: NIFI-2709 - Refactor ConsumeIMAP and ConsumePOP3 to genera...

2016-10-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1083 @olegz any feedback or :+1: ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1083: NIFI-2709 - Refactor ConsumeIMAP and ConsumePOP3 to genera...

2016-10-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1083 @olegz thanks. I wasn't sure if the comment was referring to the Java 8 or the whole thing. Thanks for clarifying and thank you for reviewing. Cheers --- If your project is set up

[GitHub] nifi issue #512: NIFI-401

2016-10-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/512 @beugley would you mind rebasing this commit? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #319: NIFI-1582 added state to UpdateAttribute as well as updated...

2016-10-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/319 @JPercivall welcome back! Could you rebase this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #409: NIFI-1840 Added compression type property in Kite processor...

2016-10-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/409 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #626: NIFI-1922 added support for HDInsight wasb file storage to ...

2016-10-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/626 @atilcock not sure why GitHub doesn't show but this PR drifted from the master in the sense we no longer specify the hadoop version within the child pom.xml Also, while I am not an expert, I

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 @mattyb149 all feedback addressed. this should be ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1083: NIFI-2709 - Refactor ConsumeIMAP and ConsumePOP3 to genera...

2016-09-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1083 @bbende code should pass contrib-check and be ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request #1085: NIFI-2816 - Clean typos across the code

2016-10-02 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1085 NIFI-2816 - Clean typos across the code You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi typo2 Alternatively you can review

[GitHub] nifi issue #285: NIFI-1636: Print Stacktrace When Unexpected OnTrigger Excep...

2016-10-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/285 @rickysaltzer - is the PR still relevant? Would you mind if we close otherwise? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1085: NIFI-2816 - Clean typos across the code

2016-10-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1085 @mcgilman would you mind having a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1085: NIFI-2816 - Clean typos across the code

2016-10-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1085 @mcgillman would you mind having a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #587: NIFI-2116 Initial Draft for Spanish readme.md

2016-10-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/587 @chagara - any chances of updating this README to match the version 1.0? @alopresto @olegz - Do we have Spanish speaking committers? It would be unfortunate to merge this but be unable

[GitHub] nifi issue #1085: NIFI-2816 - Clean typos across the code

2016-10-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1085 @pvillard31 second and final part of the typo clean up. Would appreciate a quick review so I don't need to spend eternity rebasing the PR. --- If your project is set up for it, you can reply

<    1   2   3   4   5   6   7   >