[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74362612 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -13,89 +13,52

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74362680 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74362705 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -166,317 +108,158

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74362949 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -13,89 +13,52

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74363178 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74363458 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -166,317 +108,158

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 @olegz - Tested the processor and other than the view that attributes should not be removed (as they are useful for many auditing and downstream applications) and a few remarks on SubEthaSMTP

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-10 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74364045 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/test/java/org/apache/nifi/processors/email/TestListenSMTP.java --- @@ -13,307 +13,174

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74414087 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -13,89 +13,52

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74414544 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -166,317 +108,158

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74416389 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -135,29 +89,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74418332 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74420800 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -135,29 +89,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74421721 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74425136 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74427203 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +69,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74423248 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -135,29 +89,17

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 @olegz You are clearly confusing envelope (the data exchanged within an SMTP session) with header information (the data added to the body of the message after the DATA command). They don&#

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @joewitt - 3rd party test files have been replaced with new files containing only NiFi & MiNiFi logos --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @JPercivall - Given your review of ExtractEmailAttachments do you mind reviewing this PR? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74449761 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -31,101 +30,75

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 @joewitt, @olegz code is a great improvement to the previous code. I do think the the removal of the maximum message size and timeout checks should be addressed as soon as possible: I

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 @olegz is this expected? ``` 2016-08-12 01:23:59,420 ERROR [Timer-Driven Process Thread-6] o.a.nifi.processors.email.ListenSMTP org.apache.nifi.processor.exception.ProcessException

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 1. Start ListenSMTP port 2525 with 1 maximum connection, 10 seconds of timeout ``` $ telnet 0 2525 Trying 0.0.0.0... Connected to 0. Escape character is '^]'. 220

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 Stopping the processor with an agent connected also seems to throw an exception (not sure if expected) ``` 2016-08-12 01:42:06,593 INFO [StandardProcessScheduler Thread-7

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 @olegz have you pushed the notification recently? I got just an abrupt termination ``` $ telnet 0 2525 Trying 0.0.0.0... Connected to 0. Escape character is '^]'

[GitHub] nifi issue #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/827 @olegz thanks for the clarification. Just so that we are on the same page, I am not concerned about the DFM in this case. What I mean by notification is the following: SMTP

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74527077 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +90,17

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-11 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74527655 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +90,17

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-08-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @joewitt I will need some assistance with the L&N issue: Note how POIs LICENSE makes mention to CurvesAPI https://github.com/apache/poi/blob/trunk/legal/LICENSE#

[GitHub] nifi pull request #827: NIFI-2519 Fixed and refactored ListenSMTP processor

2016-08-12 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/827#discussion_r74527190 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ListenSMTP.java --- @@ -106,26 +90,17

[GitHub] nifi issue #856: NIFI-2519 aligned processor to leverage the subethasmtp thr...

2016-08-14 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/856 :+1: Tested manually and also forced some exceptions. ListenSMTP seems to handle errors very well, example: Place breakpoint on `processSession.getProvenanceReporter

[GitHub] nifi pull request #856: NIFI-2519 aligned processor to leverage the subethas...

2016-08-14 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/856#discussion_r74700141 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/smtp/SmtpConsumer.java --- @@ -0,0 +1,161

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-15 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/858 NIFI-1971 - Introduce QueryWhois processor supporting batching (i.e. netcat protocol) You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 # Note to reviewers: # This is a logging pipeline focused processor that should be capable of reaching to a Whois server and grabbing information that can be used to enrich data. The

[GitHub] nifi pull request #871: NIFI-2519 - ListenSMTP addresses mismatch between sm...

2016-08-15 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/871 NIFI-2519 - ListenSMTP addresses mismatch between smtp.src attribute … …documentation and attribute.put You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 A gist to help people going https://gist.github.com/trixpan/9c663866d2b02322650bfddde3eefb6e --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-16 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 given your experience reviewing QueryDNS, would you mind having a look on this one? Different interface, similar outcome. Cheers --- If your project is set up for it, you can

[GitHub] nifi pull request #875: Nifi 2477

2016-08-16 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/875#discussion_r75027919 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -169,6 +169,81 @@ Now that the User Interface has been secured, we can easily secure

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-17 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75210911 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75579988 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/pom.xml --- @@ -63,5 +63,31 @@ nifi-mock test

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75579997 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/pom.xml --- @@ -63,5 +63,31 @@ nifi-mock test

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75580268 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75580295 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r75580308 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/enrich/TestQueryWhois.java --- @@ -0,0 +1,187

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 The error is expected as the regex does not contain a capture group named KEY. It is a bug as I should detect KEY or whatever value was chosen. But your feedback

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 As you can see the KEY group is documented within NiFi code but the UI lacks such explanation https://github.com/apache/nifi/pull/858/files#diff-d13cbfd36645869513f9d09b76636240R183 --- If

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r76220146 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r76225271 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi pull request #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/858#discussion_r76225290 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/enrich/QueryWhois.java --- @@ -0,0 +1,334

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-08-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 - reworded validators, unified the regex / split parses to use numeric capture groups/columns --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #940: NIFI-2662 - Fix checkstyle violations introduced by ...

2016-08-25 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/940 NIFI-2662 - Fix checkstyle violations introduced by NIFI-2605 You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2662

[GitHub] nifi issue #940: NIFI-2662 - Fix checkstyle violations introduced by NIFI-26...

2016-08-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/940 previous title and commit message referred to incorrect JIRA number. Correct number according to Github's blame view is NIFI-2635 --- If your project is set up for it, you can reply to

[GitHub] nifi pull request #941: NIFI-2662 - Fix style violations previously missed

2016-08-25 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/941 NIFI-2662 - Fix style violations previously missed Fix styles missed during PR940 You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi

[GitHub] nifi issue #941: NIFI-2662 - Fix style violations previously missed

2016-08-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/941 @mattyb149 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi issue #941: NIFI-2662 - Fix style violations previously missed

2016-08-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/941 @JPercivall - no worries at all. Please note PR940 is already live so we may be worth checking that as well --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request #941: NIFI-2662 - Fix style violations previously missed

2016-08-25 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/941 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #941: NIFI-2662 - Fix style violations previously missed

2016-08-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/941 closed as per @mcgilman request --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-27 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 @mattyb149 - For some reason I don't truly grasp TestGetJMSQueue start to fail once this processor is introduced to standard-processors Other than that code looks to be working as exp

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-27 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 figured out what it is. I needed to exclude slf4j-log4j12 from parCEFone dependency. In the process found a few bugs. Fixing. :-) --- If your project is set up for it, you can reply to this

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-27 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 Ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] nifi pull request #960: NIFI-2685 - Configure maven to use java headless mod...

2016-08-28 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/960 NIFI-2685 - Configure maven to use java headless mode during build You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2685

[GitHub] nifi pull request #961: NIFI-2685 - Configure surefire to use JAVA Headless ...

2016-08-28 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/961 NIFI-2685 - Configure surefire to use JAVA Headless mode You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2685-master

[GitHub] nifi pull request #963: NIFI-2688 - adjust ConfigEncryptionToolTest datePatt...

2016-08-28 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/963 NIFI-2688 - adjust ConfigEncryptionToolTest datePattern regex to cate… regex to cater for timezones with 4 characters You can merge this pull request into a Git repository by running: $ git

[GitHub] nifi pull request #964: Port NIFI-2688 to NIFI 1.0.0 RC1 branch

2016-08-28 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/964 Port NIFI-2688 to NIFI 1.0.0 RC1 branch adjust ConfigEncryptionToolTest datePattern regex to cater for timezones with 4 characters You can merge this pull request into a Git repository by running

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-29 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r76621207 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java --- @@ -0,0 +1,172

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-29 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r76623940 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java --- @@ -0,0 +1,172

[GitHub] nifi pull request #785: NIFI-2341 - Introduce ParseCEF processor

2016-08-29 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/785#discussion_r76626297 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseCEF.java --- @@ -0,0 +1,172

[GitHub] nifi pull request #963: NIFI-2688 - adjust ConfigEncryptionToolTest datePatt...

2016-08-30 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/963 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #963: NIFI-2688 - adjust ConfigEncryptionToolTest datePattern reg...

2016-08-30 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/963 I've seen it. Seems very good PR. Closing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] nifi pull request #964: Port NIFI-2688 to NIFI 1.0.0 RC1 branch

2016-08-30 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/964 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #960: NIFI-2685 - Configure maven to use java headless mod...

2016-09-01 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #961: NIFI-2685 - Configure surefire to use JAVA Headless mode

2016-09-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/961 @trkurc it just came to my mind that the pom.xml change should be safe to commit. The change is just pushing into the build phase a setting that is already present when nifi is

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @olegz Would you mind have a look on this PR ? Function here is to extract TNEF attachments. TNEF is the technical name for the widely loved winmail.dat files. Use case is

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 @mattyb149 feedback addressed. My comment is to play particular attention on threat concurrency around Jackson's ObjectMapper (jackson say it is threat safe but thread safe

[GitHub] nifi issue #785: NIFI-2341 - Introduce ParseCEF processor

2016-09-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/785 Rofl. Well at least I got 1 out 3 right. As you can see we security folks are a bit obsessed with threats and risks :-) --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @olegz Rebased. Please note that while I will be happy to keep rebasing as peer review is in progress, this PR makes additions to the nifi-assembly LICENSE and NOTICE files so it is

[GitHub] nifi pull request #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/985 NIFI-2728 - Attempt to fix travis-ci build woes You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2728 Alternatively you can

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 @mcgilman can you please review this and if in agreement merge it to master? Current travis-ci settings seem to be unable to reliably build nifi. I fiddled with Xmx settings, enabled

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 @mcgillman, what do you think about leaving the - T2.0C setting to speed up build and adding an extra post-compile step to run - Pcontrib-check single threaded (this is similar to spark's app

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 Seems like moving `mvn -T2.0C clean install` to travis install phase and `mvn checkstyle:check` to the script phase did the trick. around 25% reduction in build time and a far more reliable

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 Matt, the profile is still being run but it run after compilation. First (install) travis performs a multi threaded mvn build. Immediately aftet this completes it runs a mvn checkstyle:check

[GitHub] nifi issue #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/985 @apiri makes complete sense. afaik this can be achieved using `mvn apache-rat:check and checkstyle:check ` so I added the above command to the before_install stage of the travis job

[GitHub] nifi pull request #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-06 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/817#discussion_r77625666 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ExtractTNEFAttachments.java --- @@ -0,0

[GitHub] nifi pull request #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-06 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/817#discussion_r77625649 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ExtractTNEFAttachments.java --- @@ -0,0

[GitHub] nifi pull request #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-06 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/817#discussion_r77625743 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ExtractTNEFAttachments.java --- @@ -0,0

[GitHub] nifi pull request #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-06 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/817#discussion_r77626391 --- Diff: nifi-nar-bundles/nifi-email-bundle/nifi-email-processors/src/main/java/org/apache/nifi/processors/email/ExtractTNEFAttachments.java --- @@ -0,0

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-06 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @olegz hopefully all comments addressed. Code was rebased as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi-site pull request #5: NIFI-2733 - Introduce "Powered by NiFi" section t...

2016-09-06 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi-site/pull/5 NIFI-2733 - Introduce "Powered by NiFi" section to website You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi-site

[GitHub] nifi pull request #990: NIFI-2744 - turn hbase-client version into a pom.xml...

2016-09-07 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/990 NIFI-2744 - turn hbase-client version into a pom.xml property You can merge this pull request into a Git repository by running: $ git pull https://github.com/trixpan/nifi NIFI-2744

[GitHub] nifi issue #990: NIFI-2744 - turn hbase-client version into a pom.xml proper...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/990 @mattyb149 seems like this one is also required to address @xmlking concerns around MapR-DB --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] nifi pull request #991: NIFI-2742 - Explicitly declare the kite hadoop depen...

2016-09-07 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/991 NIFI-2742 - Explicitly declare the kite hadoop dependencies to allow … …kite-processor to compile against vendor hadoop libraries You can merge this pull request into a Git repository by running

[GitHub] nifi issue #991: NIFI-2742 - Explicitly declare the kite hadoop dependencies...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/991 @rdblue would you have any feedback over this change? Not ideal but I couldn't find a better way. Open to suggestions --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #991: NIFI-2742 - Explicitly declare the kite hadoop dependencies...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/991 @joewitt I will be happy to address that! Changing the master LICENSE and NOTICE files is one of my part time hobbies! :neutral_face: --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #990: NIFI-2744 - turn hbase-client version into a pom.xml...

2016-09-07 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/990 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #990: NIFI-2744 - turn hbase-client version into a pom.xml proper...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/990 No worries --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] nifi issue #980: NIFI-1170 - Improved TailFile processor to support multiple...

2016-09-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/980 Let me know when this is ready to test and I will give it a go --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] nifi issue #817: NIFI-2380 - Introduce ExtractTNEFAttachments

2016-09-08 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/817 @olegz how is testing looking like? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi issue #858: NIFI-1971 - Introduce QueryWhois processor

2016-09-08 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/858 @pvillard31 any chance of completing this PR ? :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request #985: NIFI-2728 - Attempt to fix travis-ci build woes

2016-09-09 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/985#discussion_r78266044 --- Diff: .travis.yml --- @@ -6,12 +21,22 @@ os: jdk: - oraclejdk8 +# Caches mvn repository in order to speed upbuilds +cache

<    1   2   3   4   5   6   7   8   >