[GitHub] nifi issue #1614: NIFI-3466 - Addresses ParseCEF Locale related failures and...

2017-03-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1614 also please note there seem to be an unrelated issue affecting another test unit that fails unter pt_BR and fr_FR but passes ja_JP. I suspect it is a comma vs dot number notation issue

[GitHub] nifi issue #1614: NIFI-3466 - Addresses ParseCEF Locale related failures and...

2017-03-22 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1614 please ignore the last comment regarding the error above, seems to be a rebasing issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1622: NIFI-79 - Introduces the ability to set Bulletin Level to ...

2017-03-29 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1622 @mcgilman I suspected I could be missing something. Thanks for the clarification and improvement. Happy for you to merge --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #1625: NIFI-3650 - Adjust travis to forcefuly remove $HOME/.m2/re...

2017-03-27 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1625 @apiri good catch. I wasn't aware of that feature. I pushed a modified version. let me know what you think --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1625: NIFI-3650 - Adjust travis to forcefuly remove $HOME/.m2/re...

2017-03-27 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1625 I am obviously happy to remove the pre-build cache "rm -rf" but since it should not return error, so I reckon we can leave it there as a safety mechanism in case before_cache fails -

[GitHub] nifi pull request #1639: NIFI-1939 - Correct issue where ParseSyslog was una...

2017-03-31 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1639 NIFI-1939 - Correct issue where ParseSyslog was unable to parse RFC31… …64 messages containg an IPv6 address as source Thank you for submitting a contribution to Apache NiFi

[GitHub] nifi issue #1639: NIFI-1939 - Correct issue where ParseSyslog was unable to ...

2017-03-31 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1639 @bbende - would you be able to have a look on this one? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1619 no worries. rebased --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 @brianburnett there's a minor conflict but I am more concerned with consistent failures when I run the test units? Have you been able to build this with `-Pcontrib-check` ? --- If your

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1595 @jdye64 can you please solve the conflicts? Cheers! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1595 :rofl: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1640: NIFI-3222 - Allow ExecuteScript to use ExpressionLanguage ...

2017-03-31 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1640 @mattyb149 - should be all goody now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-04-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1644 @mcgilman - I gave it a try in finding a solution. Happy to adjust in case you think it is needed. Cheers --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request #1644: NIFI-11 - Capture StringIndexOutOfBoundsException t...

2017-04-01 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1644 NIFI-11 - Capture StringIndexOutOfBoundsException to prevent failed e… …valuations from disrupting flow Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi pull request #1642: NIFI-1336 - Ensure that flowfiles are penalized upo...

2017-04-01 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1642 NIFI-1336 - Ensure that flowfiles are penalized upon exception due to… … inability to delete hold Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #1643: NIFI-2702 - Deprecates nifi-standard-bundle/*JMS and docum...

2017-04-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1643 @olegz could you have a look on this when you have time? Cheers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-04-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1619 @apiri - Added the note. Please certainly link to PerformanceConsider. As you may recall earlier this week while coding this processor I posted a message around the very same issue: It would

[GitHub] nifi pull request #1622: NIFI-79 - Introduces the ability to set Bulletin Le...

2017-04-01 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/1622 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1642: NIFI-1336 - Ensure that flowfiles are penalized upon excep...

2017-04-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1642 @markap14 hope this PR addresses the issue you reported. Could you confirm and merge/provide feedback? Cheers! --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request #1643: ST-2702 - Deprecates nifi-standard-bundle/*JMS and ...

2017-04-01 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1643 ST-2702 - Deprecates nifi-standard-bundle/*JMS and document the recom… …mended alternative Thank you for submitting a contribution to Apache NiFi. In order to streamline

[GitHub] nifi issue #1622: NIFI-79 - Introduces the ability to set Bulletin Level to ...

2017-04-01 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1622 closing as requested by @mcgilman --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-12 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1595 From a first look the code seems ok but I have a quick question: Do we truly need a permission denied relationship? It seems like a deviation from the general nature of failure relationships

[GitHub] nifi issue #1595: NIFI-3600 Improve logging and relationship routing for fai...

2017-04-12 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1595 Glad you managed to get the lines out of their conflict... 😀 will review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1608: NIFI-3607 Allow multi files mode with fixed names

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1608 Shouldn't `static final AllowableValue MODE_MULTIFILE` ... be updated to reflect new behavior? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1608: NIFI-3607 Allow multi files mode with fixed names

2017-04-10 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1608#discussion_r110654924 --- Diff: nifi-mock/src/main/java/org/apache/nifi/util/StandardProcessorTestRunner.java --- @@ -36,9 +36,9 @@ import java.util.Objects; import

[GitHub] nifi issue #1546: [NIFI-3439] when users type into sensitive property fields...

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1546 @scottyaslan - have you tested this? http://jsfiddle.net/Ldr07h2r/6/ Source: http://stackoverflow.com/questions/25822682/webkit-text-security-compatibility --- If your project

[GitHub] nifi issue #1546: [NIFI-3439] when users type into sensitive property fields...

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1546 The approach linked above seems to work on chrome without the javascript but firefox required the js code. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1546: [NIFI-3439] when users type into sensitive property fields...

2017-04-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1546 forget it. Seen what @mcgilman was referring to. Possible to play with text area but it becomes single line. :-( --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1390: NIFI-3277 - StandardProcessSession.isSpuriousRouteEvent() ...

2017-04-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1390 @brosander sorry for the delay but now it seems like this PR has merge conflicts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1568: NIFI-3561: Fix WS port forwarding

2017-04-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1568 @ijokarumawak thanks for fixing this. merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1306: [WIP] NIFI-1202: Site-to-Site batch settings.

2017-04-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1306 @ijokarumawak sorry for the delay but it seems this needs rebasing. :-( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi issue #1364: NIFI-1856 ExecuteStreamCommand Needs to Consume Standard E...

2017-04-11 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1364 @brosander are you still planning to review this at some stage? Happy to try to help if needed. Cheers! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-04-23 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 hey @brianburnett thank you for submiting a new commit. You seem to have merged the mater into your PR? You should have instead rebased the PR to master. Please refer

[GitHub] nifi issue #1553: NIFI-1449 - Migrate PutEmail tests from Mock class to List...

2017-03-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1553 Thanks for the assistance previously, it should be ready for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #1563: NIFI-XXXX - Renames jBcrypt dependency to jBCrypt

2017-03-04 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1563 NIFI- - Renames jBcrypt dependency to jBCrypt Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #1581: NIFI-3534 Add support for impersonating a user with HDFS p...

2017-03-12 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1581 @apsaltis LGTM but is there chance of making reference to proxyuser groups/ proxyuser hosts in the description or additional info? HDFS Impersonation is one of those thing people always get wrong

[GitHub] nifi pull request #1563: NIFI-3554 - Renames jBcrypt dependency to jBCrypt

2017-03-04 Thread trixpan
Github user trixpan closed the pull request at: https://github.com/apache/nifi/pull/1563 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #1563: NIFI-3554 - Renames jBcrypt dependency to jBCrypt

2017-03-04 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1563 merged pere's patch --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1551: NIFI-3054 - Create all default directories as part of mave...

2017-03-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1551 @joewitt thanks for your comments. I understand your concerns but isn't the user change of the default settings (we do ship with default location settings after all) a voluntary action

[GitHub] nifi issue #1551: NIFI-3054 - Create all default directories as part of mave...

2017-03-05 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1551 @joewitt. Thanks for the comment. I will go through your notes and adjust the PR accordingly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104021856 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104027407 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-03 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104113002 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-03 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104114824 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-03 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104143931 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-03 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104170950 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -230,27

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103599319 --- Diff: nifi-nar-bundles/nifi-lumberjack-bundle/nifi-lumberjack-processors/src/main/java/org/apache/nifi/processors/lumberjack/ListenLumberjack.java

[GitHub] nifi pull request #1418: NIFI-3238 - Introduce ListenBeats processor and dep...

2017-02-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1418#discussion_r103599241 --- Diff: nifi-nar-bundles/nifi-beats-bundle/nifi-beats-processors/src/main/java/org/apache/nifi/processors/beats/frame/BeatsDecoder.java --- @@ -0,0 +1,330

[GitHub] nifi pull request #1553: NIFI-1449 - Migrate PutEmail tests from Mock class ...

2017-03-02 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1553#discussion_r104027988 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@ -102,13

[GitHub] nifi issue #1543: NIFI-1750 - updated dict file desc

2017-03-02 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1543 @joetrite is there a chance you can squash this commit into a single commit? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #1619: NIFI-2747 - Introduce FuzzyHashContent processor

2017-04-07 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1619 @apiri? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #1640: NIFI-3222 - Allow ExecuteScript to use ExpressionLa...

2017-03-31 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1640 NIFI-3222 - Allow ExecuteScript to use ExpressionLangugage to define … …the scripting engine modules path Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] nifi issue #1640: NIFI-3222 - Allow ExecuteScript to use ExpressionLangugage...

2017-03-31 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1640 fair enough. will do both --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] nifi pull request #2016: NIFI-4196 - Expose AWS proxy authentication setting...

2017-07-18 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/2016 NIFI-4196 - Expose AWS proxy authentication settings Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 Please note the displayName settings were not added as most of the AWS related processors lack these --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1644 @mcgilman - Sorry for the delay. rebased and hopefully addressed the jUnit issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request #2017: NIFI-4197 - Expose some proxy settings to GCS Proce...

2017-07-18 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/2017 NIFI-4197 - Expose some proxy settings to GCS Processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #2018: NIFI-4175 - Add HTTP proxy support to *SFTP process...

2017-07-18 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/2018 NIFI-4175 - Add HTTP proxy support to *SFTP processors Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @jfrazee I resolved conflict with master (unrelated to the change). I would agree that the "text" qualifier was indeed missing. Fixed. --- If your project is set up for it, you

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-07-10 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @jfrazee? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #2022: NIFI-4200 - Initial commit for a ControlNiFi processor

2017-07-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2022 @pvillard31 - I assume the processor should be able to control nifi components only. Should we rename it to make this explicit? --- If your project is set up for it, you can reply to this email

[GitHub] nifi pull request #2018: NIFI-4175 - Add HTTP proxy support to *SFTP process...

2017-07-18 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2018#discussion_r128152991 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java

[GitHub] nifi issue #2016: NIFI-4196 - Expose AWS proxy authentication settings

2017-07-18 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/2016 hopefully fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #1968: NIFI-3931 - Added EL to properties in SFTP transfer

2017-07-20 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1968 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #2013: NIFI-4098 - Adjust ParseCEF to re-use bean validato...

2017-07-16 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/2013 NIFI-4098 - Adjust ParseCEF to re-use bean validator in order to impr… …ove performance Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #1921: NIFI-4081 - Added raw message option in GrokReader

2017-07-15 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1921 @pvillard31 I accept it is a bit of bit picking but is there any chance we call it _raw? IIRC this is the name we used on ParseCEF. Naming conventions make user experience smoother 😀 --- If your

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113340505 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1650: NIFI-2661 - Abstract the GeoEnrichIP processor

2017-04-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1650#discussion_r113340946 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java --- @@ -208,6 +120,8

[GitHub] nifi pull request #1650: NIFI-2661 - Abstract the GeoEnrichIP processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1650#discussion_r113411154 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIP.java --- @@ -70,6 +55,7

[GitHub] nifi pull request #1650: NIFI-2661 - Abstract the GeoEnrichIP processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1650#discussion_r113431000 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/test/java/org/apache/nifi/processors/TestISPEnrichIP.java --- @@ -0,0 +1,310

[GitHub] nifi pull request #1650: NIFI-2661 - Abstract the GeoEnrichIP processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1650#discussion_r113428044 --- Diff: nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/ISPEnrichIP.java --- @@ -0,0 +1,132

[GitHub] nifi issue #1696: NIFI-1655 - Add .gitattributes to specifically define

2017-04-26 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1696 @joewitt - When doing this change I noticed some changes to HL7 files and looking online it seems like HL7 uses CR as a "segment separator". Would you mind if I renamed the rele

[GitHub] nifi pull request #1696: NIFI-1655 - Add .gitattributes to specifically defi...

2017-04-26 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1696 NIFI-1655 - Add .gitattributes to specifically define the line ending format of particular file type (i.e. .java = LF, .bat=CRLF) Thank you for submitting a contribution

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113462423 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113462459 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113462407 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113463146 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 @alopresto - I put together the interface based approach and indeed it seems a much cleaner code so thank you for pointing me into this direction. The code has not been optimised and still

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113586323 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113586627 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113585822 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113585955 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-26 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113587423 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/FuzzyHashContent.java

[GitHub] nifi pull request #1639: NIFI-1939 - Correct issue where ParseSyslog was una...

2017-04-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1639#discussion_r114039631 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ParseSyslog.java --- @@ -57,13

[GitHub] nifi pull request #1718: NIFI-391 - Introduce the ability to deprecate a com...

2017-04-29 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1718 NIFI-391 - Introduce the ability to deprecate a component Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-25 Thread trixpan
GitHub user trixpan opened a pull request: https://github.com/apache/nifi/pull/1692 NIFI-3726 - Introduces CompareFuzzyHash processor - Abstract FuzzyhashContent to reduce a bit of code duplication Thank you for submitting a contribution to Apache

[GitHub] nifi issue #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1692 @apiri and now the comparison processor!! For the record: I tried to illustrate the potential of the processor by using two of the NiFi own 'pom.xml' and displaying how despite lack of 1

[GitHub] nifi issue #1608: NIFI-3607 Allow multi files mode with fixed names

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1608 @pvillard31 sorry for this but it seems PR is now in conflict with master. Would you mind rebasing? Cheers --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi issue #1016: NIFI-2724 New JMX Processor

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1016 @brianburnett still not rebased correctly. My suggestion is to do again the trick of branching from the master git checkout master -b nifi-2724v3 git cherry-pick your commit hash git

[GitHub] nifi pull request #1395: NIFI-3280 PostHTTP Option to write response to attr...

2017-04-25 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1395#discussion_r113209753 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java --- @@ -880,6

[GitHub] nifi issue #1395: NIFI-3280 PostHTTP Option to write response to attribute o...

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1395 @nickcarenza thanks for the PR, much appreciated. I was going through it and got myself wondering: Is there any reason why we are doing this when InvokeHTTP processor cater

[GitHub] nifi issue #1642: NIFI-1336 - Ensure that flowfiles are penalized upon excep...

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1642 @markap14 no worries. Thanks for the clarification I will try to give it another go. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] nifi issue #1644: NIFI-11 - Capture StringIndexOutOfBoundsException to preve...

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1644 @mcgilman makes total sense. Will adjust --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor

2017-04-28 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1716 @jonashartwig thank you for your contribution. I was looking at your code and was wondering if have you had a chance to see the put / fetch parquet @bbende submitted a few hours ago

[GitHub] nifi issue #1716: NIFI-3759 - avro append for PutHDFS processor

2017-04-28 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1716 Speed and overall project roadmap. The approach introduced there brings significant advantages to the use of PutHDFS. https://github.com/apache/nifi/pull/1712 --- If your

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113932077 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/FuzzyHashContent.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113917927 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi pull request #1692: NIFI-3726 - Introduces CompareFuzzyHash processor

2017-04-28 Thread trixpan
Github user trixpan commented on a diff in the pull request: https://github.com/apache/nifi/pull/1692#discussion_r113918024 --- Diff: nifi-nar-bundles/nifi-cybersecurity-bundle/nifi-cybersecurity-processors/src/main/java/org/apache/nifi/processors/cybersecurity/CompareFuzzyHash.java

[GitHub] nifi issue #1693: NIFI-3737 - Ran optipng on all png files

2017-04-25 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1693 @andrewmlim :+1: :+1: :+1: :+1: for catching this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi issue #1738: NIFI-3718: Fixed timezone issue in TestAvroReaderWithEmbed...

2017-05-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/1738 The people from the future salute you, oh fellow space traveler! LGTM. And works on GMT+11. Suggest waiting for travis to complete to ensure it runs on other Time zones (I assume you

<    1   2   3   4   5   6   7   >