[
https://issues.apache.org/jira/browse/OPENNLP-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736357#comment-17736357
]
ASF GitHub Bot commented on OPENNLP-1174:
-----------------------------------------
mawiesne merged PR #541:
URL: https://github.com/apache/opennlp/pull/541
> remove classic format support in feature generator XML config when it is no
> longer needed
> -----------------------------------------------------------------------------------------
>
> Key: OPENNLP-1174
> URL: https://issues.apache.org/jira/browse/OPENNLP-1174
> Project: OpenNLP
> Issue Type: Planned Work
> Reporter: Koji Sekiguchi
> Assignee: Richard Zowalla
> Priority: Minor
>
> I put many "TODO" marks in the patch for OPENNLP-1154, e.g.:
> {code:java}
> @Deprecated // TODO: just remove when back-compat is no longer needed
> static void register(Map<String, GeneratorFactory.XmlFeatureGeneratorFactory>
> factoryMap) {
> factoryMap.put("generators", new AggregatedFeatureGeneratorFactory());
> }
> {code}
> Before merging it, I'd like to create this ticket to get ticket number and
> add the number in the patch for OPENNLP-1154 so that we can easily find
> unnecessary codes when we want to remove in the future..
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
