[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-18 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #23 from h...@apache.org h...@apache.org --- btw. is there a standard encoding for the codebase? I personally prefer UTF-8, but as you saw many files are in iso8859-1. And some people don't use UTF-8 enabled dev environments. It

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-16 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #22 from j.nitsc...@ok.de --- (In reply to h...@apache.org from comment #21) @j.nitschke: All patches are good so far, its a wonderful cleanup. Thanks for working on it! Welcome But with AOO 4.1 beta coming soon I'd like to wait

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-14 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 h...@apache.org h...@apache.org changed: What|Removed |Added Status|CONFIRMED |ACCEPTED Target

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-12 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #19 from SVN Robot svn...@dev.null.org --- hdu committed SVN revision 1567593 into trunk: #i123862# use O*String's isEmpty() method to check for emptiness in the codem... -- You are receiving this mail because: You are on the CC

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-12 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #20 from SVN Robot svn...@dev.null.org --- hdu committed SVN revision 1567594 into trunk: #i123862# use O*String's isEmpty() method to check for emptiness in the comph... -- You are receiving this mail because: You are on the CC

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-10 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 Oliver-Rainer Wittmann o...@apache.org changed: What|Removed |Added CC|

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-10 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #18 from SVN Robot svn...@dev.null.org --- hdu committed SVN revision 1566533 into trunk: #i123862# use O*String's isEmpty() method to check for emptiness in chart2 mo... -- You are receiving this mail because: You are on the CC

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-09 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #17 from j.nitsc...@ok.de --- Created attachment 82553 -- https://issues.apache.org/ooo/attachment.cgi?id=82553action=edit use O*String isEmpty() in module dbaccess -- You are receiving this mail because: You are on the CC list

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-07 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #9 from j.nitsc...@ok.de --- Created attachment 82535 -- https://issues.apache.org/ooo/attachment.cgi?id=82535action=edit use O*String isEmpty() in module chart2 -- You are receiving this mail because: You are on the CC list for

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-07 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #10 from j.nitsc...@ok.de --- Created attachment 82536 -- https://issues.apache.org/ooo/attachment.cgi?id=82536action=edit use O*String isEmpty() in module codemaker -- You are receiving this mail because: You are on the CC list

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-07 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #11 from j.nitsc...@ok.de --- Created attachment 82537 -- https://issues.apache.org/ooo/attachment.cgi?id=82537action=edit use O*String isEmpty() in module comphelper -- You are receiving this mail because: You are on the CC

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-07 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #12 from j.nitsc...@ok.de --- Created attachment 82538 -- https://issues.apache.org/ooo/attachment.cgi?id=82538action=edit use O*String isEmpty() in module configmgr -- You are receiving this mail because: You are on the CC list

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-07 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #13 from j.nitsc...@ok.de --- Created attachment 82539 -- https://issues.apache.org/ooo/attachment.cgi?id=82539action=edit use O*String isEmpty() in module connectivity -- You are receiving this mail because: You are on the CC

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-07 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #14 from j.nitsc...@ok.de --- Created attachment 82540 -- https://issues.apache.org/ooo/attachment.cgi?id=82540action=edit use O*String isEmpty() in module cppu and cppuhelper -- You are receiving this mail because: You are on

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-07 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #16 from j.nitsc...@ok.de --- Created attachment 82542 -- https://issues.apache.org/ooo/attachment.cgi?id=82542action=edit use O*String isEmpty() in small changes in modules stating with b and c -- You are receiving this mail

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-07 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #15 from j.nitsc...@ok.de --- Created attachment 82541 -- https://issues.apache.org/ooo/attachment.cgi?id=82541action=edit use O*String isEmpty() in module cui -- You are receiving this mail because: You are on the CC list for

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-04 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #7 from SVN Robot svn...@dev.null.org --- hdu committed SVN revision 1564228 into trunk: #i123862# use O*String's isEmpty() method to check for emptiness in modules s... -- You are receiving this mail because: You are on the CC

review granted: [Bug 123862] O*String's isEmpty() should be used instead of its older alternatives : [Attachment 82480] use O*String isEmpty() in modules starting with b

2014-02-04 Thread bugzilla
h...@apache.org h...@apache.org has granted j.nitsc...@ok.de's request for review: Bug 123862: O*String's isEmpty() should be used instead of its older alternatives https://issues.apache.org/ooo/show_bug.cgi?id=123862 Attachment 82480: use O*String isEmpty() in modules starting with b https

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-04 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 h...@apache.org h...@apache.org changed: What|Removed |Added Attachment #82480|review?(h...@apache.org) |review+

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-04 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #8 from SVN Robot svn...@dev.null.org --- hdu committed SVN revision 1564230 into trunk: #i123862# use O*String's isEmpty() method to check for emptiness in modules s... -- You are receiving this mail because: You are on the CC

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #4 from j.nitsc...@ok.de --- almost missed the very common implicit casts in conditions: if (a.getLength()) a.getLength() ? b : c while (a.getLength()) and via logical operators !,|| and : a.getLength() b a.getLength() || b

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 j.nitsc...@ok.de changed: What|Removed |Added Attachment #82479||review?(h...@apache.org)

review requested: [Bug 123862] O*String's isEmpty() should be used instead of its older alternatives : [Attachment 82479] use O*String isEmpty() in modules starting with a

2014-02-03 Thread bugzilla
j.nitsc...@ok.de has asked h...@apache.org h...@apache.org for review: Bug 123862: O*String's isEmpty() should be used instead of its older alternatives https://issues.apache.org/ooo/show_bug.cgi?id=123862 Attachment 82479: use O*String isEmpty() in modules starting with a https

review requested: [Bug 123862] O*String's isEmpty() should be used instead of its older alternatives : [Attachment 82480] use O*String isEmpty() in modules starting with b

2014-02-03 Thread bugzilla
j.nitsc...@ok.de has asked h...@apache.org h...@apache.org for review: Bug 123862: O*String's isEmpty() should be used instead of its older alternatives https://issues.apache.org/ooo/show_bug.cgi?id=123862 Attachment 82480: use O*String isEmpty() in modules starting with b https

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 j.nitsc...@ok.de changed: What|Removed |Added Attachment #82480||review?(h...@apache.org)

review granted: [Bug 123862] O*String's isEmpty() should be used instead of its older alternatives : [Attachment 82479] use O*String isEmpty() in modules starting with a

2014-02-03 Thread bugzilla
h...@apache.org h...@apache.org has granted j.nitsc...@ok.de's request for review: Bug 123862: O*String's isEmpty() should be used instead of its older alternatives https://issues.apache.org/ooo/show_bug.cgi?id=123862 Attachment 82479: use O*String isEmpty() in modules starting with a https

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-03 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 h...@apache.org h...@apache.org changed: What|Removed |Added Attachment #82479|review?(h...@apache.org) |review+

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-02-01 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #3 from h...@apache.org h...@apache.org --- (In reply to h...@apache.org from comment #2) (In reply to j.nitschke from comment #1) How would you like negations formated? a) !a.isEmpty() b) ! a.isEmpty() c) ( !a.isEmpty() )

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-01-31 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 j.nitsc...@ok.de changed: What|Removed |Added CC||j.nitsc...@ok.de --- Comment #1

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2014-01-31 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 --- Comment #2 from h...@apache.org h...@apache.org --- (In reply to j.nitschke from comment #1) Hi, I would like to work on this simple task to get an overview of the various modules. Thanks for working on this! Your approach and e.g. the

[Bug 123862] O*String's isEmpty() should be used instead of its older alternatives

2013-12-16 Thread bugzilla
https://issues.apache.org/ooo/show_bug.cgi?id=123862 h...@apache.org h...@apache.org changed: What|Removed |Added Latest|--- |4.0.1