[GitHub] [openwhisk] pankaj-dahiya commented on issue #4067: [Issue] 100% reproducible ok: invoked /guest/example, but the request has not yet finished, with id xxxx

2019-08-29 Thread GitBox
pankaj-dahiya commented on issue #4067: [Issue] 100% reproducible ok: invoked /guest/example, but the request has not yet finished, with id URL: https://github.com/apache/openwhisk/issues/4067#issuecomment-526483619 same thing happening with me at hello-world function! I am just run

[GitHub] [openwhisk-deploy-kube] chetanmeh merged pull request #516: minor cleanup of invoker env templates

2019-08-29 Thread GitBox
chetanmeh merged pull request #516: minor cleanup of invoker env templates URL: https://github.com/apache/openwhisk-deploy-kube/pull/516 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4595: Pass an optional action instance to ContainerFactory

2019-08-29 Thread GitBox
chetanmeh commented on a change in pull request #4595: Pass an optional action instance to ContainerFactory URL: https://github.com/apache/openwhisk/pull/4595#discussion_r319356525 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerFactory.sc

[GitHub] [openwhisk] chetanmeh commented on issue #4594: CouchDB support in OpenWhisk Standalone mode

2019-08-29 Thread GitBox
chetanmeh commented on issue #4594: CouchDB support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4594#issuecomment-526455360 > the docs for standalone should get promoted to be "front and center" of our docs for getting started on this repo. @rabbah That

[GitHub] [openwhisk] codecov-io edited a comment on issue #4584: OpenWhisk User Events

2019-08-29 Thread GitBox
codecov-io edited a comment on issue #4584: OpenWhisk User Events URL: https://github.com/apache/openwhisk/pull/4584#issuecomment-525009358 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4584?src=pr&el=h1) Report > Merging [#4584](https://codecov.io/gh/apache/openwhisk/pull/458

[GitHub] [openwhisk-deploy-kube] dgrove-oss opened a new pull request #517: default ingress annotation

2019-08-29 Thread GitBox
dgrove-oss opened a new pull request #517: default ingress annotation URL: https://github.com/apache/openwhisk-deploy-kube/pull/517 Add proxy-body-size annotation to default ingress annotations defined in values.yaml. Fixes #509. ---

[GitHub] [openwhisk] rabbah commented on a change in pull request #4595: Pass an optional action instance to ContainerFactory

2019-08-29 Thread GitBox
rabbah commented on a change in pull request #4595: Pass an optional action instance to ContainerFactory URL: https://github.com/apache/openwhisk/pull/4595#discussion_r319206866 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerFactory.scala

[GitHub] [openwhisk] rabbah merged pull request #4594: CouchDB support in OpenWhisk Standalone mode

2019-08-29 Thread GitBox
rabbah merged pull request #4594: CouchDB support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4594 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [openwhisk-website] dgrove-oss opened a new pull request #406: Add openwhisk-client-js to download page

2019-08-29 Thread GitBox
dgrove-oss opened a new pull request #406: Add openwhisk-client-js to download page URL: https://github.com/apache/openwhisk-website/pull/406 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [openwhisk-devtools] pritidesai merged pull request #285: Fix gradle build for Java runtime

2019-08-29 Thread GitBox
pritidesai merged pull request #285: Fix gradle build for Java runtime URL: https://github.com/apache/openwhisk-devtools/pull/285 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [openwhisk-runtime-go] sciabarracom commented on issue #97: env support

2019-08-29 Thread GitBox
sciabarracom commented on issue #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97#issuecomment-526220455 According this test https://github.com/sciabarracom/openwhisk-runtime-go/blob/946e9402f1c841fac326ca0a4d4ab101afd121b7/tests/src/test/scala/runtime/actionCont

[GitHub] [openwhisk-runtime-go] rabbah commented on issue #97: env support

2019-08-29 Thread GitBox
rabbah commented on issue #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97#issuecomment-526218409 Either it was already working or it was never working. There is no apihost sent from the invoker.

[GitHub] [openwhisk-devtools] mrutkows opened a new pull request #285: Fix gradle build for Java runtime

2019-08-29 Thread GitBox
mrutkows opened a new pull request #285: Fix gradle build for Java runtime URL: https://github.com/apache/openwhisk-devtools/pull/285 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [openwhisk-runtime-go] sciabarracom commented on a change in pull request #97: env support

2019-08-29 Thread GitBox
sciabarracom commented on a change in pull request #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97#discussion_r319107552 ## File path: openwhisk/executor.go ## @@ -44,13 +44,16 @@ type Executor struct { // NewExecutor creates a child subproces

[GitHub] [openwhisk-runtime-go] sciabarracom commented on issue #97: env support

2019-08-29 Thread GitBox
sciabarracom commented on issue #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97#issuecomment-526215282 Now the __OW_APIHOST is no more propagated to the actionloop... not sure if this breaks something. It could... --

[GitHub] [openwhisk-runtime-go] sciabarracom commented on a change in pull request #97: env support

2019-08-29 Thread GitBox
sciabarracom commented on a change in pull request #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97#discussion_r319105462 ## File path: openwhisk/executor.go ## @@ -44,13 +44,16 @@ type Executor struct { // NewExecutor creates a child subproces

[GitHub] [openwhisk-runtime-go] sciabarracom commented on a change in pull request #97: env support

2019-08-29 Thread GitBox
sciabarracom commented on a change in pull request #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97#discussion_r319105462 ## File path: openwhisk/executor.go ## @@ -44,13 +44,16 @@ type Executor struct { // NewExecutor creates a child subproces

[GitHub] [openwhisk-runtime-go] sciabarracom commented on a change in pull request #97: env support

2019-08-29 Thread GitBox
sciabarracom commented on a change in pull request #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97#discussion_r319105194 ## File path: openwhisk/initHandler_test.go ## @@ -243,3 +244,24 @@ func Example_zip_init() { // XXX_THE_END_OF_A_W

[GitHub] [openwhisk-runtime-go] rabbah merged pull request #97: env support

2019-08-29 Thread GitBox
rabbah merged pull request #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [openwhisk] chetanmeh commented on issue #4596: Allow individual field sets for activation_record and user_log

2019-08-29 Thread GitBox
chetanmeh commented on issue #4596: Allow individual field sets for activation_record and user_log URL: https://github.com/apache/openwhisk/pull/4596#issuecomment-526202330 Thanks for addressing the feedback! This is an autom

[GitHub] [openwhisk-runtime-nodejs] dgrove-oss merged pull request #149: Rename method.

2019-08-29 Thread GitBox
dgrove-oss merged pull request #149: Rename method. URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on issue #436: Api Gateway not working on Docker Desktop Windows/Mac

2019-08-29 Thread GitBox
dgrove-oss commented on issue #436: Api Gateway not working on Docker Desktop Windows/Mac URL: https://github.com/apache/openwhisk-deploy-kube/issues/436#issuecomment-526200134 Good tip @chetanmeh; seems plausible to me. Thi

[GitHub] [openwhisk-deploy-kube] dgrove-oss opened a new pull request #516: minor cleanup of invoker env templates

2019-08-29 Thread GitBox
dgrove-oss opened a new pull request #516: minor cleanup of invoker env templates URL: https://github.com/apache/openwhisk-deploy-kube/pull/516 Noticed when reviewing #513 that we had allowed multiple concerns to get into the same helper macro. Break into two macros so that intent of

[GitHub] [openwhisk] ruediger-maass commented on a change in pull request #4596: Allow individual field sets for activation_record and user_log

2019-08-29 Thread GitBox
ruediger-maass commented on a change in pull request #4596: Allow individual field sets for activation_record and user_log URL: https://github.com/apache/openwhisk/pull/4596#discussion_r319080973 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/Activatio

[GitHub] [openwhisk] rabbah merged pull request #4598: Amend docs for container proxy tests.

2019-08-29 Thread GitBox
rabbah merged pull request #4598: Amend docs for container proxy tests. URL: https://github.com/apache/openwhisk/pull/4598 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [openwhisk-deploy-kube] dgrove-oss merged pull request #514: Remove duplicate configurations already in template

2019-08-29 Thread GitBox
dgrove-oss merged pull request #514: Remove duplicate configurations already in template URL: https://github.com/apache/openwhisk-deploy-kube/pull/514 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [openwhisk] codecov-io commented on issue #4598: Amend docs for container proxy tests.

2019-08-29 Thread GitBox
codecov-io commented on issue #4598: Amend docs for container proxy tests. URL: https://github.com/apache/openwhisk/pull/4598#issuecomment-526188813 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4598?src=pr&el=h1) Report > Merging [#4598](https://codecov.io/gh/apache/openwhisk

[GitHub] [openwhisk] codecov-io edited a comment on issue #4594: CouchDB support in OpenWhisk Standalone mode

2019-08-29 Thread GitBox
codecov-io edited a comment on issue #4594: CouchDB support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4594#issuecomment-525838761 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4594?src=pr&el=h1) Report > Merging [#4594](https://codecov.io/gh/a

[GitHub] [openwhisk-deploy-kube] dgrove-oss closed issue #512: helm install .... --name owdev-name-test can not have "-" in it

2019-08-29 Thread GitBox
dgrove-oss closed issue #512: helm install --name owdev-name-test can not have "-" in it URL: https://github.com/apache/openwhisk-deploy-kube/issues/512 This is an automated message from the Apache Git Service. To res

[GitHub] [openwhisk-deploy-kube] dgrove-oss commented on issue #512: helm install .... --name owdev-name-test can not have "-" in it

2019-08-29 Thread GitBox
dgrove-oss commented on issue #512: helm install --name owdev-name-test can not have "-" in it URL: https://github.com/apache/openwhisk-deploy-kube/issues/512#issuecomment-526184776 Fixed by #513 This is an automated

[GitHub] [openwhisk-deploy-kube] dgrove-oss merged pull request #513: fix: kafka, zookeeper, controller get num in hostname

2019-08-29 Thread GitBox
dgrove-oss merged pull request #513: fix: kafka, zookeeper, controller get num in hostname URL: https://github.com/apache/openwhisk-deploy-kube/pull/513 This is an automated message from the Apache Git Service. To respond to

[GitHub] [openwhisk] rabbah commented on issue #4594: CouchDB support in OpenWhisk Standalone mode

2019-08-29 Thread GitBox
rabbah commented on issue #4594: CouchDB support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4594#issuecomment-526181164 @chetanmeh the docs for standalone should get promoted to be "front and center" of our docs for getting started on this repo.

[GitHub] [openwhisk-runtime-nodejs] rabbah opened a new pull request #149: Rename method.

2019-08-29 Thread GitBox
rabbah opened a new pull request #149: Rename method. URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/149 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [openwhisk] rabbah commented on issue #4594: CouchDB support in OpenWhisk Standalone mode

2019-08-29 Thread GitBox
rabbah commented on issue #4594: CouchDB support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4594#issuecomment-526170471 Sorry fat finger! I was trying this out and tabbed to the wrong place. Thi

[GitHub] [openwhisk] chetanmeh opened a new pull request #4594: CouchDB support in OpenWhisk Standalone mode

2019-08-29 Thread GitBox
chetanmeh opened a new pull request #4594: CouchDB support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4594 Enable using CouchDB with standalone mode (#4516). This would be useful for cases where users would like to save there changes upon restarts. ##

[GitHub] [openwhisk] rabbah closed pull request #4594: CouchDB support in OpenWhisk Standalone mode

2019-08-29 Thread GitBox
rabbah closed pull request #4594: CouchDB support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4594 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [openwhisk] rabbah commented on a change in pull request #4594: CouchDB support in OpenWhisk Standalone mode

2019-08-29 Thread GitBox
rabbah commented on a change in pull request #4594: CouchDB support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4594#discussion_r319040349 ## File path: core/standalone/README.md ## @@ -77,8 +77,10 @@ $ java -jar openwhisk-standalone.jar -h

[GitHub] [openwhisk] rabbah commented on a change in pull request #4594: CouchDB support in OpenWhisk Standalone mode

2019-08-29 Thread GitBox
rabbah commented on a change in pull request #4594: CouchDB support in OpenWhisk Standalone mode URL: https://github.com/apache/openwhisk/pull/4594#discussion_r319039330 ## File path: core/standalone/README.md ## @@ -77,8 +77,10 @@ $ java -jar openwhisk-standalone.jar -h

[GitHub] [openwhisk-runtime-nodejs] chetanmeh commented on issue #143: Export activation arguments to environment during initialization.

2019-08-29 Thread GitBox
chetanmeh commented on issue #143: Export activation arguments to environment during initialization. URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/143#issuecomment-526160453 Ah you mean change `testEnvPartition`? That would require change in core repo also? ---

[GitHub] [openwhisk] rabbah opened a new pull request #4598: Amend docs for container proxy tests.

2019-08-29 Thread GitBox
rabbah opened a new pull request #4598: Amend docs for container proxy tests. URL: https://github.com/apache/openwhisk/pull/4598 Fixes some typos and amends docs for container proxy tests. ## Description ## Related issue and scope - [ ] I opened an issue to propo

[GitHub] [openwhisk-runtime-nodejs] rabbah commented on issue #143: Export activation arguments to environment during initialization.

2019-08-29 Thread GitBox
rabbah commented on issue #143: Export activation arguments to environment during initialization. URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/143#issuecomment-526159882 oy you're too fast - I was about to rename the test method name :)

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4596: Allow individual field sets for activation_record and user_log

2019-08-29 Thread GitBox
chetanmeh commented on a change in pull request #4596: Allow individual field sets for activation_record and user_log URL: https://github.com/apache/openwhisk/pull/4596#discussion_r319037428 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/ActivationFile

[GitHub] [openwhisk-runtime-nodejs] chetanmeh merged pull request #143: Export activation arguments to environment during initialization.

2019-08-29 Thread GitBox
chetanmeh merged pull request #143: Export activation arguments to environment during initialization. URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/143 This is an automated message from the Apache Git Service.

[GitHub] [openwhisk-runtime-go] rabbah commented on a change in pull request #97: env support

2019-08-29 Thread GitBox
rabbah commented on a change in pull request #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97#discussion_r319033354 ## File path: openwhisk/initHandler_test.go ## @@ -243,3 +244,24 @@ func Example_zip_init() { // XXX_THE_END_OF_A_WHISK_A

[GitHub] [openwhisk-runtime-nodejs] rabbah commented on a change in pull request #143: Export activation arguments to environment during initialization.

2019-08-29 Thread GitBox
rabbah commented on a change in pull request #143: Export activation arguments to environment during initialization. URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/143#discussion_r319030530 ## File path: core/nodejsActionBase/src/service.js ## @@ -160,6 +160

[GitHub] [openwhisk-runtime-nodejs] chetanmeh commented on a change in pull request #143: Export activation arguments to environment during initialization.

2019-08-29 Thread GitBox
chetanmeh commented on a change in pull request #143: Export activation arguments to environment during initialization. URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/143#discussion_r319008696 ## File path: core/nodejsActionBase/src/service.js ## @@ -160,6 +

[GitHub] [openwhisk-runtime-nodejs] chetanmeh commented on issue #143: Export activation arguments to environment during initialization.

2019-08-29 Thread GitBox
chetanmeh commented on issue #143: Export activation arguments to environment during initialization. URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/143#issuecomment-526135548 Relevant test also now pass ```runtime.actionContainers.NodeJs12ActionContainerTests > runtim

[GitHub] [openwhisk-runtime-nodejs] chetanmeh edited a comment on issue #143: Export activation arguments to environment during initialization.

2019-08-29 Thread GitBox
chetanmeh edited a comment on issue #143: Export activation arguments to environment during initialization. URL: https://github.com/apache/openwhisk-runtime-nodejs/pull/143#issuecomment-526135548 Relevant test also now pass ``` runtime.actionContainers.NodeJs12ActionContainerTes

[GitHub] [openwhisk] rabbah commented on issue #4597: The indent setting is different from most of the codes.

2019-08-29 Thread GitBox
rabbah commented on issue #4597: The indent setting is different from most of the codes. URL: https://github.com/apache/openwhisk/issues/4597#issuecomment-526127793 👍 This is an automated message from the Apache Git Service.

[GitHub] [openwhisk] chetanmeh commented on a change in pull request #4584: OpenWhisk User Events

2019-08-29 Thread GitBox
chetanmeh commented on a change in pull request #4584: OpenWhisk User Events URL: https://github.com/apache/openwhisk/pull/4584#discussion_r318995166 ## File path: core/monitoring/user-events/src/main/resources/application.conf ## @@ -0,0 +1,60 @@ +# +# Licensed to the Apac

[GitHub] [openwhisk-runtime-go] sciabarracom commented on issue #97: env support

2019-08-29 Thread GitBox
sciabarracom commented on issue #97: env support URL: https://github.com/apache/openwhisk-runtime-go/pull/97#issuecomment-526113636 I rebased and used a "map[string]string" as Env. Still needed the "scala" tests for that. Th

[GitHub] [openwhisk-deploy-kube] BillZong opened a new pull request #514: Remove duplicate configurations already in template

2019-08-29 Thread GitBox
BillZong opened a new pull request #514: Remove duplicate configurations already in template URL: https://github.com/apache/openwhisk-deploy-kube/pull/514 ## Description Remove duplicate configurations already in template, it's in file [`helm/openwhisk/templates/_helpers.tpl`](https

[GitHub] [openwhisk-deploy-kube] BillZong commented on issue #514: Remove duplicate configurations already in template

2019-08-29 Thread GitBox
BillZong commented on issue #514: Remove duplicate configurations already in template URL: https://github.com/apache/openwhisk-deploy-kube/pull/514#issuecomment-526088289 @chetanmeh Thx for your kindly reminding. This is an

[GitHub] [openwhisk-deploy-kube] chetanmeh commented on issue #514: Remove duplicate configurations already in template

2019-08-29 Thread GitBox
chetanmeh commented on issue #514: Remove duplicate configurations already in template URL: https://github.com/apache/openwhisk-deploy-kube/pull/514#issuecomment-526086902 @BillZong No need to close the PR. The Reviewer step is just to ensure that PR is reviewed. On your side just open t

[GitHub] [openwhisk] codecov-io edited a comment on issue #4596: Allow individual field sets for activation_record and user_log

2019-08-29 Thread GitBox
codecov-io edited a comment on issue #4596: Allow individual field sets for activation_record and user_log URL: https://github.com/apache/openwhisk/pull/4596#issuecomment-525742834 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4596?src=pr&el=h1) Report > Merging [#4596](https

[GitHub] [openwhisk] ruediger-maass edited a comment on issue #4596: Allow individual field sets for activation_record and user_log

2019-08-29 Thread GitBox
ruediger-maass edited a comment on issue #4596: Allow individual field sets for activation_record and user_log URL: https://github.com/apache/openwhisk/pull/4596#issuecomment-526064033 > Looks fine. Just to confirm my understanding - You have your own impl similar to `ArtifactWithFileStora

[GitHub] [openwhisk] ruediger-maass edited a comment on issue #4596: Allow individual field sets for activation_record and user_log

2019-08-29 Thread GitBox
ruediger-maass edited a comment on issue #4596: Allow individual field sets for activation_record and user_log URL: https://github.com/apache/openwhisk/pull/4596#issuecomment-526064033 > Looks fine. Just to confirm my understanding - You have your own impl similar to `ArtifactWithFileStora

[GitHub] [openwhisk] BillZong opened a new issue #4597: The indent setting is different from most of the codes.

2019-08-29 Thread GitBox
BillZong opened a new issue #4597: The indent setting is different from most of the codes. URL: https://github.com/apache/openwhisk/issues/4597 [As you could see here](https://github.com/apache/openwhisk/blob/b20dffbaf4e8d6ea90da5d8bd233a6b770fa74bb/tools/eclipse/scala.properties#L39)

[GitHub] [openwhisk] ruediger-maass commented on issue #4596: Allow individual field sets for activation_record and user_log

2019-08-29 Thread GitBox
ruediger-maass commented on issue #4596: Allow individual field sets for activation_record and user_log URL: https://github.com/apache/openwhisk/pull/4596#issuecomment-526064033 > Looks fine. Just to confirm my understanding - You have your own impl similar to `ArtifactWithFileStorageActiv

[GitHub] [openwhisk] ruediger-maass commented on a change in pull request #4596: Allow individual field sets for activation_record and user_log

2019-08-29 Thread GitBox
ruediger-maass commented on a change in pull request #4596: Allow individual field sets for activation_record and user_log URL: https://github.com/apache/openwhisk/pull/4596#discussion_r318919529 ## File path: common/scala/src/main/scala/org/apache/openwhisk/core/database/Activatio