[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-16 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050470989 ## tools/github/runDummyKOTests.sh: ## @@ -0,0 +1,26 @@ +#!/usr/bin/env bash Review Comment: removed -- This is an automated message from the Apache Git Se

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-16 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050472679 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action

2022-12-16 Thread GitBox
style95 commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050494234 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

[GitHub] [openwhisk] style95 commented on a diff in pull request #5361: GitHub action

2022-12-16 Thread GitBox
style95 commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050494234 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

[GitHub] [openwhisk] msciabarra commented on pull request #5361: GitHub action

2022-12-16 Thread GitBox
msciabarra commented on PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#issuecomment-1354549513 Definitely ready to merge. This is what I get on my fork: ![Screenshot 2022-12-16 at 10 52 51](https://user-images.githubusercontent.com/1595312/208082941-d902970d-787b-4b84-bedc-2

[GitHub] [openwhisk] sciabarracom merged pull request #5361: GitHub action

2022-12-16 Thread GitBox
sciabarracom merged PR #5361: URL: https://github.com/apache/openwhisk/pull/5361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@open

[GitHub] [openwhisk] msciabarra opened a new pull request, #5365: Making optional log upload and slack notifications if variables are missing

2022-12-16 Thread GitBox
msciabarra opened a new pull request, #5365: URL: https://github.com/apache/openwhisk/pull/5365 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My changes affect the following components

[GitHub] [openwhisk] msciabarra closed pull request #5365: Making optional log upload and slack notifications if variables are missing

2022-12-16 Thread GitBox
msciabarra closed pull request #5365: Making optional log upload and slack notifications if variables are missing URL: https://github.com/apache/openwhisk/pull/5365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [openwhisk] msciabarra opened a new pull request, #5366: making optional logs upload and slack notification

2022-12-16 Thread GitBox
msciabarra opened a new pull request, #5366: URL: https://github.com/apache/openwhisk/pull/5366 making optional logs upload and slack notification ## Description errors in build for missing env vars ## Related issue and scope - [ ] I opened an issue to pro

[GitHub] [openwhisk] codecov-commenter commented on pull request #5366: making optional logs upload and slack notification

2022-12-16 Thread GitBox
codecov-commenter commented on PR #5366: URL: https://github.com/apache/openwhisk/pull/5366#issuecomment-1355990340 # [Codecov](https://codecov.io/gh/apache/openwhisk/pull/5366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache