[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-16 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050472679 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-16 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050470989 ## tools/github/runDummyKOTests.sh: ## @@ -0,0 +1,26 @@ +#!/usr/bin/env bash Review Comment: removed -- This is an automated message from the Apache Git Se

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-15 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050460516 ## tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/ActivationClientProxyTests.scala: ## @@ -15,6 +15,7 @@ * limitations under the License.

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-15 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1050363178 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-15 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049618814 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-14 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049281941 ## tools/github/runDummyKOTests.sh: ## @@ -0,0 +1,26 @@ +#!/usr/bin/env bash Review Comment: yes to test a failing build... -- This is an automated message

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-14 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049281580 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-14 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049279967 ## tools/github/setup.sh: ## @@ -0,0 +1,79 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreemen

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-14 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049279581 ## tools/github/runDummyTests.sh: ## @@ -0,0 +1,26 @@ +#!/usr/bin/env bash Review Comment: to test the build without having to run a full test... it is handy t

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-14 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049279054 ## .github/workflows/README.md: ## @@ -0,0 +1,56 @@ +# How to use those workflows + +There are a few [GitHub secrets](https://docs.github.com/en/actions/security-

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-14 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049270136 ## .github/workflows/0-on-demand.yaml: ## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-14 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1049267204 ## .github/workflows/0-on-demand.yaml: ## @@ -0,0 +1,94 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-13 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1048119663 ## ansible/group_vars/all: ## @@ -458,98 +420,3 @@ metrics: port: "{{ metrics_kamon_statsd_port | default('8125') }}" user_events: "{{ user_events_enabled

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action

2022-12-12 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1046228883 ## ansible/group_vars/all: ## @@ -551,5 +551,3 @@ scheduler: throttlingFraction: "{{ scheduler_queue_throttlingFraction | default(0.9) }}" durationBuffe

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action [WIP]

2022-12-09 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1045018310 ## .github/workflows/performance.yaml: ## @@ -0,0 +1,71 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements.

[GitHub] [openwhisk] msciabarra commented on a diff in pull request #5361: GitHub action [WIP]

2022-12-09 Thread GitBox
msciabarra commented on code in PR #5361: URL: https://github.com/apache/openwhisk/pull/5361#discussion_r1045018230 ## .github/workflows/unit.yaml: ## @@ -0,0 +1,62 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See t