[GitHub] drcariel commented on a change in pull request #2605: experimental web apigw cleanup

2017-08-11 Thread git
drcariel commented on a change in pull request #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#discussion_r132807688 ## File path: tests/src/test/scala/whisk/core/cli/test/WskWebActionsTests.scala ## @@ -47,11 +47,6 @@ im

[GitHub] rabbah commented on a change in pull request #2605: experimental web apigw cleanup

2017-08-11 Thread git
rabbah commented on a change in pull request #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#discussion_r132805060 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -74,14 +74,6 @@

[GitHub] rabbah commented on a change in pull request #2605: experimental web apigw cleanup

2017-08-11 Thread git
rabbah commented on a change in pull request #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#discussion_r132805060 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -74,14 +74,6 @@

[GitHub] rabbah commented on a change in pull request #2605: experimental web apigw cleanup

2017-08-11 Thread git
rabbah commented on a change in pull request #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#discussion_r132805060 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -74,14 +74,6 @@

[GitHub] mdeuser commented on issue #2605: experimental web apigw cleanup

2017-08-11 Thread git
mdeuser commented on issue #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#issuecomment-321944882 @drcariel - the `apigw_host: "http://{{ groups['apigateway']|first }}:{{apigateway.port.api}}/v1"` path won't be used any more with the remov

[GitHub] rabbah commented on a change in pull request #2605: experimental web apigw cleanup

2017-08-11 Thread git
rabbah commented on a change in pull request #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#discussion_r132804055 ## File path: tests/src/test/scala/whisk/core/cli/test/WskWebActionsTests.scala ## @@ -47,11 +47,6 @@ impo

[GitHub] drcariel commented on issue #2605: experimental web apigw cleanup

2017-08-11 Thread git
drcariel commented on issue #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#issuecomment-321942321 sister PR in Blue ~3909 This is an automated message from the Apache Git S

[GitHub] drcariel commented on issue #2605: experimental web apigw cleanup

2017-08-11 Thread git
drcariel commented on issue #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#issuecomment-321942321 sister PR in Blue ~3909 This is an automated message from the Apache Git S

[GitHub] drcariel commented on issue #2591: User-Agent CLI/version header

2017-08-11 Thread git
drcariel commented on issue #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#issuecomment-321942115 PG1~1942 This is an automated message from the Apache Git Service. To respo

[GitHub] csantanapr closed pull request #212: Replace 'kafka_brokers_sasl' with the (correct) 'brokers'

2017-08-11 Thread git
csantanapr closed pull request #212: Replace 'kafka_brokers_sasl' with the (correct) 'brokers' URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/212 This is an automated message from the Apache Git Servi

[GitHub] csantanapr closed issue #211: kafkaProduce action references 'kafka_brokers_sasl' parameter

2017-08-11 Thread git
csantanapr closed issue #211: kafkaProduce action references 'kafka_brokers_sasl' parameter URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/211 This is an automated message from the Apache Git Servic

[GitHub] rabbah commented on issue #2605: experimental web apigw cleanup

2017-08-11 Thread git
rabbah commented on issue #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#issuecomment-321936688 can def nuke /experimental and all the stuff that goes with it. go for it. T

[GitHub] rabbah commented on issue #236: Description not clear for combinator eca iff

2017-08-11 Thread git
rabbah commented on issue #236: Description not clear for combinator eca iff URL: https://github.com/apache/incubator-openwhisk-catalog/issues/236#issuecomment-321936758 +1 to expand iff for clarity. This is an automated mes

[GitHub] rabbah closed pull request #60: Fix wording, remove breaking apostrophe

2017-08-11 Thread git
rabbah closed pull request #60: Fix wording, remove breaking apostrophe URL: https://github.com/apache/incubator-openwhisk-client-js/pull/60 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] krook commented on issue #60: Fix wording, remove breaking apostrophe

2017-08-11 Thread git
krook commented on issue #60: Fix wording, remove breaking apostrophe URL: https://github.com/apache/incubator-openwhisk-client-js/pull/60#issuecomment-321931702 Is this a quick hit to merge? This is an automated message fro

[GitHub] krook commented on issue #236: Description not clear for combinator eca iff

2017-08-11 Thread git
krook commented on issue #236: Description not clear for combinator eca iff URL: https://github.com/apache/incubator-openwhisk-catalog/issues/236#issuecomment-321931075 I thought @rabbah meant that `iff` should be replaced with `if and only if` as it's a label? I'm happy to submit a PR to

[GitHub] csantanapr commented on issue #2605: experimental web apigw cleanup

2017-08-11 Thread git
csantanapr commented on issue #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605#issuecomment-321922551 David what you have is not directly related to apigateway. This PR has two concepts that should be split. 1. apigateway experimental

[GitHub] csantanapr opened a new issue #236: Description not clear for combinator eca iff

2017-08-11 Thread git
csantanapr opened a new issue #236: Description not clear for combinator eca iff URL: https://github.com/apache/incubator-openwhisk-catalog/issues/236 User @krook thought `iff` was a typo but is actually `if only if` according to @rabbah "Event-Condition-Action: run condition action

[GitHub] drcariel opened a new pull request #2605: experimental web apigw cleanup

2017-08-11 Thread git
drcariel opened a new pull request #2605: experimental web apigw cleanup URL: https://github.com/apache/incubator-openwhisk/pull/2605 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] bjustin-ibm opened a new pull request #212: Replace 'kafka_brokers_sasl' with the (correct) 'brokers'

2017-08-11 Thread git
bjustin-ibm opened a new pull request #212: Replace 'kafka_brokers_sasl' with the (correct) 'brokers' URL: https://github.com/apache/incubator-openwhisk-package-kafka/pull/212 'kafka_brokers_sasl' is only valid in the messageHubProduce action. The equivalent for kafkaProduce is just 'broke

[GitHub] bjustin-ibm opened a new issue #211: kafkaProduce action references 'kafka_brokers_sasl' parameter

2017-08-11 Thread git
bjustin-ibm opened a new issue #211: kafkaProduce action references 'kafka_brokers_sasl' parameter URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/211 This parameter only applies to the messageHubProduce action. The equivalent parameter for kafkaProduce is `brokers`

[GitHub] rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132737302 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala ## @@ -

[GitHub] rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132738438 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala ## @@ -

[GitHub] rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132738226 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala ## @@ -

[GitHub] underwoodb-sd-ibm commented on issue #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
underwoodb-sd-ibm commented on issue #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#issuecomment-321868842 @mdeuser, @dubeejw, @csantanapr, @rabbah - here is the rough PR of how to handle `wsk activation list` descriptio

[GitHub] rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132738116 ## File path: ansible/files/whisks_design_document_for_activations_db.json ## @@ -2,7 +2,

[GitHub] rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132737843 ## File path: tests/src/test/scala/system/basic/WskBasicTests.scala ## @@ -185,6 +185,27

[GitHub] underwoodb-sd-ibm commented on a change in pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
underwoodb-sd-ibm commented on a change in pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132737849 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala #

[GitHub] rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132737302 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala ## @@ -

[GitHub] rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132737302 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala ## @@ -

[GitHub] rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
rabbah commented on a change in pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#discussion_r132737302 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskActivation.scala ## @@ -

[GitHub] underwoodb-sd-ibm commented on issue #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
underwoodb-sd-ibm commented on issue #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604#issuecomment-321867391 Issues that need to be addressed with this PR before review: - Write tests - Update the code to derive t

[GitHub] underwoodb-sd-ibm opened a new pull request #2604: (WIP) Give more information in Activation lists

2017-08-11 Thread git
underwoodb-sd-ibm opened a new pull request #2604: (WIP) Give more information in Activation lists URL: https://github.com/apache/incubator-openwhisk/pull/2604 This update is intended to add more descriptive and informative information to the output of `wsk activation list`. Currently, the

[GitHub] berndtj commented on issue #43: WIP: configure/deploy via helm charts

2017-08-11 Thread git
berndtj commented on issue #43: WIP: configure/deploy via helm charts URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/43#issuecomment-321864546 @tenczar is coming up to speed and will be working on it. Th

[GitHub] drcariel commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-11 Thread git
drcariel commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132733987 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -326,7 +326,7

[GitHub] tysonnorris commented on issue #2584: SPI for Loadbalancer

2017-08-11 Thread git
tysonnorris commented on issue #2584: SPI for Loadbalancer URL: https://github.com/apache/incubator-openwhisk/pull/2584#issuecomment-321845899 @markusthoemmes let me know if you have more comments? This is an automated messa

[GitHub] rabbah commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-11 Thread git
rabbah commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132715559 ## File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala ## @@ -121,7 +121,7 @@ pr

[GitHub] rabbah commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-11 Thread git
rabbah commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132715559 ## File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala ## @@ -121,7 +121,7 @@ pr

[GitHub] mdeuser commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-11 Thread git
mdeuser commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132710795 ## File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala ## @@ -121,7 +121,7 @@ p

[GitHub] rabbah commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-11 Thread git
rabbah commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132698730 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -326,7 +326,7 @@

[GitHub] mdeuser commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-11 Thread git
mdeuser commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r132697694 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -326,7 +326,7 @

[GitHub] bjustin-ibm commented on issue #210: How to use message feed

2017-08-11 Thread git
bjustin-ibm commented on issue #210: How to use message feed URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/210#issuecomment-321805225 Yes, please refer to the following Apache Kafka guides: https://kafka.apache.org/intro https://kafka.apache.org/quickstart

[GitHub] zhy989 commented on issue #210: How to use message feed

2017-08-11 Thread git
zhy989 commented on issue #210: How to use message feed URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/210#issuecomment-321802312 @bjustin-ibm thanks! Can Kafka instance run on the local host outside the Bluemix? ---

[GitHub] markusthoemmes opened a new pull request #2603: Revert "Temporalily use published swift3Action. (#2580)"

2017-08-11 Thread git
markusthoemmes opened a new pull request #2603: Revert "Temporalily use published swift3Action. (#2580)" URL: https://github.com/apache/incubator-openwhisk/pull/2603 Build is fine again and binaries are back online. This reverts commit 49ac756064905da0bcba8ed9978a3e29dd8c04dc.

[GitHub] markusthoemmes opened a new pull request #2602: Remove old invoker code and refactor accordingly.

2017-08-11 Thread git
markusthoemmes opened a new pull request #2602: Remove old invoker code and refactor accordingly. URL: https://github.com/apache/incubator-openwhisk/pull/2602 **Note:** This is not to be merged before the 16th of August! - Refactoring the invoker for better encapsulation and seperati

[GitHub] ningyougang commented on issue #2248: Make invoker be scaled-out via ansible. (#2247)

2017-08-11 Thread git
ningyougang commented on issue #2248: Make invoker be scaled-out via ansible. (#2247) URL: https://github.com/apache/incubator-openwhisk/pull/2248#issuecomment-321768125 @markusthoemmes ,the PR in ansible is here: https://github.com/ansible/ansible/pull/22195 ---

[GitHub] ningyougang commented on a change in pull request #2595: Remove defaultLimits and have limits only

2017-08-11 Thread git
ningyougang commented on a change in pull request #2595: Remove defaultLimits and have limits only URL: https://github.com/apache/incubator-openwhisk/pull/2595#discussion_r132641291 ## File path: ansible/README.md ## @@ -282,20 +282,24 @@ the path to your OpenWhisk `ansib

[GitHub] ningyougang commented on a change in pull request #2595: Remove defaultLimits and have limits only

2017-08-11 Thread git
ningyougang commented on a change in pull request #2595: Remove defaultLimits and have limits only URL: https://github.com/apache/incubator-openwhisk/pull/2595#discussion_r132641291 ## File path: ansible/README.md ## @@ -282,20 +282,24 @@ the path to your OpenWhisk `ansib

[GitHub] markusthoemmes commented on issue #2595: Remove defaultLimits and have limits only

2017-08-11 Thread git
markusthoemmes commented on issue #2595: Remove defaultLimits and have limits only URL: https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321751547 @ningyougang This looks super awesome, exactly what I meant! ? -

[GitHub] markusthoemmes commented on a change in pull request #2595: Remove defaultLimits and have limits only

2017-08-11 Thread git
markusthoemmes commented on a change in pull request #2595: Remove defaultLimits and have limits only URL: https://github.com/apache/incubator-openwhisk/pull/2595#discussion_r132631867 ## File path: ansible/README.md ## @@ -282,20 +282,24 @@ the path to your OpenWhisk `an

[GitHub] markusthoemmes commented on issue #2248: Make invoker be scaled-out via ansible. (#2247)

2017-08-11 Thread git
markusthoemmes commented on issue #2248: Make invoker be scaled-out via ansible. (#2247) URL: https://github.com/apache/incubator-openwhisk/pull/2248#issuecomment-321750759 @ningyougang AFAIK there is a PR or at least a design decision about this in ansible somewhere. But it'd definitly b

[GitHub] ningyougang commented on issue #2248: Make invoker be scaled-out via ansible. (#2247)

2017-08-11 Thread git
ningyougang commented on issue #2248: Make invoker be scaled-out via ansible. (#2247) URL: https://github.com/apache/incubator-openwhisk/pull/2248#issuecomment-321744859 @markusthoemmes @style95 , why not use `docker_container` module instead of `shell script: docker run`? i have check

[GitHub] ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all

2017-08-11 Thread git
ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all URL: https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321744073 @markusthoemmes , i have modified again, please review again ^^ ---