[GitHub] cbickel closed pull request #2664: Apply prereqs serially to prevent installation conflicts.

2017-08-23 Thread git
cbickel closed pull request #2664: Apply prereqs serially to prevent installation conflicts. URL: https://github.com/apache/incubator-openwhisk/pull/2664 This is an automated message from the Apache Git Service. To respond

[GitHub] lzbj commented on a change in pull request #366: Support more runtime types from bluemix host info.

2017-08-23 Thread git
lzbj commented on a change in pull request #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#discussion_r134910486 ## File path: tests/src/integration/common/wskdeploy.go ## @@ -47,17 +47,17 @@ f

[GitHub] houshengbo opened a new pull request #384: Fail the travis build as early as possible

2017-08-23 Thread git
houshengbo opened a new pull request #384: Fail the travis build as early as possible URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/384 This is an automated message from the Apache Git Service. To respon

[GitHub] lzbj commented on a change in pull request #262: Adjust the code to reflect latest API gateway version.

2017-08-23 Thread git
lzbj commented on a change in pull request #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#discussion_r134910320 ## File path: tests/src/integration/apigateway/manifest.yml ## @@ -0,0 +1,18

[GitHub] lzbj commented on issue #262: Adjust the code to reflect latest API gateway version.

2017-08-23 Thread git
lzbj commented on issue #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#issuecomment-324508805 Ok, I didn't notice that, but no worry, I think the master branch code needs some updates, as well as the unita

[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment

2017-08-23 Thread git
ningyougang commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518 @markusthoemmes Can we implement a recreate behavior like we have for all our components? answer: if use `rec

[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment

2017-08-23 Thread git
ningyougang commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518 @markusthoemmes Can we implement a recreate behavior like we have for all our components? answer: if use `rec

[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment

2017-08-23 Thread git
ningyougang commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518 @markusthoemmes Can we implement a recreate behavior like we have for all our components? answer: if use `rec

[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment

2017-08-23 Thread git
ningyougang commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518 @markusthoemmes Can we implement a recreate behavior like we have for all our components? answer: if use `rec

[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment

2017-08-23 Thread git
ningyougang commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518 @markusthoemmes Can we implement a recreate behavior like we have for all our components? answer: if use `recreate`

[GitHub] ningyougang commented on issue #2662: Add judge condition for invoker deployment

2017-08-23 Thread git
ningyougang commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324501518 @markusthoemmes Can we implement a recreate behavior like we have for all our components? answer: if use `recreate` fea

[GitHub] csantanapr commented on issue #57: removed the experimental from API Url.

2017-08-23 Thread git
csantanapr commented on issue #57: removed the experimental from API Url. URL: https://github.com/apache/incubator-openwhisk-client-js/pull/57#issuecomment-324500704 This is resolved now by #67 This is an automated message

[GitHub] csantanapr closed pull request #57: removed the experimental from API Url.

2017-08-23 Thread git
csantanapr closed pull request #57: removed the experimental from API Url. URL: https://github.com/apache/incubator-openwhisk-client-js/pull/57 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] csantanapr commented on issue #63: style: add .editorconfig, eslint and reformat js file

2017-08-23 Thread git
csantanapr commented on issue #63: style: add .editorconfig, eslint and reformat js file URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-324500642 Did you already submitted an ICLA to Apache? https://github.com/apache/incubator-openwhisk-client-js/blob/ma

[GitHub] csantanapr closed pull request #65: feat: Support version when create / update action

2017-08-23 Thread git
csantanapr closed pull request #65: feat: Support version when create / update action URL: https://github.com/apache/incubator-openwhisk-client-js/pull/65 This is an automated message from the Apache Git Service. To respond

[GitHub] csantanapr closed issue #52: Deprecate "experimental" API Gateway

2017-08-23 Thread git
csantanapr closed issue #52: Deprecate "experimental" API Gateway URL: https://github.com/apache/incubator-openwhisk-client-js/issues/52 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] csantanapr closed pull request #67: Remove "experimental" API Gateway support.

2017-08-23 Thread git
csantanapr closed pull request #67: Remove "experimental" API Gateway support. URL: https://github.com/apache/incubator-openwhisk-client-js/pull/67 This is an automated message from the Apache Git Service. To respond to the

[GitHub] pritidesai commented on a change in pull request #366: Support more runtime types from bluemix host info.

2017-08-23 Thread git
pritidesai commented on a change in pull request #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#discussion_r134899296 ## File path: tests/src/integration/common/wskdeploy.go ## @@ -47,17 +47,1

[GitHub] pritidesai commented on a change in pull request #375: Make interative mode able to set to false

2017-08-23 Thread git
pritidesai commented on a change in pull request #375: Make interative mode able to set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375#discussion_r134898915 ## File path: deployers/servicedeployer.go ## @@ -119,7 +119,7 @@ func (deployer *S

[GitHub] mrutkows commented on issue #365: Bluemix Stage 1 errors creating triggers

2017-08-23 Thread git
mrutkows commented on issue #365: Bluemix Stage 1 errors creating triggers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/365#issuecomment-324490169 @zachschultz @daisy-ycguo Daisy, did you test this with BlueWhisk or local OpenWhisk? You steps indicate "Have a clean

[GitHub] mrutkows commented on issue #360: Validate integration tests are running as part of Travis build

2017-08-23 Thread git
mrutkows commented on issue #360: Validate integration tests are running as part of Travis build URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/360#issuecomment-324488938 WIP PR: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/372 ---

[GitHub] mrutkows commented on issue #374: Interactive mode should be configurable

2017-08-23 Thread git
mrutkows commented on issue #374: Interactive mode should be configurable URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/374#issuecomment-324488020 fixed in https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375 --

[GitHub] mrutkows closed issue #374: Interactive mode should be configurable

2017-08-23 Thread git
mrutkows closed issue #374: Interactive mode should be configurable URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/374 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] mrutkows closed pull request #379: Remove the explicit api keys to access kafka service

2017-08-23 Thread git
mrutkows closed pull request #379: Remove the explicit api keys to access kafka service URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/379 This is an automated message from the Apache Git Service. To resp

[GitHub] houshengbo closed issue #125: remove step to set namespace from the docs

2017-08-23 Thread git
houshengbo closed issue #125: remove step to set namespace from the docs URL: https://github.com/apache/incubator-openwhisk-package-cloudant/issues/125 This is an automated message from the Apache Git Service. To respond to

[GitHub] houshengbo closed pull request #126: update doc to remove the namespace step for CLI no need it anymore

2017-08-23 Thread git
houshengbo closed pull request #126: update doc to remove the namespace step for CLI no need it anymore URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/126 This is an automated message from the Apac

[GitHub] csantanapr opened a new pull request #126: update doc to remove the namespace set for CLI no need it anymore

2017-08-23 Thread git
csantanapr opened a new pull request #126: update doc to remove the namespace set for CLI no need it anymore URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/126 This is an automated message from the

[GitHub] pritidesai opened a new issue #383: Delete openwhisk credentials from manifest and deployment files

2017-08-23 Thread git
pritidesai opened a new issue #383: Delete openwhisk credentials from manifest and deployment files URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/383 We have few integration tests with manifest and deployment files which have hardcoded credentials including api host a

[GitHub] pritidesai opened a new issue #382: Rename manifest and deployment files under tests/dat/...

2017-08-23 Thread git
pritidesai opened a new issue #382: Rename manifest and deployment files under tests/dat/... URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/382 We have bunch of manifest and deployment files under https://github.com/apache/incubator-openwhisk-wskdeploy/tree/master/test

[GitHub] pritidesai opened a new issue #381: Move manifest.yml and manifest.yaml out of integration test

2017-08-23 Thread git
pritidesai opened a new issue #381: Move manifest.yml and manifest.yaml out of integration test URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/381 Integration tests should not have manifest.yaml and manifest.yml files. Please move them to https://github.com/apache/inc

[GitHub] pritidesai opened a new issue #380: Add unit tests to verify that wskdeploy is able to load credentials

2017-08-23 Thread git
pritidesai opened a new issue #380: Add unit tests to verify that wskdeploy is able to load credentials URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/380 We have a plan to follow precedence order of setting whisk credentials: - API host for the OpenWhisk deploym

[GitHub] csantanapr opened a new issue #125: remove step to set namespace from the docs

2017-08-23 Thread git
csantanapr opened a new issue #125: remove step to set namespace from the docs URL: https://github.com/apache/incubator-openwhisk-package-cloudant/issues/125 Now the feed action takes the namespace from the env variable in the action `process.env.__OW_NAMESPACE` there is no requirement for

[GitHub] houshengbo commented on issue #379: Remove the explicit api keys to access kafka service

2017-08-23 Thread git
houshengbo commented on issue #379: Remove the explicit api keys to access kafka service URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/379#issuecomment-324449176 @daisy-ycguo @lzbj Please be advised that do not put valid keys of other services in the repos. --

[GitHub] houshengbo commented on issue #379: Remove the explicit api keys to access kafka service

2017-08-23 Thread git
houshengbo commented on issue #379: Remove the explicit api keys to access kafka service URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/379#issuecomment-324449176 @daisy-ycguo @lzbj Please be advised that do not put valid keys in the repos.

[GitHub] houshengbo opened a new pull request #379: Remove the explicit api keys to access kafka service

2017-08-23 Thread git
houshengbo opened a new pull request #379: Remove the explicit api keys to access kafka service URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/379 This is an automated message from the Apache Git Service.

[GitHub] zachschultz commented on issue #305: Wondering why triggers are updated with overwrite set to false

2017-08-23 Thread git
zachschultz commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324447025 @mrutkows let me build a wskdeploy with that PR included to test if it works

[GitHub] zachschultz commented on issue #365: Bluemix Stage 1 errors creating triggers

2017-08-23 Thread git
zachschultz commented on issue #365: Bluemix Stage 1 errors creating triggers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/365#issuecomment-32913 @daisy-ycguo thank you! For some reason, now I am able to get the triggers and rules working when I push data to clou

[GitHub] mrutkows commented on issue #305: Wondering why triggers are updated with overwrite set to false

2017-08-23 Thread git
mrutkows commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324429472 @zachschultz can u verify if PR 337 allows this issue to be resolved? --

[GitHub] mrutkows commented on a change in pull request #366: Support more runtime types from bluemix host info.

2017-08-23 Thread git
mrutkows commented on a change in pull request #366: Support more runtime types from bluemix host info. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/366#discussion_r134838424 ## File path: tests/src/integration/common/wskdeploy.go ## @@ -47,17 +47,17

[GitHub] zachschultz commented on issue #305: Wondering why triggers are updated with overwrite set to false

2017-08-23 Thread git
zachschultz commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324426120 Hi @daisy-ycguo, thanks for the PR! What was happening for us was that if we changed our manif

[GitHub] mrutkows closed pull request #375: Make interative mode able to set to false

2017-08-23 Thread git
mrutkows closed pull request #375: Make interative mode able to set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] mrutkows commented on a change in pull request #375: Make interative mode able to set to false

2017-08-23 Thread git
mrutkows commented on a change in pull request #375: Make interative mode able to set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/375#discussion_r134835273 ## File path: deployers/servicedeployer.go ## @@ -119,7 +119,7 @@ func (deployer *Ser

[GitHub] ert78gb commented on issue #65: feat: Support version when create / update action

2017-08-23 Thread git
ert78gb commented on issue #65: feat: Support version when create / update action URL: https://github.com/apache/incubator-openwhisk-client-js/pull/65#issuecomment-324414192 I resolved the conflict pls merge or close my PR-s. --

[GitHub] codecov-io commented on issue #65: feat: Support version when create / update action

2017-08-23 Thread git
codecov-io commented on issue #65: feat: Support version when create / update action URL: https://github.com/apache/incubator-openwhisk-client-js/pull/65#issuecomment-320595097 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/65?src=pr&el=h1) Report > Mergin

[GitHub] dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review)

2017-08-23 Thread git
dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#issuecomment-324409729 @mdeuser, @csantanapr, needs review. This is an automated mess

[GitHub] dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review)

2017-08-23 Thread git
dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#issuecomment-324409648 PG4 720. This is an automated message from the Apache Git Serv

[GitHub] mrutkows closed pull request #377: Allow trigger update when creating triggers

2017-08-23 Thread git
mrutkows closed pull request #377: Allow trigger update when creating triggers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/377 This is an automated message from the Apache Git Service. To respond to the

[GitHub] mrutkows commented on a change in pull request #377: Allow trigger update when creating triggers

2017-08-23 Thread git
mrutkows commented on a change in pull request #377: Allow trigger update when creating triggers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/377#discussion_r134787180 ## File path: deployers/servicedeployer.go ## @@ -412,7 +412,7 @@ func (deployer *S

[GitHub] tysonnorris commented on issue #2663: Simplify Spi implementations.

2017-08-23 Thread git
tysonnorris commented on issue #2663: Simplify Spi implementations. URL: https://github.com/apache/incubator-openwhisk/pull/2663#issuecomment-324369051 Looks good - Thanks This is an automated message from the Apache Git Ser

[GitHub] mrutkows commented on issue #378: Overwrite (true) should be a configurable option

2017-08-23 Thread git
mrutkows commented on issue #378: Overwrite (true) should be a configurable option URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/378#issuecomment-324359459 At the time of this issue being opened here are all the places we hardcoded the default: Matt$ grep -r "

[GitHub] mrutkows opened a new issue #378: Overwrite (true) should be a configurable option

2017-08-23 Thread git
mrutkows opened a new issue #378: Overwrite (true) should be a configurable option URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/378 Perhaps "overwrite=true" should be our default behavior, but we should give user a command line option to turn this off for all entitie

[GitHub] dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review)

2017-08-23 Thread git
dubeejw commented on issue #2544: Allow CLI to Save Code from Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2544#issuecomment-323453201 TODO: - ~~Handle `sequence` as kind~~ This is an automa

[GitHub] mrutkows commented on issue #262: Adjust the code to reflect latest API gateway version.

2017-08-23 Thread git
mrutkows commented on issue #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#issuecomment-324355802 @lzbj Build error in Travis... ``` $ make build Installing dependencies go get -d -t ./... T

[GitHub] mrutkows commented on issue #262: Adjust the code to reflect latest API gateway version.

2017-08-23 Thread git
mrutkows commented on issue #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#issuecomment-324355802 @lzbj Build error... ``` $ make build Installing dependencies go get -d -t ./... Testing

[GitHub] dubeejw commented on a change in pull request #2591: User-Agent CLI/version header

2017-08-23 Thread git
dubeejw commented on a change in pull request #2591: User-Agent CLI/version header URL: https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r134762726 ## File path: tools/cli/go-whisk/whisk/client.go ## @@ -47,6 +47,7 @@ const ( DoNotProcessTimeOut = f

[GitHub] markusthoemmes closed pull request #2592: Make the result of response consistent for both Wsk CLI and REST

2017-08-23 Thread git
markusthoemmes closed pull request #2592: Make the result of response consistent for both Wsk CLI and REST URL: https://github.com/apache/incubator-openwhisk/pull/2592 This is an automated message from the Apache Git Servic

[GitHub] markusthoemmes opened a new pull request #2664: Apply prereqs serially to prevent installation conflicts.

2017-08-23 Thread git
markusthoemmes opened a new pull request #2664: Apply prereqs serially to prevent installation conflicts. URL: https://github.com/apache/incubator-openwhisk/pull/2664 Using the same host for different "machines" seems to cause trouble when trying to concurrently install packages. ---

[GitHub] markusthoemmes commented on a change in pull request #2661: Add tests to check ha of controller

2017-08-23 Thread git
markusthoemmes commented on a change in pull request #2661: Add tests to check ha of controller URL: https://github.com/apache/incubator-openwhisk/pull/2661#discussion_r134739982 ## File path: tests/src/test/scala/ha/ShootComponentsTests.scala ## @@ -0,0 +1,158 @@ +/* + *

[GitHub] markusthoemmes commented on issue #2663: Simplify Spi implementations.

2017-08-23 Thread git
markusthoemmes commented on issue #2663: Simplify Spi implementations. URL: https://github.com/apache/incubator-openwhisk/pull/2663#issuecomment-324314498 @tysonnorris would you do me the honors? This is an automated message

[GitHub] markusthoemmes opened a new pull request #2663: Simplify Spi implementations.

2017-08-23 Thread git
markusthoemmes opened a new pull request #2663: Simplify Spi implementations. URL: https://github.com/apache/incubator-openwhisk/pull/2663 Using `object`s instead of a hollow class as the "factory" for an Spi makes them being singleton by default, which reduces boilerplate to implement an S

[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134729543 ## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala #

[GitHub] rabbah commented on a change in pull request #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
rabbah commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134728525 ## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala ## @@ -2

[GitHub] rabbah commented on a change in pull request #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
rabbah commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134729025 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala ## @@ -205,12

[GitHub] markusthoemmes commented on issue #2662: Add judge condition for invoker deployment

2017-08-23 Thread git
markusthoemmes commented on issue #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662#issuecomment-324305304 Can we implement a recreate behavior like we have for all our components? We should somehow use ansible's capabilities to

[GitHub] markusthoemmes closed pull request #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
markusthoemmes closed pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632 This is an automated message from the Apache Git Service. To respond to t

[GitHub] cbickel commented on issue #2624: Add cache invalidation between controllers

2017-08-23 Thread git
cbickel commented on issue #2624: Add cache invalidation between controllers URL: https://github.com/apache/incubator-openwhisk/pull/2624#issuecomment-323926734 PG3#1026 is ? PG4#717 is ? (23.08.2017) This is an automat

[GitHub] cbickel commented on issue #2624: Add cache invalidation between controllers

2017-08-23 Thread git
cbickel commented on issue #2624: Add cache invalidation between controllers URL: https://github.com/apache/incubator-openwhisk/pull/2624#issuecomment-323926734 PG3#1026 is ? PG4#717 is ? This is an automated message fr

[GitHub] cbickel commented on issue #2661: Add tests to check ha of controller

2017-08-23 Thread git
cbickel commented on issue #2661: Add tests to check ha of controller URL: https://github.com/apache/incubator-openwhisk/pull/2661#issuecomment-324302436 PG3#1031 is ? This is an automated message from the Apache Git Servic

[GitHub] ningyougang opened a new pull request #2662: Add judge condition for invoker deployment

2017-08-23 Thread git
ningyougang opened a new pull request #2662: Add judge condition for invoker deployment URL: https://github.com/apache/incubator-openwhisk/pull/2662 If invokers have been deployed success. Then, it will report error when execute `ansible-playbook -i environments/ invoker.yml ` again.

[GitHub] lzbj commented on issue #262: Adjust the code to reflect latest API gateway version.

2017-08-23 Thread git
lzbj commented on issue #262: Adjust the code to reflect latest API gateway version. URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/262#issuecomment-324281667 @mrutkows , yes, rebased. This is an automate

[GitHub] markusthoemmes commented on issue #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
markusthoemmes commented on issue #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#issuecomment-324264729 A few nits. Travis will suffice for the fixes. Very well done ? ---

[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134692402 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala ## @@

[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134692362 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala ## @@

[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134692316 ## File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala ## @@

[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134692157 ## File path: common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala #

[GitHub] markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations

2017-08-23 Thread git
markusthoemmes commented on a change in pull request #2632: Use the stale parameter on listing activations URL: https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134691857 ## File path: common/scala/src/main/scala/whisk/core/database/CouchDbRestClient.scala

[GitHub] cbickel opened a new pull request #2661: Add tests to check ha of controller

2017-08-23 Thread git
cbickel opened a new pull request #2661: Add tests to check ha of controller URL: https://github.com/apache/incubator-openwhisk/pull/2661 Add a test, that checks, that the hot standby controller is used as expected. This is a

[GitHub] daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false

2017-08-23 Thread git
daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324245683 @zachschultz There is a PR #377 to address this issue. But I'm very curious to your case. I th

[GitHub] daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false

2017-08-23 Thread git
daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324245683 @zachschultz There is a PR #377 to address this issue. But I'm very curious to your case. I th

[GitHub] daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false

2017-08-23 Thread git
daisy-ycguo commented on issue #305: Wondering why triggers are updated with overwrite set to false URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/305#issuecomment-324245683 @zachschultz There is a PR #377 to address this issue. But I'm very curious to your case. What

[GitHub] daisy-ycguo opened a new pull request #377: Allow trigger update when creating triggers

2017-08-23 Thread git
daisy-ycguo opened a new pull request #377: Allow trigger update when creating triggers URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/377 When creating a feed trigger, set 'overwrite=true' Address issue #305 -