[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145871321 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145871321 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145871321 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338101376 Scenario two and three are just to keep in sync with the same type functionality that currently works

[GitHub] dubeejw closed pull request #2772: Fix issue with trailing spaces and handle comments in the property file.

2017-10-19 Thread GitBox
dubeejw closed pull request #2772: Fix issue with trailing spaces and handle comments in the property file. URL: https://github.com/apache/incubator-openwhisk/pull/2772 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] dubeejw closed issue #2770: cli does not tolerate comment on api host in property file

2017-10-19 Thread GitBox
dubeejw closed issue #2770: cli does not tolerate comment on api host in property file URL: https://github.com/apache/incubator-openwhisk/issues/2770 This is an automated message from the Apache Git Service. To respond to

[GitHub] dubeejw commented on issue #2847: Treat action code as attachments for created/updated actions

2017-10-19 Thread GitBox
dubeejw commented on issue #2847: Treat action code as attachments for created/updated actions URL: https://github.com/apache/incubator-openwhisk/pull/2847#issuecomment-337048815 Can expand tests from https://github.com/apache/incubator-openwhisk/pull/2855 after that one is merged.

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145873432 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] csantanapr commented on issue #2076: Update NodeJS 6 to latest 6.11.x LTS

2017-10-19 Thread GitBox
csantanapr commented on issue #2076: Update NodeJS 6 to latest 6.11.x LTS URL: https://github.com/apache/incubator-openwhisk/issues/2076#issuecomment-338098140 Will go for 6.11.4 new runtime image being updated here https://github.com/apache/incubator-openwhisk-runtime-nodejs

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145872257 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] starpit opened a new issue #79: No tests to cover error handling?

2017-10-19 Thread GitBox
starpit opened a new issue #79: No tests to cover error handling? URL: https://github.com/apache/incubator-openwhisk-client-js/issues/79 Is it possible that the current test suite has no coverage of error handling? Because 1) earlier versions of PR #78 didn't do proper error

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145868688 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145868611 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145871321 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] style95 commented on issue #2810: Add couchdb clustering

2017-10-19 Thread GitBox
style95 commented on issue #2810: Add couchdb clustering URL: https://github.com/apache/incubator-openwhisk/pull/2810#issuecomment-338092856 @rabbah Let me explain the issues here. In this pr, `apache/couchdb` is being used. That image does not support environment variables for

[GitHub] style95 commented on issue #2810: Add couchdb clustering

2017-10-19 Thread GitBox
style95 commented on issue #2810: Add couchdb clustering URL: https://github.com/apache/incubator-openwhisk/pull/2810#issuecomment-338092856 @rabbah Let me explain the issues here. In this pr, `apache/couchdb` is being used. That image does not support environment variables for

[GitHub] style95 commented on issue #2810: Add couchdb clustering

2017-10-19 Thread GitBox
style95 commented on issue #2810: Add couchdb clustering URL: https://github.com/apache/incubator-openwhisk/pull/2810#issuecomment-338092856 @rabbah Let me explain the issues here. In this pr, `apache/couchdb` is being used. That image does not support environment variables for

[GitHub] style95 commented on issue #2810: Add couchdb clustering

2017-10-19 Thread GitBox
style95 commented on issue #2810: Add couchdb clustering URL: https://github.com/apache/incubator-openwhisk/pull/2810#issuecomment-338092856 @rabbah Let me explain the issues here. In this pr, `apache/couchdb` is being used. That image does not support environment variables for

[GitHub] style95 commented on issue #2810: Add couchdb clustering

2017-10-19 Thread GitBox
style95 commented on issue #2810: Add couchdb clustering URL: https://github.com/apache/incubator-openwhisk/pull/2810#issuecomment-338092856 @rabbah Let me explain the issues here. In this pr, `apache/couchdb` is being used. That image does not support environment variables for

[GitHub] dubeejw closed pull request #1: update nodejs:6 runtime to 6.11.4

2017-10-19 Thread GitBox
dubeejw closed pull request #1: update nodejs:6 runtime to 6.11.4 URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] dubeejw commented on a change in pull request #1: update nodejs:6 runtime to 6.11.4

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #1: update nodejs:6 runtime to 6.11.4 URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/1#discussion_r145868930 ## File path: core/nodejs6Action/CHANGELOG.md ## @@ -2,6 +2,10 @@ +## 1.1.0 Review

[GitHub] starpit opened a new pull request #78: switch from request-promise to needle

2017-10-19 Thread GitBox
starpit opened a new pull request #78: switch from request-promise to needle URL: https://github.com/apache/incubator-openwhisk-client-js/pull/78 Switch from request-promise to needle, for an initialization performance boost. Fixes #77

[GitHub] starpit opened a new issue #77: consider switching from request-promise to needle

2017-10-19 Thread GitBox
starpit opened a new issue #77: consider switching from request-promise to needle URL: https://github.com/apache/incubator-openwhisk-client-js/issues/77 request-promise depends on request, which is very slow to load: https://github.com/request/request/issues/2261 that issue aligns

[GitHub] alexkli commented on issue #2848: Support reading param.json from stdin #2837

2017-10-19 Thread GitBox
alexkli commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-338078617 @dubeejw @rabbah Thanks for the help. Once I got the tests running and the project in IntelliJ with Scala support, it was

[GitHub] csantanapr opened a new pull request #1: update nodejs:6 runtime to 6.11.4

2017-10-19 Thread GitBox
csantanapr opened a new pull request #1: update nodejs:6 runtime to 6.11.4 URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/1 This will allow to push a new image to dockerhub with nodejs 6.11.4 This is

[GitHub] rabbah commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
rabbah commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338034773 > I can see the value in the 1st use case. Maybe the scope should be limited to this? yeah

[GitHub] rabbah commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
rabbah commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338034773 > I can see the value in the 1st use case. Maybe the scope should be limited to this? yeah

[GitHub] rabbah commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
rabbah commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338034773 > I can see the value in the 1st use case. Maybe the scope should be limited to this? yeah

[GitHub] meyumeapps commented on issue #89: Provide once trigger

2017-10-19 Thread GitBox
meyumeapps commented on issue #89: Provide once trigger URL: https://github.com/apache/incubator-openwhisk-package-alarms/issues/89#issuecomment-338034178 ? this would be a very useful feature for me as currently I'm having to run clean up jobs looking for stale triggers and rules.

[GitHub] drcariel commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
drcariel commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338032843 I can see the value in the 1st use case. Maybe the scope should be limited to this? 2 is where

[GitHub] drcariel commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
drcariel commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338032843 I can see the value in the 1st use case. Maybe the scope should be limited to this? 2 is where

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338025783 To be more clear, here are some more examples. Say the user wants to create an action that has the

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338025783 To be more clear, here are some more examples. Say the user wants to create an action that has the

[GitHub] rabbah commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
rabbah commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338025830 I get that it's client only - I'm just not sure I like the automatic inference here. Note that the CLI

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338025783 To be more clear, here are some more examples. Say the user wants to create an action that has the

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338015208 No API changes here. This is a usability issue to allow the user to type less information when

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338015208 No API changes here. This is a usability issue to allow the user to type less information when

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338015208 No API changes here. This is a usability issue to allow the user to type less information when

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338015208 No API changes here. This is a usability issue to allow the user to type less information. The CLI will

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145802353 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145801536 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145801509 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145801486 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] rabbah commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
rabbah commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338011390 Less magic FTW and clarity. What's the point of saving the user from `.js` or `.py` it's not that many

[GitHub] rabbah commented on a change in pull request #2848: Support reading param.json from stdin #2837

2017-10-19 Thread GitBox
rabbah commented on a change in pull request #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#discussion_r145799109 ## File path: docs/actions.md ## @@ -202,6 +202,39 @@ Parameters can be passed to the action

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145798900 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145798662 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145797867 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145796086 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file.

2017-10-19 Thread GitBox
dubeejw commented on issue #2772: Fix issue with trailing spaces and handle comments in the property file. URL: https://github.com/apache/incubator-openwhisk/pull/2772#issuecomment-337956951 PG2 2109 ? This is an automated

[GitHub] drcariel commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
drcariel commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-338005115 I agree with @mrutkows , I think it's important to inform the user that these assumptions are being

[GitHub] mrutkows commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
mrutkows commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-338001346 @houshengbo yes, Daisy's work (and work previous) should allow replacement easily enough (that is why I

[GitHub] mrutkows commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
mrutkows commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337998797 @beemarie it could be implemented as a new feature easily with exiting code; however, we are moving away

[GitHub] mrutkows commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
mrutkows commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337998797 @beemarie it could be implemented as a new feature easily with exiting code; however, we are moving away

[GitHub] houshengbo commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
houshengbo commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-338000349 Daisy implemented the support for cloudant. I think we can directly port the code to use.

[GitHub] mrutkows commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
mrutkows commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-33768 @houshengbo as part of this feature I would like to add name validation using the regex. for valid OW

[GitHub] mrutkows commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
mrutkows commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337999702 @houshengbo also be aware that we allow "partial" replacement as well... e.g. ``` packages:

[GitHub] alexkli commented on issue #2848: Support reading param.json from stdin #2837

2017-10-19 Thread GitBox
alexkli commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-337999506 `wskdev setup props` fails similar to `tools/build/redo props`, as they seem to run the same and expect a running local ansible

[GitHub] mrutkows commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
mrutkows commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337998797 @beemarie it could be implemented as a new feature easily with exiting code; however, we are moving away

[GitHub] mrutkows commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
mrutkows commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337998797 @beemarie it could be implemented as a new feature easily with exiting code; however, we are moving away

[GitHub] mrutkows commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
mrutkows commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337998797 it could be implemented as a new feature easily with exiting code; however, we are moving away from

[GitHub] beemarie commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
beemarie commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337998070 @houshengbo @csantanapr It is more important to be able to provide PACKAGE_NAME as an env-variable

[GitHub] mrutkows commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
mrutkows commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-337996805 IMO, the CLI should be careful in not inferring too much from too little in CRUD operations... and if

[GitHub] mrutkows commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
mrutkows commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-337996805 IMO, the CLI should be careful in not inferring too much from too little in CRUD operations... and if

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145784718 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] houshengbo commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
houshengbo commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337995219 @beemarie @csantanapr We are deprecating the format in the previous comment. Here is the new format

[GitHub] houshengbo commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
houshengbo commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337995219 @beemarie @csantanapr We are deprecating the format in the previous comment. Here is the new format

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145734540 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-337964990 Scenario 2 and 3 are essentially the same. If a kind is not specified, we try to figure out the kind by

[GitHub] dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
dubeejw commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-337964990 Scenario 2 and 3 are essentially the same. If a kind is not specified, we try to figure out the kind by

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145753549 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145752489 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] csantanapr commented on issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
csantanapr commented on issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610#issuecomment-337960565 @mrutkows @houshengbo @daisy-ycguo The sample is the following, we want to be able to have a manifest

[GitHub] dubeejw commented on a change in pull request #2848: Support reading param.json from stdin #2837

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#discussion_r145748713 ## File path: tools/cli/go-whisk-cli/commands/action.go ## @@ -1060,11 +1060,11 @@ func

[GitHub] rabbah commented on issue #2848: Support reading param.json from stdin #2837

2017-10-19 Thread GitBox
rabbah commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-337955069 Try: wskdev setup props If you have not run ansible before the hosts file may not exist and the error suggests this (i guess

[GitHub] rabbah commented on issue #2848: Support reading param.json from stdin #2837

2017-10-19 Thread GitBox
rabbah commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-337955069 Try wskdev setup props If you have not run ansible before the hosts file may not exist and the error suggests this (i guess

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145745207 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145745172 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] dubeejw commented on issue #2848: Support reading param.json from stdin #2837

2017-10-19 Thread GitBox
dubeejw commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-337954262 @alexkli, I'm not familiar with the devtools project. Perhaps @rabbah has some suggestions.

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145745292 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] dubeejw commented on issue #2848: Support reading param.json from stdin #2837

2017-10-19 Thread GitBox
dubeejw commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-337949635 @alexkli, check here for positive `-P` tests.

[GitHub] drcariel commented on issue #2869: CLI should use filename as action name when one is not provided

2017-10-19 Thread GitBox
drcariel commented on issue #2869: CLI should use filename as action name when one is not provided URL: https://github.com/apache/incubator-openwhisk/issues/2869#issuecomment-337950112 in scenario 2, the CLI would need to complete the file extension based on the kind flag in order to

[GitHub] dubeejw commented on issue #2848: Support reading param.json from stdin #2837

2017-10-19 Thread GitBox
dubeejw commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-337949635 @akrabat, check here for positive `-P` tests.

[GitHub] beemarie opened a new issue #610: Provide support for an env_variable for package name

2017-10-19 Thread GitBox
beemarie opened a new issue #610: Provide support for an env_variable for package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/610 Currently in the deploy package, if we want to provide a different package name, we are parsing the file & renaming the package

[GitHub] rabbah commented on issue #1362: Support private repository from docker / bluemix

2017-10-19 Thread GitBox
rabbah commented on issue #1362: Support private repository from docker / bluemix URL: https://github.com/apache/incubator-openwhisk/issues/1362#issuecomment-337943114 One way to support this is by pulling images from the private registry to a whisk managed registry at action create

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145736423 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145735023 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] rabbah commented on issue #1362: Support private repository from docker / bluemix

2017-10-19 Thread GitBox
rabbah commented on issue #1362: Support private repository from docker / bluemix URL: https://github.com/apache/incubator-openwhisk/issues/1362#issuecomment-337943114 One way to support this is by pulling images from the private registry to a whisk managed registry at action create

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145734540 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
houshengbo commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145734281 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@

[GitHub] csantanapr closed pull request #100: increase test case wait time on trigger creation and deletion

2017-10-19 Thread GitBox
csantanapr closed pull request #100: increase test case wait time on trigger creation and deletion URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/100 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] dubeejw commented on issue #2877: Better error controller message for authorization failure

2017-10-19 Thread GitBox
dubeejw commented on issue #2877: Better error controller message for authorization failure URL: https://github.com/apache/incubator-openwhisk/pull/2877#issuecomment-337938777 @mdeuser, you need to run `./gradlew scalafmtAll` from OpenWhisk root directory then commit the changes in order

[GitHub] dubeejw commented on issue #2877: Better error controller message for authorization failure

2017-10-19 Thread GitBox
dubeejw commented on issue #2877: Better error controller message for authorization failure URL: https://github.com/apache/incubator-openwhisk/pull/2877#issuecomment-337938777 @mdeuser, you need to run `gradle scalafmtAll` from OpenWhisk root directory then commit the changes in order to

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145723997 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145724353 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145723107 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145721451 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145723872 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases

2017-10-19 Thread GitBox
dubeejw commented on a change in pull request #2589: Add the fundamental framework of REST invocation for test cases URL: https://github.com/apache/incubator-openwhisk/pull/2589#discussion_r145723997 ## File path: tests/src/test/scala/common/rest/WskRest.scala ## @@ -0,0

[GitHub] mdeuser commented on issue #2877: Better error controller message for authorization failure

2017-10-19 Thread GitBox
mdeuser commented on issue #2877: Better error controller message for authorization failure URL: https://github.com/apache/incubator-openwhisk/pull/2877#issuecomment-337931265 pg2/2187 This is an automated message from the

  1   2   >