[GitHub] daisy-ycguo commented on issue #3: Use Apache Tentacles to create a LICENSE and NOTICE report

2018-01-25 Thread GitBox
daisy-ycguo commented on issue #3: Use Apache Tentacles to create a LICENSE and NOTICE report URL: https://github.com/apache/incubator-openwhisk-release/issues/3#issuecomment-360705090 @houshengbo The tool can be executed locally but the staging repo must be online and cannot be a local r

[GitHub] daisy-ycguo commented on issue #3: Use Apache Tentacles to create a LICENSE and NOTICE report

2018-01-25 Thread GitBox
daisy-ycguo commented on issue #3: Use Apache Tentacles to create a LICENSE and NOTICE report URL: https://github.com/apache/incubator-openwhisk-release/issues/3#issuecomment-360705090 @houshengbo The tool can be executed locally but the staging repo must be online and cannot be a local r

[GitHub] tysonnorris commented on issue #92: Env update 1 25 2018

2018-01-25 Thread GitBox
tysonnorris commented on issue #92: Env update 1 25 2018 URL: https://github.com/apache/incubator-openwhisk-devtools/pull/92#issuecomment-360694209 @mcdan not sure how to add you as a reviewer, but... could you take a look at this and see if it works for you? You may need to pull latest OW

[GitHub] tysonnorris opened a new pull request #92: Env update 1 25 2018

2018-01-25 Thread GitBox
tysonnorris opened a new pull request #92: Env update 1 25 2018 URL: https://github.com/apache/incubator-openwhisk-devtools/pull/92 updating env vars to match latest OW code skip cli download when PROJECT_HOME is defined use init.sh for cmd to start containers use latest db schema

[GitHub] tysonnorris closed pull request #90: use init.sh script to start containers + update env vars

2018-01-25 Thread GitBox
tysonnorris closed pull request #90: use init.sh script to start containers + update env vars URL: https://github.com/apache/incubator-openwhisk-devtools/pull/90 This is an automated message from the Apache Git Service. To r

[GitHub] rabbah commented on issue #3220: Move log message into a closure to defer string interpolation.

2018-01-25 Thread GitBox
rabbah commented on issue #3220: Move log message into a closure to defer string interpolation. URL: https://github.com/apache/incubator-openwhisk/pull/3220#issuecomment-360668512 @starpit if you load test this, can you give it a ? or ?, ?.

[GitHub] rabbah commented on issue #3220: Move log message into a closure to defer string interpolation.

2018-01-25 Thread GitBox
rabbah commented on issue #3220: Move log message into a closure to defer string interpolation. URL: https://github.com/apache/incubator-openwhisk/pull/3220#issuecomment-360667811 Made a few more tweaks. This is an automated

[GitHub] shazron opened a new pull request #22: Added local installation documentation link to openwhisk-devtools/docker-compose docs

2018-01-25 Thread GitBox
shazron opened a new pull request #22: Added local installation documentation link to openwhisk-devtools/docker-compose docs URL: https://github.com/apache/incubator-openwhisk-workshop/pull/22 Depends on https://github.com/apache/incubator-openwhisk-devtools/pull/91 ---

[GitHub] shazron opened a new pull request #91: Add documentation for adding the OpenWhisk catalog

2018-01-25 Thread GitBox
shazron opened a new pull request #91: Add documentation for adding the OpenWhisk catalog URL: https://github.com/apache/incubator-openwhisk-devtools/pull/91 This is an automated message from the Apache Git Service. To respo

[GitHub] dubeejw commented on issue #3206: Refactor controller role to use variables for hostname and host index

2018-01-25 Thread GitBox
dubeejw commented on issue #3206: Refactor controller role to use variables for hostname and host index URL: https://github.com/apache/incubator-openwhisk/pull/3206#issuecomment-360630101 @cbickel, can you look at this one when you have a chance? It's just refactoring the controller deplo

[GitHub] pritidesai commented on issue #686: Delete APIs on undeploy

2018-01-25 Thread GitBox
pritidesai commented on issue #686: Delete APIs on undeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/686#issuecomment-360621587 working on it ... This is an automated message from the Apache Git Ser

[GitHub] tysonnorris opened a new pull request #90: use init.sh script to start containers + update env vars

2018-01-25 Thread GitBox
tysonnorris opened a new pull request #90: use init.sh script to start containers + update env vars URL: https://github.com/apache/incubator-openwhisk-devtools/pull/90 This is an automated message from the Apache Git Service

[GitHub] pritidesai opened a new issue #697: Add error reporting back - integration test

2018-01-25 Thread GitBox
pritidesai opened a new issue #697: Add error reporting back - integration test URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/697 I am trying to run integration test locally with `go test -v ./... -tags integration` which just failed with random error without any expli

[GitHub] lionelvillard commented on issue #681: proper handling of 'default' package name

2018-01-25 Thread GitBox
lionelvillard commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-360603379 what about allowing `actions` (and `rules` and `triggers`) to be specified at the top-level? ``` package

[GitHub] markusthoemmes commented on issue #3220: Move log message into a closure to defer string interpolation.

2018-01-25 Thread GitBox
markusthoemmes commented on issue #3220: Move log message into a closure to defer string interpolation. URL: https://github.com/apache/incubator-openwhisk/pull/3220#issuecomment-360600614 Easier as I thought it will be. For those curious if this really defers even the interpolation:

[GitHub] mrutkows commented on issue #681: proper handling of 'default' package name

2018-01-25 Thread GitBox
mrutkows commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-360598204 @lionelvillard thoughts? ^^^ This is an automated mess

[GitHub] mrutkows commented on issue #681: proper handling of 'default' package name

2018-01-25 Thread GitBox
mrutkows commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-360598140 Hmmm... I am not sure if I like that a tool-decided behavior as to where to relocate (under namespace directly) and it

[GitHub] mrutkows commented on issue #681: proper handling of 'default' package name

2018-01-25 Thread GitBox
mrutkows commented on issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681#issuecomment-360598140 @pritidesai Hmmm... I am not sure if I like that a tool-decided behavior as to where to relocate (under namespace dire

[GitHub] mrutkows commented on issue #686: Delete APIs on undeploy

2018-01-25 Thread GitBox
mrutkows commented on issue #686: Delete APIs on undeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/686#issuecomment-360582660 Well this should clearly be critical/top priority. This is an automated

[GitHub] houshengbo commented on issue #210: Removal of whisk.properties in OpenWhisk leading to errors in gradle build

2018-01-25 Thread GitBox
houshengbo commented on issue #210: Removal of whisk.properties in OpenWhisk leading to errors in gradle build URL: https://github.com/apache/incubator-openwhisk-cli/issues/210#issuecomment-360571169 I guess it is my problem with my local env. -

[GitHub] houshengbo closed issue #210: Removal of whisk.properties in OpenWhisk leading to errors in gradle build

2018-01-25 Thread GitBox
houshengbo closed issue #210: Removal of whisk.properties in OpenWhisk leading to errors in gradle build URL: https://github.com/apache/incubator-openwhisk-cli/issues/210 This is an automated message from the Apache Git Serv

[GitHub] mrutkows commented on issue #673: Enforce and document command line flag strict

2018-01-25 Thread GitBox
mrutkows commented on issue #673: Enforce and document command line flag strict URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/673#issuecomment-360569953 In fact, building on above, the entire "strict" path should be rated "high priority" relative to other features/enh

[GitHub] mrutkows commented on issue #673: Enforce and document command line flag strict

2018-01-25 Thread GitBox
mrutkows commented on issue #673: Enforce and document command line flag strict URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/673#issuecomment-360569750 @pritidesai Good question. This is really a convenience/tooling decision (and we have the -strict flag); this shou

[GitHub] houshengbo commented on a change in pull request #3216: Download Nginx Tarball from OpenWhisk CLI release, rather than constructing file-by-file

2018-01-25 Thread GitBox
houshengbo commented on a change in pull request #3216: Download Nginx Tarball from OpenWhisk CLI release, rather than constructing file-by-file URL: https://github.com/apache/incubator-openwhisk/pull/3216#discussion_r163934054 ## File path: ansible/roles/cli/tasks/deploy.yml

[GitHub] rabbah opened a new pull request #3220: Move log message into a closure to defer string interpolation.

2018-01-25 Thread GitBox
rabbah opened a new pull request #3220: Move log message into a closure to defer string interpolation. URL: https://github.com/apache/incubator-openwhisk/pull/3220 This is an automated message from the Apache Git Service. To

[GitHub] houshengbo opened a new issue #210: Removal of whisk.properties in OpenWhisk leading to errors in gradle build

2018-01-25 Thread GitBox
houshengbo opened a new issue #210: Removal of whisk.properties in OpenWhisk leading to errors in gradle build URL: https://github.com/apache/incubator-openwhisk-cli/issues/210 Running ./gradlew build leads to the following error: ``` * Where: Build file '/Users/vincent/workspace/o

[GitHub] jthomas opened a new issue #4: Publish OpenWhisk Swift handler library as package

2018-01-25 Thread GitBox
jthomas opened a new issue #4: Publish OpenWhisk Swift handler library as package URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/4 The current Swift files for [implementing the OpenWhisk handler](https://github.com/apache/incubator-openwhisk-runtime-swift/tree/mas

[GitHub] jthomas commented on issue #83: Add support for installing optional packages.

2018-01-25 Thread GitBox
jthomas commented on issue #83: Add support for installing optional packages. URL: https://github.com/apache/incubator-openwhisk-devtools/pull/83#issuecomment-360553222 @ddragosd done. This is an automated message from the Ap

[GitHub] jthomas commented on issue #4: Publish OpenWhisk Swift handler library as package

2018-01-25 Thread GitBox
jthomas commented on issue #4: Publish OpenWhisk Swift handler library as package URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/4#issuecomment-360545497 Can this be re-opened? It hasn't been fixed by #1. @paulcastro -

[GitHub] mcdan opened a new pull request #89: Fixes #88 - Add pull target which will work after destroy

2018-01-25 Thread GitBox
mcdan opened a new pull request #89: Fixes #88 - Add pull target which will work after destroy URL: https://github.com/apache/incubator-openwhisk-devtools/pull/89 This is an automated message from the Apache Git Service. To

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

2018-01-25 Thread GitBox
tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r163904568 ## File path: ansible/roles/invoker/tasks/deploy.yml ## @@ -173,8 +173,8 @@

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

2018-01-25 Thread GitBox
tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r163902561 ## File path: ansible/roles/invoker/tasks/deploy.yml ## @@ -173,8 +173,8 @@

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163900669 ## File path: docs/mesos.md ## @@ -0,0 +1,47 @@ +# Mesos Support + +The MesosContainerFactory enables launching acti

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163900347 ## File path: docs/mesos.md ## @@ -0,0 +1,47 @@ +# Mesos Support + +The MesosContainerFactory enables launching acti

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163900347 ## File path: docs/mesos.md ## @@ -0,0 +1,47 @@ +# Mesos Support + +The MesosContainerFactory enables launching acti

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163900014 ## File path: docs/mesos.md ## @@ -0,0 +1,47 @@ +# Mesos Support + +The MesosContainerFactory enables launching acti

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163900014 ## File path: docs/mesos.md ## @@ -0,0 +1,47 @@ +# Mesos Support + +The MesosContainerFactory enables launching acti

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163900014 ## File path: docs/mesos.md ## @@ -0,0 +1,47 @@ +# Mesos Support + +The MesosContainerFactory enables launching acti

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163899820 ## File path: common/scala/src/main/scala/whisk/core/mesos/MesosTask.scala ## @@ -0,0 +1,178 @@ +/* + * Licensed to

[GitHub] mcdan opened a new issue #88: [Feature] Create a "pull" target to let someone update their containers from upstream

2018-01-25 Thread GitBox
mcdan opened a new issue #88: [Feature] Create a "pull" target to let someone update their containers from upstream URL: https://github.com/apache/incubator-openwhisk-devtools/issues/88 Even when using :latest in a container tag, compose does not automatically pull new versions. You must u

[GitHub] mcdan commented on issue #73: Couchdb doesn't get initialized

2018-01-25 Thread GitBox
mcdan commented on issue #73: Couchdb doesn't get initialized URL: https://github.com/apache/incubator-openwhisk-devtools/issues/73#issuecomment-360524707 This was fixed in #74 This is an automated message from the Apache Gi

[GitHub] mcdan closed issue #73: Couchdb doesn't get initialized

2018-01-25 Thread GitBox
mcdan closed issue #73: Couchdb doesn't get initialized URL: https://github.com/apache/incubator-openwhisk-devtools/issues/73 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163898003 ## File path: common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala ## @@ -0,0 +1,163 @@ +/* + *

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163897717 ## File path: common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala ## @@ -0,0 +1,163 @@ +/* + *

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163896973 ## File path: common/scala/src/main/scala/whisk/core/mesos/MesosContainerFactory.scala ## @@ -0,0 +1,163 @@ +/* + *

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163895138 ## File path: common/scala/src/main/resources/application.conf ## @@ -12,3 +12,7 @@ akka.http { max-open-re

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163895717 ## File path: common/scala/build.gradle ## @@ -40,6 +40,8 @@ dependencies { compile 'com.google.code.findbugs:j

[GitHub] rabbah commented on a change in pull request #2833: MesosContainerFactory

2018-01-25 Thread GitBox
rabbah commented on a change in pull request #2833: MesosContainerFactory URL: https://github.com/apache/incubator-openwhisk/pull/2833#discussion_r163895138 ## File path: common/scala/src/main/resources/application.conf ## @@ -12,3 +12,7 @@ akka.http { max-open-re

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

2018-01-25 Thread GitBox
tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r163894165 ## File path: ansible/roles/invoker/tasks/deploy.yml ## @@ -173,8 +173,8 @@

[GitHub] houshengbo commented on issue #11: Create the project structure to release based on versions

2018-01-25 Thread GitBox
houshengbo commented on issue #11: Create the project structure to release based on versions URL: https://github.com/apache/incubator-openwhisk-release/issues/11#issuecomment-360515966 @chetanmeh Thank you. It is very neat to have Maven plugin supported by OpenWhisk core, and any other Op

[GitHub] houshengbo commented on issue #3: Use Apache Tentacles to create a LICENSE and NOTICE report

2018-01-25 Thread GitBox
houshengbo commented on issue #3: Use Apache Tentacles to create a LICENSE and NOTICE report URL: https://github.com/apache/incubator-openwhisk-release/issues/3#issuecomment-360499449 @daisy-ycguo Can we run this tools locally before we upload anything to the staging repository? For ex

[GitHub] daisy-ycguo commented on issue #12: Add the license and NOTICE file

2018-01-25 Thread GitBox
daisy-ycguo commented on issue #12: Add the license and NOTICE file URL: https://github.com/apache/incubator-openwhisk-release/issues/12#issuecomment-360467779 I think we shall add LICENSE and NOTICE to each repo. Below are quoted from [Apache Release Policy](http://www.apache.org/legal/r

[GitHub] jthomas commented on issue #83: Add support for installing optional packages.

2018-01-25 Thread GitBox
jthomas commented on issue #83: Add support for installing optional packages. URL: https://github.com/apache/incubator-openwhisk-devtools/pull/83#issuecomment-360417450 Good point - let me add the docs for this! This is an au

[GitHub] markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

2018-01-25 Thread GitBox
markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r163773800 ## File path: ansible/roles/invoker/tasks/deploy.yml ## @@ -173,8 +173,8 @@

[GitHub] markusthoemmes commented on issue #3217: Use case class instead of self-rolled class for InvokerHealth

2018-01-25 Thread GitBox
markusthoemmes commented on issue #3217: Use case class instead of self-rolled class for InvokerHealth URL: https://github.com/apache/incubator-openwhisk/pull/3217#issuecomment-360390791 It just felt weird, maybe I'm overpicky ? ---