[GitHub] tz70s closed pull request #3469: Ensure clean up testspace under wskadmin test.

2018-03-20 Thread GitBox
tz70s closed pull request #3469: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3469 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] tz70s commented on issue #3469: Ensure clean up testspace under wskadmin test.

2018-03-20 Thread GitBox
tz70s commented on issue #3469: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3469#issuecomment-374837104 Reopen this pr later, b.c. I need to figure out why the test got failed and avoid disturbing upstream travis build.

[GitHub] mrutkows closed pull request #811: Deprecating WithinOpenWhisk flag

2018-03-20 Thread GitBox
mrutkows closed pull request #811: Deprecating WithinOpenWhisk flag URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/811 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] mrutkows closed issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set

2018-03-20 Thread GitBox
mrutkows closed issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/791 This is an automated message from the Apache Git Service. To

[GitHub] csantanapr closed pull request #34: Remove swift:4.0, only swift:4.1

2018-03-20 Thread GitBox
csantanapr closed pull request #34: Remove swift:4.0, only swift:4.1 URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/34 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] csantanapr closed issue #30: Remove Swift 4.0, only support 4.1 and forward

2018-03-20 Thread GitBox
csantanapr closed issue #30: Remove Swift 4.0, only support 4.1 and forward URL: https://github.com/apache/incubator-openwhisk-runtime-swift/issues/30 This is an automated message from the Apache Git Service. To respond to

[GitHub] dubee closed pull request #3472: Remove email address

2018-03-20 Thread GitBox
dubee closed pull request #3472: Remove email address URL: https://github.com/apache/incubator-openwhisk/pull/3472 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] dubee closed pull request #250: Remove email addresses

2018-03-20 Thread GitBox
dubee closed pull request #250: Remove email addresses URL: https://github.com/apache/incubator-openwhisk-cli/pull/250 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] dubee commented on issue #250: Remove email addresses

2018-03-20 Thread GitBox
dubee commented on issue #250: Remove email addresses URL: https://github.com/apache/incubator-openwhisk-cli/pull/250#issuecomment-374769905 Travis failed because of intermittent test failure to be fixed in this PR https://github.com/apache/incubator-openwhisk-cli/pull/247.

[GitHub] mdeuser commented on issue #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
mdeuser commented on issue #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#issuecomment-374765536 @dubee changes look ok... although i think this section probably needs additional rework to better integrate the web action aspects (web

[GitHub] pritidesai commented on issue #811: Deprecating WithinOpenWhisk flag

2018-03-20 Thread GitBox
pritidesai commented on issue #811: Deprecating WithinOpenWhisk flag URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/811#issuecomment-374763837 @beemarie `exec` deals with the set of env. variables specified in execOptions, its nothing to do with `wskdeploy`. Its more

[GitHub] dubee commented on a change in pull request #247: Fix intermittent test failure

2018-03-20 Thread GitBox
dubee commented on a change in pull request #247: Fix intermittent test failure URL: https://github.com/apache/incubator-openwhisk-cli/pull/247#discussion_r175927899 ## File path: tests/src/test/scala/system/basic/WskBasicTests.scala ## @@ -549,13 +549,18 @@ class

[GitHub] dubee closed pull request #249: Use proper license headers

2018-03-20 Thread GitBox
dubee closed pull request #249: Use proper license headers URL: https://github.com/apache/incubator-openwhisk-cli/pull/249 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] houshengbo commented on issue #251: Add the support to specify the version of the binaries

2018-03-20 Thread GitBox
houshengbo commented on issue #251: Add the support to specify the version of the binaries URL: https://github.com/apache/incubator-openwhisk-cli/pull/251#issuecomment-374760632 @jonpspri Please help me review this PR, thanks.

[GitHub] dubee closed pull request #248: Fix test to not compare namespace to subject

2018-03-20 Thread GitBox
dubee closed pull request #248: Fix test to not compare namespace to subject URL: https://github.com/apache/incubator-openwhisk-cli/pull/248 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] dgrove-oss commented on issue #167: Add webhook for slackbot notification of TravisCI jobs

2018-03-20 Thread GitBox
dgrove-oss commented on issue #167: Add webhook for slackbot notification of TravisCI jobs URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/167#issuecomment-374759296 changed as requested; ready to merge.

[GitHub] beemarie commented on issue #811: Deprecating WithinOpenWhisk flag

2018-03-20 Thread GitBox
beemarie commented on issue #811: Deprecating WithinOpenWhisk flag URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/811#issuecomment-374756424 @pritidesai @mrutkows The code priti posted is how wskdeploy is being called from the deploy package. The environment data

[GitHub] houshengbo opened a new pull request #251: Add the support to specify the version of the binaries

2018-03-20 Thread GitBox
houshengbo opened a new pull request #251: Add the support to specify the version of the binaries URL: https://github.com/apache/incubator-openwhisk-cli/pull/251 This PR changes the task name from release to releaseBinaries in order to make it consistent in the release process. It also

[GitHub] houshengbo commented on issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs.

2018-03-20 Thread GitBox
houshengbo commented on issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs. URL: https://github.com/apache/incubator-openwhisk-release/issues/63#issuecomment-374753437 closes: https://github.com/apache/incubator-openwhisk-release/issues/9

[GitHub] houshengbo commented on issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs.

2018-03-20 Thread GitBox
houshengbo commented on issue #63: Verify API Gateway legal NOTICE / CREDITS files ack. licenses/contribs. URL: https://github.com/apache/incubator-openwhisk-release/issues/63#issuecomment-374753437 closes: https://github.com/apache/incubator-openwhisk-release/issues/9

[GitHub] dubee opened a new pull request #3472: Remove email address

2018-03-20 Thread GitBox
dubee opened a new pull request #3472: Remove email address URL: https://github.com/apache/incubator-openwhisk/pull/3472 Removes an email address from API GW tests. ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this

[GitHub] dubee opened a new pull request #250: Remove email addresses

2018-03-20 Thread GitBox
dubee opened a new pull request #250: Remove email addresses URL: https://github.com/apache/incubator-openwhisk-cli/pull/250 Scrub email address from a couple of files. This is an automated message from the Apache Git

[GitHub] mdeuser commented on a change in pull request #247: Fix intermittent test failure

2018-03-20 Thread GitBox
mdeuser commented on a change in pull request #247: Fix intermittent test failure URL: https://github.com/apache/incubator-openwhisk-cli/pull/247#discussion_r175916324 ## File path: tests/src/test/scala/system/basic/WskBasicTests.scala ## @@ -549,13 +549,18 @@ class

[GitHub] dubee opened a new pull request #249: Use proper license headers

2018-03-20 Thread GitBox
dubee opened a new pull request #249: Use proper license headers URL: https://github.com/apache/incubator-openwhisk-cli/pull/249 The wrong license headers were being used in a couple of files. This is an automated message

[GitHub] pritidesai commented on issue #811: Deprecating WithinOpenWhisk flag

2018-03-20 Thread GitBox
pritidesai commented on issue #811: Deprecating WithinOpenWhisk flag URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/811#issuecomment-374748897 @mrutkows based on the `exec` command from [package

[GitHub] pritidesai commented on issue #811: Deprecating WithinOpenWhisk flag

2018-03-20 Thread GitBox
pritidesai commented on issue #811: Deprecating WithinOpenWhisk flag URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/811#issuecomment-374748897 @mrutkows based on the `exec` command from [package

[GitHub] dubee opened a new pull request #248: Fix test to not compare namespace to subject

2018-03-20 Thread GitBox
dubee opened a new pull request #248: Fix test to not compare namespace to subject URL: https://github.com/apache/incubator-openwhisk-cli/pull/248 `create a trigger, and fire a trigger to get its individual fields from an activation` directly compares a namespace to a subject which will

[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175910182 ## File path: docs/actions.md ## @@ -31,6 +31,7 @@ Learn how to create, invoke, and debug actions in

[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175907988 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] mdeuser commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-20 Thread GitBox
mdeuser commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r175903104 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] dubee opened a new pull request #247: Fix intermittent test failure

2018-03-20 Thread GitBox
dubee opened a new pull request #247: Fix intermittent test failure URL: https://github.com/apache/incubator-openwhisk-cli/pull/247 `create, and get a trigger summary` fails intermittently as the returned annotations array is not always in the expected order.

[GitHub] mdeuser commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-20 Thread GitBox
mdeuser commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r175904374 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] mrutkows commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set

2018-03-20 Thread GitBox
mrutkows commented on issue #791: Crash when running with __OW_API_KEY and __OW_API_HOST set URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/791#issuecomment-374736872 @pritidesai it seems that package-deploy does not use them, but did ask for Belinda to affirm

[GitHub] mrutkows commented on issue #811: Deprecating WithinOpenWhisk flag

2018-03-20 Thread GitBox
mrutkows commented on issue #811: Deprecating WithinOpenWhisk flag URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/811#issuecomment-374736355 @beemarie Can you confirm that you no longer need to pass in arguments via a JSON structure when running 'wskdeploy' as an

[GitHub] mdeuser commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-20 Thread GitBox
mdeuser commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r175903104 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] mdeuser commented on issue #246: Fix Go regex for path parameter parsing

2018-03-20 Thread GitBox
mdeuser commented on issue #246: Fix Go regex for path parameter parsing URL: https://github.com/apache/incubator-openwhisk-cli/pull/246#issuecomment-374731987 @drcariel -- would you mind reviewing This is an automated

[GitHub] mrutkows commented on issue #807: Deprecating Interactive Mode and introducing Preview

2018-03-20 Thread GitBox
mrutkows commented on issue #807: Deprecating Interactive Mode and introducing Preview URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/807#issuecomment-374729320 @csantanapr today! This is an automated

[GitHub] mrutkows closed pull request #807: Deprecating Interactive Mode and introducing Preview

2018-03-20 Thread GitBox
mrutkows closed pull request #807: Deprecating Interactive Mode and introducing Preview URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/807 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] mrutkows closed issue #693: whiskclient_test.go: "TestNewWhiskConfigInteractiveMode" incomplete/commented out

2018-03-20 Thread GitBox
mrutkows closed issue #693: whiskclient_test.go: "TestNewWhiskConfigInteractiveMode" incomplete/commented out URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/693 This is an automated message from the

[GitHub] mrutkows closed issue #758: Deprecate interactive mode in wskdeploy

2018-03-20 Thread GitBox
mrutkows closed issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] bwmcadams opened a new pull request #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries

2018-03-20 Thread GitBox
bwmcadams opened a new pull request #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries URL: https://github.com/apache/incubator-openwhisk/pull/3471 ## Description Previously, the `idleTimeout` and `pauseGrace` settings

[GitHub] bwmcadams opened a new issue #3470: Change ContainerProxy `unusedTimeout` and `pauseGrace` from hardcoded defaults to config driven

2018-03-20 Thread GitBox
bwmcadams opened a new issue #3470: Change ContainerProxy `unusedTimeout` and `pauseGrace` from hardcoded defaults to config driven URL: https://github.com/apache/incubator-openwhisk/issues/3470 ## Steps to reproduce the issue: 1. Currently, `unusedTimeout` and `pauseGrace`

[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175886022 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175882446 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] dubee commented on issue #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on issue #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#issuecomment-374713064 @rabbah, @mdeuser, anything else? This is an automated message from the

[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175545924 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175876601 ## File path: docs/actions.md ## @@ -31,6 +31,7 @@ Learn how to create, invoke, and debug actions in your

[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175876068 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175876068 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175873830 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175865776 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] dubee commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
dubee commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175865776 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] dubee commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-20 Thread GitBox
dubee commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r175850403 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ## @@

[GitHub] dubee commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-20 Thread GitBox
dubee commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r175849808 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] dubee commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-20 Thread GitBox
dubee commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r175849353 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] dubee commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-20 Thread GitBox
dubee commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r175841358 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] dubee commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-20 Thread GitBox
dubee commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r175840729 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] dubee commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-20 Thread GitBox
dubee commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r175848990 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] tz70s opened a new pull request #3469: Ensure clean up testspace under wskadmin test.

2018-03-20 Thread GitBox
tz70s opened a new pull request #3469: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3469 Fix up testsuite `block and unblock a user respectively` fails when `testspace` contains pre-existing users. Signed-off-by: Tzu-Chiao

[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175824240 ## File path: docs/actions.md ## @@ -31,6 +31,7 @@ Learn how to create, invoke, and debug actions in

[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175823953 ## File path: docs/actions.md ## @@ -31,6 +31,7 @@ Learn how to create, invoke, and debug actions in

[GitHub] chetanmeh commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-20 Thread GitBox
chetanmeh commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374636516 > Ideally in this scenery, one would use ‘shell:’ to invoke an entry point in the invoker jar

[GitHub] jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-20 Thread GitBox
jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374627781 I was thinking about something along @chetanmeh ‘s way of thinking. Although I’d rather go the

[GitHub] rabbah commented on a change in pull request #3435: CLI docs update and markdown linting.

2018-03-20 Thread GitBox
rabbah commented on a change in pull request #3435: CLI docs update and markdown linting. URL: https://github.com/apache/incubator-openwhisk/pull/3435#discussion_r175794906 ## File path: ansible/README.md ## @@ -172,24 +172,44 @@ Use `ansible-playbook -i environments/

[GitHub] jonpspri commented on a change in pull request #3435: CLI docs update and markdown linting.

2018-03-20 Thread GitBox
jonpspri commented on a change in pull request #3435: CLI docs update and markdown linting. URL: https://github.com/apache/incubator-openwhisk/pull/3435#discussion_r175794097 ## File path: ansible/README.md ## @@ -172,24 +172,44 @@ Use `ansible-playbook -i environments/

[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-20 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-374624880 Maybe it can be, but should we move it into a different namespace from the runtime-specific code (maybe also

[GitHub] tz70s opened a new issue #3468: Docker daemon error under ubuntu xenial

2018-03-20 Thread GitBox
tz70s opened a new issue #3468: Docker daemon error under ubuntu xenial URL: https://github.com/apache/incubator-openwhisk/issues/3468 ## Environment details: Local deployment under ubuntu xenial. ## Steps to reproduce the issue: ```bash # Equivalent steps in

[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-20 Thread GitBox
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374607395 I'd like to have just one place to get these defaults. I like @chetanmeh's suggestion of

[GitHub] rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-20 Thread GitBox
rabbah commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-374605804 We will need to designate a single place as the canonical root for the common code. Maybe it can still be this

[GitHub] jonpspri opened a new pull request #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-20 Thread GitBox
jonpspri opened a new pull request #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467 ## Description When the various action controllers were spun out into their own repositories, they took their test

[GitHub] jonpspri commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions

2018-03-20 Thread GitBox
jonpspri commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#issuecomment-374599948 @Param-S The same unicode test case as above. Hold tight — I seem to have some classpath

[GitHub] chetanmeh commented on issue #3453: Introduce a AttachmentStore SPI

2018-03-20 Thread GitBox
chetanmeh commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-374598806 > dont follow the need for the volatile attachments. The updates to state are performed via stream stage and hence is single

[GitHub] chetanmeh commented on a change in pull request #3453: Introduce a AttachmentStore SPI

2018-03-20 Thread GitBox
chetanmeh commented on a change in pull request #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#discussion_r175763836 ## File path: common/scala/src/main/scala/whisk/core/database/AttachmentStore.scala ## @@ -0,0 +1,51

[GitHub] csantanapr opened a new pull request #34: Remove swift:4.0, only swift:4.1

2018-03-20 Thread GitBox
csantanapr opened a new pull request #34: Remove swift:4.0, only swift:4.1 URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/34 Remove swift:4.0 as swift:4.1 is the only right now being used. This is an

[GitHub] tz70s opened a new pull request #3466: Support alternative path for python in whiskprops

2018-03-20 Thread GitBox
tz70s opened a new pull request #3466: Support alternative path for python in whiskprops URL: https://github.com/apache/incubator-openwhisk/pull/3466 By default, the path of python2.7 is located at `/usr/bin/` instead of `/usr/local/bin/`. Since folks may desire to use homebrew

[GitHub] jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-20 Thread GitBox
jonpspri commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374580802 Hi @dgrove-oss, I missed that memo, so forgive me if I’m catching up. Currently there’s logic in

[GitHub] jonpspri commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’

2018-03-20 Thread GitBox
jonpspri commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’ URL: https://github.com/apache/incubator-openwhisk/pull/3457#issuecomment-374578440 Agreed re PG. WIll do it with @csantanapr later today.

[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-20 Thread GitBox
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374577087 I thought we decided to move the misc defaults to pureconfig

[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-20 Thread GitBox
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374577087 I thought we decided to move the misc defaults to pureconfig

[GitHub] dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes

2018-03-20 Thread GitBox
dgrove-oss commented on issue #3412: Changes to runtimes variables in support of retiring 'whisk/*' runtimes URL: https://github.com/apache/incubator-openwhisk/pull/3412#issuecomment-374577087 I thought we decided to move the misc defaults to pureconfig

[GitHub] mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs

2018-03-20 Thread GitBox
mdeuser commented on a change in pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464#discussion_r175737539 ## File path: docs/actions.md ## @@ -1219,6 +1184,71 @@ This command starts a polling loop that

[GitHub] csantanapr commented on issue #3208: Source files for images in docs folder

2018-03-20 Thread GitBox
csantanapr commented on issue #3208: Source files for images in docs folder URL: https://github.com/apache/incubator-openwhisk/issues/3208#issuecomment-374567561 @shazron Which open source tools could we use to edit PSD/EPS? I’m +1 with draw.io

[GitHub] sciabarracom commented on issue #319: plugable model for adding action language support

2018-03-20 Thread GitBox
sciabarracom commented on issue #319: plugable model for adding action language support URL: https://github.com/apache/incubator-openwhisk/issues/319#issuecomment-374524170 HI Imesh actually the "pluggable" support is already written. It lives in

[GitHub] imesh commented on issue #319: plugable model for adding action language support

2018-03-20 Thread GitBox
imesh commented on issue #319: plugable model for adding action language support URL: https://github.com/apache/incubator-openwhisk/issues/319#issuecomment-374522746 Thanks @rabbah for the update and all your help on implementing it!

[GitHub] cbickel commented on a change in pull request #3342: #3168 Rate limit requests to download CLI, Docker and iOS SDKs

2018-03-20 Thread GitBox
cbickel commented on a change in pull request #3342: #3168 Rate limit requests to download CLI, Docker and iOS SDKs URL: https://github.com/apache/incubator-openwhisk/pull/3342#discussion_r175682262 ## File path: ansible/roles/nginx/templates/nginx.conf.j2 ## @@ -94,18

[GitHub] cbickel commented on issue #3342: #3168 Rate limit requests to download CLI, Docker and iOS SDKs

2018-03-20 Thread GitBox
cbickel commented on issue #3342: #3168 Rate limit requests to download CLI, Docker and iOS SDKs URL: https://github.com/apache/incubator-openwhisk/pull/3342#issuecomment-374511609 @mptap Thanks a lot for your contribution. I like the idea of limiting the download of some

[GitHub] cbickel commented on a change in pull request #3451: Fix several loadbalancer bugs.

2018-03-20 Thread GitBox
cbickel commented on a change in pull request #3451: Fix several loadbalancer bugs. URL: https://github.com/apache/incubator-openwhisk/pull/3451#discussion_r175671605 ## File path: core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala

[GitHub] cbickel commented on a change in pull request #3451: Fix several loadbalancer bugs.

2018-03-20 Thread GitBox
cbickel commented on a change in pull request #3451: Fix several loadbalancer bugs. URL: https://github.com/apache/incubator-openwhisk/pull/3451#discussion_r175671248 ## File path: core/controller/src/main/scala/whisk/core/loadBalancer/ShardingContainerPoolBalancer.scala