[GitHub] style95 commented on issue #3106: Couchdb persistency

2018-03-21 Thread GitBox
style95 commented on issue #3106: Couchdb persistency URL: https://github.com/apache/incubator-openwhisk/pull/3106#issuecomment-375188078 Maybe similar approach should be taken: https://github.com/apache/incubator-openwhisk/pull/3432#issuecomment-373029498

[GitHub] tz70s commented on issue #3466: Support alternative path for python in whiskprops

2018-03-21 Thread GitBox
tz70s commented on issue #3466: Support alternative path for python in whiskprops URL: https://github.com/apache/incubator-openwhisk/pull/3466#issuecomment-375150664 @rabbah , this helps me a lot, thanks! This is an

[GitHub] tz70s commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
tz70s commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176288451 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@

[GitHub] rabbah commented on issue #3454: Control Container Capabilities?

2018-03-21 Thread GitBox
rabbah commented on issue #3454: Control Container Capabilities? URL: https://github.com/apache/incubator-openwhisk/issues/3454#issuecomment-375139631 cc @dgrove-oss This is an automated message from the Apache Git Service.

[GitHub] rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#discussion_r176279736 ## File path: common/scala/src/main/scala/whisk/core/database/memory/MemoryAttachmentStore.scala ## @@

[GitHub] rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#discussion_r176278665 ## File path: common/scala/src/main/scala/whisk/core/database/couchdb/CouchDbAttachmentStore.scala ##

[GitHub] rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#discussion_r176278384 ## File path: common/scala/src/main/scala/whisk/core/database/AttachmentStore.scala ## @@ -0,0 +1,51 @@

[GitHub] rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#discussion_r176279109 ## File path: common/scala/src/main/scala/whisk/core/database/memory/MemoryAttachmentStore.scala ## @@

[GitHub] rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#discussion_r176278825 ## File path: common/scala/src/main/scala/whisk/core/database/couchdb/CouchDbAttachmentStore.scala ##

[GitHub] dubee commented on a change in pull request #3479: Makes wskadmin python2 and python3 compatible

2018-03-21 Thread GitBox
dubee commented on a change in pull request #3479: Makes wskadmin python2 and python3 compatible URL: https://github.com/apache/incubator-openwhisk/pull/3479#discussion_r176275846 ## File path: tools/admin/wskadmin ## @@ -32,7 +32,10 @@ import sys import traceback

[GitHub] dubee commented on a change in pull request #3479: Makes wskadmin python2 and python3 compatible

2018-03-21 Thread GitBox
dubee commented on a change in pull request #3479: Makes wskadmin python2 and python3 compatible URL: https://github.com/apache/incubator-openwhisk/pull/3479#discussion_r176275846 ## File path: tools/admin/wskadmin ## @@ -32,7 +32,10 @@ import sys import traceback

[GitHub] rabbah commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176272831 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ##

[GitHub] rabbah commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176273146 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ##

[GitHub] rabbah commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176272831 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ##

[GitHub] rabbah commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176270902 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ##

[GitHub] rabbah commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176271547 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ##

[GitHub] rabbah commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176271547 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ##

[GitHub] rabbah commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176270902 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ##

[GitHub] rabbah commented on issue #3466: Support alternative path for python in whiskprops

2018-03-21 Thread GitBox
rabbah commented on issue #3466: Support alternative path for python in whiskprops URL: https://github.com/apache/incubator-openwhisk/pull/3466#issuecomment-375127759 @tz70s I opened https://github.com/apache/incubator-openwhisk/pull/3479 which should make wskadmin work with python3 (I

[GitHub] rabbah commented on issue #3466: Support alternative path for python in whiskprops

2018-03-21 Thread GitBox
rabbah commented on issue #3466: Support alternative path for python in whiskprops URL: https://github.com/apache/incubator-openwhisk/pull/3466#issuecomment-375127759 @tz70s I opened https://github.com/apache/incubator-openwhisk/pull/3479 which should make wskadmin work with python3 (I

[GitHub] rabbah opened a new pull request #3479: Wskadmin

2018-03-21 Thread GitBox
rabbah opened a new pull request #3479: Wskadmin URL: https://github.com/apache/incubator-openwhisk/pull/3479 ## Description Updates wskadmin to be python3 compatible. No semantic changes intended. ## My changes affect the following components - [x] General tooling ##

[GitHub] dubee closed pull request #3478: Remove deadcode and clone/own.

2018-03-21 Thread GitBox
dubee closed pull request #3478: Remove deadcode and clone/own. URL: https://github.com/apache/incubator-openwhisk/pull/3478 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] dubee commented on issue #3478: Remove deadcode and clone/own.

2018-03-21 Thread GitBox
dubee commented on issue #3478: Remove deadcode and clone/own. URL: https://github.com/apache/incubator-openwhisk/pull/3478#issuecomment-375114228 PG4 1515  This is an automated message from the Apache Git Service. To

[GitHub] dubee closed pull request #246: Fix Go regex for path parameter parsing

2018-03-21 Thread GitBox
dubee closed pull request #246: Fix Go regex for path parameter parsing URL: https://github.com/apache/incubator-openwhisk-cli/pull/246 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] dubee closed issue #237: API with back-to-back path parameters fails

2018-03-21 Thread GitBox
dubee closed issue #237: API with back-to-back path parameters fails URL: https://github.com/apache/incubator-openwhisk-cli/issues/237 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] dubee commented on issue #2795: enable concurrent activation processing

2018-03-21 Thread GitBox
dubee commented on issue #2795: enable concurrent activation processing URL: https://github.com/apache/incubator-openwhisk/pull/2795#issuecomment-375095716 @tysonnorris, looks like this one needs a rebase. This is an

[GitHub] dubee commented on issue #3211: implement ContainerFactory.cpuShare to fix #3110

2018-03-21 Thread GitBox
dubee commented on issue #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#issuecomment-375095171 @tysonnorris, can you rebase. What's the status of this one?

[GitHub] dubee closed issue #3426: CLI Builds not found in expected location

2018-03-21 Thread GitBox
dubee closed issue #3426: CLI Builds not found in expected location URL: https://github.com/apache/incubator-openwhisk/issues/3426 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] dubee closed pull request #3435: CLI docs update and markdown linting.

2018-03-21 Thread GitBox
dubee closed pull request #3435: CLI docs update and markdown linting. URL: https://github.com/apache/incubator-openwhisk/pull/3435 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] dubee commented on issue #3459: Wrap producer.send with Future

2018-03-21 Thread GitBox
dubee commented on issue #3459: Wrap producer.send with Future URL: https://github.com/apache/incubator-openwhisk/pull/3459#issuecomment-375086655 PG is good on this one. Will wait until @cbickel or @markusthoemmes take a look before merging.

[GitHub] dubee commented on issue #3421: Add ElasticSearch Log Store

2018-03-21 Thread GitBox
dubee commented on issue #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#issuecomment-375089409 PG2 2953  This is an automated message from the Apache Git Service. To respond

[GitHub] dubee commented on issue #3421: Add ElasticSearch Log Store

2018-03-21 Thread GitBox
dubee commented on issue #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#issuecomment-374297655 PG3 2010  This is an automated message from the Apache Git Service. To respond

[GitHub] dubee commented on issue #3421: Add ElasticSearch Log Store

2018-03-21 Thread GitBox
dubee commented on issue #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#issuecomment-374108734 PG3 2005  PG3 2007  This is an automated message from the Apache Git

[GitHub] dubee commented on issue #3421: Add ElasticSearch Log Store

2018-03-21 Thread GitBox
dubee commented on issue #3421: Add ElasticSearch Log Store URL: https://github.com/apache/incubator-openwhisk/pull/3421#issuecomment-372867292 PG2 2918  This is an automated message from the Apache Git Service. To respond

[GitHub] dubee commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’

2018-03-21 Thread GitBox
dubee commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’ URL: https://github.com/apache/incubator-openwhisk/pull/3457#issuecomment-375088010 Hmm, seeing an error in the PG while `initdb.yml` is running. ``` TASK [include]

[GitHub] dubee commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’

2018-03-21 Thread GitBox
dubee commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’ URL: https://github.com/apache/incubator-openwhisk/pull/3457#issuecomment-375088010 Hmm, seeing an error in the PG while `initdb.yml` is running. ``` TASK [include]

[GitHub] dubee commented on issue #3459: Wrap producer.send with Future

2018-03-21 Thread GitBox
dubee commented on issue #3459: Wrap producer.send with Future URL: https://github.com/apache/incubator-openwhisk/pull/3459#issuecomment-375086655 PG is good on this one. Will waiting until @cbickel or @markusthoemmes take a look before merging.

[GitHub] dubee commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’

2018-03-21 Thread GitBox
dubee commented on issue #3457: Ansible 2.4 deprecates ‘include’ in favor of ‘import_*’ and ‘include_tasks’ URL: https://github.com/apache/incubator-openwhisk/pull/3457#issuecomment-375083291 PG3 2036  This is an

[GitHub] dubee commented on issue #3459: Wrap producer.send with Future

2018-03-21 Thread GitBox
dubee commented on issue #3459: Wrap producer.send with Future URL: https://github.com/apache/incubator-openwhisk/pull/3459#issuecomment-375081697 PG5 1514  This is an automated message from the Apache Git Service. To

[GitHub] houshengbo opened a new pull request #812: Change the gradle build to use the gogradle plugin

2018-03-21 Thread GitBox
houshengbo opened a new pull request #812: Change the gradle build to use the gogradle plugin URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/812 This is an automated message from the Apache Git Service.

[GitHub] dubee commented on issue #3478: Remove deadcode and clone/own.

2018-03-21 Thread GitBox
dubee commented on issue #3478: Remove deadcode and clone/own. URL: https://github.com/apache/incubator-openwhisk/pull/3478#issuecomment-375081365 PG4 1515 ☃️ This is an automated message from the Apache Git Service. To

[GitHub] rabbah commented on issue #3478: Remove deadcode and clone/own.

2018-03-21 Thread GitBox
rabbah commented on issue #3478: Remove deadcode and clone/own. URL: https://github.com/apache/incubator-openwhisk/pull/3478#issuecomment-375072736 done - thanks for the pg. This is an automated message from the Apache Git

[GitHub] dubee closed pull request #3474: Ensure clean up testspace under wskadmin test.

2018-03-21 Thread GitBox
dubee closed pull request #3474: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3474 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] dubee commented on issue #3474: Ensure clean up testspace under wskadmin test.

2018-03-21 Thread GitBox
dubee commented on issue #3474: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3474#issuecomment-375062790 PG3 2035  This is an automated message from the Apache Git

[GitHub] mdeuser commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-21 Thread GitBox
mdeuser commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r176201197 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] dubee commented on issue #3478: Remove deadcode and clone/own.

2018-03-21 Thread GitBox
dubee commented on issue #3478: Remove deadcode and clone/own. URL: https://github.com/apache/incubator-openwhisk/pull/3478#issuecomment-375055401 @rabbah, can you rebase having trouble with a PG. This is an automated

[GitHub] sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176189828 ## File path: openwhisk/actionProxy.go ## @@ -0,0 +1,97 @@ +/* + * Licensed to the

[GitHub] sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176189631 ## File path: openwhisk/actionProxy.go ## @@ -0,0 +1,97 @@ +/* + * Licensed to the

[GitHub] rabbah commented on issue #3345: ansible 2.4 compatibility

2018-03-21 Thread GitBox
rabbah commented on issue #3345: ansible 2.4 compatibility URL: https://github.com/apache/incubator-openwhisk/issues/3345#issuecomment-375046366 Some more warnings: ``` TASK [nginx : copy controller cert for authentication] [WARNING]: when statements should not include jinja2

[GitHub] sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176189144 ## File path: openwhisk/actionProxy.go ## @@ -0,0 +1,97 @@ +/* + * Licensed to the

[GitHub] houshengbo closed pull request #252: Remove notes.md

2018-03-21 Thread GitBox
houshengbo closed pull request #252: Remove notes.md URL: https://github.com/apache/incubator-openwhisk-cli/pull/252 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] dubee commented on issue #3459: Wrap producer.send with Future

2018-03-21 Thread GitBox
dubee commented on issue #3459: Wrap producer.send with Future URL: https://github.com/apache/incubator-openwhisk/pull/3459#issuecomment-375045140 PG4 1514  This is an automated message from the Apache Git Service. To

[GitHub] mdeuser closed pull request #247: Fix intermittent test failure

2018-03-21 Thread GitBox
mdeuser closed pull request #247: Fix intermittent test failure URL: https://github.com/apache/incubator-openwhisk-cli/pull/247 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] dubee closed pull request #3464: Add wsk action get to CLI docs

2018-03-21 Thread GitBox
dubee closed pull request #3464: Add wsk action get to CLI docs URL: https://github.com/apache/incubator-openwhisk/pull/3464 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] dubee commented on issue #3478: Remove deadcode and clone/own.

2018-03-21 Thread GitBox
dubee commented on issue #3478: Remove deadcode and clone/own. URL: https://github.com/apache/incubator-openwhisk/pull/3478#issuecomment-375041582 PG2 2952  This is an automated message from the Apache Git Service. To

[GitHub] jonpspri commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions

2018-03-21 Thread GitBox
jonpspri commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#discussion_r17610 ## File path: core/javaAction/Dockerfile ## @@ -1,38 +1,23

[GitHub] dubee commented on issue #3427: Add Gatling tests to test performance.

2018-03-21 Thread GitBox
dubee commented on issue #3427: Add Gatling tests to test performance. URL: https://github.com/apache/incubator-openwhisk/pull/3427#issuecomment-375040708 Restarted Travis, unrelated Kafka test failed. This is an automated

[GitHub] jonpspri commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions

2018-03-21 Thread GitBox
jonpspri commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#discussion_r176183334 ## File path: core/javaAction/Dockerfile ## @@ -1,38 +1,11

[GitHub] jonpspri commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions

2018-03-21 Thread GitBox
jonpspri commented on a change in pull request #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#discussion_r17610 ## File path: core/javaAction/Dockerfile ## @@ -1,38 +1,23

[GitHub] jonpspri commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions

2018-03-21 Thread GitBox
jonpspri commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#issuecomment-375034867 Found it. For whatever reason, the proxy was running using the ‘US-ASCII’ code page to log

[GitHub] jonpspri commented on issue #251: Add the support to specify the version of the binaries

2018-03-21 Thread GitBox
jonpspri commented on issue #251: Add the support to specify the version of the binaries URL: https://github.com/apache/incubator-openwhisk-cli/pull/251#issuecomment-375033773 LGTM This is an automated message from the

[GitHub] sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176175500 ## File path: misc/.gitignore ## @@ -0,0 +1,2 @@ +exec +exec.json Review comment:

[GitHub] sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176175309 ## File path: hello/hello.go ## @@ -0,0 +1,30 @@ +package hello + +import ( +

[GitHub] sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
sciabarracom commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176174925 ## File path: .gitignore ## @@ -0,0 +1,8 @@ +.vscode/ +vendor/ +hack Review comment:

[GitHub] rabbah commented on a change in pull request #3474: Ensure clean up testspace under wskadmin test.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3474: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3474#discussion_r176174839 ## File path: tests/src/test/scala/whisk/core/admin/WskAdminTests.scala ## @@ -33,7

[GitHub] vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176160336 ## File path: misc/.gitignore ## @@ -0,0 +1,2 @@ +exec +exec.json Review comment:

[GitHub] vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176163756 ## File path: openwhisk/actionProxy.go ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache

[GitHub] vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176169507 ## File path: openwhisk/actionProxy.go ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache

[GitHub] vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176165069 ## File path: openwhisk/actionProxy.go ## @@ -0,0 +1,97 @@ +/* + * Licensed to the Apache

[GitHub] vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176156449 ## File path: .gitignore ## @@ -0,0 +1,8 @@ +.vscode/ +vendor/ +hack Review comment:

[GitHub] vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176161986 ## File path: openwhisk/_test/first/3/.gitignore ## @@ -0,0 +1 @@ +* Review comment:

[GitHub] vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime

2018-03-21 Thread GitBox
vvraskin commented on a change in pull request #2: Releasing the revised Golang runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/2#discussion_r176159666 ## File path: hello/hello.go ## @@ -0,0 +1,30 @@ +package hello + +import ( +

[GitHub] dubee opened a new pull request #252: Remove notes.md

2018-03-21 Thread GitBox
dubee opened a new pull request #252: Remove notes.md URL: https://github.com/apache/incubator-openwhisk-cli/pull/252 Per @houshengbo, this file is no longer needed. This is an automated message from the Apache Git Service.

[GitHub] dubee commented on a change in pull request #244: Add --web-secure option to action create/update

2018-03-21 Thread GitBox
dubee commented on a change in pull request #244: Add --web-secure option to action create/update URL: https://github.com/apache/incubator-openwhisk-cli/pull/244#discussion_r176168120 ## File path: commands/action.go ## @@ -442,14 +457,109 @@ func parseAction(cmd

[GitHub] dubee commented on issue #247: Fix intermittent test failure

2018-03-21 Thread GitBox
dubee commented on issue #247: Fix intermittent test failure URL: https://github.com/apache/incubator-openwhisk-cli/pull/247#issuecomment-375024959 @mdeuser, anything else on this one? This is an automated message from the

[GitHub] dubee commented on issue #3474: Ensure clean up testspace under wskadmin test.

2018-03-21 Thread GitBox
dubee commented on issue #3474: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3474#issuecomment-375024174 PG3 2035 ⏳ This is an automated message from the Apache Git

[GitHub] rabbah opened a new pull request #3478: Remove deadcode and clone/own.

2018-03-21 Thread GitBox
rabbah opened a new pull request #3478: Remove deadcode and clone/own. URL: https://github.com/apache/incubator-openwhisk/pull/3478 Removing what appears to be unnecessary/dead code. Also removed some code duplication around resolving fully qualified names. ## My changes affect

[GitHub] mdeuser opened a new issue #261: Monitor output percent units incorrect

2018-03-21 Thread GitBox
mdeuser opened a new issue #261: Monitor output percent units incorrect URL: https://github.com/apache/incubator-openwhisk-package-kafka/issues/261 ``` swap_memory['percent'] = '%d MB' % (percent / MEGABYTE) virtual_memory['percent'] = '%d MB' % (percent / MEGABYTE)

[GitHub] dgrove-oss commented on issue #168: issue about couchdb container (Error syncing pod)

2018-03-21 Thread GitBox
dgrove-oss commented on issue #168: issue about couchdb container (Error syncing pod) URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/168#issuecomment-374973553 `openwhisk/kube-couchdb` is the first container the `build.sh` script attempts to deploy. I would

[GitHub] chetanmeh opened a new issue #3477: Support extending the environment variables for docker in ansible

2018-03-21 Thread GitBox
chetanmeh opened a new issue #3477: Support extending the environment variables for docker in ansible URL: https://github.com/apache/incubator-openwhisk/issues/3477 Currently the ansible deploy scripts for invoker and controller have a specific enumerated set of environment variables

[GitHub] mrutkows commented on issue #804: Fix for 730

2018-03-21 Thread GitBox
mrutkows commented on issue #804: Fix for 730 URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/804#issuecomment-374392332 @davidbreitgand I do not like introducing a -r flag and somehow differentiating from static or dynamically linked dependent packages. IMO, and after

[GitHub] houshengbo commented on issue #251: Add the support to specify the version of the binaries

2018-03-21 Thread GitBox
houshengbo commented on issue #251: Add the support to specify the version of the binaries URL: https://github.com/apache/incubator-openwhisk-cli/pull/251#issuecomment-374962115 @jonpspri Thank you. I have changed this PR based on the comments.

[GitHub] mrutkows commented on issue #730: Multiple projects management

2018-03-21 Thread GitBox
mrutkows commented on issue #730: Multiple projects management URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/730#issuecomment-374961737 @davidbreitgand Using your example of, A -> B and project C -> B, my initial reaction is that I do not support making any changes

[GitHub] houshengbo commented on a change in pull request #251: Add the support to specify the version of the binaries

2018-03-21 Thread GitBox
houshengbo commented on a change in pull request #251: Add the support to specify the version of the binaries URL: https://github.com/apache/incubator-openwhisk-cli/pull/251#discussion_r176106334 ## File path: build.gradle ## @@ -121,6 +122,10 @@

[GitHub] houshengbo commented on a change in pull request #251: Add the support to specify the version of the binaries

2018-03-21 Thread GitBox
houshengbo commented on a change in pull request #251: Add the support to specify the version of the binaries URL: https://github.com/apache/incubator-openwhisk-cli/pull/251#discussion_r176106046 ## File path: build.gradle ## @@ -61,6 +61,7 @@ class OpenWhiskPlatform {

[GitHub] joshuabuildsthings commented on issue #3454: Control Container Capabilities?

2018-03-21 Thread GitBox
joshuabuildsthings commented on issue #3454: Control Container Capabilities? URL: https://github.com/apache/incubator-openwhisk/issues/3454#issuecomment-374958055 Yes. Currently evaluating it for my use case on a local minikube setup.

[GitHub] joshuabuildsthings commented on issue #3454: Control Container Capabilities?

2018-03-21 Thread GitBox
joshuabuildsthings commented on issue #3454: Control Container Capabilities? URL: https://github.com/apache/incubator-openwhisk/issues/3454#issuecomment-374954908 Thanks for clarifying! For my use case, a system-wide deployment parameter would work fine, and I'd be pretty happy with it.

[GitHub] rabbah commented on issue #3454: Control Container Capabilities?

2018-03-21 Thread GitBox
rabbah commented on issue #3454: Control Container Capabilities? URL: https://github.com/apache/incubator-openwhisk/issues/3454#issuecomment-374951200 > I'm currently assuming that what you're saying is that it would be easier to add this feature so it's system-wide & affects all actions

[GitHub] jonpspri commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions

2018-03-21 Thread GitBox
jonpspri commented on issue #24: Make AdoptOpenJDK Eclipse OpenJ9 the Java runtime for Java actions URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/24#issuecomment-374938212 I _think_ I found my problem buried in a circular dependency on `incubator-openwhisk` for

[GitHub] joshuabuildsthings commented on issue #3454: Control Container Capabilities?

2018-03-21 Thread GitBox
joshuabuildsthings commented on issue #3454: Control Container Capabilities? URL: https://github.com/apache/incubator-openwhisk/issues/3454#issuecomment-374937405 @rabbah - Please bear with me, I'd like to clarify terminology & make sure I'm using it correctly! I'm currently

[GitHub] tz70s commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
tz70s commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176079078 ## File path: tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala ##

[GitHub] tz70s commented on issue #3466: Support alternative path for python in whiskprops

2018-03-21 Thread GitBox
tz70s commented on issue #3466: Support alternative path for python in whiskprops URL: https://github.com/apache/incubator-openwhisk/pull/3466#issuecomment-374935244 In my experience, `wskadmin` is not python 3 compatible. For example, `httplib` is particular a python2.7 name,

[GitHub] tz70s commented on a change in pull request #3474: Ensure clean up testspace under wskadmin test.

2018-03-21 Thread GitBox
tz70s commented on a change in pull request #3474: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3474#discussion_r176076960 ## File path: tests/src/test/scala/whisk/core/admin/WskAdminTests.scala ## @@ -33,7 +34,26

[GitHub] tz70s commented on a change in pull request #3474: Ensure clean up testspace under wskadmin test.

2018-03-21 Thread GitBox
tz70s commented on a change in pull request #3474: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3474#discussion_r176076960 ## File path: tests/src/test/scala/whisk/core/admin/WskAdminTests.scala ## @@ -33,7 +34,26

[GitHub] jonpspri commented on issue #3467: WIP: Remove actionControllers tests from incubator-openwhisk repo

2018-03-21 Thread GitBox
jonpspri commented on issue #3467: WIP: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-374932385 Marking as WIP because apparently, the what’s in the runtime repo and what’s in the core repo was even

[GitHub] chetanmeh commented on issue #3453: Introduce a AttachmentStore SPI

2018-03-21 Thread GitBox
chetanmeh commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-374931027 As a next step there is now an implementation for S3 aka S3AttachementStore (see [here][1] for the diff). Once this PR is merged would

[GitHub] rabbah commented on issue #3466: Support alternative path for python in whiskprops

2018-03-21 Thread GitBox
rabbah commented on issue #3466: Support alternative path for python in whiskprops URL: https://github.com/apache/incubator-openwhisk/pull/3466#issuecomment-374925652 This change is ok but I'm wondering if we actually need this still. I a few scripts are still in python (wskdamin,

[GitHub] rabbah commented on a change in pull request #3473: Support string based status code from actions.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3473: Support string based status code from actions. URL: https://github.com/apache/incubator-openwhisk/pull/3473#discussion_r176068333 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ##

[GitHub] rabbah commented on a change in pull request #3474: Ensure clean up testspace under wskadmin test.

2018-03-21 Thread GitBox
rabbah commented on a change in pull request #3474: Ensure clean up testspace under wskadmin test. URL: https://github.com/apache/incubator-openwhisk/pull/3474#discussion_r176067405 ## File path: tests/src/test/scala/whisk/core/admin/WskAdminTests.scala ## @@ -33,7

[GitHub] z14572 opened a new issue #168: issue about couchdb container (Error syncing pod)

2018-03-21 Thread GitBox
z14572 opened a new issue #168: issue about couchdb container (Error syncing pod) URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/168 when I deploy openwhisk for kube , run the script file "build.sh", Failed to finish deploying CouchDB. kubectl get pods -n

  1   2   >