[GitHub] markusthoemmes commented on issue #3512: wrap filed rev of BulkEntityResult using Option

2018-04-02 Thread GitBox
markusthoemmes commented on issue #3512: wrap filed rev of BulkEntityResult using Option URL: https://github.com/apache/incubator-openwhisk/pull/3512#issuecomment-378148082 Ah, sorry, missed that! LGTM then! This is an autom

[GitHub] jiangpengcheng commented on issue #3512: wrap filed rev of BulkEntityResult using Option

2018-04-02 Thread GitBox
jiangpengcheng commented on issue #3512: wrap filed rev of BulkEntityResult using Option URL: https://github.com/apache/incubator-openwhisk/pull/3512#issuecomment-378145973 @markusthoemmes if there is an error field in some documents, these documents will be converted to either `D

[GitHub] cbickel commented on issue #3363: Ansible image name overrides and bump NGinx to 1.12

2018-04-02 Thread GitBox
cbickel commented on issue #3363: Ansible image name overrides and bump NGinx to 1.12 URL: https://github.com/apache/incubator-openwhisk/pull/3363#issuecomment-378143257 PG5#206 is running. This is an automated message from

[GitHub] markusthoemmes commented on issue #3512: wrap filed rev of BulkEntityResult using Option

2018-04-02 Thread GitBox
markusthoemmes commented on issue #3512: wrap filed rev of BulkEntityResult using Option URL: https://github.com/apache/incubator-openwhisk/pull/3512#issuecomment-378141881 Per the issue you opened (thanks for that!): Shall we properly deserialize this as an "error" iff the rev is missing

[GitHub] markusthoemmes commented on issue #3512: wrap filed rev of BulkEntityResult using Option

2018-04-02 Thread GitBox
markusthoemmes commented on issue #3512: wrap filed rev of BulkEntityResult using Option URL: https://github.com/apache/incubator-openwhisk/pull/3512#issuecomment-378141602 @jiangpengcheng can you elaborate on when the result would not contain a `rev` in normal operation? ---

[GitHub] markusthoemmes commented on issue #3512: wrap filed rev of BulkEntityResult using Option

2018-04-02 Thread GitBox
markusthoemmes commented on issue #3512: wrap filed rev of BulkEntityResult using Option URL: https://github.com/apache/incubator-openwhisk/pull/3512#issuecomment-378141602 @jiangpengcheng can you elaborate on when the result would not contain a `rev` in normal operation? ---

[GitHub] markusthoemmes closed pull request #3111: Replace our own clients with akka-streams-kafka.

2018-04-02 Thread GitBox
markusthoemmes closed pull request #3111: Replace our own clients with akka-streams-kafka. URL: https://github.com/apache/incubator-openwhisk/pull/3111 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenanc

[GitHub] markusthoemmes commented on issue #3111: Replace our own clients with akka-streams-kafka.

2018-04-02 Thread GitBox
markusthoemmes commented on issue #3111: Replace our own clients with akka-streams-kafka. URL: https://github.com/apache/incubator-openwhisk/pull/3111#issuecomment-378141200 Closing for now. Will reopen eventually. This is a

[GitHub] markusthoemmes commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre)

2018-04-02 Thread GitBox
markusthoemmes commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre) URL: https://github.com/apache/incubator-openwhisk/pull/3504#issuecomment-378139722 Let's not move to J9 lightly. OpenJDK in general is generally fine with me, after a quick loadt

[GitHub] markusthoemmes commented on issue #3516: Undocumented Container-Reuse

2018-04-02 Thread GitBox
markusthoemmes commented on issue #3516: Undocumented Container-Reuse URL: https://github.com/apache/incubator-openwhisk/issues/3516#issuecomment-378139299 You're right. FWIW, this bit of documentation is modeled after https://medium.com/openwhisk/uncovering-the-magic-how-serverless-platfo

[GitHub] Param-S commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre)

2018-04-02 Thread GitBox
Param-S commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre) URL: https://github.com/apache/incubator-openwhisk/pull/3504#issuecomment-378136038 OpenJ9 is open sourced implementation of Java Virtual Machine. **Please not that, the tools like jsta

[GitHub] Param-S commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre)

2018-04-02 Thread GitBox
Param-S commented on issue #3504: use alpine-java base image (alpine 3.7 + oracle 8u162b12_server-jre) URL: https://github.com/apache/incubator-openwhisk/pull/3504#issuecomment-378136038 OpenJ9 is open sourced implementation of Java Virtual Machine. **Please not that, the tools like jsta

[GitHub] chetanmeh commented on issue #3490: Move controller config to reference.conf

2018-04-02 Thread GitBox
chetanmeh commented on issue #3490: Move controller config to reference.conf URL: https://github.com/apache/incubator-openwhisk/pull/3490#issuecomment-378125525 Gentle reminder for the review? Would like to merge this as its blocking long pending #3243 ---

[GitHub] jiangpengcheng closed issue #3458: producer.send() is not full asynchronous

2018-04-02 Thread GitBox
jiangpengcheng closed issue #3458: producer.send() is not full asynchronous URL: https://github.com/apache/incubator-openwhisk/issues/3458 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] mdeuser commented on issue #259: For Ease of Maintenance, Update and Decide Where these Tests Should Live

2018-04-02 Thread GitBox
mdeuser commented on issue #259: For Ease of Maintenance, Update and Decide Where these Tests Should Live URL: https://github.com/apache/incubator-openwhisk-cli/issues/259#issuecomment-378099355 @drcariel - when a file in the description has been striked through, what does that mean? .. t

[GitHub] csantanapr commented on issue #63: style: add .editorconfig, eslint and reformat js file

2018-04-02 Thread GitBox
csantanapr commented on issue #63: style: add .editorconfig, eslint and reformat js file URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-378099049 @jthomas go ahead and merge if you are OK T

[GitHub] mdeuser commented on issue #262: rely on single base test versions from incubator openwhisk

2018-04-02 Thread GitBox
mdeuser commented on issue #262: rely on single base test versions from incubator openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#issuecomment-378099034 need to retain api gw testing with the cli for now. --

[GitHub] ScottChapman commented on a change in pull request #110: Add support for __OW_IGNORE_CERT env var

2018-04-02 Thread GitBox
ScottChapman commented on a change in pull request #110: Add support for __OW_IGNORE_CERT env var URL: https://github.com/apache/incubator-openwhisk-client-js/pull/110#discussion_r178685248 ## File path: test/unit/client.test.js ## @@ -32,15 +32,18 @@ test('should use uui

[GitHub] ScottChapman commented on a change in pull request #110: Add support for __OW_IGNORE_CERT env var

2018-04-02 Thread GitBox
ScottChapman commented on a change in pull request #110: Add support for __OW_IGNORE_CERT env var URL: https://github.com/apache/incubator-openwhisk-client-js/pull/110#discussion_r178685104 ## File path: lib/client.js ## @@ -62,7 +62,10 @@ class Client { parse_option

[GitHub] rabbah commented on issue #262: rely on single base test versions from incubator openwhisk

2018-04-02 Thread GitBox
rabbah commented on issue #262: rely on single base test versions from incubator openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#issuecomment-378061750 > I am wondering if we aren't going to test APIGW functionality in the CLI anymore as those are the only te

[GitHub] dubee commented on a change in pull request #262: rely on single base test versions from incubator openwhisk

2018-04-02 Thread GitBox
dubee commented on a change in pull request #262: rely on single base test versions from incubator openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#discussion_r178659061 ## File path: tests/src/test/scala/system/basic/WskCliActionTests.scala ## @@

[GitHub] dubee commented on a change in pull request #262: rely on single base test versions from incubator openwhisk

2018-04-02 Thread GitBox
dubee commented on a change in pull request #262: rely on single base test versions from incubator openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#discussion_r178659176 ## File path: tests/src/test/scala/system/basic/WskCliBasicNodeTests.scala ##

[GitHub] dubee commented on a change in pull request #262: rely on single base test versions from incubator openwhisk

2018-04-02 Thread GitBox
dubee commented on a change in pull request #262: rely on single base test versions from incubator openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#discussion_r178659494 ## File path: tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala ##

[GitHub] dubee commented on a change in pull request #262: rely on single base test versions from incubator openwhisk

2018-04-02 Thread GitBox
dubee commented on a change in pull request #262: rely on single base test versions from incubator openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#discussion_r178659061 ## File path: tests/src/test/scala/system/basic/WskCliActionTests.scala ## @@

[GitHub] dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178657257 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -102,

[GitHub] dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178657257 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -102,

[GitHub] dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178657576 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -102,

[GitHub] bwmcadams commented on issue #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries

2018-04-02 Thread GitBox
bwmcadams commented on issue #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries URL: https://github.com/apache/incubator-openwhisk/pull/3471#issuecomment-378054246 @dubee "PG3 2084"? I'm not sure if I missed some context or something there

[GitHub] bwmcadams commented on issue #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries

2018-04-02 Thread GitBox
bwmcadams commented on issue #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries URL: https://github.com/apache/incubator-openwhisk/pull/3471#issuecomment-378054162 config parser tests removed. -

[GitHub] dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178657257 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -102,

[GitHub] dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178657168 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -102,

[GitHub] dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178657168 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -102,

[GitHub] dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178654286 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -102,

[GitHub] dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178654286 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -102,

[GitHub] dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
dubee commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178652735 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -91,7

[GitHub] mrutkows closed pull request #834: Adding support for conductor, web sequences, and converting to web actions for api gateway

2018-04-02 Thread GitBox
mrutkows closed pull request #834: Adding support for conductor, web sequences, and converting to web actions for api gateway URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/834 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it

[GitHub] mrutkows closed issue #713: Action: Web (action): Support alias key "web" in addition to "web-export"

2018-04-02 Thread GitBox
mrutkows closed issue #713: Action: Web (action): Support alias key "web" in addition to "web-export" URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/713 This is an automated message from the Apache Git S

[GitHub] mrutkows closed issue #752: Automatically add "web-export" to each Action referenced in the "apis" (key) section

2018-04-02 Thread GitBox
mrutkows closed issue #752: Automatically add "web-export" to each Action referenced in the "apis" (key) section URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/752 This is an automated message from the A

[GitHub] mrutkows closed issue #782: Introduce Conductor in manifest/deployment file

2018-04-02 Thread GitBox
mrutkows closed issue #782: Introduce Conductor in manifest/deployment file URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/782 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] ert78gb commented on a change in pull request #110: Add support for __OW_IGNORE_CERT env var

2018-04-02 Thread GitBox
ert78gb commented on a change in pull request #110: Add support for __OW_IGNORE_CERT env var URL: https://github.com/apache/incubator-openwhisk-client-js/pull/110#discussion_r178646642 ## File path: test/unit/client.test.js ## @@ -32,15 +32,18 @@ test('should use uuid fro

[GitHub] ert78gb commented on a change in pull request #110: Add support for __OW_IGNORE_CERT env var

2018-04-02 Thread GitBox
ert78gb commented on a change in pull request #110: Add support for __OW_IGNORE_CERT env var URL: https://github.com/apache/incubator-openwhisk-client-js/pull/110#discussion_r178646113 ## File path: lib/client.js ## @@ -62,7 +62,10 @@ class Client { parse_options (op

[GitHub] regmebaby opened a new issue #3516: Undocumented Container-Reuse

2018-04-02 Thread GitBox
regmebaby opened a new issue #3516: Undocumented Container-Reuse URL: https://github.com/apache/incubator-openwhisk/issues/3516 Noticed a "bug" in the documentation: https://github.com/apache/incubator-openwhisk/blob/master/docs/about.md There is no word about container reuse o

[GitHub] jthomas commented on issue #63: style: add .editorconfig, eslint and reformat js file

2018-04-02 Thread GitBox
jthomas commented on issue #63: style: add .editorconfig, eslint and reformat js file URL: https://github.com/apache/incubator-openwhisk-client-js/pull/63#issuecomment-378032201 👋 @ert78gb. Thanks for the updates to this PR, everything looks perfect to me now 💯. If you have other re-facto

[GitHub] jonpspri commented on a change in pull request #3496: Add multi-arch runtimes doc

2018-04-02 Thread GitBox
jonpspri commented on a change in pull request #3496: Add multi-arch runtimes doc URL: https://github.com/apache/incubator-openwhisk/pull/3496#discussion_r178621810 ## File path: docs/runtimes-building.md ## @@ -0,0 +1,146 @@ + + +# Working with Runtimes locally + +This d

[GitHub] jonpspri commented on a change in pull request #3496: Add multi-arch runtimes doc

2018-04-02 Thread GitBox
jonpspri commented on a change in pull request #3496: Add multi-arch runtimes doc URL: https://github.com/apache/incubator-openwhisk/pull/3496#discussion_r178621805 ## File path: docs/runtimes-building.md ## @@ -0,0 +1,146 @@ + + +# Working with Runtimes locally + +This d

[GitHub] jonpspri commented on a change in pull request #3496: Add multi-arch runtimes doc

2018-04-02 Thread GitBox
jonpspri commented on a change in pull request #3496: Add multi-arch runtimes doc URL: https://github.com/apache/incubator-openwhisk/pull/3496#discussion_r178621312 ## File path: docs/runtimes-building.md ## @@ -0,0 +1,146 @@ + + +# Working with Runtimes locally + +This d

[GitHub] jonpspri commented on a change in pull request #28: Create a multi-architecture Docker image for the runtime

2018-04-02 Thread GitBox
jonpspri commented on a change in pull request #28: Create a multi-architecture Docker image for the runtime URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/28#discussion_r178612886 ## File path: .gitignore ## @@ -63,11 +63,8 @@ ansible/roles/nginx/

[GitHub] bwmcadams opened a new pull request #3515: Introduce separate Akka dispatchers for CouchDB and Kafka Clients (#2954)

2018-04-02 Thread GitBox
bwmcadams opened a new pull request #3515: Introduce separate Akka dispatchers for CouchDB and Kafka Clients (#2954) URL: https://github.com/apache/incubator-openwhisk/pull/3515 - Rest of system continues to use the default system dispatcher Refs #2954 ## Descr

[GitHub] jonpspri opened a new pull request #6: Multiarch framework for Go runtime

2018-04-02 Thread GitBox
jonpspri opened a new pull request #6: Multiarch framework for Go runtime URL: https://github.com/apache/incubator-openwhisk-runtime-go/pull/6 Hi all, this PR puts into place the framework I’ve been using for multi-architecture builds for all the other runtimes. It would behoove us to sta

[GitHub] jasonpet commented on issue #166: query_params should not be required when using filter

2018-04-02 Thread GitBox
jasonpet commented on issue #166: query_params should not be required when using filter URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/166#issuecomment-377992134 @mdeuser - you are referring to code in update trigger, not create trigger. -

[GitHub] mdeuser commented on issue #166: query_params should not be required when using filter

2018-04-02 Thread GitBox
mdeuser commented on issue #166: query_params should not be required when using filter URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/166#issuecomment-377990941 @jasonpet - small question about the following error message ```reject(sendError(400, 'At least one

[GitHub] dgrove-oss opened a new pull request #177: Test on both Kubernetes 1.7.4 and Kubernetes 1.8.8

2018-04-02 Thread GitBox
dgrove-oss opened a new pull request #177: Test on both Kubernetes 1.7.4 and Kubernetes 1.8.8 URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/177 Expand matrix to test multiple Kubernetes versions. Default OW_CONTAINER_FACTORY to docker in tools/travis/build.sh if

[GitHub] csantanapr closed pull request #166: query_params should not be required when using filter

2018-04-02 Thread GitBox
csantanapr closed pull request #166: query_params should not be required when using filter URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/166 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the s

[GitHub] eweiter commented on issue #264: A user reported that when doing 'wsk action get' on a zipped action the CLI "blows up the terminal"

2018-04-02 Thread GitBox
eweiter commented on issue #264: A user reported that when doing 'wsk action get' on a zipped action the CLI "blows up the terminal" URL: https://github.com/apache/incubator-openwhisk-cli/issues/264#issuecomment-377985416 Reported working as should. --

[GitHub] eweiter closed issue #264: A user reported that when doing 'wsk action get' on a zipped action the CLI "blows up the terminal"

2018-04-02 Thread GitBox
eweiter closed issue #264: A user reported that when doing 'wsk action get' on a zipped action the CLI "blows up the terminal" URL: https://github.com/apache/incubator-openwhisk-cli/issues/264 This is an automated message fr

[GitHub] jasonpet closed pull request #166: query_params should not be required when using filter

2018-04-02 Thread GitBox
jasonpet closed pull request #166: query_params should not be required when using filter URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/166 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sak

[GitHub] jasonpet opened a new pull request #166: query_params should not be required when using filter

2018-04-02 Thread GitBox
jasonpet opened a new pull request #166: query_params should not be required when using filter URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/166 fix for issue #165 This is an automated message from

[GitHub] eweiter opened a new issue #264: A user reported that when doing 'wsk action get' on a zipped action the CLI "blows up the terminal"

2018-04-02 Thread GitBox
eweiter opened a new issue #264: A user reported that when doing 'wsk action get' on a zipped action the CLI "blows up the terminal" URL: https://github.com/apache/incubator-openwhisk-cli/issues/264 A user reported that when they tried to do a `wsk action get` on a zipped Action (that appe

[GitHub] dubee closed pull request #3422: Only join cluster if seed nodes are provided.

2018-04-02 Thread GitBox
dubee closed pull request #3422: Only join cluster if seed nodes are provided. URL: https://github.com/apache/incubator-openwhisk/pull/3422 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[GitHub] rabbah commented on issue #3353: Fix the TLS issue with the CLI download

2018-04-02 Thread GitBox
rabbah commented on issue #3353: Fix the TLS issue with the CLI download URL: https://github.com/apache/incubator-openwhisk/pull/3353#issuecomment-377965035 It could still happen for outdated python versions and replacing with curl is an alternative. That said we hadn't any new complaint

[GitHub] dubee commented on issue #3353: Fix the TLS issue with the CLI download

2018-04-02 Thread GitBox
dubee commented on issue #3353: Fix the TLS issue with the CLI download URL: https://github.com/apache/incubator-openwhisk/pull/3353#issuecomment-377963474 @ddragosd, is this PR still valid? This is an automated message fro

[GitHub] dubee closed pull request #2910: [2862] Get protocol from client config base url

2018-04-02 Thread GitBox
dubee closed pull request #2910: [2862] Get protocol from client config base url URL: https://github.com/apache/incubator-openwhisk/pull/2910 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] dubee commented on issue #2910: [2862] Get protocol from client config base url

2018-04-02 Thread GitBox
dubee commented on issue #2910: [2862] Get protocol from client config base url URL: https://github.com/apache/incubator-openwhisk/pull/2910#issuecomment-377963245 Closing this one as the CLI has moved to incubator-openwhisk-cli and incubator-openwhisk-client-go. -

[GitHub] dubee commented on issue #2848: Support reading param.json from stdin #2837

2018-04-02 Thread GitBox
dubee commented on issue #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848#issuecomment-377962885 Closing this one as the CLI has moved to incubator-openwhisk-cli and incubator-openwhisk-client-go. -

[GitHub] dubee closed pull request #2848: Support reading param.json from stdin #2837

2018-04-02 Thread GitBox
dubee closed pull request #2848: Support reading param.json from stdin #2837 URL: https://github.com/apache/incubator-openwhisk/pull/2848 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] dubee commented on issue #3111: Replace our own clients with akka-streams-kafka.

2018-04-02 Thread GitBox
dubee commented on issue #3111: Replace our own clients with akka-streams-kafka. URL: https://github.com/apache/incubator-openwhisk/pull/3111#issuecomment-377962280 @markusthoemmes, is this still valid? This is an automated m

[GitHub] rabbah commented on issue #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries

2018-04-02 Thread GitBox
rabbah commented on issue #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries URL: https://github.com/apache/incubator-openwhisk/pull/3471#issuecomment-377961738 > @markusthoemmes you're probably right on the tests being overkill. Do you w

[GitHub] rabbah commented on issue #3507: allow use of string for controller id

2018-04-02 Thread GitBox
rabbah commented on issue #3507: allow use of string for controller id URL: https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-377961536 @cbickel's pr to factor out the TID to NGINX is probably better and avoid some of the underlying issue (see #3199). --

[GitHub] dubee closed pull request #3459: Wrap producer.send with Future

2018-04-02 Thread GitBox
dubee closed pull request #3459: Wrap producer.send with Future URL: https://github.com/apache/incubator-openwhisk/pull/3459 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] dubee commented on issue #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries

2018-04-02 Thread GitBox
dubee commented on issue #3471: Fixes #3470 - Changed hardcoded timeouts for idle containers and pause grace to config entries URL: https://github.com/apache/incubator-openwhisk/pull/3471#issuecomment-377961127 PG3 2084 ⏳ T

[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach

2018-04-02 Thread GitBox
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-377946685 This PR is now ready for review. Attachment inlining is done in a [separate branch][1] and can possibly be reviewed as part of sepa

[GitHub] jasonpet opened a new pull request #166: query_params should not be required when using filter

2018-04-02 Thread GitBox
jasonpet opened a new pull request #166: query_params should not be required when using filter URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/166 fix for issue #165 This is an automated message from

[GitHub] jasonpet closed pull request #166: query_params should not be required when using filter

2018-04-02 Thread GitBox
jasonpet closed pull request #166: query_params should not be required when using filter URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/166 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sak

[GitHub] drcariel commented on a change in pull request #262: rely on single base test versions from incubator openwhisk

2018-04-02 Thread GitBox
drcariel commented on a change in pull request #262: rely on single base test versions from incubator openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#discussion_r178561794 ## File path: tests/src/test/scala/system/basic/WskCliRuleTests.scala ## @

[GitHub] drcariel commented on a change in pull request #262: rely on single base test versions from incubator openwhisk

2018-04-02 Thread GitBox
drcariel commented on a change in pull request #262: rely on single base test versions from incubator openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#discussion_r178561658 ## File path: tests/src/test/scala/system/basic/WskCliActionTests.scala ##

[GitHub] drcariel commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
drcariel commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178561338 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -8

[GitHub] drcariel commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
drcariel commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178561118 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -9

[GitHub] chetanmeh commented on issue #3453: Introduce a AttachmentStore SPI

2018-04-02 Thread GitBox
chetanmeh commented on issue #3453: Introduce a AttachmentStore SPI URL: https://github.com/apache/incubator-openwhisk/pull/3453#issuecomment-377947469 Blocked on #3502 This is an automated message from the Apache Git Service

[GitHub] jasonpet opened a new pull request #166: query_params should not be required when using filter

2018-04-02 Thread GitBox
jasonpet opened a new pull request #166: query_params should not be required when using filter URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/166 fix for issue #165 This is an automated message from

[GitHub] chetanmeh commented on issue #3502: Immutable attachments via putAndAttach

2018-04-02 Thread GitBox
chetanmeh commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-377946685 This PR is now ready for review. Attachment inlining is done in a [separate branch][1] and can possibly be reviewed as part of sepa

[GitHub] dgrove-oss closed pull request #172: test both DockerContainerFactory and KubernetesContainerFactory

2018-04-02 Thread GitBox
dgrove-oss closed pull request #172: test both DockerContainerFactory and KubernetesContainerFactory URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/172 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] jasonpet commented on issue #165: Possible bug around empty query_params when filter is present

2018-04-02 Thread GitBox
jasonpet commented on issue #165: Possible bug around empty query_params when filter is present URL: https://github.com/apache/incubator-openwhisk-package-cloudant/issues/165#issuecomment-377945299 looks like a regression due to PR 164. query_params should not be required. --

[GitHub] eweiter commented on issue #165: Possible bug around empty query_params when filter is present

2018-04-02 Thread GitBox
eweiter commented on issue #165: Possible bug around empty query_params when filter is present URL: https://github.com/apache/incubator-openwhisk-package-cloudant/issues/165#issuecomment-377941842 @csantanapr This is the PR: https://github.com/apache/incubator-openwhisk-package-clouda

[GitHub] csantanapr commented on issue #165: Possible bug around empty query_params when filter is present

2018-04-02 Thread GitBox
csantanapr commented on issue #165: Possible bug around empty query_params when filter is present URL: https://github.com/apache/incubator-openwhisk-package-cloudant/issues/165#issuecomment-377938930 @eweiter >recent fix for validating the "query_params" to be correct JSON. Can

[GitHub] drcariel commented on a change in pull request #262: rely on single base test versions from incubator openwhisk

2018-04-02 Thread GitBox
drcariel commented on a change in pull request #262: rely on single base test versions from incubator openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/pull/262#discussion_r178552137 ## File path: tests/src/test/scala/system/basic/WskCliRuleTests.scala ## @

[GitHub] drcariel commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests

2018-04-02 Thread GitBox
drcariel commented on a change in pull request #3503: move CLI node tests to CLI repo and sync node default tests URL: https://github.com/apache/incubator-openwhisk/pull/3503#discussion_r178551945 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -8

[GitHub] eweiter opened a new issue #165: Possible bug around empty query_params when filter is present

2018-04-02 Thread GitBox
eweiter opened a new issue #165: Possible bug around empty query_params when filter is present URL: https://github.com/apache/incubator-openwhisk-package-cloudant/issues/165 This issue has two parts: 1) It was discovered that when trying to create a Cloudant Trigger if one specifies a "

[GitHub] csantanapr commented on issue #285: Multi-architecture build of API Gateway.

2018-04-02 Thread GitBox
csantanapr commented on issue #285: Multi-architecture build of API Gateway. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/285#issuecomment-377935179 Approach looks sound This is an automated message fro

[GitHub] jonpspri opened a new pull request #285: Multi-architecture build of API Gateway.

2018-04-02 Thread GitBox
jonpspri opened a new pull request #285: Multi-architecture build of API Gateway. URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/285 This ended up a lot more massive that I’d intended, but we’ll start with the big one and figure out what works and what doesn’t to get fr

[GitHub] neerajmangal opened a new issue #3514: CLI installation failed due to unzip command not found.

2018-04-02 Thread GitBox
neerajmangal opened a new issue #3514: CLI installation failed due to unzip command not found. URL: https://github.com/apache/incubator-openwhisk/issues/3514 ## Environment details: * Distributed Ubuntu ## Steps to reproduce the issue: 1. As part of installation whe

[GitHub] neerajmangal opened a new issue #3513: Enabling docker.user causes whiskhost playbook to fail.

2018-04-02 Thread GitBox
neerajmangal opened a new issue #3513: Enabling docker.user causes whiskhost playbook to fail. URL: https://github.com/apache/incubator-openwhisk/issues/3513 ## Environment details: Distributed Ubuntu. ## Steps to reproduce the issue: 1. enable docker.user setting in grou

[GitHub] jiangpengcheng opened a new issue #3511: the return data of `_bulk_doc` may not contain filed "rev", which will lead an spray json deserialization error

2018-04-02 Thread GitBox
jiangpengcheng opened a new issue #3511: the return data of `_bulk_doc` may not contain filed "rev", which will lead an spray json deserialization error URL: https://github.com/apache/incubator-openwhisk/issues/3511 The return data of `_bulk_docs` api of CouchDB is just like below if every

[GitHub] jiangpengcheng opened a new pull request #3512: wrap filed rev of BulkEntityResult using Option

2018-04-02 Thread GitBox
jiangpengcheng opened a new pull request #3512: wrap filed rev of BulkEntityResult using Option URL: https://github.com/apache/incubator-openwhisk/pull/3512 Some normal results of API `_bulk_docs` can not be deserialization to BulkEntityResult ## Description some items in the ret

[GitHub] Liu-HongYe commented on issue #3346: Integrate kube deployment?

2018-04-02 Thread GitBox
Liu-HongYe commented on issue #3346: Integrate kube deployment? URL: https://github.com/apache/incubator-openwhisk/issues/3346#issuecomment-377896930 How is it going? This is an automated message from the Apache Git Service.

[GitHub] style95 commented on issue #3106: Couchdb persistency

2018-04-02 Thread GitBox
style95 commented on issue #3106: Couchdb persistency URL: https://github.com/apache/incubator-openwhisk/pull/3106#issuecomment-377894867 Because of travis limitation, it seems custom image for couchdb is required to pass travis build. Would it be ok to go further in that direction? --