[GitHub] matt-boyd commented on issue #3691: README: Available typo

2018-05-24 Thread GitBox
matt-boyd commented on issue #3691: README: Available typo URL: https://github.com/apache/incubator-openwhisk/pull/3691#issuecomment-391957655 Yes! Signed the CLA! This is an automated message from the Apache Git Service. To

[GitHub] cmonkey commented on issue #3590: Collect test reports as part of log collection

2018-05-24 Thread GitBox
cmonkey commented on issue #3590: Collect test reports as part of log collection URL: https://github.com/apache/incubator-openwhisk/pull/3590#issuecomment-391949397 b!不b c But t e a a. . Ya jajtjj t. T W Carlos Santana 于 2018年5月3日周四 05:36写道: > *@csantanapr* requeste

[GitHub] chetanmeh commented on issue #3704: Provide invoker maintenance mode

2018-05-24 Thread GitBox
chetanmeh commented on issue #3704: Provide invoker maintenance mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391940408 I believe this is first management api over REST which allows change of state of system. Does this api has some form of security enabled

[GitHub] rabbah commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified.

2018-05-24 Thread GitBox
rabbah commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified. URL: https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-391929679 @csantanapr made the changes we discussed on Slack to disentangle the image pulls from th

[GitHub] rabbah commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified.

2018-05-24 Thread GitBox
rabbah commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified. URL: https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-391716877 relabeling `wip` to rework the pull/tag bits... maybe experiment with moving these bits i

[GitHub] rabbah commented on a change in pull request #41: remove use of state in nodejs app

2018-05-24 Thread GitBox
rabbah commented on a change in pull request #41: remove use of state in nodejs app URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#discussion_r190771688 ## File path: tests/src/test/scala/runtime/actionContainers/NodeJsActionContainerTests.scala ###

[GitHub] rabbah commented on issue #41: remove use of state in nodejs app

2018-05-24 Thread GitBox
rabbah commented on issue #41: remove use of state in nodejs app URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#issuecomment-391913875 @tysonnorris could we factor out the changes to `ActionContainer` to break the cyclic dependence? I looked over those specific c

[GitHub] codecov-io commented on issue #3687: Concurrency limit per action

2018-05-24 Thread GitBox
codecov-io commented on issue #3687: Concurrency limit per action URL: https://github.com/apache/incubator-openwhisk/pull/3687#issuecomment-391897951 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3687?src=pr&el=h1) Report > Merging [#3687](https://codecov.io/gh/apa

[GitHub] tysonnorris commented on issue #41: remove use of state in nodejs app

2018-05-24 Thread GitBox
tysonnorris commented on issue #41: remove use of state in nodejs app URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/41#issuecomment-391910983 Working on tests - they won't run till https://github.com/apache/incubator-openwhisk/pull/3687 (which could possibly suppl

[GitHub] houshengbo closed pull request #937: getting rid of node modules

2018-05-24 Thread GitBox
houshengbo closed pull request #937: getting rid of node modules URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/937 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] houshengbo closed pull request #939: introducing deployment to IBM cloud functions using exported manifest

2018-05-24 Thread GitBox
houshengbo closed pull request #939: introducing deployment to IBM cloud functions using exported manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/939 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] codecov-io commented on issue #3687: Concurrency limit per action

2018-05-24 Thread GitBox
codecov-io commented on issue #3687: Concurrency limit per action URL: https://github.com/apache/incubator-openwhisk/pull/3687#issuecomment-391897951 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3687?src=pr&el=h1) Report > Merging [#3687](https://codecov.io/gh/apa

[GitHub] ddragosd commented on issue #3671: Activation id in header

2018-05-24 Thread GitBox
ddragosd commented on issue #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-391897739 makes sense @rabbah . I'd say we can safely assume that the Gateway generates unique activation IDs.

[GitHub] rabbah commented on issue #3582: [Feature Request] Include activation ID in web action header.

2018-05-24 Thread GitBox
rabbah commented on issue #3582: [Feature Request] Include activation ID in web action header. URL: https://github.com/apache/incubator-openwhisk/issues/3582#issuecomment-391667371 I’m not suggesting we do that yet was wondering if someone else has given it some thought. There may be some

[GitHub] rabbah commented on issue #3582: [Feature Request] Include activation ID in web action header.

2018-05-24 Thread GitBox
rabbah commented on issue #3582: [Feature Request] Include activation ID in web action header. URL: https://github.com/apache/incubator-openwhisk/issues/3582#issuecomment-391667371 I’m not suggesting we do that yet was wondering if someone else has given it some thought. They may be some

[GitHub] rabbah commented on issue #3671: Activation id in header

2018-05-24 Thread GitBox
rabbah commented on issue #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-391895179 activation id needs to be unique to a namespace since it serves as part of the document id stored in the activation store (for metadata etc)... if th

[GitHub] ddragosd commented on issue #3671: Activation id in header

2018-05-24 Thread GitBox
ddragosd commented on issue #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-391894132 > should the two be the same Any reason they can't be the same ? This is a

[GitHub] rabbah commented on issue #3671: Activation id in header

2018-05-24 Thread GitBox
rabbah commented on issue #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-391893924 @ddragosd the request id isn't the activation id though --- although I raised the question in the related issue: should the two be the same in which

[GitHub] ddragosd commented on issue #3671: Activation id in header

2018-05-24 Thread GitBox
ddragosd commented on issue #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-391893653 Given that the API Gateway sets the `X-Request-Id` as per #3199 , wouldn't it be easier to have the Gateway add it to the response header as well

[GitHub] pritidesai opened a new pull request #939: introducing deployment to IBM cloud functions using exported manifest

2018-05-24 Thread GitBox
pritidesai opened a new pull request #939: introducing deployment to IBM cloud functions using exported manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/939 This is an automated message from the Apa

[GitHub] pritidesai closed issue #924: binary releases for a platform include binaries for all other platforms

2018-05-24 Thread GitBox
pritidesai closed issue #924: binary releases for a platform include binaries for all other platforms URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/924 This is an automated message from the Apache Git S

[GitHub] pritidesai closed pull request #938: Fix the format issue of the binaries

2018-05-24 Thread GitBox
pritidesai closed pull request #938: Fix the format issue of the binaries URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/938 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] houshengbo closed pull request #3702: Add ASF license to optional XML files and last gradle file.

2018-05-24 Thread GitBox
houshengbo closed pull request #3702: Add ASF license to optional XML files and last gradle file. URL: https://github.com/apache/incubator-openwhisk/pull/3702 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pr

[GitHub] houshengbo opened a new pull request #938: Fix the format issue of the binaries

2018-05-24 Thread GitBox
houshengbo opened a new pull request #938: Fix the format issue of the binaries URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/938 Closes: #924 This is an automated message from the Apache Git Service. To re

[GitHub] houshengbo closed pull request #41: Update scancode .cfg files to account for performance directory change.

2018-05-24 Thread GitBox
houshengbo closed pull request #41: Update scancode .cfg files to account for performance directory change. URL: https://github.com/apache/incubator-openwhisk-utilities/pull/41 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below

[GitHub] pritidesai opened a new pull request #937: getting rid of node modules

2018-05-24 Thread GitBox
pritidesai opened a new pull request #937: getting rid of node modules URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/937 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] mrutkows opened a new pull request #41: Update scancode .cfg files to account for performance directory change.

2018-05-24 Thread GitBox
mrutkows opened a new pull request #41: Update scancode .cfg files to account for performance directory change. URL: https://github.com/apache/incubator-openwhisk-utilities/pull/41 This is an automated message from the Apach

[GitHub] rabbah commented on issue #924: binary releases for a platform include binaries for all other platforms

2018-05-24 Thread GitBox
rabbah commented on issue #924: binary releases for a platform include binaries for all other platforms URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/924#issuecomment-391841091 I downloaded the Mac release but the binary is for Linux. ---

[GitHub] houshengbo commented on issue #924: binary releases for a platform include binaries for all other platforms

2018-05-24 Thread GitBox
houshengbo commented on issue #924: binary releases for a platform include binaries for all other platforms URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/924#issuecomment-391840422 @rabbah It is a mistake to add the additional tgz and zip files inside this artifact,

[GitHub] pritidesai closed pull request #936: Add the build_tag_release script back

2018-05-24 Thread GitBox
pritidesai closed pull request #936: Add the build_tag_release script back URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/936 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As t

[GitHub] tysonnorris opened a new pull request #3687: Concurrency limit per action

2018-05-24 Thread GitBox
tysonnorris opened a new pull request #3687: Concurrency limit per action URL: https://github.com/apache/incubator-openwhisk/pull/3687 ## Description After #2795 which only provides system-wider concurrency settings, this will allow per-action concurrency limit. T

[GitHub] tysonnorris closed pull request #3687: Concurrency limit per action

2018-05-24 Thread GitBox
tysonnorris closed pull request #3687: Concurrency limit per action URL: https://github.com/apache/incubator-openwhisk/pull/3687 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] houshengbo opened a new pull request #936: Add the build_tag_release script back

2018-05-24 Thread GitBox
houshengbo opened a new pull request #936: Add the build_tag_release script back URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/936 This is an automated message from the Apache Git Service. To respond to th

[GitHub] codecov-io commented on issue #3703: Add the license and notice for ConcurrentMapBackedCache.scala

2018-05-24 Thread GitBox
codecov-io commented on issue #3703: Add the license and notice for ConcurrentMapBackedCache.scala URL: https://github.com/apache/incubator-openwhisk/pull/3703#issuecomment-391831090 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr&el=h1) Report > Merging

[GitHub] codecov-io commented on issue #3703: Add the license and notice for ConcurrentMapBackedCache.scala

2018-05-24 Thread GitBox
codecov-io commented on issue #3703: Add the license and notice for ConcurrentMapBackedCache.scala URL: https://github.com/apache/incubator-openwhisk/pull/3703#issuecomment-391831090 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3703?src=pr&el=h1) Report > Merging

[GitHub] codecov-io commented on issue #3704: Provide invoker maintenance mode

2018-05-24 Thread GitBox
codecov-io commented on issue #3704: Provide invoker maintenance mode URL: https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr&el=h1) Report > Merging [#3704](https://codecov.io/gh

[GitHub] houshengbo closed pull request #935: WIP: Test the travis

2018-05-24 Thread GitBox
houshengbo closed pull request #935: WIP: Test the travis URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/935 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] houshengbo closed pull request #933: replacing cat with a simple helloworld example

2018-05-24 Thread GitBox
houshengbo closed pull request #933: replacing cat with a simple helloworld example URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/933 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[GitHub] houshengbo closed issue #932: Remove or credit the copied NPM `cat` package from test

2018-05-24 Thread GitBox
houshengbo closed issue #932: Remove or credit the copied NPM `cat` package from test URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/932 This is an automated message from the Apache Git Service. To respo

[GitHub] pritidesai closed pull request #934: Remove the redundant packages from the release artifacts

2018-05-24 Thread GitBox
pritidesai closed pull request #934: Remove the redundant packages from the release artifacts URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/934 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake

[GitHub] houshengbo opened a new pull request #935: WIP: Test the travis

2018-05-24 Thread GitBox
houshengbo opened a new pull request #935: WIP: Test the travis URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/935 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] dubee opened a new pull request #3704: Terminate invoker health scheduler via REST endpoint

2018-05-24 Thread GitBox
dubee opened a new pull request #3704: Terminate invoker health scheduler via REST endpoint URL: https://github.com/apache/incubator-openwhisk/pull/3704 Allows an invoker to manually be marked as down so that maintenance can be performed on the invoker. When in maintenance mode, the in

[GitHub] codecov-io commented on issue #3702: Add ASF license to optional XML files and last gradle file.

2018-05-24 Thread GitBox
codecov-io commented on issue #3702: Add ASF license to optional XML files and last gradle file. URL: https://github.com/apache/incubator-openwhisk/pull/3702#issuecomment-391810253 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3702?src=pr&el=h1) Report > Merging [

[GitHub] houshengbo opened a new pull request #3703: Add the license and notice for ConcurrentMapBackedCache.scala

2018-05-24 Thread GitBox
houshengbo opened a new pull request #3703: Add the license and notice for ConcurrentMapBackedCache.scala URL: https://github.com/apache/incubator-openwhisk/pull/3703 The source code file called ConcurrentMapBackedCache.scala uses the source code of Spray. Closes: apache/incubator

[GitHub] brunogirin commented on issue #899: wskdeploy export fails to export the `main` attribute for Java actions

2018-05-24 Thread GitBox
brunogirin commented on issue #899: wskdeploy export fails to export the `main` attribute for Java actions URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/899#issuecomment-391808765 I'll verify asap, thanks! -

[GitHub] houshengbo opened a new pull request #934: Remove the redundant packages from the release artufacts

2018-05-24 Thread GitBox
houshengbo opened a new pull request #934: Remove the redundant packages from the release artufacts URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/934 This is an automated message from the Apache Git Servi

[GitHub] mrutkows opened a new pull request #3702: Add ASF license to optional XML files and last gradle file.

2018-05-24 Thread GitBox
mrutkows opened a new pull request #3702: Add ASF license to optional XML files and last gradle file. URL: https://github.com/apache/incubator-openwhisk/pull/3702 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this chan

[GitHub] mrutkows closed pull request #3701: Add ASF license headers to optional files where possible.

2018-05-24 Thread GitBox
mrutkows closed pull request #3701: Add ASF license headers to optional files where possible. URL: https://github.com/apache/incubator-openwhisk/pull/3701 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of proven

[GitHub] mrutkows opened a new pull request #3701: Add ASF license headers to optional files where possible.

2018-05-24 Thread GitBox
mrutkows opened a new pull request #3701: Add ASF license headers to optional files where possible. URL: https://github.com/apache/incubator-openwhisk/pull/3701 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change

[GitHub] pritidesai opened a new pull request #933: replacing cat with a simple helloworld example

2018-05-24 Thread GitBox
pritidesai opened a new pull request #933: replacing cat with a simple helloworld example URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/933 Closes #932 This is an automated message from the Apache Git Ser

[GitHub] codecov-io commented on issue #3700: allow to override vagrant box os with trusty

2018-05-24 Thread GitBox
codecov-io commented on issue #3700: allow to override vagrant box os with trusty URL: https://github.com/apache/incubator-openwhisk/pull/3700#issuecomment-391790909 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700?src=pr&el=h1) Report > Merging [#3700](https://

[GitHub] codecov-io commented on issue #3700: allow to override vagrant box os with trusty

2018-05-24 Thread GitBox
codecov-io commented on issue #3700: allow to override vagrant box os with trusty URL: https://github.com/apache/incubator-openwhisk/pull/3700#issuecomment-391790909 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3700?src=pr&el=h1) Report > Merging [#3700](https://

[GitHub] dubee closed pull request #3692: Slightly expand description of ICLA process.

2018-05-24 Thread GitBox
dubee closed pull request #3692: Slightly expand description of ICLA process. URL: https://github.com/apache/incubator-openwhisk/pull/3692 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] dubee closed pull request #3695: Use method links and correct method name.

2018-05-24 Thread GitBox
dubee closed pull request #3695: Use method links and correct method name. URL: https://github.com/apache/incubator-openwhisk/pull/3695 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] csantanapr closed pull request #201: apigateway working with helm+minikube (NodePort)

2018-05-24 Thread GitBox
csantanapr closed pull request #201: apigateway working with helm+minikube (NodePort) URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/201 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of pro

[GitHub] csantanapr opened a new pull request #3700: allow to override vagrant box os with trusty

2018-05-24 Thread GitBox
csantanapr opened a new pull request #3700: allow to override vagrant box os with trusty URL: https://github.com/apache/incubator-openwhisk/pull/3700 ## Description allow to override vagrant box with trusty ## My changes affect the following components - [ ] API - [

[GitHub] csantanapr closed pull request #3696: Move the files under performance to tests/performance

2018-05-24 Thread GitBox
csantanapr closed pull request #3696: Move the files under performance to tests/performance URL: https://github.com/apache/incubator-openwhisk/pull/3696 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] houshengbo closed pull request #38: Make ASF license header exclusion listings as granular as possible.

2018-05-24 Thread GitBox
houshengbo closed pull request #38: Make ASF license header exclusion listings as granular as possible. URL: https://github.com/apache/incubator-openwhisk-utilities/pull/38 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] codecov-io commented on issue #118: add User-Agent to request header

2018-05-24 Thread GitBox
codecov-io commented on issue #118: add User-Agent to request header URL: https://github.com/apache/incubator-openwhisk-client-js/pull/118#issuecomment-391745379 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/118?src=pr&el=h1) Report > Merging [#118](https

[GitHub] mrutkows opened a new issue #932: Remove or credit the copied NPM `cat` package from test

2018-05-24 Thread GitBox
mrutkows opened a new issue #932: Remove or credit the copied NPM `cat` package from test URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/932 Either credit (for source code release) the copy of the NPM "cat" (which is MIT from searching NPM git repo.) or remove it as th

[GitHub] codecov-io commented on issue #3696: Move the files under performance to tests/performance

2018-05-24 Thread GitBox
codecov-io commented on issue #3696: Move the files under performance to tests/performance URL: https://github.com/apache/incubator-openwhisk/pull/3696#issuecomment-391564547 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3696?src=pr&el=h1) Report > Merging [#3696]

[GitHub] mrutkows opened a new issue #163: Exclude "tests" directories in source code release archives from all repos.

2018-05-24 Thread GitBox
mrutkows opened a new issue #163: Exclude "tests" directories in source code release archives from all repos. URL: https://github.com/apache/incubator-openwhisk-release/issues/163 It appears that we have many JAR and ZIP files where we do not have the source or the source is not compiled a

[GitHub] codecov-io commented on issue #118: add User-Agent to request header

2018-05-24 Thread GitBox
codecov-io commented on issue #118: add User-Agent to request header URL: https://github.com/apache/incubator-openwhisk-client-js/pull/118#issuecomment-391745379 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk-client-js/pull/118?src=pr&el=h1) Report > Merging [#118](https

[GitHub] starpit commented on issue #118: add User-Agent to request header

2018-05-24 Thread GitBox
starpit commented on issue #118: add User-Agent to request header URL: https://github.com/apache/incubator-openwhisk-client-js/pull/118#issuecomment-391744268 done and done This is an automated message from the Apache Git Ser

[GitHub] codecov-io commented on issue #3694: Add retries to CLI test framework for network errors

2018-05-24 Thread GitBox
codecov-io commented on issue #3694: Add retries to CLI test framework for network errors URL: https://github.com/apache/incubator-openwhisk/pull/3694#issuecomment-391475522 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr&el=h1) Report > Merging [#3694](

[GitHub] houshengbo commented on issue #3696: Move the files under performance to tests/performance

2018-05-24 Thread GitBox
houshengbo commented on issue #3696: Move the files under performance to tests/performance URL: https://github.com/apache/incubator-openwhisk/pull/3696#issuecomment-391734844 @csantanapr Yes, I changed that line. This is an

[GitHub] cbickel commented on a change in pull request #3671: Activation id in header

2018-05-24 Thread GitBox
cbickel commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190587631 ## File path: tests/src/test/scala/whisk/core/controller/test/ControllerTestCommon.scala ## @@ -91,6 +91,8 @@ pr

[GitHub] rabbah commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified.

2018-05-24 Thread GitBox
rabbah commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified. URL: https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-391716877 relabeling `wip` to rework the pull/tag bits... maybe experiment with moving these bits i

[GitHub] rabbah commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified.

2018-05-24 Thread GitBox
rabbah commented on issue #3680: Adjust invoker playbook to pull blackbox docker images when a prefix is specified. URL: https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-391716877 relabelling `wip` to rework the pull/tag bits... maybe experiment with moving these bits

[GitHub] cbickel commented on a change in pull request #3671: Activation id in header

2018-05-24 Thread GitBox
cbickel commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190587154 ## File path: core/controller/src/main/scala/whisk/core/controller/Entities.scala ## @@ -65,14 +65,25 @@ protecte

[GitHub] jthomas commented on issue #119: add support for retries

2018-05-24 Thread GitBox
jthomas commented on issue #119: add support for retries URL: https://github.com/apache/incubator-openwhisk-client-js/issues/119#issuecomment-391716059 @starpit can you provide more details? when does this happen any why? Th

[GitHub] dubee commented on issue #306: API URL with templated parameters in query parameters parsed incorrectly.

2018-05-24 Thread GitBox
dubee commented on issue #306: API URL with templated parameters in query parameters parsed incorrectly. URL: https://github.com/apache/incubator-openwhisk-cli/issues/306#issuecomment-391713246 @mdeuser, FYI. This is an au

[GitHub] starpit commented on issue #119: add support for retries

2018-05-24 Thread GitBox
starpit commented on issue #119: add support for retries URL: https://github.com/apache/incubator-openwhisk-client-js/issues/119#issuecomment-391708670 possibly, but every single user of this npm will face the issue, when talking on linux to ibm cloud.

[GitHub] kpavel closed pull request #918: Adds support for api export

2018-05-24 Thread GitBox
kpavel closed pull request #918: Adds support for api export URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/918 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] kpavel opened a new pull request #918: Adds support for api export

2018-05-24 Thread GitBox
kpavel opened a new pull request #918: Adds support for api export URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/918 Exporting APIs when its target action is managed by specified project This is an automate

[GitHub] codecov-io commented on issue #3699: Add gatling-throughput test for cold invocations.

2018-05-24 Thread GitBox
codecov-io commented on issue #3699: Add gatling-throughput test for cold invocations. URL: https://github.com/apache/incubator-openwhisk/pull/3699#issuecomment-391705629 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3699?src=pr&el=h1) Report > Merging [#3699](htt

[GitHub] codecov-io commented on issue #3669: Make stemcells configurable by deployment

2018-05-24 Thread GitBox
codecov-io commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389936897 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr&el=h1) Report > Merging [#3669](https://cod

[GitHub] codecov-io commented on issue #3669: Make stemcells configurable by deployment

2018-05-24 Thread GitBox
codecov-io commented on issue #3669: Make stemcells configurable by deployment URL: https://github.com/apache/incubator-openwhisk/pull/3669#issuecomment-389936897 # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3669?src=pr&el=h1) Report > Merging [#3669](https://cod

[GitHub] fmaschler commented on issue #3579: Using non root user in controller

2018-05-24 Thread GitBox
fmaschler commented on issue #3579: Using non root user in controller URL: https://github.com/apache/incubator-openwhisk/pull/3579#issuecomment-391695352 This is good when you talk about INSIDE containers but this is about the OUTSIDE: The containers process on the host runs as root. >

[GitHub] cbickel opened a new pull request #3699: Add gatling-throughput test for cold invocations.

2018-05-24 Thread GitBox
cbickel opened a new pull request #3699: Add gatling-throughput test for cold invocations. URL: https://github.com/apache/incubator-openwhisk/pull/3699 Add another gatling load test. It executes as much cold invocations as possible. ## Related issue and scope - [ ] I opened a

[GitHub] cbickel opened a new pull request #3698: Make amount of parallel docker runs configurable.

2018-05-24 Thread GitBox
cbickel opened a new pull request #3698: Make amount of parallel docker runs configurable. URL: https://github.com/apache/incubator-openwhisk/pull/3698 This PR makes the amount of parallel docker runs configurable. In addition, it reduces the amount of checks, if the database already exi

[GitHub] rabbah commented on issue #3582: [Feature Request] Include activation ID in web action header.

2018-05-24 Thread GitBox
rabbah commented on issue #3582: [Feature Request] Include activation ID in web action header. URL: https://github.com/apache/incubator-openwhisk/issues/3582#issuecomment-391667371 I’m not suggesting we do that was wondering if someone else has given it some thought. They may be some unin

[GitHub] jthomas commented on issue #119: add support for retries

2018-05-24 Thread GitBox
jthomas commented on issue #119: add support for retries URL: https://github.com/apache/incubator-openwhisk-client-js/issues/119#issuecomment-391663271 Implementing retry logic for connection errors is not normally the responsibility of the client library. This is not standard behaviour fo

[GitHub] rabbah commented on a change in pull request #3671: Activation id in header

2018-05-24 Thread GitBox
rabbah commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190532434 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -634,37 +634,40 @@ trai

[GitHub] rabbah commented on a change in pull request #3671: Activation id in header

2018-05-24 Thread GitBox
rabbah commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190532434 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -634,37 +634,40 @@ trai

[GitHub] rabbah commented on a change in pull request #3671: Activation id in header

2018-05-24 Thread GitBox
rabbah commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190532434 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -634,37 +634,40 @@ trai

[GitHub] style95 commented on issue #3671: Activation id in header

2018-05-24 Thread GitBox
style95 commented on issue #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#issuecomment-391659979 @rabbah Activation id header checking is added in existing tests. This is a

[GitHub] style95 commented on a change in pull request #3671: Activation id in header

2018-05-24 Thread GitBox
style95 commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190531314 ## File path: core/controller/src/main/scala/whisk/core/controller/Actions.scala ## @@ -257,24 +256,31 @@ trait W

[GitHub] jthomas closed pull request #128: Remove duplicated port setting

2018-05-24 Thread GitBox
jthomas closed pull request #128: Remove duplicated port setting URL: https://github.com/apache/incubator-openwhisk-devtools/pull/128 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fo

[GitHub] jthomas opened a new issue #304: API Gateway Path Parameters For Query Params?

2018-05-24 Thread GitBox
jthomas opened a new issue #304: API Gateway Path Parameters For Query Params? URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/304 Is it possible for the API Gateway to support mandatory query parameters? For example, the following URL structure. ``` /

[GitHub] jthomas opened a new issue #306: API URL with templated parameters in query parameters parsed incorrectly.

2018-05-24 Thread GitBox
jthomas opened a new issue #306: API URL with templated parameters in query parameters parsed incorrectly. URL: https://github.com/apache/incubator-openwhisk-cli/issues/306 User has reported an issue creating an API when including template parameters in both path and query URL parameters

[GitHub] style95 commented on issue #3582: [Feature Request] Include activation ID in web action header.

2018-05-24 Thread GitBox
style95 commented on issue #3582: [Feature Request] Include activation ID in web action header. URL: https://github.com/apache/incubator-openwhisk/issues/3582#issuecomment-391655987 @rabbah Yes I have seen transaction id is included in `X-Request-Id`, if it is ok to override it using acti

[GitHub] benemon opened a new issue #129: make quick-start hangs on setup phase

2018-05-24 Thread GitBox
benemon opened a new issue #129: make quick-start hangs on setup phase URL: https://github.com/apache/incubator-openwhisk-devtools/issues/129 When running `make quick-start`, the setup task hangs indefinitely after initialising openwhisk_minio_1, leading to a lot of dots appearing on the s

[GitHub] style95 commented on a change in pull request #3671: Activation id in header

2018-05-24 Thread GitBox
style95 commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190526404 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -634,37 +634,40 @@ tra

[GitHub] style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy

2018-05-24 Thread GitBox
style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy URL: https://github.com/apache/incubator-openwhisk/pull/3663#issuecomment-391654007 The basic idea behind above approach is, `ContainerProxy` and `ContainerPool` have strong correlation to each other. I

[GitHub] rabbah commented on a change in pull request #3671: Activation id in header

2018-05-24 Thread GitBox
rabbah commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190523911 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -634,37 +634,40 @@ trai

[GitHub] rabbah commented on a change in pull request #3671: Activation id in header

2018-05-24 Thread GitBox
rabbah commented on a change in pull request #3671: Activation id in header URL: https://github.com/apache/incubator-openwhisk/pull/3671#discussion_r190523185 ## File path: core/controller/src/main/scala/whisk/core/controller/Actions.scala ## @@ -257,24 +256,31 @@ trait Wh

[GitHub] rabbah commented on issue #3663: Support SPI for ContainerPool and ContainerProxy

2018-05-24 Thread GitBox
rabbah commented on issue #3663: Support SPI for ContainerPool and ContainerProxy URL: https://github.com/apache/incubator-openwhisk/pull/3663#issuecomment-391651443 Discalimer: i need to catch up on the tech exchange and various other write ups. But at first glance two adapters avoids co

[GitHub] style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy

2018-05-24 Thread GitBox
style95 commented on issue #3663: Support SPI for ContainerPool and ContainerProxy URL: https://github.com/apache/incubator-openwhisk/pull/3663#issuecomment-391650438 @tysonnorris suggested to use a single SPI implementation for `ContainerProxy` and `ContainerPool`. At first time,

[GitHub] rabbah commented on issue #3582: [Feature Request] Include activation ID in web action header.

2018-05-24 Thread GitBox
rabbah commented on issue #3582: [Feature Request] Include activation ID in web action header. URL: https://github.com/apache/incubator-openwhisk/issues/3582#issuecomment-391627594 Markus, Dominic have you thought about using the request id (aka tid) as the activation id? This would avoid

  1   2   >