markusthoemmes commented on issue #3507: allow use of string for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-395314428
Existential question: Should we have `ControllerInstanceId` and
`InvokerInstanceId`? I think with landing the TransactionId hea
mhamann commented on issue #304: API Gateway Path Parameters For Query Params?
URL:
https://github.com/apache/incubator-openwhisk-apigateway/issues/304#issuecomment-395296505
Path parameters are critical to the gateway routing the request, so there's
not much choice there. Query params are
codecov-io commented on issue #3694: Add retries to CLI test framework for
network errors
URL:
https://github.com/apache/incubator-openwhisk/pull/3694#issuecomment-391475522
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3694?src=pr&el=h1)
Report
> Merging
[#3694](
csantanapr commented on issue #212: Reorganize docs to steer users to Helm
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/212#issuecomment-395270148
the troubleshooting doc is very useful
This is an autom
csantanapr commented on issue #212: Reorganize docs to steer users to Helm
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/212#issuecomment-395270114
@dgrove-oss feel free to merge this version, or make adjustments and merge
-
csantanapr commented on a change in pull request #212: Reorganize docs to steer
users to Helm
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/212#discussion_r193606130
##
File path: README.md
##
@@ -56,88 +56,147 @@ Travis CI testing.
1.8.0 | 0.25.2 |
csantanapr commented on a change in pull request #212: Reorganize docs to steer
users to Helm
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/212#discussion_r193605918
##
File path: README.md
##
@@ -56,88 +56,147 @@ Travis CI testing.
1.8.0 | 0.25.2 |
csantanapr commented on a change in pull request #212: Reorganize docs to steer
users to Helm
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/212#discussion_r193605331
##
File path: README.md
##
@@ -26,23 +26,23 @@ This repository can be used to deploy
codecov-io commented on issue #3507: allow use of string for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-390280747
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3507?src=pr&el=h1)
Report
> Merging
[#3507](https://codecov.
dgrove-oss commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193573246
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,20
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193572556
##
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##
@@ -20
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193572050
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -113,
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193570701
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -113,13 +1
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193570372
##
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##
@@ -202,7 +
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193570048
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -113,
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193565511
##
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##
@@ -20
dgrove-oss commented on issue #212: Reorganize docs to steer users to Helm
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/212#issuecomment-395217659
@rabbah @csantanapr could one of you give this a review? Thanks!
--
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193562166
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,20 @@
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193562100
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,20 @@
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193561679
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,2
mrutkows commented on a change in pull request #950: Continue spec. conversion
to markdown and add navigation
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/950#discussion_r193553489
##
File path: specification/html/spec_actions.md
##
@@ -19,87 +19,44 @
codecov-io commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr&el=h1)
Report
> Merging
[#3704](https://codecov.
codecov-io commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr&el=h1)
Report
> Merging
[#3704](https://codecov.
dgrove-oss opened a new pull request #212: Reorganize docs to steer users to
Helm
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/212
Reorganize the documentation to make Helm the recommended way of
deploying OpenWhisk on Kubernetes. In the process, take an editing
houshengbo commented on issue #280: Add the DISCLAIMER file for Apache
incubator project
URL:
https://github.com/apache/incubator-openwhisk-catalog/pull/280#issuecomment-395197732
@rabbah the file DISCLAIMER.txt is a must for incubators. The Disclaimer
section is not as mandatory as the f
dubee commented on a change in pull request #3704: Provide graceful shutdown
for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193537921
##
File path:
common/scala/src/main/scala/whisk/core/connector/MessageConsumer.scala
##
@@ -163,6 +
dubee commented on a change in pull request #3704: Provide graceful shutdown
for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193537921
##
File path:
common/scala/src/main/scala/whisk/core/connector/MessageConsumer.scala
##
@@ -163,6 +
csantanapr closed issue #180: Add DISCLAIMER files to each openwhisk repo
URL: https://github.com/apache/incubator-openwhisk-release/issues/180
This is an automated message from the Apache Git Service.
To respond to the messa
csantanapr closed pull request #3727: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk/pull/3727
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenanc
csantanapr commented on issue #3727: Add the DISCLAIMER file for Apache
incubator project
URL:
https://github.com/apache/incubator-openwhisk/pull/3727#issuecomment-395187882
@rabbah I think this change is good compromise, leaves the current
instructions like we have them, and it doesn't h
codecov-io commented on issue #3727: Add the DISCLAIMER file for Apache
incubator project
URL:
https://github.com/apache/incubator-openwhisk/pull/3727#issuecomment-395187337
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3727?src=pr&el=h1)
Report
> Merging
[#3727](
houshengbo commented on issue #180: Add DISCLAIMER files to each openwhisk repo
URL:
https://github.com/apache/incubator-openwhisk-release/issues/180#issuecomment-395178697
@mrutkows I have added it to all the repos.
This is
houshengbo opened a new pull request #44: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-runtime-docker/pull/44
Partially-closes: apache/incubator-openwhisk-release#180
houshengbo opened a new pull request #28: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-runtime-python/pull/28
Partially-closes: apache/incubator-openwhisk-release#180
houshengbo opened a new pull request #26: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-runtime-php/pull/26
Partially-closes: apache/incubator-openwhisk-release#180
Th
csantanapr commented on a change in pull request #3720: Update the document
regarding Open JDK and Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#discussion_r193528834
##
File path: tools/macos/README.md
##
@@ -54,6 +54,24 @@ sudo easy_install pip
houshengbo opened a new pull request #65: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-runtime-swift/pull/65
Partially-closes: apache/incubator-openwhisk-release#180
houshengbo opened a new pull request #56: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/56
Partially-closes: apache/incubator-openwhisk-release#180
houshengbo opened a new issue #180: Add DISCLAIMER files to each openwhisk repo
URL: https://github.com/apache/incubator-openwhisk-release/issues/180
At the stage of being incubated, OpenWhisk projects need to include
DISCLAIMER in order to indicate that the project is under incubation in A
houshengbo commented on issue #180: Add DISCLAIMER files to each openwhisk repo
URL:
https://github.com/apache/incubator-openwhisk-release/issues/180#issuecomment-395178697
@mrutkows yes I am doing it.
This is an automated me
houshengbo opened a new pull request #57: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/57
Partially-closes: apache/incubator-openwhisk-release#180
T
houshengbo opened a new pull request #3727: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk/pull/3727
This PR adds the disclaimer based on Apache policy regarding incubation.
In addition, it changes the instruction about Open JDK fo
mrutkows commented on issue #180: Add DISCLAIMER files to each openwhisk repo
URL:
https://github.com/apache/incubator-openwhisk-release/issues/180#issuecomment-395176378
@houshengbo are you continuing to add them to the other release repos.? that
is:
incubator-openwhisk
incubator-op
mrutkows closed pull request #952: Add the DISCLAIMER file for Apache incubator
project
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/952
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of pro
mrutkows closed pull request #93: Add the DISCLAIMER file for Apache incubator
project
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/93
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of prove
mrutkows closed pull request #280: Add the DISCLAIMER file for Apache incubator
project
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/280
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of prove
mrutkows closed issue #180: Add DISCLAIMER files to each openwhisk repo
URL: https://github.com/apache/incubator-openwhisk-release/issues/180
This is an automated message from the Apache Git Service.
To respond to the message
mrutkows closed pull request #308: Add the DISCLAIMER file for Apache incubator
project
URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/308
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of pr
rabbah commented on a change in pull request #3720: Update the document
regarding Open JDK and Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#discussion_r193516165
##
File path: tools/macos/README.md
##
@@ -54,6 +54,24 @@ sudo easy_install pip
su
csantanapr commented on a change in pull request #3720: Update the document
regarding Open JDK and Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#discussion_r193515405
##
File path: tools/vagrant/Vagrantfile
##
@@ -87,7 +87,7 @@ Vagrant.configure(
csantanapr commented on a change in pull request #3720: Update the document
regarding Open JDK and Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#discussion_r193514608
##
File path: tools/macos/README.md
##
@@ -54,6 +54,24 @@ sudo easy_install pip
houshengbo opened a new pull request #952: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/952
Partially-closes: apache/incubator-openwhisk-release#180
Th
houshengbo opened a new pull request #93: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-client-go/pull/93
Partially-closes: apache/incubator-openwhisk-release#180
This
houshengbo opened a new pull request #312: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-cli/pull/312
Partially-closes: apache/incubator-openwhisk-release#180
This is
houshengbo opened a new pull request #308: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-apigateway/pull/308
Partially-closes: apache/incubator-openwhisk-release#180
T
houshengbo opened a new pull request #280: Add the DISCLAIMER file for Apache
incubator project
URL: https://github.com/apache/incubator-openwhisk-catalog/pull/280
Partially-closes: apache/incubator-openwhisk-release#180
This
dubee commented on issue #3726: Install nodejs in scala image
URL:
https://github.com/apache/incubator-openwhisk/pull/3726#issuecomment-395158045
Figured out a different way to do this.
This is an automated message from the A
houshengbo opened a new issue #180: Add DISCLAIMER files to each openwhisk repo
URL: https://github.com/apache/incubator-openwhisk-release/issues/180
At the stage of being incubated, OpenWhisk projects need to include
DISCLAIMER in order to indicate that the project is under incubation in A
codecov-io commented on issue #3726: Install nodejs in scala image
URL:
https://github.com/apache/incubator-openwhisk/pull/3726#issuecomment-395150659
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3726?src=pr&el=h1)
Report
> Merging
[#3726](https://codecov.io/gh/ap
dubee closed pull request #3726: Install nodejs in scala image
URL: https://github.com/apache/incubator-openwhisk/pull/3726
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
codecov-io commented on issue #3467: Remove actionControllers tests from
incubator-openwhisk repo
URL:
https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-386808429
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3467?src=pr&el=h1)
Report
> Merging
rabbah commented on issue #3726: Install nodejs in scala image
URL:
https://github.com/apache/incubator-openwhisk/pull/3726#issuecomment-395140067
Where is this needed (and why not install it just there?)
This is an autom
dubee commented on issue #3726: Install nodejs in scala image
URL:
https://github.com/apache/incubator-openwhisk/pull/3726#issuecomment-395139783
PG5 365 ⏳
This is an automated message from the Apache Git Service.
To respond
dubee opened a new pull request #3726: Install nodejs in scala image
URL: https://github.com/apache/incubator-openwhisk/pull/3726
## Description
## Related issue and scope
- [ ] I opened an issue to propose and discuss this change (#)
## My changes af
rabbah commented on issue #3467: Remove actionControllers tests from
incubator-openwhisk repo
URL:
https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-395131289
@csantanapr I rebased this PR and resolved the conflict. I believe the
latest changes address your concerns as
pritidesai opened a new pull request #951: API path parameters with adding
support for repsonse type HTTP
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/951
This is an automated message from the Apache Git
codecov-io commented on issue #3680: Adjust invoker playbook to pull docker
images when a prefix and tag is specified.
URL:
https://github.com/apache/incubator-openwhisk/pull/3680#issuecomment-390292471
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3680?src=pr&el=h1)
rabbah closed pull request #3718: Only get action metadata when working with
rules.
URL: https://github.com/apache/incubator-openwhisk/pull/3718
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As
dgrove-oss commented on issue #211: Controller pod shuts down with no errors
after start
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/issues/211#issuecomment-395073323
Great, glad it is working now.
This is
dgrove-oss closed issue #211: Controller pod shuts down with no errors after
start
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/211
This is an automated message from the Apache Git Service.
To respon
vcosqui commented on issue #211: Controller pod shuts down with no errors after
start
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/issues/211#issuecomment-395065959
Hello David,
apparently the error was caused by a typo in one of the couchdb configmap
parameters d
rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193384207
##
File path: docs/parameters.md
##
@@ -25,7 +25,7 @@ This page outlines how to configure parameters when
dep
remore commented on issue #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#issuecomment-395009644
@rabbah Thanks for catching this up. I have just sent an email to
`d...@openwhisk.incubator.apache.org` but correct me if the email address was
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193351872
##
File path: docs/reference.md
##
@@ -434,6 +434,14 @@ The following Composer packages are also available:
-
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193351829
##
File path: docs/reference.md
##
@@ -434,6 +434,14 @@ The following Composer packages are also available:
-
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193351680
##
File path: actionRuntimes/ruby2.5Action/Dockerfile
##
@@ -0,0 +1 @@
+FROM openwhisk/action-ruby-v2.5
Rev
remore commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193351775
##
File path: docs/parameters.md
##
@@ -25,7 +25,7 @@ This page outlines how to configure parameters when
dep
rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193316824
##
File path: docs/reference.md
##
@@ -434,6 +434,14 @@ The following Composer packages are also available:
-
rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193316114
##
File path: actionRuntimes/ruby2.5Action/Dockerfile
##
@@ -0,0 +1 @@
+FROM openwhisk/action-ruby-v2.5
Rev
rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193316683
##
File path: docs/reference.md
##
@@ -434,6 +434,14 @@ The following Composer packages are also available:
-
rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193316921
##
File path: settings.gradle
##
@@ -28,6 +28,7 @@ include 'actionRuntimes:swift3.1.1Action'
include 'actionR
rabbah commented on a change in pull request #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#discussion_r193316333
##
File path: docs/parameters.md
##
@@ -25,7 +25,7 @@ This page outlines how to configure parameters when
dep
rabbah commented on issue #3725: Add Ruby2.5 runtime support
URL:
https://github.com/apache/incubator-openwhisk/pull/3725#issuecomment-394968695
Thanks for this contribution!
Two comments:
1. The container tests should be in the runtime repository and we should
generally remo
83 matches
Mail list logo
