[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments

chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-413795573 @dubee Is there anything else to be addressed in this PR? Would like to have this merged early next week as there are 3 more PR to

[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments

chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-413110603 @dubee Good point. Update php runtime entry also to use attachment This

[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments

chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-412835996 > you may want to alert the dev-list about this change as it is rather significant. I have sent a mail [on dev][1] sometime back a

[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments

chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-412055273 @dubee new actions would be stored with `code` as object. That format was already being used by Java actions so should work fine.

[GitHub] chetanmeh commented on issue #3945: Treat action code as attachments

chetanmeh commented on issue #3945: Treat action code as attachments URL: https://github.com/apache/incubator-openwhisk/pull/3945#issuecomment-411022379 This PR is ready for review. One aspect which is still to be addressed is should we raise the default `max-inline-size` (defaults 16 KB)