csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370113952
I think I'm ready for review and final merge of this PR
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370113609
> With now 4.2 announced 4.1 is stable, so skip/remove 4.0 support only do
4.1 for now
Going to move this to a new
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301
Thanks @jthomas for the review and starting the work to externalize the
epilogue in to it's own library/package.
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370113363
Woot !
- [x] Improved error handled to give more descriptive messages, e.g.
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370113363
Woot !
- [ ] Improved error handled to give more descriptive messages, e.g.
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301
Thanks @jthomas for the review and starting the work to externalize the
epilogue in to it's own library/package.
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370058906
Woot !
- [x] Use @escaping instead for the callback
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370058906
Woot !
- [ ] Use @escaping instead for the callback
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370058906
Woot !
- [x] Use `@escaping` instead for the callback
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301
Thanks @jthomas for the review and starting the work to externalize the
epilogue in to it's own library/package.
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370057360
Woot !
- [ ] Refresh
again with latest 4.1 snapshot
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370056572
Woot !
- [ ] Finish with the Codable test cases
This
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370056572
Woot !
- [x] Finish with the Codable test cases
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370056572
Woot !
- [ ] Finish with the Codable test cases
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301
Thanks @jthomas for the review and starting the work to externalize the
epilogue in to it's own library/package.
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-370027301
Thanks @jthomas for the review and starting the work to externalize the
epilogue in to it's own library/package.
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-365519693
TODOs
- [x] Handle when input params is empty
- [x] Add tests cases for Codable
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-365519693
TODOs
- [x] Handle when input params is empty
- [ ] Add tests cases for Codable
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-365519693
TODOs
- [ ] Handle when input params is empty
- [ ] Add tests cases for Codable
csantanapr commented on issue #23: Add Codable Support for Swift 4.x
URL:
https://github.com/apache/incubator-openwhisk-runtime-swift/pull/23#issuecomment-365519578
Depends on #22
Closes #2
This is an automated message
20 matches
Mail list logo
