[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-08 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-321041935 Rebased for API experimental removal conflicts. This

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-08 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320978156 @mdeuser, anything else on this one? This is an

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-07 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320834166 PG3 976 ? . This is an automated message from the

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-07 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320804315 PG3 976. ? This is an automated message from the

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-07 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320804315 PG3 975. ? This is an automated message from the

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-07 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320675253 @mdeuser, any review comments? This is an automated

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-05 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320454465 @akrabat, @csantanapr, current code in the PR to has the described functionality. Just needs a final review. Feel free

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-04 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320374587 PG2 1909 ? This is an automated message from the

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-04 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320375177 @mdeuser, take another look. Made some updates to keep the current semantics in place.

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-04 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320374587 PG2 1909 ? This is an automated message from the

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-03 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320043982 With the implementation from this PR action1 will have annotations for key1, key2 and the web annotations when the

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-03 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320043982 With the implementation from this PR action1 will have annotations for key1, key2 and the web annotations when the

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-08-03 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-320042920 What is here works and will fix the issue. Problem is that the action update command with the web flag specified will

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-06-30 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-312331317 @mdeuser, @rabbah, the alternative here would be to always pass in a value of `false` into this line:

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-06-30 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-312331317 @mdeuser, @rabbah, the alternative here would be to always pass in a value of `false` into this line:

[GitHub] dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review)

2017-06-30 Thread git
dubeejw commented on issue #2435: Ensure Action Update Creates a Web Action (Review) URL: https://github.com/apache/incubator-openwhisk/pull/2435#issuecomment-312299689 @rabbah, recent a change went in that flipped the update flag to `true` for action updates