[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-05-05 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-386806002 Also tinkering with how the Docker URL is discovered, because the newer runtime build Gradles know their Dock

[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-27 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-376508199 Yeah, I ran across the trait in question in a couple places during my works on the runtimes. For the moment,

[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-26 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-376336913 @csantanapr @rabbah Please review. Moving ActionContainer and ResourceHelpers into a 'common.actionContainer

[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-26 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-376152622 Naming WIP again. I intend to find a home for at least `ActionContainer.scala` and `ResourceHelpers.scala` i

[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-24 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-375916468 @csantanapr @rabbah To be precise, these are the modules of concern (all from tests/src/test/scala/ac

[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-24 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-375916468 @csantanapr @rabbah To be precise, these are the modules of concern (all from tests/src/test/scala/ac

[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-22 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-375383358 Removing the WIP tag, because I’ve resolved the namespace oversights as I’ve moved through the runtimes. It’

[GitHub] jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo

2018-03-20 Thread GitBox
jonpspri commented on issue #3467: Remove actionControllers tests from incubator-openwhisk repo URL: https://github.com/apache/incubator-openwhisk/pull/3467#issuecomment-374624880 Maybe it can be, but should we move it into a different namespace from the runtime-specific code (maybe also