markusthoemmes commented on a change in pull request #4115: Don't react on
Completion message of blocking requests.
URL:
https://github.com/apache/incubator-openwhisk/pull/4115#discussion_r234927460
##########
File path:
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/ContainerProxy.scala
##########
@@ -497,10 +497,10 @@ class ContainerProxy(
}
// Sending active ack. Entirely asynchronous and not waited upon.
- if (job.msg.blocking) {
- activation.foreach(
+ val sendResult = if (job.msg.blocking) {
+ activation.map(
sendActiveAck(tid, _, job.msg.blocking, job.msg.rootControllerIndex,
job.msg.user.namespace.uuid, false))
Review comment:
We shoudl reconcile any errors here into a Future.successful or use
`onComplete` below. Otherwise you'll end up not sending the second message if
the first failed. Unlikely, but just a teeny bit more defensive. I'd go for
`onComplete` below, because that makes it more clear on the calling side, that
you don't care about errors.
FWIW I like this solution a lot better than the one before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
