[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-13 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132842737 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -173,16 +173,2

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-13 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132842354 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -173,16 +173,2

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-13 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132840748 ## File path: tests/src/test/scala/whisk/core/controller/test/TriggersApiTests.scala ## @@ -214,7 +21

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-13 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132838852 ## File path: tests/src/test/scala/whisk/core/controller/test/TriggersApiTests.scala ## @@ -214,7 +21

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132818376 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -137,29 +145,19 @@ t

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132818253 ## File path: core/controller/src/main/scala/whisk/core/controller/AuthenticatedRoute.scala ## @@ -38

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132818195 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -321,7 +328,19

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132818186 ## File path: core/controller/src/main/scala/whisk/core/controller/Activations.scala ## @@ -184,33 +1

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814115 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -118,7 +125

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814453 ## File path: core/controller/src/main/scala/whisk/core/controller/AuthenticatedRoute.scala ## @@ -38

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132813919 ## File path: core/controller/src/main/scala/whisk/core/controller/AuthenticatedRoute.scala ## @@ -38

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814453 ## File path: core/controller/src/main/scala/whisk/core/controller/AuthenticatedRoute.scala ## @@ -38

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814130 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -256,36 +26

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814387 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -502,25 +50

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814139 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -502,25 +50

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814387 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -502,25 +50

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814339 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +86,47 @@ tra

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130367222 ## File path: tests/src/test/scala/whisk/core/controller/test/TriggersApiTests.scala ## @@ -199,10 +2

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132813987 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +94,58 @@ tra

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132813861 ## File path: core/controller/src/main/scala/whisk/core/controller/Activations.scala ## @@ -184,33 +1

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814130 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -256,36 +26

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814115 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -118,7 +125

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814208 ## File path: tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala ## @@ -932,17

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132813801 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +86,47 @@ tra

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132805647 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +86,47 @@ tra

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814139 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -502,25 +50

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814048 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -321,7 +328,19

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814179 ## File path: tests/src/test/scala/whisk/core/controller/test/AuthenticateTests.scala ## @@ -113,61 +

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132813919 ## File path: core/controller/src/main/scala/whisk/core/controller/AuthenticatedRoute.scala ## @@ -38

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132805567 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +86,47 @@ tra

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132814012 ## File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala ## @@ -79,101 +77,82

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-08-09 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r132202766 ## File path: core/controller/src/main/scala/whisk/core/controller/Actions.scala ## @@ -619,18 +626,33

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130372110 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -118,7 +125

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130370264 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -251,36 +25

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130367459 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -72,7 +

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130364594 ## File path: core/controller/src/main/scala/whisk/core/controller/ApiUtils.scala ## @@ -105,7 +107,7

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130367222 ## File path: tests/src/test/scala/whisk/core/controller/test/TriggersApiTests.scala ## @@ -199,10 +2

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130363445 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +86,57 @@ tra

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130366069 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -251,36 +25

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130365579 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -118,7 +125

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130363331 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +94,58 @@ tra

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130366531 ## File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala ## @@ -503,8 +503,9 @@ obje

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130366310 ## File path: core/controller/src/main/scala/whisk/core/controller/WebActions.scala ## @@ -497,25 +49

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130365240 ## File path: core/controller/src/main/scala/whisk/core/controller/RestAPIs.scala ## @@ -1,292 +0,0 @@

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130364139 ## File path: core/controller/src/main/scala/whisk/core/controller/API.scala ## @@ -0,0 +1,275 @@ +/*

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130366873 ## File path: tests/src/test/scala/whisk/core/controller/test/ActivationsApiTests.scala ## @@ -72,7 +

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130363893 ## File path: core/controller/src/main/scala/whisk/core/controller/API.scala ## @@ -0,0 +1,275 @@ +/*

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130364920 ## File path: core/controller/src/main/scala/whisk/core/controller/Controller.scala ## @@ -208,8 +191

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130363710 ## File path: common/scala/src/main/scala/whisk/http/ErrorResponse.scala ## @@ -168,7 +168,7 @@ case c

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-31 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r130363005 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -86,39 +86,57 @@ tra

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-17 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127741152 ## File path: core/controller/src/main/scala/whisk/core/controller/API.scala ## @@ -0,0 +1,277 @@ +/*

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127038883 ## File path: common/scala/src/main/scala/whisk/http/BasicHttpService.scala ## @@ -19,56 +19,64 @@ pac

[GitHub] rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka

2017-07-12 Thread git
rabbah commented on a change in pull request #2218: Port Controller from Spray to Akka URL: https://github.com/apache/incubator-openwhisk/pull/2218#discussion_r127030713 ## File path: core/controller/src/main/scala/whisk/core/controller/Triggers.scala ## @@ -173,16 +174,2