Re: [I] ORC-1741: Respect decimal reader isRepeating flag [orc]

2024-07-24 Thread via GitHub
dongjoon-hyun closed issue #1989: ORC-1741: Respect decimal reader isRepeating flag URL: https://github.com/apache/orc/issues/1989 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] ORC-1741: Respect decimal reader isRepeating flag [orc]

2024-07-24 Thread via GitHub
dongjoon-hyun commented on issue #1989: URL: https://github.com/apache/orc/issues/1989#issuecomment-2249089454 This is resolved via https://github.com/apache/orc/commit/ded9d769a9f3f290d5b2ef80268487e562e64069 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] ORC-1741: Respect decimal reader isRepeating flag [orc]

2024-07-23 Thread via GitHub
dongjoon-hyun closed pull request #1960: ORC-1741: Respect decimal reader isRepeating flag URL: https://github.com/apache/orc/pull/1960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add a copyright messaging to the BpackingAvx512.hh [orc]

2024-07-22 Thread via GitHub
wgtmac commented on PR #1691: URL: https://github.com/apache/orc/pull/1691#issuecomment-2244181804 @wpleonardo Sorry to hear that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ORC-1748: Upgrade `commons-lang3` to 3.15.0 [orc]

2024-07-22 Thread via GitHub
cxzl25 closed pull request #1988: ORC-1748: Upgrade `commons-lang3` to 3.15.0 URL: https://github.com/apache/orc/pull/1988 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] ORC-1741: Respect decimal reader isRepeating flag [orc]

2024-07-22 Thread via GitHub
dongjoon-hyun commented on PR #1960: URL: https://github.com/apache/orc/pull/1960#issuecomment-2243556290 If that is your intention, please switch it to `Bug` instead of `Improvement` because we don't backport `Improvement` in `core` module. Anyway, that's too bad because we missed

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-3 to 1.5.6-4 in /java [orc]

2024-07-22 Thread via GitHub
dependabot[bot] commented on PR #1987: URL: https://github.com/apache/orc/pull/1987#issuecomment-2243550582 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

Re: [PR] Bump com.github.luben:zstd-jni from 1.5.6-3 to 1.5.6-4 in /java [orc]

2024-07-22 Thread via GitHub
dongjoon-hyun closed pull request #1987: Bump com.github.luben:zstd-jni from 1.5.6-3 to 1.5.6-4 in /java URL: https://github.com/apache/orc/pull/1987 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] ORC-1747: Upgrade `zstd-jni` to 1.5.6-4 [orc]

2024-07-22 Thread via GitHub
dongjoon-hyun closed pull request #1986: ORC-1747: Upgrade `zstd-jni` to 1.5.6-4 URL: https://github.com/apache/orc/pull/1986 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Add a copyright messaging to the BpackingAvx512.hh [orc]

2024-07-22 Thread via GitHub
wpleonardo commented on PR #1691: URL: https://github.com/apache/orc/pull/1691#issuecomment-2242930439 > > If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that

[PR] Bump org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0 in /java [orc]

2024-07-22 Thread via GitHub
dependabot[bot] opened a new pull request, #1988: URL: https://github.com/apache/orc/pull/1988 Bumps org.apache.commons:commons-lang3 from 3.14.0 to 3.15.0. [![Dependabot compatibility

[PR] Bump com.github.luben:zstd-jni from 1.5.6-3 to 1.5.6-4 in /java [orc]

2024-07-22 Thread via GitHub
dependabot[bot] opened a new pull request, #1987: URL: https://github.com/apache/orc/pull/1987 Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.6-3 to 1.5.6-4. Commits

Re: [PR] Add a copyright messaging to the BpackingAvx512.hh [orc]

2024-07-22 Thread via GitHub
CalvinKirs commented on PR #1691: URL: https://github.com/apache/orc/pull/1691#issuecomment-2242532253 > If we need to regard the code as third-party and remove ASF license header, some refactoring work is required to isolate code from Intel QPL and then add the copyright. It seems that

Re: [PR] ORC-1741: Respect decimal reader isRepeating flag [orc]

2024-07-21 Thread via GitHub
cxzl25 commented on code in PR #1960: URL: https://github.com/apache/orc/pull/1960#discussion_r1685963387 ## java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java: ## @@ -1562,7 +1563,11 @@ private void nextVector(DecimalColumnVector result, }

Re: [PR] ORC-1741: Respect decimal reader isRepeating flag [orc]

2024-07-21 Thread via GitHub
cxzl25 commented on PR #1960: URL: https://github.com/apache/orc/pull/1960#issuecomment-2242083787 > Which version is this PR targeting If the introduction of ORC-1266 causes Hive calculation results to be inaccurate, in order to ensure that Hive can use the 1.9.x version, I hope to

Re: [PR] ORC-1717: Add geometry type [orc-format]

2024-07-19 Thread via GitHub
dongjoon-hyun commented on PR #18: URL: https://github.com/apache/orc-format/pull/18#issuecomment-2240636648 Thank you! If it's finalized, please send a head-up email to dev@orc once more. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] ORC-1741: Respect decimal reader isRepeating flag [orc]

2024-07-19 Thread via GitHub
dongjoon-hyun commented on PR #1960: URL: https://github.com/apache/orc/pull/1960#issuecomment-2238163439 Which version is this PR targeting, @cxzl25 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] ORC-1717: Add geometry type [orc-format]

2024-07-18 Thread via GitHub
wgtmac commented on PR #18: URL: https://github.com/apache/orc-format/pull/18#issuecomment-2238245084 @dongjoon-hyun This is not finalized yet. I will update it once ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] ORC-1717: Add geometry type [orc-format]

2024-07-18 Thread via GitHub
dongjoon-hyun commented on PR #18: URL: https://github.com/apache/orc-format/pull/18#issuecomment-2238169119 Also, cc @williamhyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ORC-1717: Add geometry type [orc-format]

2024-07-18 Thread via GitHub
dongjoon-hyun commented on PR #18: URL: https://github.com/apache/orc-format/pull/18#issuecomment-2238168172 Thank you, @wgtmac . Is it for Apache ORC 1.1.0? If this is final, I'm +1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] ORC-1741: Respect decimal reader isRepeating flag [orc]

2024-07-18 Thread via GitHub
dongjoon-hyun commented on PR #1960: URL: https://github.com/apache/orc/pull/1960#issuecomment-2238165388 If this is not a bug, please set the milestone of this PR to ORC 2.1.0. Otherwise, please set the milestone to 1.9.5 and change the JIRA issue type from `Improvement` to `Bug`.

Re: [PR] MINOR: Fix syntax of DOAP [orc]

2024-07-18 Thread via GitHub
dongjoon-hyun commented on PR #1964: URL: https://github.com/apache/orc/pull/1964#issuecomment-2238162515 Merged to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] MINOR: Fix syntax of DOAP [orc]

2024-07-18 Thread via GitHub
dongjoon-hyun closed pull request #1964: MINOR: Fix syntax of DOAP URL: https://github.com/apache/orc/pull/1964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] How does hive.exec.orc.default.buffer.size affect the file size? [orc]

2024-07-18 Thread via GitHub
dongjoon-hyun commented on issue #1985: URL: https://github.com/apache/orc/issues/1985#issuecomment-2237089298 Could you share some sample reproducible data, @loukey-lj ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[I] How does hive.exec.orc.default.buffer.size affect the file size? [orc]

2024-07-17 Thread via GitHub
loukey-lj opened a new issue, #1985: URL: https://github.com/apache/orc/issues/1985 i write orc file use spark sql 3.3。 I noticed that in the production environment, many ORC files had small stripe sizes. So, I decided to adjust the value of hive.exec.orc.default.buffer.size from 256K

Re: [I] Release ORC 1.9.4 [orc]

2024-07-16 Thread via GitHub
williamhyun closed issue #1969: Release ORC 1.9.4 URL: https://github.com/apache/orc/issues/1969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] ORC-1746: Bump `netty-all` to 4.1.110.Final in `bench` module [orc]

2024-07-15 Thread via GitHub
dongjoon-hyun closed pull request #1984: ORC-1746: Bump `netty-all` to 4.1.110.Final in `bench` module URL: https://github.com/apache/orc/pull/1984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] ORC-1745: Remove `Ubuntu 20.04` Support [orc]

2024-07-15 Thread via GitHub
dongjoon-hyun closed pull request #1983: ORC-1745: Remove `Ubuntu 20.04` Support URL: https://github.com/apache/orc/pull/1983 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] ORC-1745: Remove `Ubuntu 20.04` Support [orc]

2024-07-15 Thread via GitHub
dongjoon-hyun commented on PR #1983: URL: https://github.com/apache/orc/pull/1983#issuecomment-2227897939 Thank you, @cxzl25 ! Merged to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] ORC-1746: Bump `netty-all` to 4.1.110.Final [orc]

2024-07-14 Thread via GitHub
cxzl25 opened a new pull request, #1984: URL: https://github.com/apache/orc/pull/1984 ### What changes were proposed in this pull request? This PR aims to bump `netty-all` to 4.1.110.Final. ### Why are the changes needed? 1. Align the netty version with Spark 4.0.0-preview1

Re: [PR] ORC-1745: Remove `Ubuntu 20.04` Support [orc]

2024-07-14 Thread via GitHub
dongjoon-hyun commented on PR #1983: URL: https://github.com/apache/orc/pull/1983#issuecomment-2227540244 Could you review this, @williamhyun ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] ORC-1745: Remove `Ubuntu 20.04` Support [orc]

2024-07-14 Thread via GitHub
dongjoon-hyun opened a new pull request, #1983: URL: https://github.com/apache/orc/pull/1983 ### What changes were proposed in this pull request? ### Why are the changes needed? ### How was this patch tested? ### Was this patch authored or

Re: [PR] ORC-1744: Add `ubuntu-24.04` to GitHub Action [orc]

2024-07-14 Thread via GitHub
dongjoon-hyun closed pull request #1982: ORC-1744: Add `ubuntu-24.04` to GitHub Action URL: https://github.com/apache/orc/pull/1982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ORC-1744: Add `ubuntu-24.04` to GitHub Action [orc]

2024-07-14 Thread via GitHub
dongjoon-hyun commented on PR #1982: URL: https://github.com/apache/orc/pull/1982#issuecomment-2227493770 CI passed. Since this is only an addition to the test coverage, let me merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] ORC-1744: Add `ubuntu-24.04` to GitHub Action [orc]

2024-07-14 Thread via GitHub
dongjoon-hyun opened a new pull request, #1982: URL: https://github.com/apache/orc/pull/1982 ### What changes were proposed in this pull request? ### Why are the changes needed? ### How was this patch tested? ### Was this patch authored or

Re: [PR] ORC-1743: Upgrade Spark to 4.0.0-preview1 [orc]

2024-07-12 Thread via GitHub
dongjoon-hyun closed pull request #1909: ORC-1743: Upgrade Spark to 4.0.0-preview1 URL: https://github.com/apache/orc/pull/1909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] ORC-1743: Upgrade Spark to 4.0.0-preview1 [orc]

2024-07-12 Thread via GitHub
dongjoon-hyun commented on PR #1909: URL: https://github.com/apache/orc/pull/1909#issuecomment-2225929205 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] ORC-1390: [C++] Support schema evolution from string group to decimal/timestamp [orc]

2024-07-12 Thread via GitHub
wgtmac commented on PR #1949: URL: https://github.com/apache/orc/pull/1949#issuecomment-2225926340 Thanks @ffacs and @dongjoon-hyun! I just merged it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] ORC-1390: [C++] Support schema evolution from string group to decimal/timestamp [orc]

2024-07-12 Thread via GitHub
wgtmac closed pull request #1949: ORC-1390: [C++] Support schema evolution from string group to decimal/timestamp URL: https://github.com/apache/orc/pull/1949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] ORC-1743: Upgrade Spark to 4.0.0-preview1 [orc]

2024-07-11 Thread via GitHub
cxzl25 commented on PR #1909: URL: https://github.com/apache/orc/pull/1909#issuecomment-2224563208 > If there is no further issue, shall we finalize this PR and merge with `4.0.0-preview1` I did some validation testing locally and I think the PR is ready to be merged. --

Re: [I] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on issue #1979: URL: https://github.com/apache/orc/issues/1979#issuecomment-2224002641 This is resolved via https://github.com/apache/orc/commit/55bb0de8f1968a6891521410bbe306542eeeffb7 -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun closed issue #1979: ORC-1738: [C++] Fix wrong Int128 maximum value URL: https://github.com/apache/orc/issues/1979 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on issue #1980: URL: https://github.com/apache/orc/issues/1980#issuecomment-2224002052 This is resolved via https://github.com/apache/orc/commit/552b9656ff2f1d3e2ac2a871ac30cc8e51d94c60 -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun closed issue #1980: ORC-1738: [C++] Fix wrong Int128 maximum value URL: https://github.com/apache/orc/issues/1980 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on issue #1981: URL: https://github.com/apache/orc/issues/1981#issuecomment-2224001181 This is resolved via https://github.com/apache/orc/commit/a7e10682fe277878fd5091dd46e3a46255a43d37 -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun closed issue #1981: ORC-1738: [C++] Fix wrong Int128 maximum value URL: https://github.com/apache/orc/issues/1981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] Release ORC 1.9.4 [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on issue #1969: URL: https://github.com/apache/orc/issues/1969#issuecomment-2223542337 Please let me know if you need any help for release preparation, @williamhyun . Thank you always! -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] ORC-1619: Add `MacOS 14` to GitHub Action [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on issue #1978: URL: https://github.com/apache/orc/issues/1978#issuecomment-2223504922 This is resolved via https://github.com/apache/orc/commit/1c9d91efbc8141c303ac3b95b3dd2d7eb8152239 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Test Spark 4.0.0-preview1 [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on PR #1909: URL: https://github.com/apache/orc/pull/1909#issuecomment-2223497359 If there is no further issue, shall we finalize this PR and merge with `4.0.0-preview1`, @cxzl25 ? -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] ORC-1540: Remove MacOS 11 from GitHub Action CI and docs [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on issue #1977: URL: https://github.com/apache/orc/issues/1977#issuecomment-2223487654 This is resolved via https://github.com/apache/orc/commit/9c934d3a1375ba5bd3f5d723f09b1ba05f2186c0 -- This is an automated message from the Apache Git Service. To respond to the

[I] ORC-1540: Remove MacOS 11 from GitHub Action CI and docs [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun opened a new issue, #1977: URL: https://github.com/apache/orc/issues/1977 This is a clone of #1678 MacOS 11 is removed from GitHub Action on July 10th, 2024. So, we need this at branch-1.7. - https://github.com/actions/runner-images/pull/10198 -- This is an

Re: [I] ORC-1540: Remove MacOS 11 from GitHub Action CI and docs [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on issue #1976: URL: https://github.com/apache/orc/issues/1976#issuecomment-2223482182 This is resolved via https://github.com/apache/orc/commit/a93d58a50699fb1a100f7c0d0fd2c75d6df655c0 -- This is an automated message from the Apache Git Service. To respond to the

[I] ORC-1540: Remove MacOS 11 from GitHub Action CI and docs [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun opened a new issue, #1976: URL: https://github.com/apache/orc/issues/1976 This is a clone of #1678 MacOS 11 is removed from GitHub Action on July 10th, 2024. So, we need this at branch-1.8. - https://github.com/actions/runner-images/pull/10198 -- This is an

Re: [I] ORC-1540: Remove MacOS 11 from GitHub Action CI and docs [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on issue #1975: URL: https://github.com/apache/orc/issues/1975#issuecomment-2223479869 This is resolved via https://github.com/apache/orc/commit/e3e86777e65a336e413a01cb4617825aa61482f4 -- This is an automated message from the Apache Git Service. To respond to the

[I] ORC-1540: Remove MacOS 11 from GitHub Action CI and docs [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun opened a new issue, #1975: URL: https://github.com/apache/orc/issues/1975 This is a clone of #1678 MacOS 11 is removed from GitHub Action on July 10th, 2024. So, we need this at branch-1.9. - https://github.com/actions/runner-images/pull/10198 -- This is an

Re: [PR] ORC-1540: Remove MacOS 11 from GitHub Action CI and docs [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on PR #1678: URL: https://github.com/apache/orc/pull/1678#issuecomment-2223472113 MacOS 11 is removed from GitHub Action on July 10th, 2024. So, I backported this to live release branches. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] ORC-1742: Suppor print the id, name and type of each column in dump tool [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun closed pull request #1974: ORC-1742: Suppor print the id, name and type of each column in dump tool URL: https://github.com/apache/orc/pull/1974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] ORC-1742: Suppor print the id, name and type of each column in dump tool [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on PR #1974: URL: https://github.com/apache/orc/pull/1974#issuecomment-2223291745 Merged to main/2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on PR #1963: URL: https://github.com/apache/orc/pull/1963#issuecomment-2223286671 Thank you, @luffy-zh , @wgtmac , @kou . Merged to main/2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun closed pull request #1963: ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS URL: https://github.com/apache/orc/pull/1963 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] ORC-1740: Avoid the dump tool repeatedly parsing ColumnStatistics [orc]

2024-07-11 Thread via GitHub
dongjoon-hyun commented on PR #1972: URL: https://github.com/apache/orc/pull/1972#issuecomment-2223280317 Thank you, @cxzl25 and @williamhyun . I cherry-pick this to `branch-2.0` because this is `java/tools`. -- This is an automated message from the Apache Git Service. To respond

Re: [PR] ORC-1742: Suppor print the id, name and type of each column in dump tool [orc]

2024-07-11 Thread via GitHub
cxzl25 commented on code in PR #1974: URL: https://github.com/apache/orc/pull/1974#discussion_r1673916633 ## java/tools/src/test/resources/orc-file-dump-column-type.out: ## @@ -0,0 +1,121 @@ +Structure for TestFileDump.testDump.orc +File Version: 0.12 with ORC_14 by ORC Java

Re: [I] [Java] Different semantic of lengths for CHAR(n) with C++ [orc]

2024-07-11 Thread via GitHub
ffacs commented on issue #1973: URL: https://github.com/apache/orc/issues/1973#issuecomment-406407 Hi @SiasDoming , it seems there is a proposal in 2015 to provide a option, but was not implemented yet. FYI: https://issues.apache.org/jira/browse/ORC-35 -- This is an automated

[I] [Java] Different semantic of lengths for CHAR(n) with C++ [orc]

2024-07-11 Thread via GitHub
SiasDoming opened a new issue, #1973: URL: https://github.com/apache/orc/issues/1973 I'm migrating from Core-C++ to Core-Java. But while reading data of type `CHAR(n)`, I found the `BytesColumnVector.length` in Java has a different semantic compared with `StringVectorBatch.length` in C++.

Re: [PR] ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS [orc]

2024-07-10 Thread via GitHub
luffy-zh commented on code in PR #1963: URL: https://github.com/apache/orc/pull/1963#discussion_r1673356581 ## .github/workflows/build_and_test.yml: ## @@ -197,3 +197,25 @@ jobs: with: config: .github/.licenserc.yaml + macos-cpp-check: +name: "C++

Re: [PR] ORC-1740: Avoid the dump tool repeatedly parsing ColumnStatistics [orc]

2024-07-10 Thread via GitHub
williamhyun closed pull request #1972: ORC-1740: Avoid the dump tool repeatedly parsing ColumnStatistics URL: https://github.com/apache/orc/pull/1972 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] ORC-1740: Avoid the dump tool repeatedly parsing ColumnStatistics [orc]

2024-07-10 Thread via GitHub
dongjoon-hyun commented on PR #1972: URL: https://github.com/apache/orc/pull/1972#issuecomment-2221094240 cc @williamhyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS [orc]

2024-07-10 Thread via GitHub
dongjoon-hyun commented on code in PR #1963: URL: https://github.com/apache/orc/pull/1963#discussion_r1672552594 ## .github/workflows/build_and_test.yml: ## @@ -197,3 +197,25 @@ jobs: with: config: .github/.licenserc.yaml + macos-cpp-check: +name:

Re: [PR] ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS [orc]

2024-07-10 Thread via GitHub
luffy-zh commented on code in PR #1963: URL: https://github.com/apache/orc/pull/1963#discussion_r1671956616 ## .github/workflows/build_and_test.yml: ## @@ -197,3 +197,25 @@ jobs: with: config: .github/.licenserc.yaml + macos-cpp-check: +name: "C++

Re: [PR] ORC-1739: Bump `spotbugs-maven-plugin` to 4.8.6.2 [orc]

2024-07-10 Thread via GitHub
dependabot[bot] commented on PR #1971: URL: https://github.com/apache/orc/pull/1971#issuecomment-2219680348 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

Re: [PR] ORC-1739: Bump `spotbugs-maven-plugin` to 4.8.6.2 [orc]

2024-07-10 Thread via GitHub
cxzl25 closed pull request #1971: ORC-1739: Bump `spotbugs-maven-plugin` to 4.8.6.2 URL: https://github.com/apache/orc/pull/1971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun commented on PR #1970: URL: https://github.com/apache/orc/pull/1970#issuecomment-2218476457 cc @williamhyun too because he is a release manager of ORC 1.9.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun commented on PR #1970: URL: https://github.com/apache/orc/pull/1970#issuecomment-2218475575 Welcome to the Apache ORC community, @letian-jiang . I added you to the Apache ORC contributor group and assigned ORC-1738 to you. Thank you again! -- This is an automated

Re: [PR] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun closed pull request #1970: ORC-1738: [C++] Fix wrong Int128 maximum value URL: https://github.com/apache/orc/pull/1970 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun commented on code in PR #1963: URL: https://github.com/apache/orc/pull/1963#discussion_r1671041204 ## .github/workflows/build_and_test.yml: ## @@ -197,3 +197,25 @@ jobs: with: config: .github/.licenserc.yaml + macos-cpp-check: +name:

Re: [PR] MINOR: Fix Patched Base doc in specification [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun commented on PR #1948: URL: https://github.com/apache/orc/pull/1948#issuecomment-2218462277 Merged to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] MINOR: Fix Patched Base doc in specification [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun closed pull request #1948: MINOR: Fix Patched Base doc in specification URL: https://github.com/apache/orc/pull/1948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Fix Patched Base doc in specification [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun commented on PR #1948: URL: https://github.com/apache/orc/pull/1948#issuecomment-2218461420 > @dongjoon-hyun We have duplicate content at https://github.com/apache/orc-format/tree/main/specification. Is it inevitable to maintain the two copies unless we have a orc-site repo?

Re: [PR] ORC-1724: JsonFileDump utility should print user metadata [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun closed pull request #1946: ORC-1724: JsonFileDump utility should print user metadata URL: https://github.com/apache/orc/pull/1946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] ORC-1700: Write parquet decimal type data in Benchmark using `FIXED_LEN_BYTE_ARRAY` type [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun commented on PR #1910: URL: https://github.com/apache/orc/pull/1910#issuecomment-2218457205 Merged to main/2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ORC-1700: Write parquet decimal type data in Benchmark using `FIXED_LEN_BYTE_ARRAY` type [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun commented on PR #1910: URL: https://github.com/apache/orc/pull/1910#issuecomment-2218456637 Sorry for the long delay. Thank you, @cxzl25 and @wgtmac . :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] ORC-1700: Write parquet decimal type data in Benchmark using `FIXED_LEN_BYTE_ARRAY` type [orc]

2024-07-09 Thread via GitHub
dongjoon-hyun closed pull request #1910: ORC-1700: Write parquet decimal type data in Benchmark using `FIXED_LEN_BYTE_ARRAY` type URL: https://github.com/apache/orc/pull/1910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] ORC-1738: [C++] Fix wrong Int128 maximum value [orc]

2024-07-09 Thread via GitHub
ffacs commented on PR #1970: URL: https://github.com/apache/orc/pull/1970#issuecomment-2218003753 It's an issue from day one; perhaps we should consider cherry-picking it into branch-1.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] Bump com.github.spotbugs:spotbugs-maven-plugin from 4.8.6.1 to 4.8.6.2 in /java [orc]

2024-07-08 Thread via GitHub
dependabot[bot] opened a new pull request, #1971: URL: https://github.com/apache/orc/pull/1971 Bumps [com.github.spotbugs:spotbugs-maven-plugin](https://github.com/spotbugs/spotbugs-maven-plugin) from 4.8.6.1 to 4.8.6.2. Release notes Sourced from

Re: [PR] ORC-1732: [C++] Fix detecting Homebrew-installed Protobuf on MacOS [orc]

2024-07-08 Thread via GitHub
kou commented on code in PR #1963: URL: https://github.com/apache/orc/pull/1963#discussion_r1668231591 ## cmake_modules/FindProtobuf.cmake: ## @@ -55,15 +64,34 @@ if (Protobuf_FOUND) get_target_property (target_type protobuf::libprotobuf TYPE) if (target_type

[PR] ORC-1738: Fix wrong Int128 maximum value [orc]

2024-07-06 Thread via GitHub
letian-jiang opened a new pull request, #1970: URL: https://github.com/apache/orc/pull/1970 ### What changes were proposed in this pull request? ### Why are the changes needed? The low part of Int128::maximumValue is wrong. In hex format, it should be

Re: [PR] Respect Decimal isRepeating flag [orc]

2024-07-04 Thread via GitHub
guiyanakuang commented on PR #1960: URL: https://github.com/apache/orc/pull/1960#issuecomment-2208881314 ``` private void setIsRepeatingIfNeeded(DecimalColumnVector result, int index) { if (result.isRepeating && index > 0 && (!result.vector[0].equals(result.vector[index])

Re: [PR] Respect Decimal isRepeating flag [orc]

2024-07-04 Thread via GitHub
guiyanakuang commented on PR #1960: URL: https://github.com/apache/orc/pull/1960#issuecomment-2208857254 @williamhyun, Thank you for the reminder. I reviewed the code again and found the root cause of the issue. I believe we need to update this patch to ensure a thorough fix for this bug.

Re: [PR] Respect Decimal isRepeating flag [orc]

2024-07-04 Thread via GitHub
cxzl25 commented on code in PR #1960: URL: https://github.com/apache/orc/pull/1960#discussion_r1665268089 ## java/core/src/java/org/apache/orc/impl/TreeReaderFactory.java: ## @@ -1562,7 +1563,11 @@ private void nextVector(DecimalColumnVector result, }

Re: [PR] ORC-1737: Bump `spotbugs-maven-plugin` to 4.8.6.1 [orc]

2024-07-04 Thread via GitHub
cxzl25 closed pull request #1968: ORC-1737: Bump `spotbugs-maven-plugin` to 4.8.6.1 URL: https://github.com/apache/orc/pull/1968 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] ORC-1737: Bump `spotbugs-maven-plugin` to 4.8.6.1 [orc]

2024-07-04 Thread via GitHub
dependabot[bot] commented on PR #1968: URL: https://github.com/apache/orc/pull/1968#issuecomment-2208288782 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me

Re: [PR] ORC-1736: Bump `junit` to 5.10.3 [orc]

2024-07-04 Thread via GitHub
dependabot[bot] commented on PR #1967: URL: https://github.com/apache/orc/pull/1967#issuecomment-2208284314 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by

Re: [PR] ORC-1736: Bump `junit` to 5.10.3 [orc]

2024-07-04 Thread via GitHub
cxzl25 closed pull request #1967: ORC-1736: Bump `junit` to 5.10.3 URL: https://github.com/apache/orc/pull/1967 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] ORC-1390: [C++] Support schema evolution from string group to decimal/timestamp [orc]

2024-07-03 Thread via GitHub
ffacs commented on code in PR #1949: URL: https://github.com/apache/orc/pull/1949#discussion_r1664221402 ## c++/src/ConvertColumnReader.cc: ## @@ -801,6 +821,196 @@ namespace orc { } }; + class StringVariantToTimestampColumnReader : public

Re: [PR] ORC-1390: [C++] Support schema evolution from string group to decimal/timestamp [orc]

2024-07-03 Thread via GitHub
ffacs commented on code in PR #1949: URL: https://github.com/apache/orc/pull/1949#discussion_r1664221116 ## c++/src/ConvertColumnReader.cc: ## @@ -801,6 +821,196 @@ namespace orc { } }; + class StringVariantToTimestampColumnReader : public

Re: [PR] ORC-1732:[C++] fix failure to detect Protobuf installed by Homebrew o… [orc]

2024-07-02 Thread via GitHub
wgtmac commented on code in PR #1963: URL: https://github.com/apache/orc/pull/1963#discussion_r1663450145 ## .github/workflows/build_and_test.yml: ## @@ -197,3 +197,29 @@ jobs: with: config: .github/.licenserc.yaml + macos-c++-check: +name: "C++ Test

Re: [PR] ORC-1732:[C++] fix failure to detect Protobuf installed by Homebrew o… [orc]

2024-07-02 Thread via GitHub
wgtmac commented on code in PR #1963: URL: https://github.com/apache/orc/pull/1963#discussion_r1663449700 ## .github/workflows/build_and_test.yml: ## @@ -197,3 +197,29 @@ jobs: with: config: .github/.licenserc.yaml + macos-c++-check: Review Comment:

Re: [PR] ORC-1732:[C++] fix failure to detect Protobuf installed by Homebrew o… [orc]

2024-07-02 Thread via GitHub
luffy-zh commented on code in PR #1963: URL: https://github.com/apache/orc/pull/1963#discussion_r1663446826 ## cmake_modules/FindProtobuf.cmake: ## @@ -55,15 +56,34 @@ if (Protobuf_FOUND) get_target_property (target_type protobuf::libprotobuf TYPE) if (target_type

[PR] Fix syntax of DOAP [orc]

2024-07-02 Thread via GitHub
raboof opened a new pull request, #1964: URL: https://github.com/apache/orc/pull/1964 ### What changes were proposed in this pull request? I'm having some trouble finding an authoritative reference, but it looks like a release (which is a property) may not contain multiple Versions

[PR] Bump org.apache.maven.plugins:maven-jar-plugin from 3.4.1 to 3.4.2 in /java [orc]

2024-06-24 Thread via GitHub
dependabot[bot] opened a new pull request, #1962: URL: https://github.com/apache/orc/pull/1962 Bumps [org.apache.maven.plugins:maven-jar-plugin](https://github.com/apache/maven-jar-plugin) from 3.4.1 to 3.4.2. Release notes Sourced from

  1   2   3   4   5   6   7   8   9   10   >