dongjoon-hyun commented on PR #1963:
URL: https://github.com/apache/orc/pull/1963#issuecomment-2223286671
Thank you, @luffy-zh , @wgtmac , @kou .
Merged to main/2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
dongjoon-hyun closed pull request #1963: ORC-1732: [C++] Fix detecting
Homebrew-installed Protobuf on MacOS
URL: https://github.com/apache/orc/pull/1963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
luffy-zh commented on code in PR #1963:
URL: https://github.com/apache/orc/pull/1963#discussion_r1673356581
##
.github/workflows/build_and_test.yml:
##
@@ -197,3 +197,25 @@ jobs:
with:
config: .github/.licenserc.yaml
+ macos-cpp-check:
+name: "C++ Test
dongjoon-hyun commented on code in PR #1963:
URL: https://github.com/apache/orc/pull/1963#discussion_r1672552594
##
.github/workflows/build_and_test.yml:
##
@@ -197,3 +197,25 @@ jobs:
with:
config: .github/.licenserc.yaml
+ macos-cpp-check:
+name: "C++
luffy-zh commented on code in PR #1963:
URL: https://github.com/apache/orc/pull/1963#discussion_r1671956616
##
.github/workflows/build_and_test.yml:
##
@@ -197,3 +197,25 @@ jobs:
with:
config: .github/.licenserc.yaml
+ macos-cpp-check:
+name: "C++ Test
dongjoon-hyun commented on code in PR #1963:
URL: https://github.com/apache/orc/pull/1963#discussion_r1671041204
##
.github/workflows/build_and_test.yml:
##
@@ -197,3 +197,25 @@ jobs:
with:
config: .github/.licenserc.yaml
+ macos-cpp-check:
+name: "C++
kou commented on code in PR #1963:
URL: https://github.com/apache/orc/pull/1963#discussion_r1668231591
##
cmake_modules/FindProtobuf.cmake:
##
@@ -55,15 +64,34 @@ if (Protobuf_FOUND)
get_target_property (target_type protobuf::libprotobuf TYPE)
if (target_type STREQUA
