Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-18 Thread via GitHub
weimingdiit commented on PR #7150: URL: https://github.com/apache/ozone/pull/7150#issuecomment-2357798756 Additional notes: 1. You can use different ini files to customize the rocksDB configuration of corresponding services (such as OM, SCM, DN). For example, you can create a file

Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-16 Thread via GitHub
weimingdiit commented on PR #7150: URL: https://github.com/apache/ozone/pull/7150#issuecomment-2353072859 @errose28 Hi, could you help review the pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-16 Thread via GitHub
weimingdiit commented on code in PR #7150: URL: https://github.com/apache/ozone/pull/7150#discussion_r1761261384 ## pom.xml: ## @@ -1531,6 +1531,17 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs org.rocksdb.Transactio

Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-13 Thread via GitHub
weimingdiit commented on PR #7150: URL: https://github.com/apache/ozone/pull/7150#issuecomment-2348231544 > > Do we have mechanism to control service specific usecase, like if OM, SCM and DN have different configuration, like WAL manual flush may need disable only for OM ? > > Probab

Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-06 Thread via GitHub
sadanand48 commented on PR #7150: URL: https://github.com/apache/ozone/pull/7150#issuecomment-2333406390 > Do we have mechanism to control service specific usecase, like if OM, SCM and DN have different configuration, like WAL manual flush may need disable only for OM ? Probably we c

Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-05 Thread via GitHub
sumitagrawl commented on PR #7150: URL: https://github.com/apache/ozone/pull/7150#issuecomment-2333241833 @weimingdiit Do we have mechanism to control service specific usecase, like if OM, SCM and DN have different configuration, like WAL manual flush may need disable only for OM ? -- Th

Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-03 Thread via GitHub
errose28 commented on PR #7150: URL: https://github.com/apache/ozone/pull/7150#issuecomment-2327495975 @kerneltime I agree. I made the same [suggestion](https://github.com/apache/ozone/pull/7117#issuecomment-2310925940) in #7117 with a pointer to the [RocksDB docs](https://github.com/faceb

Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-03 Thread via GitHub
kerneltime commented on PR #7150: URL: https://github.com/apache/ozone/pull/7150#issuecomment-2327118410 @weimingdiit instead of wrapping every config via Ozone, why not let Ozone specify the RockDB config file https://github.com/facebook/rocksdb/blob/5b40c0c074f16dae6e1d60a3c5d7aa3e7d63fdc

Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-03 Thread via GitHub
szetszwo commented on code in PR #7150: URL: https://github.com/apache/ozone/pull/7150#discussion_r1742328258 ## pom.xml: ## @@ -1531,6 +1531,17 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs org.rocksdb.TransactionLo

Re: [PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-03 Thread via GitHub
weimingdiit commented on PR #7150: URL: https://github.com/apache/ozone/pull/7150#issuecomment-2325853348 @jojochuang @szetszwo @adoroszlai Could you help review this PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[PR] HDDS-11404. Make RocksDB all parameters configurable. [ozone]

2024-09-03 Thread via GitHub
weimingdiit opened a new pull request, #7150: URL: https://github.com/apache/ozone/pull/7150 ## What changes were proposed in this pull request? Make RocksDB all parameters configurable. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-11404