swamirishi commented on PR #7188:
URL: https://github.com/apache/ozone/pull/7188#issuecomment-2348871920
Thank you for reviewing the PR @szetszwo @prashantpogde @aswinshakil
@adoroszlai @hemantk-12
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
swamirishi merged PR #7188:
URL: https://github.com/apache/ozone/pull/7188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apac
swamirishi commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1757533025
##
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##
@@ -437,17 +453,21 @@ private String addToBatch(Queue bu
swamirishi commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1757388443
##
hadoop-ozone/ozone-manager/dev-support/findbugsExcludeFile.xml:
##
@@ -89,4 +89,9 @@
+
+
+
+
+
Review Comment:
yeah I agree abou
swamirishi commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1757388443
##
hadoop-ozone/ozone-manager/dev-support/findbugsExcludeFile.xml:
##
@@ -89,4 +89,9 @@
+
+
+
+
+
Review Comment:
yeah I agree abou
szetszwo commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1757353630
##
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##
@@ -437,17 +453,21 @@ private String addToBatch(Queue buff
szetszwo commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1757338835
##
hadoop-ozone/ozone-manager/dev-support/findbugsExcludeFile.xml:
##
@@ -89,4 +89,9 @@
+
+
+
+
+
Review Comment:
The `splitReadyBuff
swamirishi commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1757333412
##
hadoop-ozone/ozone-manager/dev-support/findbugsExcludeFile.xml:
##
@@ -89,4 +89,9 @@
+
+
+
+
+
Review Comment:
We don't need an
szetszwo commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1757318617
##
hadoop-ozone/ozone-manager/dev-support/findbugsExcludeFile.xml:
##
@@ -89,4 +89,9 @@
+
+
+
+
+
Review Comment:
@swamirishi , How a
swamirishi commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1756987726
##
pom.xml:
##
@@ -1312,6 +1313,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xs
nimbus-jose-jwt
${com.nimbusd
adoroszlai commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1756912289
##
pom.xml:
##
@@ -1312,6 +1313,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xs
nimbus-jose-jwt
${com.nimbusd
adoroszlai commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1756912289
##
pom.xml:
##
@@ -1312,6 +1313,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xs
nimbus-jose-jwt
${com.nimbusd
swamirishi commented on PR #7188:
URL: https://github.com/apache/ozone/pull/7188#issuecomment-2346321603
@hemantk-12 please take a look at the patch again. There was a findbugs
failure. I added an annotation in OMDoubleBuffer class to suppress the warnings.
--
This is an automated message
swamirishi commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1755878436
##
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##
@@ -437,17 +448,22 @@ private String addToBatch(Queue bu
swamirishi commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1755772997
##
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##
@@ -437,17 +448,22 @@ private String addToBatch(Queue bu
hemantk-12 commented on code in PR #7188:
URL: https://github.com/apache/ozone/pull/7188#discussion_r1755766115
##
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java:
##
@@ -437,17 +448,22 @@ private String addToBatch(Queue bu
swamirishi opened a new pull request, #7188:
URL: https://github.com/apache/ozone/pull/7188
## What changes were proposed in this pull request?
Since purgeSnapshot transaction on a standalone basis is an idempotent
operation. Once the directory gets deleted the previous transactions that
17 matches
Mail list logo
