Re: [PR] HDDS-10742. Add option to close all pipelines [ozone]

2024-04-29 Thread via GitHub
errose28 commented on code in PR #6577: URL: https://github.com/apache/ozone/pull/6577#discussion_r1583761758 ## hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/ClosePipelineSubcommand.java: ## @@ -51,7 +51,7 @@ public class ClosePipelineSubcommand

Re: [PR] HDDS-10649. Handle auto hsync commit key having directories. [ozone]

2024-04-29 Thread via GitHub
jojochuang commented on code in PR #6530: URL: https://github.com/apache/ozone/pull/6530#discussion_r1583851920 ## hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/multipart/TestS3InitiateMultipartUploadRequestWithFSO.java: ## @@ -98,8 +98,6 @@

[jira] [Updated] (HDDS-10770) [Hsync] Allow overwrite hsynced file

2024-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-10770: -- Labels: pull-request-available (was: ) > [Hsync] Allow overwrite hsynced file >

[jira] [Commented] (HDDS-10736) [hsync] OMKeyCommitRequest should reject if client id doesn't match

2024-04-29 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842173#comment-17842173 ] Wei-Chiu Chuang commented on HDDS-10736: Yes inconsistency is possible. Another scenario is when

[jira] [Commented] (HDDS-10736) [hsync] OMKeyCommitRequest should reject if client id doesn't match

2024-04-29 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842226#comment-17842226 ] Sammi Chen commented on HDDS-10736: --- [~weichiu], after HDDS-10770 is applied, the above case client1,

[jira] [Commented] (HDDS-10736) [hsync] OMKeyCommitRequest should reject if client id doesn't match

2024-04-29 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842174#comment-17842174 ] Wei-Chiu Chuang commented on HDDS-10736: cc [~sammichen] this one looks related to HDDS-10770 >

Re: [PR] HDDS-10559. Add a warning or a check to run repair tool as System user [ozone]

2024-04-29 Thread via GitHub
DaveTeng0 commented on PR #6574: URL: https://github.com/apache/ozone/pull/6574#issuecomment-2083914958 > Thanks for adding this @DaveTeng0. The repair command could have uses on all nodes, not just OM. I think it is also difficult to figure out which user is usually being used to run each

Re: [PR] HDDS-10295. Provide an "ozone repair" subcommand to update the snapshot info in transactionInfoTable [ozone]

2024-04-29 Thread via GitHub
DaveTeng0 commented on code in PR #6533: URL: https://github.com/apache/ozone/pull/6533#discussion_r1583796513 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/om/TransactionInfoRepair.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

Re: [PR] HDDS-10559. Add a warning or a check to run repair tool as System user [ozone]

2024-04-29 Thread via GitHub
DaveTeng0 commented on code in PR #6574: URL: https://github.com/apache/ozone/pull/6574#discussion_r1583984050 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/OzoneRepair.java: ## @@ -61,4 +71,33 @@ public OzoneConfiguration getOzoneConf() { public static

Re: [PR] HDDS-10559. Add a warning or a check to run repair tool as System user [ozone]

2024-04-29 Thread via GitHub
DaveTeng0 commented on code in PR #6574: URL: https://github.com/apache/ozone/pull/6574#discussion_r1583990695 ## hadoop-ozone/tools/src/test/java/org/apache/hadoop/ozone/repair/TestOzoneRepair.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] HDDS-10295. Provide an "ozone repair" subcommand to update the snapshot info in transactionInfoTable [ozone]

2024-04-29 Thread via GitHub
DaveTeng0 commented on code in PR #6533: URL: https://github.com/apache/ozone/pull/6533#discussion_r1583793530 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java: ## @@ -0,0 +1,98 @@ +/** + * Licensed to the Apache Software

Re: [PR] HDDS-10295. Provide an "ozone repair" subcommand to update the snapshot info in transactionInfoTable [ozone]

2024-04-29 Thread via GitHub
DaveTeng0 commented on code in PR #6533: URL: https://github.com/apache/ozone/pull/6533#discussion_r1583792426 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/shell/TestOzoneRepairShell.java: ## @@ -0,0 +1,98 @@ +/** + * Licensed to the Apache Software

Re: [PR] HDDS-10770. [Hsync] Allow overwrite hsynced file [ozone]

2024-04-29 Thread via GitHub
jojochuang commented on code in PR #6603: URL: https://github.com/apache/ozone/pull/6603#discussion_r1583937646 ## hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/TestHSync.java: ## @@ -962,4 +966,300 @@ public void writeWithBigBuffer(boolean

Re: [PR] HDDS-10559. Add a warning or a check to run repair tool as System user [ozone]

2024-04-29 Thread via GitHub
DaveTeng0 commented on code in PR #6574: URL: https://github.com/apache/ozone/pull/6574#discussion_r1583988171 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/repair/OzoneRepair.java: ## @@ -22,8 +22,11 @@ import org.apache.hadoop.hdds.cli.GenericCli; import

[jira] [Updated] (HDDS-10770) [Hsync] Allow overwrite hsynced file

2024-04-29 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen updated HDDS-10770: -- Description: Case1 1. client1 open fileA with block1, write some data 2. client2 open fileA with

[jira] [Updated] (HDDS-10770) [Hsync] Allow overwrite hsynced file

2024-04-29 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen updated HDDS-10770: -- Attachment: screenshot-1.png > [Hsync] Allow overwrite hsynced file >

[jira] [Updated] (HDDS-10770) [Hsync] Allow overwrite hsynced file

2024-04-29 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen updated HDDS-10770: -- Description: Case1 1. client1 open fileA with block1, write some data 2. client2 open fileA with

Re: [PR] HDDS-10749. Shutdown datanode when RatisServer is down [ozone]

2024-04-29 Thread via GitHub
ChenSammi commented on PR #6587: URL: https://github.com/apache/ozone/pull/6587#issuecomment-2084368821 @adoroszlai , I noticed the impact to the integration test too. It looks like terminate the DN in ContainerStateMachine is not a good idea for DN. Let me think if there is other

[jira] [Assigned] (HDDS-10490) Intermittent NPE in TestSnapshotDiffManager#testLoadJobsOnStartUp

2024-04-29 Thread Raju Balpande (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raju Balpande reassigned HDDS-10490: Assignee: Muskan Mishra > Intermittent NPE in

Re: [PR] Add FSO repair tool to ozone CLI in read-only and repair modes [ozone]

2024-04-29 Thread via GitHub
DaveTeng0 commented on PR #6608: URL: https://github.com/apache/ozone/pull/6608#issuecomment-2083909916 cc. @errose28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Resolved] (HDDS-10736) [hsync] OMKeyCommitRequest should reject if client id doesn't match

2024-04-29 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HDDS-10736. Resolution: Duplicate > [hsync] OMKeyCommitRequest should reject if client id doesn't

[jira] [Commented] (HDDS-10739) OM down to InterruptedException 'Unable to process metadata snapshot request'

2024-04-29 Thread Jyotirmoy Sinha (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17841852#comment-17841852 ] Jyotirmoy Sinha commented on HDDS-10739: [~hemantk] - Thanks for the analysis. But are we then

Re: [PR] HDDS-10341. Implement a task/framework in Recon to sync full/delta SCM Metadata DB updates at regular intervals. [ozone]

2024-04-29 Thread via GitHub
ArafatKhan2198 commented on code in PR #6272: URL: https://github.com/apache/ozone/pull/6272#discussion_r1582598255 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/SCMDBMetaDataInitializationTask.java: ## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache

Re: [PR] HDDS-10649. Handle auto hsync commit key having directories. [ozone]

2024-04-29 Thread via GitHub
ChenSammi commented on code in PR #6530: URL: https://github.com/apache/ozone/pull/6530#discussion_r1582614237 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMFileRequest.java: ## @@ -472,15 +472,13 @@ public static void

Re: [PR] HDDS-10732. Add CRYPTO_COMPLIANCE tag to client checksum type and bytes per checksum configs [ozone]

2024-04-29 Thread via GitHub
adoroszlai merged PR #6606: URL: https://github.com/apache/ozone/pull/6606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HDDS-10732) Add CRYPTO_COMPLIANCE tag to client checksum type and bytes per checksum configs

2024-04-29 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-10732. - Fix Version/s: 1.5.0 Resolution: Implemented > Add CRYPTO_COMPLIANCE tag to

Re: [PR] HDDS-10657. Design Doc for overwriting a key if it has not changed [ozone]

2024-04-29 Thread via GitHub
sodonnel merged PR #6482: URL: https://github.com/apache/ozone/pull/6482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (HDDS-10773) Simplify OM RaftProperties formatting

2024-04-29 Thread Hongbing Wang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hongbing Wang updated HDDS-10773: - Summary: Simplify OM RaftProperties formatting (was: Simplify OM RaftProperties formatting to

[jira] [Created] (HDDS-10774) [hsync] Show deleted hsync keys in ListOpenFile CLI

2024-04-29 Thread Ashish Kumar (Jira)
Ashish Kumar created HDDS-10774: --- Summary: [hsync] Show deleted hsync keys in ListOpenFile CLI Key: HDDS-10774 URL: https://issues.apache.org/jira/browse/HDDS-10774 Project: Apache Ozone Issue

Re: [PR] HDDS-10568. When the ldb command is executed, it is output by line [ozone]

2024-04-29 Thread via GitHub
adoroszlai commented on PR #6420: URL: https://github.com/apache/ozone/pull/6420#issuecomment-2081979840 > In CI, it is prompted that File-related operations cannot be performed, such as mkdirs(). ``` M B RV: Exceptional return value of java.io.File.mkdirs() ignored in

[PR] HDDS-10732. Add CRYPTO_COMPLIANCE tag to client checksum type and bytes per checksum configs [ozone]

2024-04-29 Thread via GitHub
dombizita opened a new pull request, #6606: URL: https://github.com/apache/ozone/pull/6606 ## What changes were proposed in this pull request? I added the CRYPTO_COMPLIANCE tag to the `ozone.client.checksum.type` and `ozone.client.bytes.per.checksum` config options. ## What is

Re: [PR] HDDS-5570. security/SecuringOzoneHTTP.md translation [ozone]

2024-04-29 Thread via GitHub
ChenSammi commented on code in PR #6584: URL: https://github.com/apache/ozone/pull/6584#discussion_r1582692312 ## hadoop-hdds/docs/content/security/SecuringOzoneHTTP.zh.md: ## @@ -0,0 +1,130 @@ +--- +title: "安全化 HTTP" Review Comment: HTTP 安全配置 -- This is an automated

[jira] [Resolved] (HDDS-10769) Integration check no longer needs Ozone repo

2024-04-29 Thread Nandakumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nandakumar resolved HDDS-10769. --- Fix Version/s: 1.5.0 Resolution: Fixed The PR is now merged! Thanks [~adoroszlai] for the

[jira] [Updated] (HDDS-10775) Support bucket ownership verification

2024-04-29 Thread Ivan Andika (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Andika updated HDDS-10775: --- Description: Ozone bucket contains owner field. This can be used for S3 bucket owner condition

Re: [PR] HDDS-10341. Implement a task/framework in Recon to sync full/delta SCM Metadata DB updates at regular intervals. [ozone]

2024-04-29 Thread via GitHub
ArafatKhan2198 commented on code in PR #6272: URL: https://github.com/apache/ozone/pull/6272#discussion_r1582796709 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/SCMDBMetaDataInitializationTask.java: ## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache

Re: [PR] HDDS-10649. Handle auto hsync commit key having directories. [ozone]

2024-04-29 Thread via GitHub
ChenSammi commented on PR #6530: URL: https://github.com/apache/ozone/pull/6530#issuecomment-2082120271 > @ChenSammi I have made the change and the tests are running. One point is for hsync keys keyArgs are formed based on fileTable and not openFileTable in openKeyCleanupService. So even

Re: [PR] HDDS-10769. Integration check no longer needs Ozone repo [ozone]

2024-04-29 Thread via GitHub
nandakumar131 merged PR #6604: URL: https://github.com/apache/ozone/pull/6604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDDS-10769. Integration check no longer needs Ozone repo [ozone]

2024-04-29 Thread via GitHub
nandakumar131 commented on PR #6604: URL: https://github.com/apache/ozone/pull/6604#issuecomment-2082189263 Thanks @adoroszlai for the improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] HDDS-5570. security/SecuringOzoneHTTP.md translation [ozone]

2024-04-29 Thread via GitHub
ChenSammi merged PR #6584: URL: https://github.com/apache/ozone/pull/6584 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (HDDS-5570) security/SecuringOzoneHTTP.md translation

2024-04-29 Thread Sammi Chen (Jira)
[ https://issues.apache.org/jira/browse/HDDS-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sammi Chen resolved HDDS-5570. -- Fix Version/s: 1.5.0 Resolution: Fixed > security/SecuringOzoneHTTP.md translation >

[jira] [Resolved] (HDDS-10657) Design Doc for overwriting a key if it has not changed

2024-04-29 Thread Stephen O'Donnell (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen O'Donnell resolved HDDS-10657. -- Fix Version/s: 1.5.0 Resolution: Fixed > Design Doc for overwriting a key if it

Re: [PR] HDDS-10657. Design Doc for overwriting a key if it has not changed [ozone]

2024-04-29 Thread via GitHub
sodonnel commented on PR #6482: URL: https://github.com/apache/ozone/pull/6482#issuecomment-2082284845 I went ahead and merged it. We can create followup PRs based on the implementation, and I don't like "completed" PRs hanging around in the queue unnecessarily. -- This is an automated

[jira] [Updated] (HDDS-10773) Simplify OM RaftProperties formatting

2024-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-10773: -- Labels: pull-request-available (was: ) > Simplify OM RaftProperties formatting >

Re: [PR] HDDS-5570. security/SecuringOzoneHTTP.md translation [ozone]

2024-04-29 Thread via GitHub
ChenSammi commented on code in PR #6584: URL: https://github.com/apache/ozone/pull/6584#discussion_r1582692312 ## hadoop-hdds/docs/content/security/SecuringOzoneHTTP.zh.md: ## @@ -0,0 +1,130 @@ +--- +title: "安全化 HTTP" Review Comment: HTTP 安全配置 -- This is an automated

Re: [PR] HDDS-10769. Integration check no longer needs Ozone repo [ozone]

2024-04-29 Thread via GitHub
adoroszlai commented on PR #6604: URL: https://github.com/apache/ozone/pull/6604#issuecomment-2082194612 Thanks @nandakumar131 for reviewing and merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDDS-10341. Implement a task/framework in Recon to sync full/delta SCM Metadata DB updates at regular intervals. [ozone]

2024-04-29 Thread via GitHub
devmadhuu commented on PR #6272: URL: https://github.com/apache/ozone/pull/6272#issuecomment-2082312110 > The `SCMDBMetaDataInitializationTask` class is responsible for processing delta updates from the `SCM` database and applying them to the Recon component's in-memory data structures. It

[jira] [Updated] (HDDS-10732) Add CRYPTO_COMPLIANCE tag to client checksum type and bytes per checksum configs

2024-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-10732: -- Labels: pull-request-available (was: ) > Add CRYPTO_COMPLIANCE tag to client checksum type

[jira] [Updated] (HDDS-10750) Intermittent fork timeout while stopping Ratis server

2024-04-29 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-10750: Priority: Critical (was: Major) > Intermittent fork timeout while stopping Ratis server >

Re: [PR] HDDS-10649. Handle auto hsync commit key having directories. [ozone]

2024-04-29 Thread via GitHub
ChenSammi commented on code in PR #6530: URL: https://github.com/apache/ozone/pull/6530#discussion_r1582624089 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java: ## @@ -1849,7 +1849,7 @@ public ExpiredOpenKeys

Re: [PR] HDDS-10715. Remove Decommision nodes on replication [ozone]

2024-04-29 Thread via GitHub
symious commented on PR #6558: URL: https://github.com/apache/ozone/pull/6558#issuecomment-2082156007 @sodonnel PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Created] (HDDS-10775) Support bucket ownership verification

2024-04-29 Thread Ivan Andika (Jira)
Ivan Andika created HDDS-10775: -- Summary: Support bucket ownership verification Key: HDDS-10775 URL: https://issues.apache.org/jira/browse/HDDS-10775 Project: Apache Ozone Issue Type: Sub-task

Re: [PR] HDDS-10341. Implement a task/framework in Recon to sync full/delta SCM Metadata DB updates at regular intervals. [ozone]

2024-04-29 Thread via GitHub
devmadhuu commented on code in PR #6272: URL: https://github.com/apache/ozone/pull/6272#discussion_r1582795024 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/SCMDBMetaDataInitializationTask.java: ## @@ -0,0 +1,176 @@ +/* + * Licensed to the Apache

Re: [PR] HDDS-10435. Support S3 object tags for existing requests [ozone]

2024-04-29 Thread via GitHub
ivandika3 commented on PR #6607: URL: https://github.com/apache/ozone/pull/6607#issuecomment-2082350903 @vtutrinov @SaketaChalamchala @tanvipenumudy Could you help take a look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] HDDS-10732. Add CRYPTO_COMPLIANCE tag to client checksum type and bytes per checksum configs [ozone]

2024-04-29 Thread via GitHub
adoroszlai commented on PR #6606: URL: https://github.com/apache/ozone/pull/6606#issuecomment-2082422858 Thanks @dombizita for the patch, @fapifta, @Galsza for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HDDS-8188. Support max allowed length in response of ozone admin container list [ozone]

2024-04-29 Thread via GitHub
Galsza commented on code in PR #6497: URL: https://github.com/apache/ozone/pull/6497#discussion_r1582903438 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java: ## @@ -462,29 +465,47 @@ public List listContainer(long

Re: [PR] HDDS-10568. When the ldb command is executed, it is output by line [ozone]

2024-04-29 Thread via GitHub
jianghuazhu commented on PR #6420: URL: https://github.com/apache/ozone/pull/6420#issuecomment-2082527092 ci: https://github.com/jianghuazhu/ozone/actions/runs/8876637070 I've updated it. Can you help me look at this PR again, @errose28 @xichen01 @adoroszlai ? Thanks. -- This is

Re: [PR] HDDS-10744. Standardize byte array conversion to String for LiveFileMetaData in RocksDB. [ozone]

2024-04-29 Thread via GitHub
adoroszlai commented on PR #6580: URL: https://github.com/apache/ozone/pull/6580#issuecomment-2082581612 Thanks @fapifta for the patch, @Galsza, @szetszwo for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] HDDS-10744. Standardize byte array conversion to String for LiveFileMetaData in RocksDB. [ozone]

2024-04-29 Thread via GitHub
adoroszlai merged PR #6580: URL: https://github.com/apache/ozone/pull/6580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDDS-10751. Detect missing EC padding blocks [ozone]

2024-04-29 Thread via GitHub
siddhantsangwan commented on PR #6593: URL: https://github.com/apache/ozone/pull/6593#issuecomment-2082601059 > @siddhantsangwan would you like to take a look? I haven't followed last week's developments on this, so we don't need to wait for my review. Thanks for asking! -- This is an

Re: [PR] HDDS-10634. Recon - listKeys API for listing of OBS , FSO and Legacy bucket keys with filters. [ozone]

2024-04-29 Thread via GitHub
devmadhuu commented on code in PR #6503: URL: https://github.com/apache/ozone/pull/6503#discussion_r1583147434 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/FSOBucketHandler.java: ## @@ -146,49 +145,116 @@ public long calculateDUUnderObject(long

[jira] [Updated] (HDDS-10751) Detect missing EC padding blocks

2024-04-29 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated HDDS-10751: Fix Version/s: 1.5.0 Resolution: Implemented Status: Resolved (was:

Re: [PR] HDDS-10634. Recon - listKeys API for listing of OBS , FSO and Legacy bucket keys with filters. [ozone]

2024-04-29 Thread via GitHub
devmadhuu commented on PR #6503: URL: https://github.com/apache/ozone/pull/6503#issuecomment-2082889722 > Since this endpoint `/listKeys` is part of the various `NSSummaryEndpoints`, can we introduce an integration test for the endpoint as well? We currently do not have one, and in our

Re: [PR] HDDS-10634. Recon - listKeys API for listing of OBS , FSO and Legacy bucket keys with filters. [ozone]

2024-04-29 Thread via GitHub
devmadhuu commented on code in PR #6503: URL: https://github.com/apache/ozone/pull/6503#discussion_r1583177829 ## hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java: ## @@ -145,6 +146,12 @@ public class

Re: [PR] HDDS-10650. Delete hsync key info from openFileTable while deleting directory recursively. [ozone]

2024-04-29 Thread via GitHub
smengcl commented on PR #6495: URL: https://github.com/apache/ozone/pull/6495#issuecomment-2082918323 Hi @ashishkumar50 , do we need to cherry-pick this to `master` branch as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDDS-10608. Recon can't get full key when using Recon API. [ozone]

2024-04-29 Thread via GitHub
ArafatKhan2198 commented on code in PR #6492: URL: https://github.com/apache/ozone/pull/6492#discussion_r1583242681 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/codec/NSSummaryCodec.java: ## @@ -117,6 +120,14 @@ public NSSummary fromPersistedFormat(byte[]

[jira] [Updated] (HDDS-10650) Deleting Volume/Bucket/Directory doesn't remove key from OpenKeyTable

2024-04-29 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang updated HDDS-10650: --- Fix Version/s: HDDS-7593 (was: 1.5.0) > Deleting

Re: [PR] HDDS-10715. Remove Decommision nodes on replication [ozone]

2024-04-29 Thread via GitHub
sodonnel commented on code in PR #6558: URL: https://github.com/apache/ozone/pull/6558#discussion_r1583142984 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeManager.java: ## @@ -119,6 +122,24 @@ default void

Re: [PR] HDDS-10751. Detect missing EC padding blocks [ozone]

2024-04-29 Thread via GitHub
adoroszlai commented on PR #6593: URL: https://github.com/apache/ozone/pull/6593#issuecomment-2082838796 Thanks @siddhantsangwan, @sodonnel for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] HDDS-10751. Detect missing EC padding blocks [ozone]

2024-04-29 Thread via GitHub
adoroszlai merged PR #6593: URL: https://github.com/apache/ozone/pull/6593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDDS-10608. Recon can't get full key when using Recon API. [ozone]

2024-04-29 Thread via GitHub
sumitagrawl commented on code in PR #6492: URL: https://github.com/apache/ozone/pull/6492#discussion_r1583238548 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/codec/NSSummaryCodec.java: ## @@ -117,6 +120,14 @@ public NSSummary fromPersistedFormat(byte[]

Re: [PR] HDDS-10773. Simplify OM RaftProperties formatting [ozone]

2024-04-29 Thread via GitHub
szetszwo merged PR #6605: URL: https://github.com/apache/ozone/pull/6605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] HDDS-10634. Recon - listKeys API for listing of OBS , FSO and Legacy bucket keys with filters. [ozone]

2024-04-29 Thread via GitHub
devmadhuu commented on code in PR #6503: URL: https://github.com/apache/ozone/pull/6503#discussion_r1583177483 ## hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java: ## @@ -134,6 +134,7 @@ public class

[jira] [Assigned] (HDDS-10776) determine container pipeline information similar to blocks pipeline in HDFS

2024-04-29 Thread Krishna Kumar Asawa (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krishna Kumar Asawa reassigned HDDS-10776: -- Assignee: Tejaskriya Madhan > determine container pipeline information

Re: [PR] HDDS-10608. Recon can't get full key when using Recon API. [ozone]

2024-04-29 Thread via GitHub
ArafatKhan2198 commented on code in PR #6492: URL: https://github.com/apache/ozone/pull/6492#discussion_r1583212190 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/codec/NSSummaryCodec.java: ## @@ -110,13 +113,17 @@ public NSSummary fromPersistedFormat(byte[]

Re: [PR] HDDS-10746. Expose ssl.server.keystore.type and ssl.server.truststore.type to ozone-default.xml with CRYPTO_COMPLIANCE tag [ozone]

2024-04-29 Thread via GitHub
adoroszlai commented on PR #6595: URL: https://github.com/apache/ozone/pull/6595#issuecomment-2082423569 Thanks @Galsza for the patch, @fapifta for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] HDDS-10751. Detect missing EC padding blocks [ozone]

2024-04-29 Thread via GitHub
adoroszlai commented on PR #6593: URL: https://github.com/apache/ozone/pull/6593#issuecomment-2082474979 @siddhantsangwan would you like to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HDDS-8188. Support max allowed length in response of ozone admin container list [ozone]

2024-04-29 Thread via GitHub
Galsza commented on code in PR #6497: URL: https://github.com/apache/ozone/pull/6497#discussion_r1582903438 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java: ## @@ -462,29 +465,47 @@ public List listContainer(long

[jira] [Resolved] (HDDS-10744) Standardize byte array conversion to String for LiveFileMetaData in RocksDB

2024-04-29 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-10744. - Fix Version/s: 1.5.0 Resolution: Implemented > Standardize byte array conversion

Re: [PR] HDDS-10767. Reducing DatanodeDetails in the ContainerLocationCache [ozone]

2024-04-29 Thread via GitHub
guohao-rosicky closed pull request #6602: HDDS-10767. Reducing DatanodeDetails in the ContainerLocationCache URL: https://github.com/apache/ozone/pull/6602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] HDDS-10767. Reducing DatanodeDetails in the ContainerLocationCache [ozone]

2024-04-29 Thread via GitHub
guohao-rosicky commented on PR #6602: URL: https://github.com/apache/ozone/pull/6602#issuecomment-2082620494 My problem, I will delete this branch. @adoroszlai Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] HDDS-10634. Recon - listKeys API for listing of OBS , FSO and Legacy bucket keys with filters. [ozone]

2024-04-29 Thread via GitHub
devmadhuu commented on code in PR #6503: URL: https://github.com/apache/ozone/pull/6503#discussion_r1583050747 ## hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithOBSAndLegacy.java: ## @@ -904,6 +975,101 @@ public void

[jira] [Updated] (HDDS-10435) Support S3 object tags for existing requests

2024-04-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-10435: -- Labels: pull-request-available (was: ) > Support S3 object tags for existing requests >

[PR] HDDS-10435. Support S3 object tags for existing requests [ozone]

2024-04-29 Thread via GitHub
ivandika3 opened a new pull request, #6607: URL: https://github.com/apache/ozone/pull/6607 ## What changes were proposed in this pull request? This patch implements the fundamental changes to support object tags. This includes: - Protobuf field addition for support object tags

Re: [PR] HDDS-10649. Handle auto hsync commit key having directories. [ozone]

2024-04-29 Thread via GitHub
ashishkumar50 commented on PR #6530: URL: https://github.com/apache/ozone/pull/6530#issuecomment-2082559304 > > @ChenSammi I have made the change and the tests are running. One point is for hsync keys keyArgs are formed based on fileTable and not openFileTable in openKeyCleanupService. So

Re: [PR] HDDS-10568. When the ldb command is executed, it is output by line [ozone]

2024-04-29 Thread via GitHub
adoroszlai commented on PR #6420: URL: https://github.com/apache/ozone/pull/6420#issuecomment-2082573888 /ready -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HDDS-9626. [Recon] Disk Usage page with high number of key/bucket/volume [ozone]

2024-04-29 Thread via GitHub
smitajoshi12 commented on PR #6535: URL: https://github.com/apache/ozone/pull/6535#issuecomment-2082551771 > Thanks for working on this @smitajoshi12 While testing this patch locally I noticed a few discrepancies while setting the Display Limit :- > > * I currently have **56 keys**

[jira] [Created] (HDDS-10777) Error parsing xml in concurrent execution Complete Multipart Upload

2024-04-29 Thread GuoHao (Jira)
GuoHao created HDDS-10777: - Summary: Error parsing xml in concurrent execution Complete Multipart Upload Key: HDDS-10777 URL: https://issues.apache.org/jira/browse/HDDS-10777 Project: Apache Ozone

[jira] [Resolved] (HDDS-10746) Expose ssl.server.keystore.type and ssl.server.truststore.type to ozone-default.xml with CRYPTO_COMPLIANCE tag

2024-04-29 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai resolved HDDS-10746. - Fix Version/s: 1.5.0 Resolution: Implemented > Expose ssl.server.keystore.type

Re: [PR] HDDS-10746. Expose ssl.server.keystore.type and ssl.server.truststore.type to ozone-default.xml with CRYPTO_COMPLIANCE tag [ozone]

2024-04-29 Thread via GitHub
adoroszlai merged PR #6595: URL: https://github.com/apache/ozone/pull/6595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (HDDS-10776) determine container pipeline information similar to blocks pipeline in HDFS

2024-04-29 Thread Navin Kumar (Jira)
Navin Kumar created HDDS-10776: -- Summary: determine container pipeline information similar to blocks pipeline in HDFS Key: HDDS-10776 URL: https://issues.apache.org/jira/browse/HDDS-10776 Project:

[jira] [Commented] (HDDS-10739) OM down to InterruptedException 'Unable to process metadata snapshot request'

2024-04-29 Thread Hemant Kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842093#comment-17842093 ] Hemant Kumar commented on HDDS-10739: - This change is available in Ozone-1.4.0 because Ozone has

[jira] [Assigned] (HDDS-10739) OM down to InterruptedException 'Unable to process metadata snapshot request'

2024-04-29 Thread Hemant Kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hemant Kumar reassigned HDDS-10739: --- Assignee: Hemant Kumar > OM down to InterruptedException 'Unable to process metadata

Re: [PR] HDDS-10773. Simplify OM RaftProperties formatting [ozone]

2024-04-29 Thread via GitHub
whbing commented on PR #6605: URL: https://github.com/apache/ozone/pull/6605#issuecomment-2083077932 Thanks @szetszwo review and merge ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (HDDS-10739) OM down to InterruptedException 'Unable to process metadata snapshot request'

2024-04-29 Thread Hemant Kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842090#comment-17842090 ] Hemant Kumar commented on HDDS-10739: - As in the previous comments, OM crashed because StateMachine

[jira] [Resolved] (HDDS-10739) OM down to InterruptedException 'Unable to process metadata snapshot request'

2024-04-29 Thread Hemant Kumar (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hemant Kumar resolved HDDS-10739. - Fix Version/s: 1.4.0 Resolution: Fixed > OM down to InterruptedException 'Unable to

[jira] [Resolved] (HDDS-10773) Simplify OM RaftProperties formatting

2024-04-29 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze resolved HDDS-10773. --- Fix Version/s: 1.5.0 Resolution: Fixed The pull request is now merged. Thanks,

Re: [PR] HDDS-10608. Recon can't get full key when using Recon API. [ozone]

2024-04-29 Thread via GitHub
ArafatKhan2198 commented on code in PR #6492: URL: https://github.com/apache/ozone/pull/6492#discussion_r1583563556 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconUtils.java: ## @@ -246,25 +253,74 @@ public void untarCheckpointFile(File tarFile, Path

Re: [PR] HDDS-10608. Recon can't get full key when using Recon API. [ozone]

2024-04-29 Thread via GitHub
ArafatKhan2198 commented on PR #6492: URL: https://github.com/apache/ozone/pull/6492#issuecomment-2083407606 > @ArafatKhan2198 backward compatibility is still not resolved, please check comments reply Thanks for the find @sumitagrawl You are right if we try to read beyond the

[jira] [Resolved] (HDDS-10651) HBase WAL splitting fails due to lease recovery

2024-04-29 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HDDS-10651. Resolution: Not A Bug Resolve as not a bug. HDFS behaves the same. > HBase WAL splitting

[jira] [Resolved] (HDDS-10675) [Hsync] OverWrite using "sh key cp" shouldn't be allowed on hsynced files.

2024-04-29 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-10675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wei-Chiu Chuang resolved HDDS-10675. Resolution: Duplicate It duplicates HDDS-10670. Will continue the work over there. >

  1   2   >