sunxiaojian commented on PR #2815:
URL:
https://github.com/apache/incubator-paimon/pull/2815#issuecomment-1916262440
@yuzelin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
JingsongLi commented on code in PR #2789:
URL: https://github.com/apache/incubator-paimon/pull/2789#discussion_r1470702570
##
paimon-core/src/main/java/org/apache/paimon/catalog/AbstractCatalog.java:
##
@@ -54,32 +61,43 @@
import static org.apache.paimon.utils.Preconditions.che
JingsongLi opened a new pull request, #2817:
URL: https://github.com/apache/incubator-paimon/pull/2817
…
### Purpose
The previous approach made the file structure too complex, which is not
conducive to adding file compression in the future.
We can interact so
TaoZex commented on PR #2748:
URL:
https://github.com/apache/incubator-paimon/pull/2748#issuecomment-1916151074
> Hi @TaoZex, I browsed through your request and thx for ur work. In my
humble opinion, this PR contains lots of changes and can be separated into
several PRs in order to improve
TaoZex commented on code in PR #2748:
URL: https://github.com/apache/incubator-paimon/pull/2748#discussion_r1470636068
##
paimon-core/src/main/java/org/apache/paimon/utils/BranchManager.java:
##
@@ -72,6 +73,9 @@ public Path branchPath(String branchName) {
}
public v
TaoZex commented on code in PR #2748:
URL: https://github.com/apache/incubator-paimon/pull/2748#discussion_r1470634782
##
paimon-core/src/main/java/org/apache/paimon/utils/BranchManager.java:
##
@@ -72,6 +73,9 @@ public Path branchPath(String branchName) {
}
public v
TaoZex commented on code in PR #2748:
URL: https://github.com/apache/incubator-paimon/pull/2748#discussion_r1470634482
##
paimon-core/src/test/java/org/apache/paimon/table/FileStoreTableTestBase.java:
##
@@ -1240,6 +1248,50 @@ public void testSchemaPathOption() throws Exception
TaoZex commented on PR #2809:
URL:
https://github.com/apache/incubator-paimon/pull/2809#issuecomment-1916050236
Close this pr and I will reopen it when flink oracle cdc is more perfect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
TaoZex closed pull request #2809: [CDC]Support oracle sync table cdc
URL: https://github.com/apache/incubator-paimon/pull/2809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
JingsongLi merged PR #2808:
URL: https://github.com/apache/incubator-paimon/pull/2808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
XuQianJin-Stars commented on PR #2808:
URL:
https://github.com/apache/incubator-paimon/pull/2808#issuecomment-1916022713
Overall it looks like a good implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
harveyyue commented on PR #2813:
URL:
https://github.com/apache/incubator-paimon/pull/2813#issuecomment-1915979548
@yuzelin Could you help to look this pr? It will align decimal/set data
types to mysql/pg cdc.
--
This is an automated message from the Apache Git Service.
To respond to the
JingsongLi commented on code in PR #2760:
URL: https://github.com/apache/incubator-paimon/pull/2760#discussion_r1470517772
##
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalogOptions.java:
##
@@ -52,5 +52,13 @@ public final class HiveCatalogOptions
JingsongLi commented on code in PR #2760:
URL: https://github.com/apache/incubator-paimon/pull/2760#discussion_r1470517305
##
paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveCatalog.java:
##
@@ -439,14 +441,41 @@ protected void alterTableImpl(Identifier
FangYongs commented on code in PR #2748:
URL: https://github.com/apache/incubator-paimon/pull/2748#discussion_r1470514654
##
paimon-core/src/test/java/org/apache/paimon/table/FileStoreTableTestBase.java:
##
@@ -1240,6 +1248,50 @@ public void testSchemaPathOption() throws Excepti
wg1026688210 commented on PR #2749:
URL:
https://github.com/apache/incubator-paimon/pull/2749#issuecomment-1914871524
@leaves12138 @JingsongLi PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
JingsongLi merged PR #2812:
URL: https://github.com/apache/incubator-paimon/pull/2812
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
s7monk commented on PR #184:
URL:
https://github.com/apache/incubator-paimon-webui/pull/184#issuecomment-1914761943
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
sunxiaojian opened a new pull request, #2815:
URL: https://github.com/apache/incubator-paimon/pull/2815
### Purpose
Linked issue: close #xxx
### Tests
### API and Format
### Documentation
--
This is an automated me
sunxiaojian commented on issue #2701:
URL:
https://github.com/apache/incubator-paimon/issues/2701#issuecomment-1914578744
> > @zhangjun0x01 I remember this feature is already supported. Is there any
problem now? 我记得这个功能已经支持了。现在有什么问题吗？
>
> The json given by flink-cdc does not contain
JingsongLi commented on PR #2797:
URL:
https://github.com/apache/incubator-paimon/pull/2797#issuecomment-1914501925
@chenxi0599 Please fix compile checkstyle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
JingsongLi merged PR #2810:
URL: https://github.com/apache/incubator-paimon/pull/2810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...
harveyyue opened a new pull request, #2813:
URL: https://github.com/apache/incubator-paimon/pull/2813
### Purpose
Linked issue: close #xxx
### Tests
### API and Format
### Documentation
--
This is an automated mess
JingsongLi commented on PR #2810:
URL:
https://github.com/apache/incubator-paimon/pull/2810#issuecomment-1914295997
Looks reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
JingsongLi commented on PR #2797:
URL:
https://github.com/apache/incubator-paimon/pull/2797#issuecomment-1914292063
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
25 matches
Mail list logo
