[jira] [Commented] (PHOENIX-4799) Write cells using checkAndMutate to prevent conflicting changes

2018-08-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569041#comment-16569041 ] Hadoop QA commented on PHOENIX-4799: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-4799) Write cells using checkAndMutate to prevent conflicting changes

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568866#comment-16568866 ] ASF GitHub Bot commented on PHOENIX-4799: - Github user twdsilva commented on a

[GitHub] phoenix pull request #313: PHOENIX-4799 Write cells using checkAndMutate to ...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/313#discussion_r207681657 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -2957,6 +3006,16 @@ MutationState dropTable(String schemaName, St

[jira] [Commented] (PHOENIX-4799) Write cells using checkAndMutate to prevent conflicting changes

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568830#comment-16568830 ] ASF GitHub Bot commented on PHOENIX-4799: - Github user karanmehta93 commented o

[GitHub] phoenix pull request #313: PHOENIX-4799 Write cells using checkAndMutate to ...

2018-08-03 Thread karanmehta93
Github user karanmehta93 commented on a diff in the pull request: https://github.com/apache/phoenix/pull/313#discussion_r207674894 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -2957,6 +3006,16 @@ MutationState dropTable(String schemaName

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568818#comment-16568818 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user JamesRTaylor commented o

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread JamesRTaylor
Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207673751 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java --- @@ -204,15 +205,19 @@ private void appendPKColumnValue(StringBuil

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568789#comment-16568789 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568790#comment-16568790 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568793#comment-16568793 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568788#comment-16568788 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568787#comment-16568787 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568784#comment-16568784 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568792#comment-16568792 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568783#comment-16568783 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568791#comment-16568791 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568782#comment-16568782 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568781#comment-16568781 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568785#comment-16568785 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568780#comment-16568780 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-3547) Promote CATALOG.VIEW_INDEX_ID to an int

2018-08-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-3547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568786#comment-16568786 ] ASF GitHub Bot commented on PHOENIX-3547: - Github user twdsilva commented on a

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207665609 --- Diff: phoenix-protocol/src/main/MetaDataService.proto --- @@ -75,7 +76,8 @@ message MetaDataResponse { repeated SharedTableState sharedTablesToDe

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207657327 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -317,6 +318,10 @@ private static final KeyVa

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207661302 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java --- @@ -3037,6 +3037,14 @@ protected PhoenixConnection upg

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207659334 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1431,11 +1438,42 @@ private PTable getTable(RegionSc

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207662014 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java --- @@ -2544,7 +2546,7 @@ else if (!SchemaUtil.isSystemTable(Bytes.toBy

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207659847 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataProtocol.java --- @@ -393,9 +408,12 @@ public static MetaDataMutationResult c

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207669604 --- Diff: phoenix-protocol/src/main/PTable.proto --- @@ -85,7 +85,7 @@ message PTable { optional bytes viewStatement = 18; repeated bytes phys

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207661456 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/query/QueryConstants.java --- @@ -192,7 +192,8 @@ DISABLE_WAL + " BOOLEAN,\n" +

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207659053 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -1431,11 +1438,42 @@ private PTable getTable(RegionSc

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207670259 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java --- @@ -2285,6 +2317,7 @@ public void createTable(RpcControl

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207661113 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/iterate/ExplainTable.java --- @@ -204,15 +205,19 @@ private void appendPKColumnValue(StringBuilder

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207665512 --- Diff: phoenix-protocol/src/main/MetaDataService.proto --- @@ -75,7 +76,8 @@ message MetaDataResponse { repeated SharedTableState sharedTablesToDe

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207660126 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/index/IndexMaintainer.java --- @@ -1340,6 +1344,9 @@ public static IndexMaintainer fromProto(Serve

[GitHub] phoenix pull request #317: PHOENIX-3547 Supporting more number of indices pe...

2018-08-03 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/317#discussion_r207669858 --- Diff: phoenix-protocol/src/main/ServerCachingService.proto --- @@ -62,6 +62,7 @@ message IndexMaintainer { repeated ColumnInfo indexedColumnInfo

[jira] [Commented] (PHOENIX-4751) Support client-side hash aggregation with SORT_MERGE_JOIN

2018-08-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567892#comment-16567892 ] Hudson commented on PHOENIX-4751: - FAILURE: Integrated in Jenkins build Phoenix-4.x-HBa

[jira] [Commented] (PHOENIX-4476) Range scan used for point lookups if filter is not in order of primary keys

2018-08-03 Thread Xu Cang (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567887#comment-16567887 ] Xu Cang commented on PHOENIX-4476: -- thank you [~jamestaylor] Your explanation is very