[jira] [Commented] (PHOENIX-4891) An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661776#comment-16661776 ] ASF GitHub Bot commented on PHOENIX-4891: - Github user ChinmaySKulkarni comment

[GitHub] phoenix issue #364: PHOENIX-4891: An index should inherit UPDATE_CACHE_FREQU...

2018-10-23 Thread ChinmaySKulkarni
Github user ChinmaySKulkarni commented on the issue: https://github.com/apache/phoenix/pull/364 @twdsilva Addressed review comments. Please merge this pr. Thanks ---

[jira] [Commented] (PHOENIX-4891) An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661775#comment-16661775 ] ASF GitHub Bot commented on PHOENIX-4891: - Github user ChinmaySKulkarni comment

[GitHub] phoenix issue #363: PHOENIX-4891: An index should inherit UPDATE_CACHE_FREQU...

2018-10-23 Thread ChinmaySKulkarni
Github user ChinmaySKulkarni commented on the issue: https://github.com/apache/phoenix/pull/363 @twdsilva Addressed review commits, but a force push closed this PR. Please merge https://github.com/apache/phoenix/pull/364 Thanks ---

[jira] [Commented] (PHOENIX-4891) An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661771#comment-16661771 ] ASF GitHub Bot commented on PHOENIX-4891: - GitHub user ChinmaySKulkarni opened

[GitHub] phoenix pull request #364: PHOENIX-4891: An index should inherit UPDATE_CACH...

2018-10-23 Thread ChinmaySKulkarni
GitHub user ChinmaySKulkarni opened a pull request: https://github.com/apache/phoenix/pull/364 PHOENIX-4891: An index should inherit UPDATE_CACHE_FREQUENCY setting rom parent table You can merge this pull request into a Git repository by running: $ git pull https://github.com

[jira] [Commented] (PHOENIX-4990) When stopping IndexWriter, give tasks a chance to complete

2018-10-23 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661762#comment-16661762 ] Vincent Poon commented on PHOENIX-4990: --- [~gjacoby] The check immediately after a

[jira] [Comment Edited] (PHOENIX-4990) When stopping IndexWriter, give tasks a chance to complete

2018-10-23 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661762#comment-16661762 ] Vincent Poon edited comment on PHOENIX-4990 at 10/24/18 6:00 AM:

[jira] [Commented] (PHOENIX-4988) Incorrect index rowkey generated when updating only non-indexed columns after a delete

2018-10-23 Thread Lars Hofhansl (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661761#comment-16661761 ] Lars Hofhansl commented on PHOENIX-4988: Do we need to do the RAW scan here? M

[GitHub] phoenix pull request #363: PHOENIX-4891: An index should inherit UPDATE_CACH...

2018-10-23 Thread ChinmaySKulkarni
Github user ChinmaySKulkarni closed the pull request at: https://github.com/apache/phoenix/pull/363 ---

[jira] [Commented] (PHOENIX-4891) An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661746#comment-16661746 ] ASF GitHub Bot commented on PHOENIX-4891: - Github user ChinmaySKulkarni closed

[jira] [Commented] (PHOENIX-4977) Make KillServerOnFailurePolicy a configurable option in PhoenixIndexFailurePolicy

2018-10-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661737#comment-16661737 ] Hadoop QA commented on PHOENIX-4977: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-4891) An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661712#comment-16661712 ] ASF GitHub Bot commented on PHOENIX-4891: - Github user ChinmaySKulkarni comment

[GitHub] phoenix pull request #363: PHOENIX-4891: An index should inherit UPDATE_CACH...

2018-10-23 Thread ChinmaySKulkarni
Github user ChinmaySKulkarni commented on a diff in the pull request: https://github.com/apache/phoenix/pull/363#discussion_r227638634 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/PropertiesInSyncIT.java --- @@ -402,16 +486,17 @@ private String createBaseTableWithP

[jira] [Commented] (PHOENIX-4975) Fix failing unit tests for Omid due to shadow cells and no local indexes

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661692#comment-16661692 ] Hudson commented on PHOENIX-4975: - ABORTED: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-4981) Add tests for ORDER BY, GROUP BY, salted tables using phoenix-spark

2018-10-23 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661685#comment-16661685 ] Karan Mehta commented on PHOENIX-4981: -- [~tdsilva] It would be good to put it up a

[jira] [Commented] (PHOENIX-4891) An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661617#comment-16661617 ] ASF GitHub Bot commented on PHOENIX-4891: - Github user twdsilva commented on a

[jira] [Commented] (PHOENIX-4891) An index should inherit UPDATE_CACHE_FREQUENCY setting from parent table

2018-10-23 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661618#comment-16661618 ] ASF GitHub Bot commented on PHOENIX-4891: - Github user twdsilva commented on a

[GitHub] phoenix pull request #363: PHOENIX-4891: An index should inherit UPDATE_CACH...

2018-10-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/363#discussion_r227621900 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/PropertiesInSyncIT.java --- @@ -402,16 +486,17 @@ private String createBaseTableWithProps(Con

[GitHub] phoenix pull request #363: PHOENIX-4891: An index should inherit UPDATE_CACH...

2018-10-23 Thread twdsilva
Github user twdsilva commented on a diff in the pull request: https://github.com/apache/phoenix/pull/363#discussion_r227622543 --- Diff: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java --- @@ -151,6 +152,14 @@ + "(TENANT_ID, TABLE_SCHEM, TABLE_N

[jira] [Commented] (PHOENIX-4990) When stopping IndexWriter, give tasks a chance to complete

2018-10-23 Thread Geoffrey Jacoby (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661607#comment-16661607 ] Geoffrey Jacoby commented on PHOENIX-4990: -- Maybe I'm missing something, but i

[jira] [Commented] (PHOENIX-4977) Make KillServerOnFailurePolicy a configurable option in PhoenixIndexFailurePolicy

2018-10-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661559#comment-16661559 ] Hadoop QA commented on PHOENIX-4977: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-4977) Make KillServerOnFailurePolicy a configurable option in PhoenixIndexFailurePolicy

2018-10-23 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661552#comment-16661552 ] Karan Mehta commented on PHOENIX-4977: -- LGTM +1 > Make KillServerOnFailurePolicy

[jira] [Commented] (PHOENIX-4977) Make KillServerOnFailurePolicy a configurable option in PhoenixIndexFailurePolicy

2018-10-23 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661549#comment-16661549 ] Vincent Poon commented on PHOENIX-4977: --- Thanks for the review [~karanmehta93].

[jira] [Commented] (PHOENIX-4990) When stopping IndexWriter, give tasks a chance to complete

2018-10-23 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661545#comment-16661545 ] Vincent Poon commented on PHOENIX-4990: --- v2 makes the timeout configurable. I fo

[jira] [Commented] (PHOENIX-4977) Make KillServerOnFailurePolicy a configurable option in PhoenixIndexFailurePolicy

2018-10-23 Thread Karan Mehta (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661493#comment-16661493 ] Karan Mehta commented on PHOENIX-4977: -- [~vincentpoon] The property can be set pe

[jira] [Commented] (PHOENIX-4888) Create script that starts Omid transaction manager

2018-10-23 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661442#comment-16661442 ] James Taylor commented on PHOENIX-4888: --- [~mujtabachohan] may know the answer to

[jira] [Commented] (PHOENIX-4977) Make KillServerOnFailurePolicy a configurable option in PhoenixIndexFailurePolicy

2018-10-23 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661438#comment-16661438 ] Vincent Poon commented on PHOENIX-4977: --- [~karanmehta93] [~gjacoby] quick review

[jira] [Commented] (PHOENIX-4990) When stopping IndexWriter, give tasks a chance to complete

2018-10-23 Thread Vincent Poon (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661416#comment-16661416 ] Vincent Poon commented on PHOENIX-4990: --- [~gjacoby] [~karanmehta93] Can you do a

[jira] [Commented] (PHOENIX-4963) Do not throw when transitioning to PENDING_DISABLE if index is already disabled

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661310#comment-16661310 ] Hudson commented on PHOENIX-4963: - FAILURE: Integrated in Jenkins build Phoenix-omid2 #

[jira] [Commented] (PHOENIX-4975) Fix failing unit tests for Omid due to shadow cells and no local indexes

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661313#comment-16661313 ] Hudson commented on PHOENIX-4975: - FAILURE: Integrated in Jenkins build Phoenix-omid2 #

[jira] [Commented] (PHOENIX-4988) Incorrect index rowkey generated when updating only non-indexed columns after a delete

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661312#comment-16661312 ] Hudson commented on PHOENIX-4988: - FAILURE: Integrated in Jenkins build Phoenix-omid2 #

[jira] [Commented] (PHOENIX-4960) Write to table with global index failed if meta of index changed (split, move, etc)

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661311#comment-16661311 ] Hudson commented on PHOENIX-4960: - FAILURE: Integrated in Jenkins build Phoenix-omid2 #

[jira] [Commented] (PHOENIX-4975) Fix failing unit tests for Omid due to shadow cells and no local indexes

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661185#comment-16661185 ] Hudson commented on PHOENIX-4975: - SUCCESS: Integrated in Jenkins build Phoenix-4.x-HBa

[jira] [Commented] (PHOENIX-4988) Incorrect index rowkey generated when updating only non-indexed columns after a delete

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661122#comment-16661122 ] Hudson commented on PHOENIX-4988: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-4960) Write to table with global index failed if meta of index changed (split, move, etc)

2018-10-23 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661121#comment-16661121 ] Hudson commented on PHOENIX-4960: - FAILURE: Integrated in Jenkins build PreCommit-PHOEN

[jira] [Commented] (PHOENIX-4989) Include disruptor jar in shaded dependency

2018-10-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661120#comment-16661120 ] Hadoop QA commented on PHOENIX-4989: {color:red}-1 overall{color}. Here are the re

[jira] [Comment Edited] (PHOENIX-4982) Query Fails For Join with Order By that is fully qualified

2018-10-23 Thread Andrew Khor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661065#comment-16661065 ] Andrew Khor edited comment on PHOENIX-4982 at 10/23/18 6:01 PM: -

[jira] [Issue Comment Deleted] (PHOENIX-4982) Query Fails For Join with Order By that is fully qualified

2018-10-23 Thread Andrew Khor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Khor updated PHOENIX-4982: - Comment: was deleted (was: Fixed by https://issues.apache.org/jira/browse/PHOENIX-4933) > Quer

[jira] [Comment Edited] (PHOENIX-4982) Query Fails For Join with Order By that is fully qualified

2018-10-23 Thread Andrew Khor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661065#comment-16661065 ] Andrew Khor edited comment on PHOENIX-4982 at 10/23/18 6:00 PM: -

[jira] [Commented] (PHOENIX-4982) Query Fails For Join with Order By that is fully qualified

2018-10-23 Thread Andrew Khor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661065#comment-16661065 ] Andrew Khor commented on PHOENIX-4982: -- Tested with latest version and issue no lo

[jira] [Commented] (PHOENIX-1567) Publish Phoenix-Client & Phoenix-Server jars into Maven Repo

2018-10-23 Thread Jerry Chabot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661052#comment-16661052 ] Jerry Chabot commented on PHOENIX-1567: --- Yes, I will create a separate issue if n

[jira] [Commented] (PHOENIX-4989) Include disruptor jar in shaded dependency

2018-10-23 Thread Andrew Purtell (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16661049#comment-16661049 ] Andrew Purtell commented on PHOENIX-4989: - +1 > Include disruptor jar in shad

[jira] [Commented] (PHOENIX-4975) Fix failing unit tests for Omid due to shadow cells and no local indexes

2018-10-23 Thread James Taylor (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660935#comment-16660935 ] James Taylor commented on PHOENIX-4975: --- Sorry about that, [~tdsilva]. All fixed

[jira] [Commented] (PHOENIX-1567) Publish Phoenix-Client & Phoenix-Server jars into Maven Repo

2018-10-23 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660860#comment-16660860 ] Josh Elser commented on PHOENIX-1567: - {quote}Unfortunately, using the phoenix-clie

[jira] [Commented] (PHOENIX-1567) Publish Phoenix-Client & Phoenix-Server jars into Maven Repo

2018-10-23 Thread Jerry Chabot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660857#comment-16660857 ] Jerry Chabot commented on PHOENIX-1567: --- Unfortunately, using the phoenix-client

[jira] [Commented] (PHOENIX-1567) Publish Phoenix-Client & Phoenix-Server jars into Maven Repo

2018-10-23 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660846#comment-16660846 ] Josh Elser commented on PHOENIX-1567: - {quote}Short of building it myself and addin

[jira] [Commented] (PHOENIX-1567) Publish Phoenix-Client & Phoenix-Server jars into Maven Repo

2018-10-23 Thread Jerry Chabot (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660842#comment-16660842 ] Jerry Chabot commented on PHOENIX-1567: --- What is the status of this request? I as

[jira] [Commented] (PHOENIX-4989) Include disruptor jar in shaded dependency

2018-10-23 Thread Aman Poonia (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660753#comment-16660753 ] Aman Poonia commented on PHOENIX-4989: -- [~apurtell] [~vincentpoon] - FYI > Includ

[jira] [Comment Edited] (PHOENIX-4982) Query Fails For Join with Order By that is fully qualified

2018-10-23 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660241#comment-16660241 ] Toshihiro Suzuki edited comment on PHOENIX-4982 at 10/23/18 8:15 AM:

[jira] [Commented] (PHOENIX-4982) Query Fails For Join with Order By that is fully qualified

2018-10-23 Thread Toshihiro Suzuki (JIRA)
[ https://issues.apache.org/jira/browse/PHOENIX-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660241#comment-16660241 ] Toshihiro Suzuki commented on PHOENIX-4982: --- [~akhor] what is a error are you